Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-18 Thread Ilya Maximets
On 18.12.2017 16:20, Loftus, Ciara wrote: >> >> On 18.12.2017 15:28, Loftus, Ciara wrote: Not a full review. >>> >>> Thanks for your feedback. >>> General thoughts: If following conditions are true: 1. We don't need to add new feature to deprecated vhostuser

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-18 Thread Loftus, Ciara
> > On 18.12.2017 15:28, Loftus, Ciara wrote: > >> > >> Not a full review. > > > > Thanks for your feedback. > > > >> > >> General thoughts: > >> > >> If following conditions are true: > >> > >> 1. We don't need to add new feature to deprecated vhostuser port. > > > > Agree. > > > >> > >> 2. We

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-18 Thread Ilya Maximets
On 18.12.2017 15:28, Loftus, Ciara wrote: >> >> Not a full review. > > Thanks for your feedback. > >> >> General thoughts: >> >> If following conditions are true: >> >> 1. We don't need to add new feature to deprecated vhostuser port. > > Agree. > >> >> 2. We actually don't need to have

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-18 Thread Loftus, Ciara
> > Not a full review. Thanks for your feedback. > > General thoughts: > > If following conditions are true: > > 1. We don't need to add new feature to deprecated vhostuser port. Agree. > > 2. We actually don't need to have ability to change ZC config if vhost-server- > path >already

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Stokes, Ian
> On 12/15/2017 12:32 PM, Jan Scheurich wrote: > > Hi, > > > What if we have 2, 4, 10 HW NICs and a few different destinations for > traffic from VM? > What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and > just a few different packet flows? > What if we have HW NICs

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Kevin Traynor
On 12/15/2017 09:39 AM, Ilya Maximets wrote: >>> What if we have 2, 4, 10 HW NICs and a few different destinations for >>> traffic from VM? >>> What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and just a >>> few different packet flows? >>> What if we have HW NICs with small number

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Kevin Traynor
On 12/15/2017 12:32 PM, Jan Scheurich wrote: > Hi, > What if we have 2, 4, 10 HW NICs and a few different destinations for traffic from VM? What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and just a few different packet flows? What if we have HW NICs with

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Ilya Maximets
Not a full review. General thoughts: If following conditions are true: 1. We don't need to add new feature to deprecated vhostuser port. 2. We actually don't need to have ability to change ZC config if vhost-server-path already configured. Let me explain this condition: To change

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Jan Scheurich
Hi, > >> What if we have 2, 4, 10 HW NICs and a few different destinations for > >> traffic from VM? > >> What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and just a > >> few different packet flows? > >> What if we have HW NICs with small number of TX queues (like VFs) and XPS >

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Stokes, Ian
> Hello Ciara, > Thanks for the patches. > > I did not review the code. But I have few general concerns about number of > tx descriptors in HW NICs inline. > > Best regards, Ilya Maximets. > > On 08.12.2017 18:26, Ciara Loftus wrote: > > Enabled per port like so: > > ovs-vsctl set Interface

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-15 Thread Ilya Maximets
On 14.12.2017 19:26, Kevin Traynor wrote: > On 12/14/2017 03:30 PM, Ilya Maximets wrote: >> Hello Ciara, >> Thanks for the patches. >> >> I did not review the code. But I have few general concerns about number >> of tx descriptors in HW NICs inline. >> >> Best regards, Ilya Maximets. >> >> On

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-14 Thread Kevin Traynor
On 12/14/2017 03:30 PM, Ilya Maximets wrote: > Hello Ciara, > Thanks for the patches. > > I did not review the code. But I have few general concerns about number > of tx descriptors in HW NICs inline. > > Best regards, Ilya Maximets. > > On 08.12.2017 18:26, Ciara Loftus wrote: >> Enabled per

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-14 Thread Ilya Maximets
Hello Ciara, Thanks for the patches. I did not review the code. But I have few general concerns about number of tx descriptors in HW NICs inline. Best regards, Ilya Maximets. On 08.12.2017 18:26, Ciara Loftus wrote: > Enabled per port like so: > ovs-vsctl set Interface dpdkvhostuserclient0