Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-02-03 Thread Alin Serdean
> > On 1/31/20, 10:42, "Amber Hu" wrote: > > > Formerly, there is no tunnel information appended in the upcall’s > packet data, which is expected by IPFIX in userspace to calculate > the template for exporting the sampled flow record of on egress > tunnel

[ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-30 Thread Amber Hu via dev
Formerly, there is no tunnel information appended in the upcall’s packet data, which is expected by IPFIX in userspace to calculate the template for exporting the sampled flow record of on egress tunnel port. To fix this, during performing OvsOutputUserspaceAction(), we would check whether

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-21 Thread Amber Hu via dev
Hi Alin, Will update the patch and change it according to the comments. Thanks very much. BR/Amber On 1/22/20, 12:43, "Alin Serdean" wrote: Hi Amber, The patch fails to apply: "error: corrupt patch at line 198" Please rebase on master. Trimming the patch a

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-21 Thread Alin Serdean
Hi Amber, The patch fails to apply: "error: corrupt patch at line 198" Please rebase on master. Trimming the patch a bit and comments inlined. > -Original Message- > From: Amber Hu > Sent: Tuesday, January 14, 2020 7:50 AM > To: d...@openvswitch.org; Alin Serdean > Cc: Qiong Wang ;

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-21 Thread Alin Serdean
Sure. I will review it tonight. Thanks, Alin. -Original Message- From: Ben Pfaff Sent: Tuesday, January 21, 2020 7:59 PM To: Amber Hu Cc: d...@openvswitch.org; Alin Serdean ; Qiong Wang Subject: Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-21 Thread Ben Pfaff
I expect that, of the OVS maintainers, Alin is most qualified to review it. Alin, are you planning to take a look at it? On Tue, Jan 21, 2020 at 02:52:54AM +, Amber Hu via dev wrote: > Hi, > > May I ask the process of reviewing for the below patch >

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-20 Thread Amber Hu via dev
Hi, May I ask the process of reviewing for the below patch https://patchwork.ozlabs.org/patch/1222463/ Thanks for your time. BR/Amber From: Amber Hu Date: Tuesday, January 14, 2020 at 13:49 To: "d...@openvswitch.org" , Alin Serdean Cc: Qiong Wang , Wenyu Zhang , Jinjun Gao Subject:

Re: [ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-13 Thread 0-day Robot
Bleep bloop. Greetings Amber Hu via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: corrupt patch at line 19 Repository lacks necessary blobs to fall back on 3-way merge.

[ovs-dev] [patch] datapath-windows: Append tunnel info to upcall for correct template

2020-01-13 Thread Amber Hu via dev
Formerly, there is no tunnel information appended in the upcall’s packet data, which is expected by IPFIX in userspace to calculate the template for exporting the sampled flow record of on egress tunnel port. To fix this, during performing OvsOutputUserspaceAction(), we would check whether it is