Re: [ovs-dev] [patch v3 3/4] conntrack: Enforce conn_type for flush tuple.

2018-12-11 Thread Ben Pfaff
On Mon, Dec 10, 2018 at 07:26:32PM -0800, Darrell Ball wrote: > On Mon, Dec 10, 2018 at 5:42 PM Ben Pfaff wrote: > > > On Mon, Nov 26, 2018 at 08:48:39AM -0800, Darrell Ball wrote: > > > The user should only reference a conntrack entry by the forward > > > direction context, as per

Re: [ovs-dev] [patch v3 3/4] conntrack: Enforce conn_type for flush tuple.

2018-12-10 Thread Darrell Ball
On Mon, Dec 10, 2018 at 5:42 PM Ben Pfaff wrote: > On Mon, Nov 26, 2018 at 08:48:39AM -0800, Darrell Ball wrote: > > The user should only reference a conntrack entry by the forward > > direction context, as per 'conntrack_flush()', enforce this by > > checking for 'default' conn_type. The

[ovs-dev] [patch v3 3/4] conntrack: Enforce conn_type for flush tuple.

2018-11-26 Thread Darrell Ball
The user should only reference a conntrack entry by the forward direction context, as per 'conntrack_flush()', enforce this by checking for 'default' conn_type. The likelihood of a user not using the original tuple is low, but it should be guarded against, logged and documented. Signed-off-by: