Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-20 Thread Darrell Ball
-Original Message- From: on behalf of Joe Stringer Date: Thursday, July 20, 2017 at 11:17 AM To: Darrell Ball Cc: ovs dev Subject: Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test. On 16 July 2017 at 11:27, Darrell Ball wrote: > One SNAT t

Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-20 Thread Joe Stringer
On 16 July 2017 at 11:27, Darrell Ball wrote: > One SNAT test is based on a single ping being successful; > to make the result more predictable, static arp binding is now used. > Occasionally, tracing shows the reply side stack does not respond, > but this is much less common with this change. > I

Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-17 Thread Darrell Ball
On 7/17/17, 12:48 AM, "Ilya Maximets" wrote: Not a full review. And I most likely will not review the logic. Just one comment inline. Best regards, Ilya Maximets. > One SNAT test is based on a single ping being successful; > to make the result more predictable, sta

Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-17 Thread Ilya Maximets
Not a full review. And I most likely will not review the logic. Just one comment inline. Best regards, Ilya Maximets. > One SNAT test is based on a single ping being successful; > to make the result more predictable, static arp binding is now used. > Occasionally, tracing shows the reply side sta

[ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-16 Thread Darrell Ball
One SNAT test is based on a single ping being successful; to make the result more predictable, static arp binding is now used. Occasionally, tracing shows the reply side stack does not respond, but this is much less common with this change. I considered changing the test design itself, but I though