Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-29 Thread Ferriter, Cian
Hi Eelco, Thanks for your comments. My response is inline. Cian > -Original Message- > From: Eelco Chaudron > Sent: Friday 25 June 2021 16:14 > To: Ferriter, Cian > Cc: Flavio Leitner ; ovs-dev@openvswitch.org; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-28 Thread Ferriter, Cian
ject: Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif > implementation. > > > > On 17 Jun 2021, at 18:18, Cian Ferriter wrote: > > > From: Harry van Haaren > > > > This commit adds a new command to allow the user to switch >

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-28 Thread Eelco Chaudron
On 17 Jun 2021, at 18:18, Cian Ferriter wrote: > From: Harry van Haaren > > This commit adds a new command to allow the user to switch > the active DPIF implementation at runtime. A probe function > is executed before switching the DPIF implementation, to ensure > the CPU is capable of

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-25 Thread Eelco Chaudron
On 24 Jun 2021, at 13:53, Ferriter, Cian wrote: > Hi Flavio, > > Thanks for the review. My responses are inline. > > Cian > >>> >>> +static void >>> +dpif_netdev_impl_set(struct unixctl_conn *conn, int argc, >>> + const char *argv[], void *aux OVS_UNUSED) >>> +{ >>> +

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-25 Thread Ferriter, Cian
y 23 June 2021 19:18 > > To: Ferriter, Cian > > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > > Subject: Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif > > implementation. > > > > On Thu, Jun 17, 2021 at 05:18:18PM +0100, Cian Ferriter wrote: >

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-24 Thread Ferriter, Cian
Hi Flavio, Thanks for clarifying. My response is inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Thursday 24 June 2021 13:26 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 05/12] dpif-netdev: Add

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-24 Thread Flavio Leitner
On Thu, Jun 24, 2021 at 11:53:34AM +, Ferriter, Cian wrote: [...] > > On Thu, Jun 17, 2021 at 05:18:18PM +0100, Cian Ferriter wrote: > > > + > > > +VLOG_DEFINE_THIS_MODULE(dpif_netdev_impl); > > > + > > > +/* Actual list of implementations goes here. */ > > > +static struct

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-24 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Wednesday 23 June 2021 19:18 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 05/12] dpif-n

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-23 Thread Flavio Leitner
On Thu, Jun 17, 2021 at 05:18:18PM +0100, Cian Ferriter wrote: > From: Harry van Haaren > > This commit adds a new command to allow the user to switch > the active DPIF implementation at runtime. A probe function > is executed before switching the DPIF implementation, to ensure > the CPU is

[ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-17 Thread Cian Ferriter
From: Harry van Haaren This commit adds a new command to allow the user to switch the active DPIF implementation at runtime. A probe function is executed before switching the DPIF implementation, to ensure the CPU is capable of running the ISA required. For example, the below code will switch to