Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-09 Thread Flavio Leitner
gt;> To: Amber, Kumar > >> Cc: Flavio Leitner ; Ferriter, Cian > >> ; > >> ovs-dev@openvswitch.org; i.maxim...@ovn.org > >> Subject: Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and > >> function > >> pointer for miniflow extrac

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-09 Thread Eelco Chaudron
l Message- >>>> From: Eelco Chaudron >>>> Sent: Friday, July 9, 2021 4:36 PM >>>> To: Amber, Kumar >>>> Cc: Flavio Leitner ; Ferriter, Cian >>>> ; ovs-dev@openvswitch.org; >>>> i.maxim...@ovn.org >>>> Subject: Re:

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-09 Thread Amber, Kumar
To: Amber, Kumar > >> Cc: Flavio Leitner ; Ferriter, Cian > >> ; ovs-dev@openvswitch.org; > >> i.maxim...@ovn.org > >> Subject: Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and > >> function pointer for miniflow extract > >&

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-09 Thread Eelco Chaudron
i.maxim...@ovn.org >> Subject: Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function >> pointer for miniflow extract >> >> >> >> On 8 Jul 2021, at 16:01, Amber, Kumar wrote: >> >>> Hi Flavio, >>> >>> Thanks

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-09 Thread Amber, Kumar
Hi Eelco, > -Original Message- > From: Eelco Chaudron > Sent: Friday, July 9, 2021 4:36 PM > To: Amber, Kumar > Cc: Flavio Leitner ; Ferriter, Cian > ; > ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command lin

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-09 Thread Eelco Chaudron
On 8 Jul 2021, at 16:01, Amber, Kumar wrote: > Hi Flavio, > > Thanks for the Review > Replies are inline. > > > >>> +miniflow_extract_func >>> +dp_mfex_impl_get_default(void) >>> +{ >>> +/* For the first call, this will be NULL. Compute the compile time >>> default. >>> + */ >>> +

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-08 Thread Amber, Kumar
Hi Flavio, Thanks for the Review Replies are inline. > > +miniflow_extract_func > > +dp_mfex_impl_get_default(void) > > +{ > > +/* For the first call, this will be NULL. Compute the compile time > > default. > > + */ > > +if (!default_mfex_func) { > > + > > +

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-08 Thread Flavio Leitner
Hi, Eelco did an extensive review on this one already, so I will try to not repeat the same. See below. On Tue, Jul 06, 2021 at 02:11:40PM +0100, Cian Ferriter wrote: > From: Kumar Amber > > This patch introduces the mfex function pointers which allows > the user to switch between different

Re: [ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-06 Thread 0-day Robot
Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (lib/dpif-netdev.c). error: could not build fake

[ovs-dev] [v6 01/11] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-06 Thread Cian Ferriter
From: Kumar Amber This patch introduces the mfex function pointers which allows the user to switch between different miniflow extract implementations which are provided by the OVS based on optimized ISA CPU. The user can query for the available minflow extract variants available for that CPU by