Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Eelco Chaudron
On 8 Jul 2021, at 14:11, Stokes, Ian wrote: >>> -Original Message- >>> From: Eelco Chaudron >>> Sent: Thursday, July 8, 2021 11:48 AM >>> To: Ferriter, Cian >>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van >>> Haaren, Harry ; Amber, Kumar >>> ; Stokes, Ian

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Stokes, Ian
> > -Original Message- > > From: Eelco Chaudron > > Sent: Thursday, July 8, 2021 11:48 AM > > To: Ferriter, Cian > > Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van > > Haaren, Harry ; Amber, Kumar > > ; Stokes, Ian > > Subject: Re: [v6 06/11] dpif-netdev: Add

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Van Haaren, Harry
> -Original Message- > From: Eelco Chaudron > Sent: Thursday, July 8, 2021 11:48 AM > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van > Haaren, Harry ; Amber, Kumar > ; Stokes, Ian > Subject: Re: [v6 06/11] dpif-netdev: Add packet count and

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Eelco Chaudron
On 6 Jul 2021, at 15:11, Cian Ferriter wrote: > From: Kumar Amber > > This commit introduces additional command line paramter > for mfex study function. If user provides additional packet out > it is used in study to compare minimum packets which must be processed > else a default value is

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Amber, Kumar
Thanks Again, Fixed the formatting  > -Original Message- > From: Eelco Chaudron > Sent: Thursday, July 8, 2021 4:10 PM > To: Amber, Kumar > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry > ; Stokes, Ian > Subject: Re: [v6

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Eelco Chaudron
On 8 Jul 2021, at 12:34, Amber, Kumar wrote: > Hi Eelco, > > Pls find replies inline. > >> -Original Message- >> From: Eelco Chaudron >> Sent: Thursday, July 8, 2021 2:14 PM >> To: Amber, Kumar >> Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; >> f...@sysclose.org; i.maxim...@ovn.org;

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Amber, Kumar
Hi Eelco, Pls find replies inline. > -Original Message- > From: Eelco Chaudron > Sent: Thursday, July 8, 2021 2:14 PM > To: Amber, Kumar > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry > ; Stokes, Ian > Subject: Re: [v6 06/11]

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Eelco Chaudron
On 8 Jul 2021, at 9:41, Amber, Kumar wrote: > Hi Eelco, > > > >> -Original Message- >> From: Eelco Chaudron >> Sent: Thursday, July 8, 2021 1:00 PM >> To: Amber, Kumar >> Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; >> f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry >> ;

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Amber, Kumar
Hi Eelco, > -Original Message- > From: Eelco Chaudron > Sent: Thursday, July 8, 2021 1:00 PM > To: Amber, Kumar > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry > ; Stokes, Ian > Subject: Re: [v6 06/11] dpif-netdev: Add packet

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-08 Thread Eelco Chaudron
On 7 Jul 2021, at 17:16, Amber, Kumar wrote: > Hi Eelco, > > Don’t know the formatting keeps breaking . replies are inline. > > + /* argv[2] is optional packet count, which user can provide along with > + * study function to set the minimum packet that must be matched in order > + * to choose

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-07 Thread Amber, Kumar
Hi Eelco, Don’t know the formatting keeps breaking . replies are inline. +optimal implementation. If no packet count is provided then the default value +128 is chosen. Not a native speaker, but I think the sentence need some commas? “If no packet count is provided, then the default value,

Re: [ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-07 Thread Eelco Chaudron
Did not do a full review, just some small comments as this will change with the suggested -pmd option. On 6 Jul 2021, at 15:11, Cian Ferriter wrote: From: Kumar Amber This commit introduces additional command line paramter for mfex study function. If user provides additional packet out it

[ovs-dev] [v6 06/11] dpif-netdev: Add packet count and core id paramters for study

2021-07-06 Thread Cian Ferriter
From: Kumar Amber This commit introduces additional command line paramter for mfex study function. If user provides additional packet out it is used in study to compare minimum packets which must be processed else a default value is choosen. Also introduces a third paramter for choosing a