Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Thanks for the confirmation Yi. I will post the fix straight away. The other fix for double encap() is also ready. BR, Jan > -Original Message- > From: Yang, Yi [mailto:yi.y.y...@intel.com] > Sent: Monday, 26 March, 2018 03:42 > To: Jan Scheurich > Cc:

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

I tried the below fix patch you mentioned, it did fix this issue. diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index db85716..87797bc 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -6985,9 +6985,6 @@ ofpact_is_set_or_move_action(const struct ofpact *a) case

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Jan, thank you so much, very exhaustive analysis :), I'll double check your fix patch. From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] Sent: Sunday, March 25, 2018 9:09 AM To: Yang, Yi Y Cc: d...@openvswitch.org; Zoltán Balogh Subject:

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Hi Yi, Part of the seemingly strange behavior of the encap(nsh) action in a group is caused by the (often forgotten) fact that group buckets do not contain action *lists* but action *sets*. I have no idea why it was defined like this when groups were first introduced in OpenFlow 1.1. In my

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Hi Yi, OK, this is an ALL group with two buckets. xlate_generic_encap_action is supposed to be called once for each bucket. In theory the translation in the second bucket should start from the same fresh base_flow as in the first bucket, as each bucket should process a clone of the original

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

On Fri, Mar 23, 2018 at 07:51:45AM +, Jan Scheurich wrote: > Hi Yi, > > Could you please provide the OF pipeline (flows and groups) and an > ofproto/trace command that triggers that fault? > > Thanks, Jan Hi, Jan my br-int has the below ports: 1(dpdk0): addr:08:00:27:c6:9f:ff

Re: [ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Hi Yi, Could you please provide the OF pipeline (flows and groups) and an ofproto/trace command that triggers that fault? Thanks, Jan > -Original Message- > From: Yang, Yi [mailto:yi.y.y...@intel.com] > Sent: Friday, 23 March, 2018 04:53 > To: d...@openvswitch.org > Cc: Jan Scheurich

[ovs-dev] OVS will hit an assert if encap(nsh) is done in bucket of group

Hi, guys A NSH user found OVS will hit the below assert in function commit_set_nsh_action in file lib/odp-util.c if encap(nsh) is done in bucket of group ovs_assert(flow->nsh.mdtype == base_flow->nsh.mdtype && flow->nsh.np == base_flow->nsh.np); But it isn't an issue if