Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-27 Thread Jarno Rajahalme
> On Jan 27, 2017, at 1:01 PM, Thomas Morin wrote: > > Jarno, > > 2017-01-27, Jarno Rajahalme: >> Cleanest solution would be to use the new clone action for the datapath, >> which, if important, we could also backport to OVS 2.5.x. > > Yes, clone is indeed much more

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-27 Thread Jarno Rajahalme
> On Jan 27, 2017, at 7:40 AM, Thomas Morin wrote: > > Hi Jarno, all, > > Sorry for being slow to react. > I'd be glad to test a fix, but I'm unclear if there is one ready to be tested. > > Perhasp "xlate: Recirculate also when MPLS POP is implicit." but I'm not sure

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-27 Thread Thomas Morin
Hi Jarno, all, Sorry for being slow to react. I'd be glad to test a fix, but I'm unclear if there is one ready to be tested. Perhasp "xlate: Recirculate also when MPLS POP is implicit." but I'm not sure there has been a follow-up to the discuss between you and Ben? Or is the new clone action

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-05 Thread Jarno Rajahalme
I sent a patch to do this fix on OVS master. IMO we should also make the datapath more flexible so that it would be able to POP back to IP after PUSH actions on an IP packet in the same action list. But that will not make it to OVS 2.7. I would appreciate if Thomas could apply the and test!

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-13 Thread Takashi YAMAMOTO
On Wed, Dec 14, 2016 at 9:02 AM, Jarno Rajahalme wrote: > > On Dec 13, 2016, at 3:32 PM, Takashi YAMAMOTO wrote: > > > > On Tue, Dec 13, 2016 at 6:49 PM, Thomas Morin > wrote: > >> Hi Jarno, >> >> 2016-12-10, Jarno Rajahalme: >> >> On

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-13 Thread Takashi YAMAMOTO
On Tue, Dec 13, 2016 at 6:49 PM, Thomas Morin wrote: > Hi Jarno, > > 2016-12-10, Jarno Rajahalme: > > On Dec 9, 2016, at 7:04 AM, Thomas Morin wrote: > > > 2016-12-09, Thomas Morin: > > In the same setup as the one on which the bug was observed,

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-13 Thread Thomas Morin
Hi Jarno, 2016-12-10, Jarno Rajahalme: On Dec 9, 2016, at 7:04 AM, Thomas Morin > wrote: 2016-12-09, Thomas Morin: In the same setup as the one on which the bug was observed, [...] I was confused, I in fact tested the patch

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-09 Thread Jarno Rajahalme
> On Dec 9, 2016, at 7:04 AM, Thomas Morin wrote: > > 2016-12-09, Thomas Morin: >> In the same setup as the one on which the bug was observed, [...] > > I was confused, I in fact tested the patch (branch-2.5) on a /different/ > setup as the one on which we hit the

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-09 Thread Thomas Morin
2016-12-09, Thomas Morin: In the same setup as the one on which the bug was observed, [...] I was confused, I in fact tested the patch (branch-2.5) on a /different/ setup as the one on which we hit the bug, using MPLS over a GRE tunnel port, rather than plain MPLS over an eth port. Sorry if

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-09 Thread Thomas Morin
Hi Jarno, 2016-12-03, Jarno Rajahalme: I sent a patch to fix this on OVS master. After it is reviewed I’ll backport it to branch-2.5 (it only needs trivial fixes to apply, so you may want to try that as well). I tested the patch (on branch-2.5) and have mixed results. In the same setup as

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-05 Thread Thomas Morin
2016-12-03, Jarno Rajahalme: I sent a patch to fix this on OVS master. After it is reviewed I’ll backport it to branch-2.5 (it only needs trivial fixes to apply, so you may want to try that as well). Thank you very much. I'll try it this week. Best, -Thomas On Dec 1, 2016, at 5:57 PM,

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-02 Thread Jarno Rajahalme
I sent a patch to fix this on OVS master. After it is reviewed I’ll backport it to branch-2.5 (it only needs trivial fixes to apply, so you may want to try that as well). Jarno > On Dec 1, 2016, at 5:57 PM, Jarno Rajahalme wrote: > > >> On Nov 30, 2016, at 8:50 PM, Ben

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-02 Thread Thomas Morin
Hi Jarno, 2016-12-02, Jarno Rajahalme: 2016-11-29T14:44:40.126Z|1|odp_util(revalidator45)|WARN|commit_set_ipv4_action assert would fail 2016-11-29T14:44:40.126Z|2|odp_util(revalidator45)|WARN| base_flow:

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-02 Thread Takashi YAMAMOTO
hi, On Fri, Dec 2, 2016 at 10:57 AM, Jarno Rajahalme wrote: > > > On Nov 30, 2016, at 8:50 PM, Ben Pfaff wrote: > > > > On Wed, Nov 30, 2016 at 06:58:57PM -0800, Jarno Rajahalme wrote: > >> > >>> On Nov 30, 2016, at 8:41 AM, Ben Pfaff wrote: > >>> >

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-01 Thread Jarno Rajahalme
> On Nov 30, 2016, at 8:50 PM, Ben Pfaff wrote: > > On Wed, Nov 30, 2016 at 06:58:57PM -0800, Jarno Rajahalme wrote: >> >>> On Nov 30, 2016, at 8:41 AM, Ben Pfaff wrote: >>> >>> On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: Hi Ben,

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-11-30 Thread Ben Pfaff
On Wed, Nov 30, 2016 at 06:58:57PM -0800, Jarno Rajahalme wrote: > > > On Nov 30, 2016, at 8:41 AM, Ben Pfaff wrote: > > > > On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: > >> Hi Ben, > >> > >> 2016-11-30, Ben Pfaff: > >>> Do you have any idea what in your

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-11-30 Thread Jarno Rajahalme
> On Nov 30, 2016, at 8:41 AM, Ben Pfaff wrote: > > On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: >> Hi Ben, >> >> 2016-11-30, Ben Pfaff: >>> Do you have any idea what in your OpenFlow pipeline might do that, >>> i.e. is there anything especially tricky in the

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-11-30 Thread Ben Pfaff
On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: > Hi Ben, > > 2016-11-30, Ben Pfaff: > >Do you have any idea what in your OpenFlow pipeline might do that, > >i.e. is there anything especially tricky in the OpenFlow flows? > > > > Are you willing to show us your OpenFlow flow table?

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-11-30 Thread Simon Horman
Hi Thomas, On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: > Hi Ben, > > 2016-11-30, Ben Pfaff: > >Do you have any idea what in your OpenFlow pipeline might do that, > >i.e. is there anything especially tricky in the OpenFlow flows? > > > > Are you willing to show us your OpenFlow

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-11-30 Thread Thomas Morin
Hi Ben, 2016-11-30, Ben Pfaff: Do you have any idea what in your OpenFlow pipeline might do that, i.e. is there anything especially tricky in the OpenFlow flows? > > Are you willing to show us your OpenFlow flow table? The setup involves three OVS bridges connected with patch-ports: br-int