Re: [ovs-dev] [PATCH 09/15] ovsdb-server: Add support for a built-in _Server database.

2018-02-01 Thread Justin Pettit
> On Feb 1, 2018, at 11:10 AM, Ben Pfaff wrote: > > I think that these are the same things that are getting allocated in > open_db() for "real" databases, so they should be getting freed in the > same way. (Maybe there is a memory leak in that case too, but I do not > see it

Re: [ovs-dev] [PATCH 09/15] ovsdb-server: Add support for a built-in _Server database.

2018-02-01 Thread Ben Pfaff
On Thu, Feb 01, 2018 at 11:05:35AM -0800, Justin Pettit wrote: > > > On Feb 1, 2018, at 10:59 AM, Ben Pfaff wrote: > > > > On Tue, Jan 30, 2018 at 03:27:18PM -0800, Justin Pettit wrote: > >> > >>> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > >>> > >>> @@ -328,6

Re: [ovs-dev] [PATCH 09/15] ovsdb-server: Add support for a built-in _Server database.

2018-02-01 Thread Justin Pettit
> On Feb 1, 2018, at 10:59 AM, Ben Pfaff wrote: > > On Tue, Jan 30, 2018 at 03:27:18PM -0800, Justin Pettit wrote: >> >>> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: >>> >>> @@ -328,6 +333,7 @@ main(int argc, char *argv[]) >>>ovs_fatal(0, "%s",

Re: [ovs-dev] [PATCH 09/15] ovsdb-server: Add support for a built-in _Server database.

2018-02-01 Thread Ben Pfaff
On Tue, Jan 30, 2018 at 03:27:18PM -0800, Justin Pettit wrote: > > > On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > > > @@ -5,6 +7,7 @@ > > /ovsdb-idlc > > /ovsdb-server > > /ovsdb-server.1 > > +/ovsdb-server.5 > > Do you need to add the new man page to the distributions?

Re: [ovs-dev] [PATCH 09/15] ovsdb-server: Add support for a built-in _Server database.

2018-01-30 Thread Justin Pettit
> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > @@ -5,6 +7,7 @@ > /ovsdb-idlc > /ovsdb-server > /ovsdb-server.1 > +/ovsdb-server.5 Do you need to add the new man page to the distributions? debian/openvswitch-switch.manpages rhel/openvswitch-fedora.spec.in