Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-19 Thread Darrell Ball
On 5/19/17, 6:39 AM, "Ilya Maximets" wrote: On 18.05.2017 16:34, Aaron Conole wrote: > Hi Ilya, > > Ilya Maximets writes: > >> On 17.05.2017 18:32, Darrell Ball wrote: >>> >>> >>> On 5/17/17, 7:59 AM, "Ilya

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-19 Thread Ilya Maximets
On 18.05.2017 16:34, Aaron Conole wrote: > Hi Ilya, > > Ilya Maximets writes: > >> On 17.05.2017 18:32, Darrell Ball wrote: >>> >>> >>> On 5/17/17, 7:59 AM, "Ilya Maximets" wrote: >>> >>> I guess, we need some more opinions about this. >>>

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-18 Thread Aaron Conole
Hi Ilya, Ilya Maximets writes: > On 17.05.2017 18:32, Darrell Ball wrote: >> >> >> On 5/17/17, 7:59 AM, "Ilya Maximets" wrote: >> >> I guess, we need some more opinions about this. >> >> My comments inline. >> >> Best

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-18 Thread Ilya Maximets
On 17.05.2017 18:32, Darrell Ball wrote: > > > On 5/17/17, 7:59 AM, "Ilya Maximets" wrote: > > I guess, we need some more opinions about this. > > My comments inline. > > Best regards, Ilya Maximets. > > On 13.05.2017 07:00, Darrell Ball

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-17 Thread Ilya Maximets
I guess, we need some more opinions about this. My comments inline. Best regards, Ilya Maximets. On 13.05.2017 07:00, Darrell Ball wrote: > > > On 5/12/17, 8:04 AM, "Ilya Maximets" wrote: > > On 05.04.2017 22:34, Darrell Ball wrote: > > > > > > On

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-12 Thread Darrell Ball
On 5/12/17, 8:04 AM, "Ilya Maximets" wrote: On 05.04.2017 22:34, Darrell Ball wrote: > > > On 4/3/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya Maximets" wrote:

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-05-12 Thread Ilya Maximets
On 05.04.2017 22:34, Darrell Ball wrote: > > > On 4/3/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya > Maximets" i.maxim...@samsung.com> wrote: > > Currently, signed integer is used for 'port_id' variable and > '-1' as

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-04-05 Thread Darrell Ball
On 4/3/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya Maximets" wrote: Currently, signed integer is used for 'port_id' variable and '-1' as identifier of bad or uninitialized 'port_id'.

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-04-03 Thread Aaron Conole
Ilya Maximets writes: > Currently, signed integer is used for 'port_id' variable and > '-1' as identifier of bad or uninitialized 'port_id'. > > This inconsistent with dpdk library and, also, in few cases, > leads to passing '-1' to dpdk functions where uint8_t expected.