Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

2022-09-09 Thread Han Zhou
On Fri, Sep 9, 2022 at 4:41 AM Dumitru Ceara wrote: > > On 9/9/22 07:26, Han Zhou wrote: > > Thanks for the review and sorry for the late response. > > > > On Tue, Aug 23, 2022 at 5:22 AM Dumitru Ceara wrote: > >> > >> Hi Han, > >> > >> On 8/23/22 06:44, Han Zhou wrote: > >>> On Tue, Jul 5, 2022

Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

2022-09-09 Thread Dumitru Ceara
On 9/9/22 07:26, Han Zhou wrote: > Thanks for the review and sorry for the late response. > > On Tue, Aug 23, 2022 at 5:22 AM Dumitru Ceara wrote: >> >> Hi Han, >> >> On 8/23/22 06:44, Han Zhou wrote: >>> On Tue, Jul 5, 2022 at 3:41 PM Han Zhou wrote: The column was not tracked before

Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

2022-09-08 Thread Han Zhou
Thanks for the review and sorry for the late response. On Tue, Aug 23, 2022 at 5:22 AM Dumitru Ceara wrote: > > Hi Han, > > On 8/23/22 06:44, Han Zhou wrote: > > On Tue, Jul 5, 2022 at 3:41 PM Han Zhou wrote: > >> > >> The column was not tracked before while it should. The column includes > >>

Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

2022-08-23 Thread Dumitru Ceara
Hi Han, On 8/23/22 06:44, Han Zhou wrote: > On Tue, Jul 5, 2022 at 3:41 PM Han Zhou wrote: >> >> The column was not tracked before while it should. The column includes >> many ovn-controller global configurations that could impact the way >> flows are computed. It worked before because lots of

Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

2022-08-22 Thread Han Zhou
On Tue, Jul 5, 2022 at 3:41 PM Han Zhou wrote: > > The column was not tracked before while it should. The column includes > many ovn-controller global configurations that could impact the way > flows are computed. It worked before because lots of the configurations > are also populated to OVN-SB

Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

2022-07-05 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #36 FILE: controller/ovn-controller.c:926: * XXX: when