Re: [ovs-dev] [PATCH v10] utilities/ofctl: add-meters for save and restore

2023-05-04 Thread Ilya Maximets
On 4/11/23 15:25, Wan Junjie via dev wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie Hi. Thanks for the patch! See some comemnts inline. Best

Re: [ovs-dev] [PATCH v10] utilities/ofctl: add-meters for save and restore

2023-04-17 Thread Simon Horman
On Tue, Apr 11, 2023 at 09:25:43PM +0800, Wan Junjie wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie > > --- > v10: > merge oneline to verbosity

Re: [ovs-dev] [PATCH v10] utilities/ofctl: add-meters for save and restore

2023-04-11 Thread 0-day Robot
Bleep bloop. Greetings Wan Junjie, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #195 FILE: lib/ofp-meter.c:871: error =