Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-06 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 11:42:18AM -0800, Ben Pfaff wrote: > On Mon, Nov 05, 2018 at 06:17:54PM +0100, Lorenzo Bianconi wrote: > > > > > > Thanks for the patch. > > > > Hi Ben, > > > > thx for the review. Few comments inline. > > > > Regards, > > Lorenzo > > > > > > > > I'm not sure in what

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 06:17:54PM +0100, Lorenzo Bianconi wrote: > > > > Thanks for the patch. > > Hi Ben, > > thx for the review. Few comments inline. > > Regards, > Lorenzo > > > > > I'm not sure in what circumstances a broadcast domain would be shared > > among deployments. I tend to

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-05 Thread Lorenzo Bianconi
> > Thanks for the patch. Hi Ben, thx for the review. Few comments inline. Regards, Lorenzo > > I'm not sure in what circumstances a broadcast domain would be shared > among deployments. I tend to think of OVN L2 networks as contained. > But I guess this patch was written for a reason, so it

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-05 Thread Ben Pfaff
Thanks for the patch. I'm not sure in what circumstances a broadcast domain would be shared among deployments. I tend to think of OVN L2 networks as contained. But I guess this patch was written for a reason, so it must be common enough. I can see at least two possible routes here: - The

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-10-26 Thread Mark Michelson
Looks good, Lorenzo, Just to reaaffirm my previous ack: Acked-by: Mark Michelson On 10/26/2018 12:20 PM, Lorenzo Bianconi wrote: Add the possibility to specify a given mac address prefix for dynamically generated mac address. Mac address prefix can be specified in nbdb NB_Global table,