Re: [ovs-dev] [PATCH v2] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-15 Thread Stokes, Ian
> >> Thanks for the patch, in general this looks ok to me, but I realize Ilya > >> had a > few comments on the v1. I think these are addressed here but maybe Ilya would > like to confirm before sign off? > > > > Thanks, Ian. > > I'll take a look at this patch tomorrow. > > > >> > >> @Ilya

Re: [ovs-dev] [PATCH v2] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-15 Thread Ilya Maximets
On 2/14/22 18:35, Ilya Maximets wrote: > On 2/14/22 17:39, Stokes, Ian wrote: >>> The subtable search function can be used at any time by a PMD thread. >>> Setting the subtable search function should be done atomically to >>> prevent garbage data from being read. >>> >>> A

Re: [ovs-dev] [PATCH v2] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-14 Thread Ilya Maximets
On 2/14/22 17:39, Stokes, Ian wrote: >> The subtable search function can be used at any time by a PMD thread. >> Setting the subtable search function should be done atomically to >> prevent garbage data from being read. >> >> A dpcls_subtable_lookup_reprobe() call can happen at the same time that

Re: [ovs-dev] [PATCH v2] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-14 Thread Stokes, Ian
> The subtable search function can be used at any time by a PMD thread. > Setting the subtable search function should be done atomically to > prevent garbage data from being read. > > A dpcls_subtable_lookup_reprobe() call can happen at the same time that > DPCLS subtables are being sorted. This