Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Ilya Maximets
On 7/7/23 16:50, Eelco Chaudron wrote: > > > On 7 Jul 2023, at 16:48, Ilya Maximets wrote: > >> On 7/7/23 16:42, Eelco Chaudron wrote: >>> >>> >>> On 7 Jul 2023, at 16:06, Ilya Maximets wrote: >>> On 7/7/23 15:51, Eric Garver wrote: > On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Eelco Chaudron
On 7 Jul 2023, at 16:48, Ilya Maximets wrote: > On 7/7/23 16:42, Eelco Chaudron wrote: >> >> >> On 7 Jul 2023, at 16:06, Ilya Maximets wrote: >> >>> On 7/7/23 15:51, Eric Garver wrote: On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote: > > > On 7 Jul 2023, at

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Ilya Maximets
On 7/7/23 16:42, Eelco Chaudron wrote: > > > On 7 Jul 2023, at 16:06, Ilya Maximets wrote: > >> On 7/7/23 15:51, Eric Garver wrote: >>> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote: On 7 Jul 2023, at 13:08, Ilya Maximets wrote: > On 7/5/23 21:47, Eelco

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Eelco Chaudron
On 7 Jul 2023, at 16:06, Ilya Maximets wrote: > On 7/7/23 15:51, Eric Garver wrote: >> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote: >>> >>> >>> On 7 Jul 2023, at 13:08, Ilya Maximets wrote: >>> On 7/5/23 21:47, Eelco Chaudron wrote: > > > On Wed, Jul 5, 2023

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Ilya Maximets
On 7/7/23 15:51, Eric Garver wrote: > On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote: >> >> >> On 7 Jul 2023, at 13:08, Ilya Maximets wrote: >> >>> On 7/5/23 21:47, Eelco Chaudron wrote: On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote: On Wed, Jul 05,

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Eric Garver
On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote: > > > On 7 Jul 2023, at 13:08, Ilya Maximets wrote: > > > On 7/5/23 21:47, Eelco Chaudron wrote: > >> > >> > >> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote: > >> > >> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Eelco Chaudron
On 7 Jul 2023, at 13:08, Ilya Maximets wrote: > On 7/5/23 21:47, Eelco Chaudron wrote: >> >> >> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote: >> >> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote: >> > >> > >> > On 30 Jun 2023, at 21:05, Eric Garver wrote: >>

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-07 Thread Ilya Maximets
On 7/5/23 21:47, Eelco Chaudron wrote: > > > On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote: > > On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote: > > > > > > On 30 Jun 2023, at 21:05, Eric Garver wrote: > > Hi Eric, > > > > I started reviewing the

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-05 Thread Eelco Chaudron
On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote: > On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote: > > > > > > On 30 Jun 2023, at 21:05, Eric Garver wrote: > > Hi Eric, > > > > I started reviewing the series, and this test was failing every other > run for me on

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-05 Thread Eric Garver
On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote: > > > On 30 Jun 2023, at 21:05, Eric Garver wrote: > Hi Eric, > > I started reviewing the series, and this test was failing every other run for > me on ‘check-system-userspace’. I ended up making the following additional >

Re: [ovs-dev] [PATCH v2 4/4] tests: system-traffic: add coverage for drop action

2023-07-05 Thread Eelco Chaudron
On 30 Jun 2023, at 21:05, Eric Garver wrote: Hi Eric, I started reviewing the series, and this test was failing every other run for me on ‘check-system-userspace’. I ended up making the following additional change: diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index