Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-07 Thread Bodireddy, Bhanuprakash
>"Bodireddy, Bhanuprakash" writes: > >> Hi Aaron, >> >>>Quick comment before I do an in-depth review. >>> >>>One thing that is missing in this series is some form of documentation >>>added to explain why this feature should exist (for instance, why >>>can't the

Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-06 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: > Hi Aaron, > >>Quick comment before I do an in-depth review. >> >>One thing that is missing in this series is some form of documentation added >>to explain why this feature should exist (for instance, why can't the standard

Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-06 Thread Bodireddy, Bhanuprakash
Hi Aaron, >Quick comment before I do an in-depth review. > >One thing that is missing in this series is some form of documentation added >to explain why this feature should exist (for instance, why can't the standard >posix process accounting information suffice?) and what the high-level

Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-06 Thread Aaron Conole
Hi Bhanu, Bhanuprakash Bodireddy writes: > Keepalive feature is aimed at achieving Fastpath Service Assurance > in OVS-DPDK deployments. It adds support for monitoring the packet > processing cores(PMD thread cores) by dispatching heartbeats at regular >

Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-05 Thread Fischetti, Antonio
Hi Bhanu, I added some comments on patches #2, 5 and 7. Besides that LGTM. I applied this patch series to commit 84d2723305064e25402cb89a16bf7ad1aa2cda70 and it works as expected. -Antonio > -Original Message- > From: ovs-dev-boun...@openvswitch.org