Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-20 Thread Darrell Ball
On Tue, Aug 20, 2019 at 12:30 PM Yi-Hung Wei wrote: > On Tue, Aug 20, 2019 at 12:46 AM Darrell Ball wrote: > > After fixing a bug in my proposed incremental and adding tracking of an > already removed sub timeout policy: > > Pls double check. > > Thanks for the proposed incremental. > > I

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-20 Thread Yi-Hung Wei
On Tue, Aug 20, 2019 at 12:46 AM Darrell Ball wrote: > After fixing a bug in my proposed incremental and adding tracking of an > already removed sub timeout policy: > Pls double check. Thanks for the proposed incremental. I checked all the other logging places in dpif-netlink, we usually do

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-20 Thread Darrell Ball
On Mon, Aug 19, 2019 at 7:41 PM Darrell Ball wrote: > > > On Mon, Aug 19, 2019 at 12:42 PM Darrell Ball wrote: > >> >> >> On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei >> wrote: >> >>> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: >>> > >>> > Thanks for the patch >>> > >>> > Pls let me

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-19 Thread Darrell Ball
On Mon, Aug 19, 2019 at 12:42 PM Darrell Ball wrote: > > > On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei wrote: > >> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: >> > >> > Thanks for the patch >> > >> > Pls let me know if this incremental works for you. >> > Main change is logging fix

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-19 Thread Darrell Ball
On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei wrote: > On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: > > > > Thanks for the patch > > > > Pls let me know if this incremental works for you. > > Main change is logging fix for timeout policy deletion. > > > > Darrell > > > > diff --git

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-19 Thread Yi-Hung Wei
On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: > > Thanks for the patch > > Pls let me know if this incremental works for you. > Main change is logging fix for timeout policy deletion. > > Darrell > > diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c > index 1d4ee60..00d957b 100644 > ---

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-16 Thread Darrell Ball
Thanks for the patch Pls let me know if this incremental works for you. Main change is logging fix for timeout policy deletion. Darrell diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 1d4ee60..00d957b 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2822,11 +2822,10 @@