Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-27 Thread Russell Bryant
On Tue, Jul 18, 2017 at 2:05 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil > > This change adds commands to set, get and delete gateway chassis > for logical router port. > > Signed-off-by: Venkata Anil Kommaddi > --- >

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-20 Thread Miguel Angel Ajo Pelayo
ack, ok, from that point of view, current name makes more sense IMO. Thank you. On Thu, Jul 20, 2017 at 6:22 PM, Anil Venkata wrote: > Thanks Miguel. > lrp-set-gateway-chassis is also used for updating the priority. > User can initially set priority to some value and

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-20 Thread Anil Venkata
Thanks Miguel. lrp-set-gateway-chassis is also used for updating the priority. User can initially set priority to some value and later can update with another value. For example, user can add chassis with priority 5, later can update it to 10 ovn-nbctl lrp-set-gateway-chassis lrp0 chassis1 5

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-20 Thread Miguel Angel Ajo Pelayo
One last comment, sorry to come late with more comments: if lrp-set-gateway-chassis is additive, shouldn't we rename it to: lrp-add-gateway-chassis ? Thanks, and best regards On Tue, Jul 18, 2017 at 8:05 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil