Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2019-02-06 Thread Darrell Ball
Thanks very much for the thorough review sorry; I made the changes last year and then ran into vacation and internal priorities. On Tue, Dec 11, 2018 at 8:15 AM Ben Pfaff wrote: > On Mon, Nov 19, 2018 at 11:09:25AM -0800, Darrell Ball wrote: > > Fragmentation handling is added for supporting

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-12-12 Thread Darrell Ball
I'll respond to the individual comments soon, although some comments are answered by subsequent patches. I did notice a problem that I will fix and make adjustments for, in that the ipf context should have been per datapath. Thanks Darrell On Tue, Dec 11, 2018 at 8:15 AM Ben Pfaff wrote: > On

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-12-11 Thread Ben Pfaff
On Mon, Nov 19, 2018 at 11:09:25AM -0800, Darrell Ball wrote: > Fragmentation handling is added for supporting conntrack. > Both v4 and v6 are supported. > > After discussion with several people, I decided to not store > configuration state in the database to be more consistent with > the kernel

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-11-19 Thread Darrell Ball
I folded in the following incremental locally to address: 1/ Below mentioned capitalization inconsistency in 'releases.rst'. 2/ Misplaced counter increment. Darrell diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index d281c97..1fb3b1c 100644 ---

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-11-19 Thread Darrell Ball
On Mon, Nov 19, 2018 at 11:11 AM Darrell Ball wrote: > Fragmentation handling is added for supporting conntrack. > Both v4 and v6 are supported. > > After discussion with several people, I decided to not store > configuration state in the database to be more consistent with > the kernel in