Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-10-25 Thread Ben Pfaff
> @@ -2336,6 +2364,7 @@ netdev_dpdk_update_flags__(struct netdev_dpdk *dev, > } > } > > +dev->flags = new_flags; > return 0; > } > > --8<--------------------->8-- > > Also, the diff a

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-08-01 Thread Ilya Maximets
rte_strerror(-diag)); + return -diag; + } } rte_eth_promiscuous_enable(dev->port_id); --8<->8-- It is to prevent stopped port starting on each reconfiguration. > Be

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-08-01 Thread Ilya Maximets
-->8-- Also, the diff above made on top of current master. So, you possibly will need to port it a little. Best regards, Ilya Maximets. > > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Monday, July 31,

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-08-01 Thread Keshav Gupta
packet (dpdk Rxq size)). Thanks Keshav -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Monday, July 31, 2017 9:26 PM To: Ilya Maximets Cc: ovs-dev@openvswitch.org; Keshav Gupta Subject: Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-31 Thread Ben Pfaff
Thanks. It doesn't cherry-pick cleanly to branch-2.6, so I think I'll leave it for now since Darrell made the reasonable point that DPDK was experimental in 2.6. On Mon, Jul 31, 2017 at 06:20:28PM +0300, Ilya Maximets wrote: > On 31.07.2017 16:05, Ben Pfaff wrote: > > Ilya, should we apply this

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-31 Thread Ben Pfaff
vswitch.org" <ovs-dev@openvswitch.org>, Keshav Gupta > <keshav.gu...@ericsson.com> > Subject: Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond > port using "ovs-ofctl mod-port br-prv dpdk1 down" > > Ilya, should we apply this patch to branch-2.

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-31 Thread Ilya Maximets
On 31.07.2017 16:05, Ben Pfaff wrote: > Ilya, should we apply this patch to branch-2.6? Are there other patches > that should be backported? It's definitely a bug and should be backported if someone wants to use barnch-2.6 with DPDK datapath. I traced only this exact case, so it's hard to say if

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-31 Thread Ben Pfaff
Ilya, should we apply this patch to branch-2.6? Are there other patches that should be backported? On Wed, Jul 26, 2017 at 03:28:12PM +0300, Ilya Maximets wrote: > Hi. > > You need to backport at least following patch: > > commit 3b1fb0779b87788968c1a6a9ff295a9883547485 > Author: Daniele Di

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-31 Thread Keshav Gupta
'; ovs-dev@openvswitch.org Subject: RE: Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down" Thanks Ilya Maximets It fixes the issue. Thanks Keshav -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-27 Thread Keshav Gupta
penvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down" Hi. You need to backport at least following patch: commit 3b1fb0779b87788968c1a6a9ff295a9883547485 Author: Daniele Di Proietto <diproiet...@vmware.com> Date: Tue Nov 15 15:40:49 2

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

2017-07-26 Thread Ilya Maximets
Hi. You need to backport at least following patch: commit 3b1fb0779b87788968c1a6a9ff295a9883547485 Author: Daniele Di Proietto Date: Tue Nov 15 15:40:49 2016 -0800 netdev-dpdk: Don't call rte_dev_stop() in update_flags(). Calling rte_eth_dev_stop() while