[ovs-dev] [PATCH] netdev-dpdk: fix flow based tunnel

The push/pop header of flow based tunnel is generated dynamically by flows, so there won't be any tunnel header associated to netdev. The patch fixes that tnl_port_cache doesn't contain any flow based tunnel. Signed-off-by: Zang MingJie --- lib/dpif-netdev.c | 2 +-

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix mempool_configure error state

> netdev_dpdk_mempool_configure obtains a handle to a DPDK memory pool via a > call to dpdk_mp_get. If dpdk_mp_get fails, the former informs the user > that insufficient memory is available, and returns ENOMEM. However, this > is potentially misleading, as there are a number of reasons why

Re: [ovs-dev] [PATCH] netdev-dpdk: fix mempool_configure error state

> netdev_dpdk_mempool_configure obtains a handle to a DPDK memory pool via a > call to dpdk_mp_get. If dpdk_mp_get fails, the former informs the user > that insufficient memory is available, and returns ENOMEM. However, this > is potentially misleading, as there are a number of reasons why

[ovs-dev] [PATCH V2] netdev-dpdk: fix mempool_configure error state

netdev_dpdk_mempool_configure obtains a handle to a DPDK memory pool via a call to dpdk_mp_get. If dpdk_mp_get fails, the former informs the user that insufficient memory is available, and returns ENOMEM. However, this is potentially misleading, as there are a number of reasons why creation of a

Re: [ovs-dev] [PATCH] netdev-dpdk: fix mempool_configure error state

> >> netdev_dpdk_mempool_configure obtains a handle to a DPDK memory pool via a >> call to dpdk_mp_get. If dpdk_mp_get fails, the former informs the user >> that insufficient memory is available, and returns ENOMEM. However, this >> is potentially misleading, as there are a number of reasons why

[ovs-dev] [PATCH ovs V4 22/24] tests: Add system-offloads-testsuite

From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey

[ovs-dev] [PATCH ovs V4 19/24] netdev-vport: Use common offloads interface

From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan ---

[ovs-dev] [PATCH ovs V4 18/24] netdev-linux: Disallow setting policing when configured with hw offload

From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-linux.c |8 1 files changed, 8

[ovs-dev] [PATCH ovs V4 06/24] dpif-netlink: Flush added ports using netdev flow api

From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c |5 + lib/netdev.c | 12

[ovs-dev] [PATCH ovs V4 05/24] dpif: Save added ports in a port map for netdev flow api use

From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by:

[ovs-dev] [PATCH ovs V4 02/24] netdev: Adding a new netdev api to be used for offloading flows

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/automake.mk |2 + lib/netdev-bsd.c |2 + lib/netdev-dpdk.c|1 + lib/netdev-dummy.c |2 + lib/netdev-linux.c

[ovs-dev] [PATCH ovs V4 20/24] netdev-tc-offloads: Add ingress on netdev flow api init

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/lib/netdev-tc-offloads.c

[ovs-dev] [PATCH ovs V4 13/24] netdev-tc-offloads: Implement netdev flow put using tc interface

From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 309 - 1 files changed, 302 insertions(+), 7

[ovs-dev] [PATCH ovs V4 24/24] netdev: Init flow api on already added ports on offload enable

From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev.c | 14

[ovs-dev] [PATCH ovs V4 09/24] netdev-tc-offloads: Add ufid to tc/netdev map

From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey

[ovs-dev] [PATCH ovs V4 04/24] other-config: Add tc-policy switch to control tc flower flag

From: Paul Blakey Add a new configuration tc-policy option that controls tc flower flag. Possible options are none, skip_sw, skip_hw. The default is none which is to insert the rule both to sw and hw. This option is only relevant if hw-offload is enabled. Signed-off-by: Paul

[ovs-dev] [PATCH net] vxlan: fix ovs support

The required changes in the function vxlan_dev_create() were missing in commit 8bcdc4f3a20b. The vxlan device is not registered anymore after this patch and the error path causes an stack dump: WARNING: CPU: 3 PID: 1498 at net/core/dev.c:6713 rollback_registered_many+0x9d/0x3f0 Fixes:

[ovs-dev] [PATCH ovs V4 10/24] netdev-tc-offloads: Implement netdev flow dump api using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 161 +++-- 1 files changed, 153 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH ovs V4 11/24] dpif-netlink: Use netdev flow put api to insert a flow

From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan

[ovs-dev] [PATCH ovs V4 15/24] netdev-tc-offloads: Implement netdev flow del using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 33 ++--- 1 files changed, 30 insertions(+), 3 deletions(-) diff --git a/lib/netdev-tc-offloads.c

[ovs-dev] [PATCH ovs V4 16/24] dpif-netlink: Use netdev flow get api to query a flow

From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c | 50

[ovs-dev] [PATCH ovs V4 01/24] tc: Add tc flower interface

From: Paul Blakey Add tc flower interface that will be used to offload flows via tc flower classifier. Depending on the flag used (skip_sw/hw) flower will pass those to HW or handle them itself. Move some tc related functions from netdev-linux.c to tc.c Co-authored-by:

[ovs-dev] [PATCH v2] ofproto: Add some examples for 'ofproto/trace' in ovs-vswitchd man page

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1339097 Signed-off-by: Timothy Redaelli --- Changes in v2: - Don't use mask, but use an example MAC address for dl_dst ofproto/ofproto-unixctl.man | 36 1 file changed, 36

[ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support native DNS

From: Numan Siddique OVN implements native DNS resolution which can be used to resolve the internal DNS names belonging to a logical datapath. To support this, the logical ports should be configured with the hostname in the 'Logical_Switch_Port.options:hostname' and an

[ovs-dev] [PATCH v2 1/2] ovn-controller: Add 'dns_lookup' action

From: Numan Siddique This patch adds a new OVN action 'dns_lookup' to support native DNS. ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow with 'pause' flag set. A new table 'DNS' is added in the SB DB to look up and resolve the DNS queries. When a valid

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Add 'dns_lkup' action

Thanks for the review Ben. Please see inline for few comments. Numan On Wed, Mar 8, 2017 at 10:22 PM, Ben Pfaff wrote: > On Fri, Feb 10, 2017 at 08:02:15PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds a new OVN action

[ovs-dev] Writers for web content

Hello! I hope things are well. Firstly, I am not an SEO =) I am a content writer working for an Agency out of Melbourne. Being a stickler for content I noticed a couple of meta-data related mistakes on your website that I thought I would bring to your attention. It is on one of the inner pages.

[ovs-dev] openvswitch conntrack and nat problem in first packet with RST

Hi all, There is a simple test for conntrack and nat. I want to do stateful firewall with conntrack then do nat netns1 port1 with ip 10.0.0.7 netns2 port2 with ip 1.1.1.7 netns1 10.0.0.7 src -nat to 2.2.1.7 access netns2 1.1.1.7 1. # ovs-ofctl add-flow br0 'ip,in_port=1

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH: Minutes of meeting Mon 2017-03-13, 17:00 CET

Hi Jan, I do not understand the concept of masked packet type. The note below from the call is: - For masked packet_types use “/mask” or “*” notation , e.g. packet_type=(1,*) to match any packet with name space ethertype. Is this intended to relate to the canonical packet type ID or to

Re: [ovs-dev] [PATCH net] vxlan: fix ovs support

From: Nicolas Dichtel Date: Mon, 13 Mar 2017 16:24:03 +0100 > The required changes in the function vxlan_dev_create() were missing > in commit 8bcdc4f3a20b. > The vxlan device is not registered anymore after this patch and the error > path causes an stack dump: >

Re: [ovs-dev] [PATCH v2 1/2] nx-match: Use vl_mff_map to parse match field.

On Fri, Mar 10, 2017 at 11:06 AM, Joe Stringer wrote: > On 9 March 2017 at 10:24, Yi-Hung Wei wrote: > > vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix > variable > > length meta-flow OXMs") to account variable length mf_field, and it is >

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Add ref counting for variable length mf_fields.

On Fri, Mar 10, 2017 at 4:28 PM, Joe Stringer wrote: > On 9 March 2017 at 10:25, Yi-Hung Wei wrote: > > Currently, a controller may potentially trigger a segmentation fault if > it > > accidentally removes a TLV mapping that is still used by an active flow. >

Re: [ovs-dev] Sync on PTAP, EXT-382 and NSH: Minutes of meeting Mon 2017-03-13, 17:00 CET

On Mon, Mar 13, 2017 at 05:23:26PM +, Jan Scheurich wrote: > 2. Kernel datapath tunnel configuration (RedHat, Eric Garver) > * Still no comment yet > * Resend as non-RFC patch to trigger new comments. Please review! > * Jan to include the new patch in Gitlab repo (see

[ovs-dev] [PATCH v3 3/4] ofproto: Add ref counting for variable length mf_fields.

Currently, a controller may potentially trigger a segmentation fault if it accidentally removes a TLV mapping that is still used by an active flow. To resolve this issue, in this patch, we maintain reference counting for each dynamically allocated variable length mf_fields, so that vswitchd can

[ovs-dev] [PATCH v3 4/4] ofproto: Move tun_table and vl_mff_map deletion.

In this patch, we move the tun_table and vl_mff_map deletion in ofproto_destory__() to be in the following order. 1. Delete all the flows. 2. Delete vl_mff_map. 3. Delete tun_table. The rationale behind this order is that a flow may use a variable length mf_field, and a variable length

Re: [ovs-dev] [PATCH RFC v5 0/8] create tunnel devices using rtnetlink interface

Hi Joe, are you the right person to review this series? If not, do you have a suggestion who should? Thanks, Ben. On Thu, Feb 16, 2017 at 05:25:25PM -0500, Eric Garver wrote: > This series adds support for the creation of tunnels using the rtnetlink > interface. This will open the possibility

[ovs-dev] [PATCH v3 1/4] nx-match: Fix oxm decode.

decode_nx_packet_in2() may be used by the switch to parse NXT_RESUME messages, where we need exact match on the oxm header. Therefore, change oxm_decode_loose() to oxm_decode() that takes an extra argument to indicate whether we want strict or loose match. Fixes: 7befb20d0f70 ("ofp-util: Ignore

[ovs-dev] [PATCH v3 2/4] nx-match: Use vl_mff_map to parse match field.

vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs") to account variable length mf_field, and it is used to decode variable length mf_field in ofp_action. In this patch, vl_mff_map is further used to decode the variable length match field as well.

Re: [ovs-dev] [PATCH RFC v5 0/8] create tunnel devices using rtnetlink interface

On 13 March 2017 at 10:34, Ben Pfaff wrote: > Hi Joe, are you the right person to review this series? If not, do you > have a suggestion who should? Yes, I think I'm the right person. I'll start looking at it. ___ dev mailing list

Re: [ovs-dev] [PATCH ovs V4 00/24] Introducing HW offload support for openvswitch

On Mon, Mar 13, 2017 at 03:36:50PM +0200, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are able to

Re: [ovs-dev] [PATCH 1/4] stp: Change the api for next patch.

Is there someone can help me to review stp patches? http://patchwork.ozlabs.org/patch/736157/ http://patchwork.ozlabs.org/patch/736158/ http://patchwork.ozlabs.org/patch/736159/

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

On Fri, Mar 10, 2017 at 4:48 PM, Russell Bryant wrote: > On Fri, Mar 10, 2017 at 2:35 PM, Russell Bryant wrote: >> On Thu, Mar 9, 2017 at 11:52 PM, Numan Siddique wrote: >> I don't think it's a Neutron issue. >> >> I see the conntrack entry

[ovs-dev] [PATCH] ofproto: Add appctl command to show Datapath features

Exporting Datapath runtime detected features can be useful for both debugging and for writing system unit testing easier. Signed-off-by: Andy Zhou --- ofproto/ofproto-dpif.c | 53 +- 1 file changed, 52 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH ovs V4 08/24] dpif-netlink: Dump netdevs flows on flow dump

From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c | 179

[ovs-dev] [PATCH ovs V4 00/24] Introducing HW offload support for openvswitch

This patch series introduces rule offload functionality to dpif-netlink via netdev ports new flow offloading API. The user can specify whether to enable rule offloading or not via OVS configuration. Netdev providers are able to implement netdev flow offload API in order to offload rules. This

[ovs-dev] [PATCH ovs V4 21/24] dpctl: Add an option to dump only certain kinds of flows

From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to dump only flows that are offloaded: ovs-dpctl dump-flows type=offloaded

[ovs-dev] [ovs-dev, RFC] ovn: Revised support for service function chaining

This patch set is an alternative implementation of service function chaining (SFC) for OVS/OVN. The major change from the previous patch is that the overloading of the ACL stage in ovn-northd.c has been removed and replaced with additional logic in the CHAIN stage. This was done to improve

Re: [ovs-dev] OVN: Compromised Chassis Mitigation

> From: "Mickey Spiegel" > To: "Lance Richardson" > Cc: "devovs" > Sent: Thursday, March 9, 2017 6:49:53 PM > Subject: Re: [ovs-dev] OVN: Compromised Chassis Mitigation > > On Thu, Mar 9, 2017 at 8:52 AM, Lance Richardson

[ovs-dev] [PATCH] Document OVN support in ovs-sandbox.

A previous commit removed the original ovs-sandbox based OVN tutorial because it became too outdated and difficult to maintain. However, the use of ovs-sandbox for basic OVN development and testing is incredibly useful, so we should provide at least basic documentation on how to use it. This

[ovs-dev] [RFC] Use tox to build docs.

There have been a few patches lately tweaking docs to deal with different sphinx versions in different linux distributions. This patch demonstrates an alternative approach to avoid those types of issues. Instead of calling sphinx-build directly, it uses tox to build a Python virtual environment