Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Fix comments for dp_netdev_pmd_thread struct.

2017-04-28 Thread Bodireddy, Bhanuprakash
> > >How about something like this ? > >+ * Each struct has its own flow cache and classifier per managed inport. >Packets >+ *received from managed ports are looked up in the corresponding pmd >+ * thread's flow cache and corresponding classifier, if the flow cache >misses. >+ *

Re: [ovs-dev] [action upcall meters 2/5] ofproto-dpif: Use backer to manage datapath meter allocation

2017-04-28 Thread Jarno Rajahalme
> On Apr 27, 2017, at 11:48 PM, Andy Zhou wrote: > > On Thu, Apr 27, 2017 at 3:23 PM, Jarno Rajahalme > wrote: >> >>> On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: >>> >>> Add 'meter_ids', an id-pool object to manage

Re: [ovs-dev] [PATCH] rhel: add python-sphinx as a build dependency

2017-04-28 Thread Russell Bryant
On Wed, Apr 26, 2017 at 11:09 AM, Leif Madsen wrote: > On Tue, Apr 25, 2017 at 4:48 PM, Lance Richardson > wrote: > >> The python-sphinx package is now required in order to build >> man pages, add this package as a build requirement. >> >> Reported-by:

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-28 Thread Jarno Rajahalme
> On Apr 27, 2017, at 11:28 PM, Andy Zhou wrote: > > On Thu, Apr 27, 2017 at 3:14 PM, Jarno Rajahalme > wrote: >> This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially >> being used uninitialized: >> >> diff --git

Re: [ovs-dev] Hi,

2017-04-28 Thread Liezel Delos Trino
-- -- Hi, How are you? I’m s simple and easy going young beautiful girl, I like making friend with you. I'm Liezel Delos. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] config: Define OVS_CT_EVENT_* mask macros.

2017-04-28 Thread Jarno Rajahalme
> On Apr 28, 2017, at 5:56 PM, Joe Stringer wrote: > > On 28 April 2017 at 17:46, Jarno Rajahalme wrote: >> Unconditionally define OVS_CT_EVENT_* macros for the datapath netlink >> interface so that we do not need to include platform dependent files. >> This fixes

[ovs-dev] [PATCH v2] config: Define OVS_CT_EVENT_* mask macros.

2017-04-28 Thread Jarno Rajahalme
Unconditionally define OVS_CT_EVENT_* macros for the datapath netlink interface so that we do not need to include platform dependent files. This fixes the build on non-Linux (and non-Windows) platforms. Also define a macro for the default set of events set by OVS userspace. Reported-by: Joe

Re: [ovs-dev] [PATCH v2] config: Define OVS_CT_EVENT_* mask macros.

2017-04-28 Thread Joe Stringer
On 28 April 2017 at 17:46, Jarno Rajahalme wrote: > Unconditionally define OVS_CT_EVENT_* macros for the datapath netlink > interface so that we do not need to include platform dependent files. > This fixes the build on non-Linux (and non-Windows) platforms. > > Also define a macro

Re: [ovs-dev] [RFC PATCH] config: Compat for older kernels not having IPCT_LABEL.

2017-04-28 Thread Jarno Rajahalme
> On Apr 28, 2017, at 4:53 PM, Joe Stringer wrote: > > On 28 April 2017 at 15:49, Jarno Rajahalme > wrote: >> Detect the presence of enum ip_conntrack_events member IPCT_LABEL at >> configure time, and define it in the generated

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-28 Thread Ben Pfaff
Is it running with the --monitor option? If not, either --monitor should be added or the upstart features should be used. On Fri, Apr 28, 2017 at 05:16:09PM -0700, Aliasgar Mikail Ginwala wrote: > I did double verify: > > This is what is happening after crashing the ovn pid: > > service

Re: [ovs-dev] [PATCH v5] xlate: Use OVS_CT_ATTR_EVENTMASK.

2017-04-28 Thread Joe Stringer
On 27 April 2017 at 17:21, Jarno Rajahalme wrote: > Specify the event mask with CT commit including bits for CT features > exposed at the OVS interface (mark and label changes in addition to > basic creation and destruction of conntrack entries). > > Without this any listener of

[ovs-dev] RFC: ovs-dump-flows utility

2017-04-28 Thread Aaron Conole
Greetings dev, I have whipped up a quick little utility (find below), that I've done a bit of debugging with and it seems to have made working with dump-flows from ovs-ofctl a little easier to use. If you think it's worthwhile to add to the repository, I'll submit it formally. We were using it

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 14:18 -0700, Joe Stringer wrote: > On 28 April 2017 at 14:02, Greg Rose wrote: > > On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: > >> On 27 April 2017 at 16:13, Greg Rose wrote: > >> > Parenthetical imbalance was causing

Re: [ovs-dev] [action upcall meter v2 4/5] ofproto: Meter sample action when configured.

2017-04-28 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Apr 28, 2017, at 2:01 AM, Andy Zhou wrote: > > When slowpath meter is configured, add meter action when translate > sample action. > > Signed-off-by: Andy Zhou > > --- > v1->v2: Fix test case 1128 failure. > --- >

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Joe Stringer
On 28 April 2017 at 14:18, Joe Stringer wrote: > On 28 April 2017 at 14:02, Greg Rose wrote: >> On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: >>> On 27 April 2017 at 16:13, Greg Rose wrote: >>> > Parenthetical imbalance was

Re: [ovs-dev] [PATCH 2/4] acinclude.m4: Add check for struct net parameter

2017-04-28 Thread Joe Stringer
On 27 April 2017 at 14:05, Andy Zhou wrote: > On Thu, Apr 27, 2017 at 1:08 PM, Greg Rose wrote: >> The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 >> >> Signed-off-by: Greg Rose > > Thanks for working on this! > > It

[ovs-dev] Balanced Scorecard - En Línea

2017-04-28 Thread Aplicación e Implementación
En línea y en Vivo / Para todo su Equipo con una sola Conexión BALANCED SCORECARD: APLICACIÓN E IMPLEMENTACIÓN 12 de Mayo - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00Hrs El BSC es un poderoso instrumento para medir el desempeño corporativo y se ha demostrado que es la

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-04-28 Thread Darrell Ball
There two ways to go with the design. 1) Make it generic, so that it is not so PMD specific, as it is now. 2) If it stays PMD specific, make it stronger; right now, the health check is limited – it detects that a PMD thread is proceeding or not. For something like DPDK, I don’t think that

Re: [ovs-dev] [action upcall meter v2 2/5] ofproto-dpif: Add 'meter_ids' to backer

2017-04-28 Thread Jarno Rajahalme
With a note below: Acked-by: Jarno Rajahalme > On Apr 28, 2017, at 2:01 AM, Andy Zhou wrote: > > Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. > provider_meter_id. > > Currently, only userspace datapath supports meter, and it implements >

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Joe Stringer
On 27 April 2017 at 16:13, Greg Rose wrote: > Parenthetical imbalance was causing some checks to not run > > Signed-off-by: Greg Rose > --- > acinclude.m4 | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/acinclude.m4

Re: [ovs-dev] [action upcall meter v2 5/5] ofproto: Meter slowpath action when action upcall meters are configured

2017-04-28 Thread Jarno Rajahalme
With the white-space nits below: Acked-by: Jarno Rajahalme > On Apr 28, 2017, at 2:01 AM, Andy Zhou wrote: > > If a slow path action is a controller action, meter it when the > controller meter is configured. For other kinds of slow path actions, > meter it when

Re: [ovs-dev] [PATCH v5] xlate: Use OVS_CT_ATTR_EVENTMASK.

2017-04-28 Thread Jarno Rajahalme
> On Apr 28, 2017, at 12:31 PM, Joe Stringer wrote: > > On 27 April 2017 at 17:21, Jarno Rajahalme > wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at the OVS interface (mark and label changes in

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: > On 27 April 2017 at 16:13, Greg Rose wrote: > > Parenthetical imbalance was causing some checks to not run > > > > Signed-off-by: Greg Rose > > --- > > acinclude.m4 | 6 +++--- > > 1 file

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Joe Stringer
On 28 April 2017 at 14:02, Greg Rose wrote: > On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: >> On 27 April 2017 at 16:13, Greg Rose wrote: >> > Parenthetical imbalance was causing some checks to not run >> > >> > Signed-off-by: Greg Rose

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 14:21 -0700, Joe Stringer wrote: > On 28 April 2017 at 14:18, Joe Stringer wrote: > > On 28 April 2017 at 14:02, Greg Rose wrote: > >> On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: > >>> On 27 April 2017 at 16:13, Greg Rose

Re: [ovs-dev] [PATCH] db-ctl-base: Allow record UUIDs to be abbreviated.

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 12:36 PM, Ben Pfaff wrote: > This makes it easier to type ovs-vsctl, ovn-sbctl, ovn-nbctl, and vtep-ctl > commands without cut-and-paste. > > Signed-off-by: Ben Pfaff Very handy!. Now I can just use ovs-vsctl list a table, and then dump a row

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-28 Thread Aliasgar Mikail Ginwala
I did double verify: This is what is happening after crashing the ovn pid: service ovn-host status Pidfile for ovn-controller (/var/run/openvswitch/ovn-controller.pid) is stale Works only after manual restart and didn't respawn service ovn-host restart

[ovs-dev] [PATCH] ofp-actions: Document that learn(limit=0) is no limit.

2017-04-28 Thread Joe Stringer
Signed-off-by: Joe Stringer --- include/openvswitch/ofp-actions.h | 2 +- lib/ofp-actions.c | 3 ++- utilities/ovs-ofctl.8.in | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/openvswitch/ofp-actions.h

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 14:33 -0700, Joe Stringer wrote: > On 28 April 2017 at 14:31, Greg Rose wrote: > > On Fri, 2017-04-28 at 14:21 -0700, Joe Stringer wrote: > >> On 28 April 2017 at 14:18, Joe Stringer wrote: > >> > On 28 April 2017 at 14:02, Greg Rose

Re: [ovs-dev] [action upcall meter v2 2/5] ofproto-dpif: Add 'meter_ids' to backer

2017-04-28 Thread Andy Zhou
On Fri, Apr 28, 2017 at 12:47 PM, Jarno Rajahalme wrote: > With a note below: > > Acked-by: Jarno Rajahalme > >> On Apr 28, 2017, at 2:01 AM, Andy Zhou wrote: >> >> Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. >>

[ovs-dev] [ovs and ovn missing respawn]

2017-04-28 Thread Aliasgar Mikail Ginwala
Hello Devs: Recently when I was adding monitoring and alerting for ovs and ovn version 2.7.0, I found both of the upstart services are missing *respawn* . Is it on purpose? If it's not then lets handle it as an improvement to add it in the upstart. Suggestions welcome. Looking forward for your

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-28 Thread Ben Pfaff
On Fri, Apr 28, 2017 at 04:02:26PM -0700, Aliasgar Mikail Ginwala wrote: > Recently when I was adding monitoring and alerting for ovs and ovn version > 2.7.0, I found both of the upstart services are missing *respawn* . Is it > on purpose? If it's not then lets handle it as an improvement to add

Re: [ovs-dev] [PATCH] travis: Break Mac OS build for format specifier warnings.

2017-04-28 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Mar 20, 2017, at 10:10 PM, Ben Pfaff wrote: > > Until now, the Travis build for Mac OS X has been configured to ignore > format specifier warnings. These warnings have now been fixed, so this > commit changes such warnings to error.

Re: [ovs-dev] [PATCH V2 4/4] travis: Update kernels to kernel.org latest

2017-04-28 Thread Joe Stringer
On 27 April 2017 at 16:13, Greg Rose wrote: > Signed-off-by: Greg Rose > --- LGTM, thanks. Will apply to master soon. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH V2 2/4] acinclude.m4: Add check for struct net parameter

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 14:34 -0700, Joe Stringer wrote: > On 27 April 2017 at 16:13, Greg Rose wrote: > > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 > > > > Signed-off-by: Greg Rose > > Thanks for the patch. Since this macro is

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 14:47 -0700, Joe Stringer wrote: [snip] > > I've just started using "git clean" for this purpose, not sure if it's > more or less reliable than your methods. It will clobber any untracked > files though, so don't save any handy scripts in the directory :-) Ah yes, the

Re: [ovs-dev] [RFC 0/2] Rename libopenvswitch to include MAJOR.MINOR number.

2017-04-28 Thread Joe Stringer
On 27 April 2017 at 14:37, Aaron Conole wrote: > Hi Joe, > > Some stream-of-consciousness thoughts follow, sorry if it's a bit > disconnected. Thanks for the thoughts! > Joe Stringer writes: >> * Backport the fix and modify current, for example for 2.7 to

Re: [ovs-dev] [PATCH V2 3/4] compat: Fix build error in kernels 4.10+

2017-04-28 Thread Greg Rose
On Fri, 2017-04-28 at 14:34 -0700, Joe Stringer wrote: > On 27 April 2017 at 16:13, Greg Rose wrote: > > This is an alternative solution patch for the issue reported by > > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses > > the acinclude.m4 configuration

[ovs-dev] [RFC PATCH] config: Compat for older kernels not having IPCT_LABEL.

2017-04-28 Thread Jarno Rajahalme
Detect the presence of enum ip_conntrack_events member IPCT_LABEL at configure time, and define it in the generated odp-netlink.h if missing. This allows OVS userspace to be compiled with older Linux kernel headers, such as those used in Travis userspace builds. Reported-by: Joe Stringer

Re: [ovs-dev] [PATCH] compat: Remove unused netdevice backport code.

2017-04-28 Thread Jarno Rajahalme
Maybe mention in the commit message that these are unused due to older than X.Y.Z Linux kernel versions not being supported any more. Acked-by: Jarno Rajahalme > On Feb 8, 2017, at 4:50 PM, Joe Stringer wrote: > > Signed-off-by: Joe Stringer > ---

Re: [ovs-dev] [PATCH] compat: Remove unused netdevice backport code.

2017-04-28 Thread Joe Stringer
On 28 April 2017 at 16:48, Jarno Rajahalme wrote: > Maybe mention in the commit message that these are unused due to older than > X.Y.Z Linux kernel versions not being supported any more. > > Acked-by: Jarno Rajahalme Done and applied to master, thanks.

Re: [ovs-dev] [v2] vswitchd: Add --cleanup option to the 'appctl exit' command

2017-04-28 Thread Jarno Rajahalme
Some types noted below, otherwise: Acked-by: Jarno Rajahalme > On Apr 26, 2017, at 3:38 PM, Andy Zhou wrote: > > 'appctl exit' stops the running vswitchd daemon, without releasing > the datapath resources (such as bridges and ports) that vswitchd > has created.

Re: [ovs-dev] [PATCH] ofproto-dpif: Send QinQ related sFlow counters

2017-04-28 Thread Rzasik, LukaszX
The discussion has been started on sFlow group and can be found here: https://groups.google.com/forum/#!topic/sflow/S22dbzam404 -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Saturday, April 22, 2017 6:43 AM To: Neil McKee Cc: Eric Garver

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-04-28 Thread Bodireddy, Bhanuprakash
>> This patch is aimed at achieving Fastpath Service Assurance in >> OVS-DPDK deployments. This commit adds support for monitoring the >> packet processing cores(pmd thread cores) by dispatching heartbeats at >> regular intervals. Incase of heartbeat miss the failure shall be >> detected &

Re: [ovs-dev] [action upcall meters 3/5] ofproto: Support action upcall meters

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 3:33 PM, Jarno Rajahalme wrote: > With small nits below: > > Acked-by: Jarno Rajahalme > >> On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: >> >> Allow action upcall meters, i.e. slowpath and controller meters, >> to be added

Re: [ovs-dev] [action upcall meters 4/5] ofproto: Meter sample action when configured.

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 3:42 PM, Jarno Rajahalme wrote: > This breaks the test "ofproto-dpif - Bridge IPFIX sanity check” (currently > test #1128), which appears to be the tests case that is being modified. Oops. As you have noticed with patch 5, I messed up in splitting those

Re: [ovs-dev] [action upcall meters 5/5] ofproto: Meter slowpath action when action upcall meters are configured

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 3:49 PM, Jarno Rajahalme wrote: > See comments below. > > Jarno > >> On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: >> >> If a slow path action is a controller action, meter it when the >> controller meter is configured. For other kinds of

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 3:14 PM, Jarno Rajahalme wrote: > This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially > being used uninitialized: > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 2e80db8..eb060d0 100644 > --- a/ofproto/ofproto.c > +++

Re: [ovs-dev] [action upcall meters 2/5] ofproto-dpif: Use backer to manage datapath meter allocation

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 3:23 PM, Jarno Rajahalme wrote: > >> On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: >> >> Add 'meter_ids', an id-pool object to manage datapath meter id. >> >> Currently, only userspace datapath supports meter, and it implements >> the

[ovs-dev] Sync on PTAP, EXT-382 and NSH - Tue 2017-05-09 17:00 CET

2017-04-28 Thread Jan Scheurich
Moved to 2pm CET to accommodate Ben, who is in Boston that week. Perhaps also Yi can join at that time slot. Hi, Let's have a look at the status and work out a plan how to accelerate the review and merging in order to achieve the agreed target to upstream these changes in time for OVS 2.8.

[ovs-dev] [action upcall meter v2 1/5] ofproto: Store meters using hmap

2017-04-28 Thread Andy Zhou
Currently, meters are stored in a fixed pointer array. It is not very efficient since the controller, at least in theory, can pick any meter id (up to the limits to uint32_t), not necessarily within the lower end of a region, or in close range to each other. In particular, OFPM_SLOWPATH and

[ovs-dev] [action upcall meter v2 2/5] ofproto-dpif: Add 'meter_ids' to backer

2017-04-28 Thread Andy Zhou
Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. provider_meter_id. Currently, only userspace datapath supports meter, and it implements the provider_meter_id management. Moving this function to 'backer' allows other datapath implementation to share the same logic.

[ovs-dev] [action upcall meter v2 3/5] ofproto: Support action upcall meters

2017-04-28 Thread Andy Zhou
Allow action upcall meters, i.e. slowpath and controller meters, to be added and displayed. Keep track of datapath meter ID of those action upcall meters in ofproto to aid action translation. Later patches will make use of them. Signed-off-by: Andy Zhou Acked-by: Jarno Rajahalme

[ovs-dev] [action upcall meter v2 5/5] ofproto: Meter slowpath action when action upcall meters are configured

2017-04-28 Thread Andy Zhou
If a slow path action is a controller action, meter it when the controller meter is configured. For other kinds of slow path actions, meter it when the slowpath meter is configured. Note, this patch only considers the meters configuration of the packet's input bridge, which may not be the same

[ovs-dev] [action upcall meter v2 4/5] ofproto: Meter sample action when configured.

2017-04-28 Thread Andy Zhou
When slowpath meter is configured, add meter action when translate sample action. Signed-off-by: Andy Zhou --- v1->v2: Fix test case 1128 failure. --- ofproto/ofproto-dpif-xlate.c | 14 -- tests/ofproto-dpif.at| 14 ++ 2 files changed, 26