Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Change assertion to log message.

On Thu, Dec 07, 2017 at 01:55:58PM -0800, Gregory Rose wrote: > On 12/7/2017 1:01 PM, Ben Pfaff wrote: > >Until now, compose_output_action__() has asserted that a packet output to > >a patch port is not to be truncated. This commit changes this to an error > >that will be included in trace

Re: [ovs-dev] [PATCH] tests: Always ignore "Broken pipe" and "Connection reset" log messages.

On Fri, Dec 08, 2017 at 02:43:54PM -0800, Justin Pettit wrote: > > > On Dec 8, 2017, at 1:28 PM, Ben Pfaff wrote: > > > > Until now, the ovn-controller-vtep, ovn-nbctl, and ovn-sbctl tests have > > ignored "Broken pipe" and "Connection reset" messages. The same rationale > > that

[ovs-dev] [PATCH] doc: Correct path of kernel system tests results directory.

Signed-off-by: Justin Pettit --- Documentation/topics/testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst index 85aa6a1fb495..1ecda00d069c 100644 ---

[ovs-dev] [PATCH V3 1/6] datapath: Fix netdev_master_upper_dev_link for 4.14

An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose --- acinclude.m4| 3 +++ datapath/linux/compat/include/linux/netdevice.h |

[ovs-dev] [PATCH V3 0/6] Enable OVS on Linux 4.14 kernel

Various fixes and compat layer changes required to enable building OVS for the upstream Linux 4.14 kernel. The constant changing of the netdev_master_upper_dev_link parameters is a real headache. I couldn't think of any cleaner way to do it than the approach I used but I welcome suggestions on

[ovs-dev] [PATCH V3 2/6] compat: Do not include headers when not compiling

If the entire file is not going to be compiled because OVS is using upstream tunnel support then also don't bother pulling in the headers. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c| 2 +- datapath/linux/compat/ip_output.c | 2 +- 2 files changed, 2

[ovs-dev] [PATCH V3 4/6] datapath: Fix SKB_GSO_UDP usage

Using SKB_GSO_UDP breaks the compilation on Linux 4.14. Check for the HAVE_SKB_GSO_UDP compiler #define. Signed-off-by: Greg Rose --- datapath/datapath.c | 9 ++--- datapath/linux/compat/stt.c | 11 ++- 2 files changed, 16 insertions(+), 4 deletions(-)

[ovs-dev] [PATCH V3 5/6] acinclude.m4: Enable Linux 4.14

Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 6511a24..b815c58 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -143,10 +143,10 @@ AC_DEFUN([OVS_CHECK_LINUX], [

[ovs-dev] [PATCH V3 3/6] datapath: conntrack: make protocol tracker pointers const

From: Florian Westphal Upstream commit: commit b3480fe059ac9121b5714205b4ddae14b59ef4be Author: Florian Westphal Date: Sat Aug 12 00:57:08 2017 +0200 netfilter: conntrack: make protocol tracker pointers const Doesn't change generated code,

[ovs-dev] [PATCH V3 6/6] travis: Update kernel test list from kernel.org

Signed-off-by: Greg Rose --- .travis.yml | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index f217840..8ca6d75 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,17 +25,16 @@ sudo: false env: -

Re: [ovs-dev] [PATCH 1/2] test-ovsdb: Simplify code in do_trigger().

> On Dec 8, 2017, at 11:43 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 2/2] test-ovsdb: Triggers should wake up other triggers immediately.

> On Dec 8, 2017, at 11:43 AM, Ben Pfaff wrote: > > When a trigger executes, it can make changes to the database that fulfill > the conditions for some other trigger to execute. ovsdb-server implements > this properly, but the code in test-ovsdb for testing triggers outside >

[ovs-dev] OVS DPDK: dpdk_merge pull request

Hi Ben, The following changes since commit 65d9759c4fc433dbda89ad3d7225c1f5eac274ca: ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function definitions. (2017-12-08 13:39:29 -0800) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch

Re: [ovs-dev] [PATCH 2/2] test-ovsdb: Triggers should wake up other triggers immediately.

On Fri, Dec 08, 2017 at 02:12:49PM -0800, Justin Pettit wrote: > > > > On Dec 8, 2017, at 11:43 AM, Ben Pfaff wrote: > > > > When a trigger executes, it can make changes to the database that fulfill > > the conditions for some other trigger to execute. ovsdb-server implements >

Re: [ovs-dev] [PATCH] stream-unix: Give accepted sockets distinct names for log messages.

> On Dec 8, 2017, at 11:36 AM, Ben Pfaff wrote: > > diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at > index 4fbb10070342..ed37ebbc84a6 100644 > --- a/tests/ofproto-macros.at > +++ b/tests/ofproto-macros.at > @@ -32,6 +32,7 @@ prt==1 { sub(/[ \t]*$/, ""); print $0 }

Re: [ovs-dev] [PATCH] stream-unix: Give accepted sockets distinct names for log messages.

On Fri, Dec 08, 2017 at 02:17:54PM -0800, Justin Pettit wrote: > > > On Dec 8, 2017, at 11:36 AM, Ben Pfaff wrote: > > > > diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at > > index 4fbb10070342..ed37ebbc84a6 100644 > > --- a/tests/ofproto-macros.at > > +++

Re: [ovs-dev] [PATCH] ovsdb-server: Document monitor_cond_change behavior for unmentioned tables.

> On Dec 8, 2017, at 12:53 PM, Ben Pfaff wrote: > > It seems best to be explicit about this. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] jsonrpc-server: Report monitor session ID properly in error message.

> On Dec 8, 2017, at 1:01 PM, Ben Pfaff wrote: > > The error message in question is about the monitor session ID but it > actually reports the JSON-RPC request ID instead, which is surprising. > > Found by inspection. > > Signed-off-by: Ben Pfaff Acked-by:

[ovs-dev] [PATCH] ovsdb-client: Show even constraint-breaking data in "dump" output.

The ovsdb-client "dump" command is a fairly low-level tool that can be used, among other purposes, to debug the OVSDB protocol. It's better if it just prints what the server sends without being too judgmental about it. Thus, we might as well ignore constraints for the purpose of dumping tables.

[ovs-dev] [PATCH] table: Add --max-column-width option.

This can make it easier to read tables that contain wide data in some columns. Signed-off-by: Ben Pfaff --- NEWS | 2 ++ lib/table.c | 22 +- lib/table.h | 13 ++--- lib/table.man | 5 + 4 files changed, 34 insertions(+), 8

[ovs-dev] [PATCH] ovsdb-server: Forbid user-specified databases with reserved names.

Names that begin with "_" are reserved, but ovsdb-server didn't previously enforce this. At the same time, make ovsdb-client ignore databases with reserved names for the purpose of selecting a default database to work on. This is in preparation for ovsdb-server starting to serve a new database,

[ovs-dev] [PATCH] ovsdb-server: Document monitor_cond_change behavior for unmentioned tables.

It seems best to be explicit about this. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-server.1.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-server.1.in b/ovsdb/ovsdb-server.1.in index cf3884ccc294..f1c6466ccb75 100644 ---

[ovs-dev] [PATCH] jsonrpc-server: Enforce uniqueness of monitor IDs.

This oversight allowed monitor IDs to be duplicated when the monitor_cond_change request changed them. Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/ovsdb/jsonrpc-server.c

[ovs-dev] [PATCH] jsonrpc-server: Report monitor session ID properly in error message.

The error message in question is about the monitor session ID but it actually reports the JSON-RPC request ID instead, which is surprising. Found by inspection. Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

<    1   2