Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On 16 January 2018 at 15:33, Gregory Rose wrote: > On 1/16/2018 2:38 PM, Guru Shetty wrote: >> >> >> >> On 16 January 2018 at 08:44, Greg Rose > > wrote: >> >> Add post install and post un-install scripts to make sure

[ovs-dev] [PATCH 1/2] rhel: add missing mandatory build dependencies

From: Ansis Atteka autoconf, automake and libtool are required for ./boot.sh. python-sphinx is required to prevent an error where ovs-test.8 is otherwise not generated. Signed-off-by: Ansis Atteka --- rhel/openvswitch.spec.in | 2 ++ 1 file changed, 2

[ovs-dev] [PATCH 2/2] rhel: Add the new ovsdb manpages to %files list (also for RHEL)

From: Ansis Atteka Currently, "rpmbuild -bb rhel/openvswitch.spec" doesn't work correctly since the new ovsdb manpages (ovsdb.5, ovsdb.7 and ovsdb-server.7) were added. This patch adds the new ovsdb manpages in the %files list in the spec file. CC: Ben Pfaff

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

> -Original Message- > From: Loftus, Ciara > Sent: Friday, January 5, 2018 4:14 PM > To: d...@openvswitch.org > Cc: Loftus, Ciara ; Stokes, Ian > ; jan.scheur...@ericsson.com; ktray...@redhat.com; > i.maxim...@samsung.com > Subject: [PATCH v8]

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status.

On 01/16/2018 04:22 AM, Flavio Leitner wrote: > Expose relevant vhost-user information in status. > > Signed-off-by: Flavio Leitner LGTM Tested-by: Kevin Traynor Acked-by: Kevin Traynor > --- > NEWS | 1 + >

Re: [ovs-dev] [PATCH] bfd: Send BFD packets with DSCP CS6

Hi, Acked-by: Zoltan Balogh Ben, is there a chance to get this into 2.9? Best regards, Zoltan > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Venkatesan Pradeep > Sent: Wednesday, January

Re: [ovs-dev] [PATCH v6 0/8] Add OVS DPDK keep-alive functionality.

>Hi, > >Sorry to jump on this at v6 only, but I skimmed over the code and I am >struggling to understand what problem you're trying to solve. Yes, I realize >you want some sort of feedback about the PMD processing, but it's not clear >to me what exactly you want from it. > >This last patchset uses

[ovs-dev] [PATCH OVS 1/1] dpif: geneve: supply dpif function to get ifindex

Geneve tunnels are not given a netdev_class function to determine their ifindex. This means when ofproto-dpif attempts to add a geneve netdev it fails in 'netdev_ports_insert' in netdev.c. Failure to add this means that further operations like offloading a rule that egresses to a geneve port will

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

On Thu, Jan 11, 2018 at 11:36 AM, Timothy Redaelli wrote: > RHEL 6 is not supported anymore since it uses Python 2.6 and GCC 4.4.x, > but Open vSwitch needs, at least, Python 2.7 and GCC 4.6 to build correctly. > >

[ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

Add post install and post un-install scripts to make sure that the openvswitch kernel modules are correctly written with the weak-modules utility. This ensures that after an upgrade to a newer kernel the correct openvswitch kernel modules from a previous installation will be found by the depmod

Re: [ovs-dev] [PATCH 12/15] ovsdb-client: Add --timeout option.

Looks good to me, thanks. Reviewed-by: Yifeng Sun On Sun, Dec 31, 2017 at 9:16 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > NEWS| 1 + > ovsdb/ovsdb-client.1.in | 6 ++ > ovsdb/ovsdb-client.c| 12

Re: [ovs-dev] [PATCH v3 0/3] Add dpif support for ct_clear action

On Sat, Nov 18, 2017 at 07:41:43PM -0500, Eric Garver wrote: > This series adds dpif support for OVS_ACTION_ATTR_CT_CLEAR. Previously the > ct_clear action was a userspace only operation, but it has use cases in the > dpif as well. Namely changing a packet's tuple after a ct() lookup has >

Re: [ovs-dev] [PATCH 14/15] json: Make it safe to pass null pointers to json_equal().

Looks good to me, thanks for the patch. Reviewed-by: Yifeng Sun On Sun, Dec 31, 2017 at 9:16 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/json.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

On Tue, Jan 16, 2018 at 10:42:16AM -0500, Eric Garver wrote: > On Fri, Jan 12, 2018 at 12:44:59PM -0800, Ben Pfaff wrote: > > The kernel GRE driver ignores IFLA_MTU in RTM_NEWLINK requests and > > overrides the MTU to 1472 bytes. This commit works around the problem by > > following up a request

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Tue, Jan 16, 2018 at 06:27:23AM +, James Page wrote: > On Mon, 15 Jan 2018 at 18:55 Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > > > On Mon, Jan 15, 2018 at 5:43 PM, Eric Garver wrote: > > > On Mon, Jan 15, 2018 at 11:32:32AM -0500, Eric Garver wrote: >

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Tue, 16 Jan 2018 at 16:23 James Page wrote: > > On Tue, 16 Jan 2018 at 15:47 Eric Garver wrote: > [...] > >> > Re-tested with the mainline kernel; gre_sys device is still configured >> with >> > a 1472 MTU, however I was then able to increase it using ip

Re: [ovs-dev] Hardware acceleration in OVS-DPDK

Hi All, MOM is uploaded in the google doc as below. https://docs.google.com/document/d/1KeQB5NIUph721uuk1f1wMy4QXwSWxlzDaumd_bWX6YI/edit?usp=sharing Regards _Sugesh -Original Appointment- From: Chandran, Sugesh Sent: Friday, January 12, 2018 9:43 AM To:

[ovs-dev] [PATCH v4 1/2] dpif-netdev: Add percentage of pmd/core used by each rxq.

It is based on the length of history that is stored about an rxq (currently 1 min). $ ovs-appctl dpif-netdev/pmd-rxq-show pmd thread numa_id 0 core_id 4: isolated : false port: dpdkphy1 queue-id: 0pmd usage: 70 % port: dpdkvhost0 queue-id: 0pmd

[ovs-dev] [PATCH v7 0/3] dpif-netdev: Detailed PMD performance metrics and supervision

The run-time performance of PMDs is often difficult to understand and trouble-shoot. The existing PMD statistics counters only provide a coarse grained average picture. At packet rates of several Mpps sporadic drops of packet bursts happen at sub-millisecond time scales and are impossible to

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Add percentage of pmd/core used by each rxq.

Not a full review. Few comments inline. Best regards, Ilya Maximets. On 15.01.2018 20:58, Kevin Traynor wrote: > It is based on the length of history that is stored about an > rxq (currently 1 min). > > $ ovs-appctl dpif-netdev/pmd-rxq-show > pmd thread numa_id 0 core_id 4: > isolated :

[ovs-dev] [PATCH v4 2/2] NEWS: Add entry for new appctl dpif-netdev/pmd-rxq-rebalance.

This feature was added earlier but we thought it better to advertise in NEWS after there was stats provided to help the user decide whether they should use it. Signed-off-by: Kevin Traynor --- V4: - No change. V3: - Rebased to DPDK_MERGE branch. V2: - Newly added. NEWS

[ovs-dev] [PATCH v7 1/3] netdev: Add rxq callback function rxq_length()

If implememented, this function returns the number of packets in an rx queue of the netdev. If not implemented, it returns -1. This function will be used in the upcoming commit for PMD performance metrics to supervise the rx queue fill level for DPDK vhostuser ports. Signed-off-by: Jan Scheurich

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On 16 January 2018 at 08:44, Greg Rose wrote: > Add post install and post un-install scripts to make sure that the > openvswitch kernel modules are correctly written with the weak-modules > utility. This ensures that after an upgrade to a newer kernel the > correct

Re: [ovs-dev] [PATCH 2/3] ofp-util: New data structure for mapping between table names and numbers.

It looks like that the not-null-validation of 'map' can be removed in static function ofputil_name_map_destroy but should be added for ofputil_port_map_destroy and ofputil_table_map_destroy. Other than that, this patch looks good to me. Thanks. Reviewed-by: Yifeng Sun

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On Tue, Jan 16, 2018 at 08:44:15AM -0800, Greg Rose wrote: > Add post install and post un-install scripts to make sure that the > openvswitch kernel modules are correctly written with the weak-modules > utility. This ensures that after an upgrade to a newer kernel the > correct openvswitch kernel

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On 1/16/2018 10:02 AM, Ansis Atteka wrote: On 16 January 2018 at 08:44, Greg Rose wrote: Add post install and post un-install scripts to make sure that the openvswitch kernel modules are correctly written with the weak-modules utility. This ensures that after an upgrade

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On 1/16/2018 10:15 AM, Flavio Leitner wrote: On Tue, Jan 16, 2018 at 08:44:15AM -0800, Greg Rose wrote: Add post install and post un-install scripts to make sure that the openvswitch kernel modules are correctly written with the weak-modules utility. This ensures that after an upgrade to a

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

On Fri, Jan 12, 2018 at 12:44:59PM -0800, Ben Pfaff wrote: > The kernel GRE driver ignores IFLA_MTU in RTM_NEWLINK requests and > overrides the MTU to 1472 bytes. This commit works around the problem by > following up a request to create a GRE device with a second request to set > the MTU. > >

[ovs-dev] [PATCH v7 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

This patch enhances dpif-netdev-perf to detect iterations with suspicious statistics according to the following criteria: - iteration lasts longer than US_THR microseconds (default 250). This can be used to capture events where a PMD is blocked or interrupted for such a period of time that

[ovs-dev] [PATCH v7 2/3] dpif-netdev: Detailed performance stats for PMDs

This patch instruments the dpif-netdev datapath to record detailed statistics of what is happening in every iteration of a PMD thread. The collection of detailed statistics can be controlled by a new Open_vSwitch configuration parameter "other_config:pmd-perf-metrics". By default it is disabled.

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On 1/16/2018 3:39 PM, Ansis Atteka wrote: On 16 January 2018 at 15:33, Gregory Rose wrote: On 1/16/2018 2:38 PM, Guru Shetty wrote: On 16 January 2018 at 08:44, Greg Rose > wrote: Add post install and post

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On 16 January 2018 at 08:44, Greg Rose wrote: > Add post install and post un-install scripts to make sure that the > openvswitch kernel modules are correctly written with the weak-modules > utility. This ensures that after an upgrade to a newer kernel the > correct

Re: [ovs-dev] [PATCH 1/2] rhel: add missing mandatory build dependencies

On 16 January 2018 at 15:55, Ansis Atteka wrote: > From: Ansis Atteka > > autoconf, automake and libtool are required for ./boot.sh. > > python-sphinx is required to prevent an error where ovs-test.8 is > otherwise not generated. > > Signed-off-by: Ansis

[ovs-dev] Recursos Humanos 2018

Buenos Días, En gusto compartirle la información de nuestra más reciente Póliza de Capacitación Online con un precio especial ¡a casi 40% del precio real! Este programa está orientado a todo el personal involucrado con los Recursos Humanos de su empresa y le permitirá conocer las herramientas

Re: [ovs-dev] [PATCH 2/2] rhel: Add the new ovsdb manpages to %files list (also for RHEL)

On 16 January 2018 at 16:49, Gregory Rose wrote: > On 1/16/2018 3:55 PM, Ansis Atteka wrote: >> >> From: Ansis Atteka >> >> Currently, "rpmbuild -bb rhel/openvswitch.spec" doesn't work correctly >> since the new ovsdb manpages (ovsdb.5, ovsdb.7 and

Re: [ovs-dev] [PATCH 2/2] rhel: Add the new ovsdb manpages to %files list (also for RHEL)

On 1/16/2018 3:55 PM, Ansis Atteka wrote: From: Ansis Atteka Currently, "rpmbuild -bb rhel/openvswitch.spec" doesn't work correctly since the new ovsdb manpages (ovsdb.5, ovsdb.7 and ovsdb-server.7) were added. This patch adds the new ovsdb manpages in the %files list

Re: [ovs-dev] [PATCH v7 0/3] dpif-netdev: Detailed PMD performance metrics and supervision

On 17.01.2018 10:49, Ilya Maximets wrote: > Not a full review, just a note about man pages. > Current version of netdev-dpif-unixctl.man doesn't scale and looks bad > with different terminal widths. I refactored it to look more like a man > page. See the incremental patch below. > > What changed:

Re: [ovs-dev] [PATCH v7 0/3] dpif-netdev: Detailed PMD performance metrics and supervision

Not a full review, just a note about man pages. Current version of netdev-dpif-unixctl.man doesn't scale and looks bad with different terminal widths. I refactored it to look more like a man page. See the incremental patch below. What changed: * Dash lists re-formatted using "\(em" tags. *

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

Hi Mark, Thanks for the review (and pointers), I very much appreciate it. I've only skimmed through it so far, but I'll take it into account when sending v2. As I mentioned before I want to put some testing in place first and haven't had time to get that into place yet, hopefully this coming

[ovs-dev] [PATCH v2] odp-util: fix a compiler warning

The result of a ternary operation will be promoted at least to int type. As such, the compiler may generate a warning as: format specifies type 'unsigned char' but the argument has type 'int' Squelch this by preferring the %d format specifier to print 1/0 values. Fixes: 74c4530dca93

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Tue, 16 Jan 2018 at 16:26 James Page wrote: > On Tue, 16 Jan 2018 at 16:23 James Page wrote: > >> >> On Tue, 16 Jan 2018 at 15:47 Eric Garver wrote: >> [...] >> >>> > Re-tested with the mainline kernel; gre_sys device is still

Re: [ovs-dev] Odd gre_sys MTU setting (2.6.x vs 2.8.x)

On Tue, 16 Jan 2018 at 15:47 Eric Garver wrote: [...] > > Re-tested with the mainline kernel; gre_sys device is still configured > with > > a 1472 MTU, however I was then able to increase it using ip link set > > gre_sys mtu , confirming that the kernel applied hardware limit

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

On Tue, Jan 16, 2018 at 09:16:47AM -0800, Ben Pfaff wrote: > On Tue, Jan 16, 2018 at 10:42:16AM -0500, Eric Garver wrote: > > On Fri, Jan 12, 2018 at 12:44:59PM -0800, Ben Pfaff wrote: > > > The kernel GRE driver ignores IFLA_MTU in RTM_NEWLINK requests and > > > overrides the MTU to 1472 bytes.

Re: [ovs-dev] [PATCH V2] rhel: Ensure proper OVS kernel modules load after upgrade

On Tue, Jan 16, 2018 at 10:31:29AM -0800, Gregory Rose wrote: > On 1/16/2018 10:15 AM, Flavio Leitner wrote: > > On Tue, Jan 16, 2018 at 08:44:15AM -0800, Greg Rose wrote: > > > Add post install and post un-install scripts to make sure that the > > > openvswitch kernel modules are correctly