Re: [ovs-dev] [PATCH 0/8] Split up the DPDK howto

> Hi Ian. I have not seen much feedback on this series. Are you thinking > about merging it? Stephen's contributions to the documentation are, > ordinarily, quite valuable. > Thanks for flagging this, I started reviewing last week and have feedback to give. I'm also going to highlight it at

Re: [ovs-dev] [PATCH] tests: Skip tests that need "normal" diff if not available.

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Monday, April 2, 2018 8:15 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Stuart Cardall > Subiect: [ovs-dev] [PATCH] tests:

Re: [ovs-dev] [PATCH] netlink-socket: don't check for namespace id under Windows

writes: >> -Mesaj original- >> De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Flavio Leitner >> Trimis: Tuesday, April 3, 2018 2:48 AM >> Către: Aaron Conole >> Cc: d...@openvswitch.org; Alin Gabriel Serdean

Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs

Hi Ben, > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Sunday, April 1, 2018 1:27 AM > To: O Mahony, Billy > Cc: d...@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs > > On

Re: [ovs-dev] [PATCH v2 1/1] userspace: Add IPv6 extension header parsing for tunnels

On 30/03/18 18:35, William Tu wrote: On Wed, Mar 28, 2018 at 9:52 AM, Eelco Chaudron wrote: On 03/09/2018 03:59 PM, William Tu wrote: On Thu, Feb 8, 2018 at 10:42 AM, Eric Garver wrote: On Thu, Feb 08, 2018 at 04:40:38PM +0100, Eelco Chaudron wrote: While

Re: [ovs-dev] [PATCH] netlink-socket: Fix broken build on Windows

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Monday, April 2, 2018 7:35 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] netlink-socket: Fix broken build on

Re: [ovs-dev] [PATCH] netlink-socket: don't check for namespace id under Windows

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Flavio Leitner > Trimis: Tuesday, April 3, 2018 2:48 AM > Către: Aaron Conole > Cc: d...@openvswitch.org; Alin Gabriel Serdean > Subiect: Re: [ovs-dev]

[ovs-dev] [PATCH] tests: Allow only 1 job at once during recheck (RECHECK=yes)

Currently some tests fails if run with multiple jobs at once, so this commit disables parallel jobs during the recheck phase. Signed-off-by: Timothy Redaelli --- tests/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/automake.mk

[ovs-dev] [PATCH] RFC datapath-windows: Create com device only when extension is enabled

Until now the communication device between the kernel and userspace is created when the network driver is installed. Since we only do processing if the Hyper-V vSwitch extension is enabled by the user, it makes more sense to move the device creation only when that is true. Signed-off-by: Alin

Re: [ovs-dev] [PATCH] netdev-dpdk: Refactor custom stats.

On 22.03.2018 11:05, Weglicki, MichalX wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Wednesday, March 21, 2018 3:07 PM >> To: Weglicki, MichalX ; ovs-dev@openvswitch.org >> Cc: Heetae Ahn

Re: [ovs-dev] [PATCH 2/2] ovs-vswitchd: Do not use system routing table with --disable-system.

On Sat, 31 Mar 2018 17:12:55 -0700 Ben Pfaff wrote: > The --disable-system option indicates that the user wants to avoid > using the host's datapath. This is also a good indication that the > user does not want to use other host resources such as the routing > table, so this

Re: [ovs-dev] [PATCH 2/2] ovs-vswitchd: Do not use system routing table with --disable-system.

On Tue, Apr 03, 2018 at 07:14:25PM +0200, Timothy Redaelli wrote: > On Sat, 31 Mar 2018 17:12:55 -0700 > Ben Pfaff wrote: > > > The --disable-system option indicates that the user wants to avoid > > using the host's datapath. This is also a good indication that the > > user does

Re: [ovs-dev] [PATCH] ofp-actions: Correct execution of encap/decap actions in action set

On Mon, Mar 26, 2018 at 09:36:27AM +0200, Jan Scheurich wrote: > The actions encap, decap and dec_nsh_ttl were wrongly flagged as set_field > actions in ofpact_is_set_or_move_action(). This caused them to be executed > twice in the action set or a group bucket, once explicitly in >

Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs

On Tue, Apr 03, 2018 at 09:06:18AM +, O Mahony, Billy wrote: > Hi Ben, > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Sunday, April 1, 2018 1:27 AM > > To: O Mahony, Billy > > Cc: d...@openvswitch.org; i.maxim...@samsung.com > >

Re: [ovs-dev] [PATCH] tests: Allow only 1 job at once during recheck (RECHECK=yes)

On Tue, Apr 03, 2018 at 03:38:28PM +0200, Timothy Redaelli wrote: > Currently some tests fails if run with multiple jobs at once, so > this commit disables parallel jobs during the recheck phase. > > Signed-off-by: Timothy Redaelli I think that this is a useful patch. To

[ovs-dev] [PATCH] checkpatch: Fix mis-flagging of division operators as lacking whitespace.

The regular expression here would flag any slash that wasn't adjacent to an asterisk as missing whitespace. This fixes the problem. Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py

Re: [ovs-dev] [PATCH v7 0/5] Stopwatch Library

On 04/03/2018 01:25 PM, Ben Pfaff wrote: On Wed, Mar 28, 2018 at 04:35:04PM -0500, Mark Michelson wrote: This set of commits adds a new library for OVS that allows for measuring the performance of operations in OVS and compiling statistics from these measurements. For developers, this can

Re: [ovs-dev] [PATCH] ovsdb: omit_alert should implicitely turn off tracking.

On Sun, Apr 01, 2018 at 08:32:02PM -0700, Han Zhou wrote: > On Sun, Apr 1, 2018 at 4:26 PM, Ben Pfaff wrote: > > > > On Fri, Mar 16, 2018 at 07:02:43PM -0700, Han Zhou wrote: > > > OVSDB_IDL_TRACK is not valid without OVSDB_IDL_ALERT, so it should > > > be turned off as well in

Re: [ovs-dev] [PATCH] tests: Fix sed usage in pmd test.

On Sun, Apr 01, 2018 at 10:01:24AM -0700, Ben Pfaff wrote: > SUSv7 2016 Edition says: > > [2addr] {editing command > editing command > ... > } > > Execute a list of sed editing commands only when the pattern space is > selected. The list of sed editing commands shall be

Re: [ovs-dev] [PATCH v7 0/5] Stopwatch Library

On Wed, Mar 28, 2018 at 04:35:04PM -0500, Mark Michelson wrote: > This set of commits adds a new library for OVS that allows for measuring > the performance of operations in OVS and compiling statistics from these > measurements. > > For developers, this can provide a measurement of something

Re: [ovs-dev] [PATCH] tests: Skip tests that need "normal" diff if not available.

On Tue, Apr 03, 2018 at 03:12:40PM +0300, aserd...@ovn.org wrote: > > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff > > Trimis: Monday, April 2, 2018 8:15 PM > > Către: d...@openvswitch.org > > Cc: Ben Pfaff ;

[ovs-dev] [PATCH v2] ovn-ctl: Support starting clustered OVN dbs

From: Numan Siddique This patch adds the options to start clustered OVN db servers in ovn-ctl. To support this, following options are added - '--db-(nb/sb)-cluster-local-addr', '--db-(nb/sb)-cluster-local-port', '--db-(nb/sb)-cluster-local-proto',

Re: [ovs-dev] [PATCH] checkpatch: Fix mis-flagging of division operators as lacking whitespace.

Ben Pfaff writes: > The regular expression here would flag any slash that wasn't adjacent to > an asterisk as missing whitespace. This fixes the problem. > > Signed-off-by: Ben Pfaff > --- Tested-by: Aaron Conole I noticed that one of the raft

Re: [ovs-dev] [PATCH] checkpatch: Fix mis-flagging of division operators as lacking whitespace.

On Tue, Apr 03, 2018 at 04:19:38PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > The regular expression here would flag any slash that wasn't adjacent to > > an asterisk as missing whitespace. This fixes the problem. > > > > Signed-off-by: Ben Pfaff > > --- >

Re: [ovs-dev] [PATCH] ofp-actions: Correct execution of encap/decap actions in action set

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, 03 April, 2018 20:36 > > On Mon, Mar 26, 2018 at 09:36:27AM +0200, Jan Scheurich wrote: > > The actions encap, decap and dec_nsh_ttl were wrongly flagged as set_field > > actions in

Re: [ovs-dev] [PATCH v7 0/5] Stopwatch Library

On Tue, Apr 03, 2018 at 01:30:09PM -0500, Mark Michelson wrote: > On 04/03/2018 01:25 PM, Ben Pfaff wrote: > >On Wed, Mar 28, 2018 at 04:35:04PM -0500, Mark Michelson wrote: > >>This set of commits adds a new library for OVS that allows for measuring > >>the performance of operations in OVS and

[ovs-dev] [PATCH 2/2] ofp-flow: minimatch is initialized twice.

It is possible that 'fm->match' gets initialized twice in this function, which makes the first one leak because its pointer is overwritten by the second initialization. This patch fixes this issue. Signed-off-by: Yifeng Sun --- lib/ofp-flow.c | 1 - 1 file changed, 1

[ovs-dev] [PATCH 1/2] ovsdb-idl: properly destroy ovsdb_idl.server

This patch fixes the memory leak reported by valgrind in testing "learning action - TCPv6 port learning" 150 (40 direct, 110 indirect) bytes in 1 blocks are definitely lost in loss record 329 of 363 at

Re: [ovs-dev] [PATCH v2] ovn-ctl: Support starting clustered OVN dbs

On Wed, Apr 04, 2018 at 12:24:27AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds the options to start clustered OVN db servers in ovn-ctl. > To support this, following options are added - > '--db-(nb/sb)-cluster-local-addr', >

Re: [ovs-dev] [PATCH v2] ovn-ctl: Support starting clustered OVN dbs

On Wed, Apr 4, 2018, 4:42 AM Ben Pfaff wrote: > On Wed, Apr 04, 2018 at 12:24:27AM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds the options to start clustered OVN db servers in ovn-ctl. > > To support this, following

Re: [ovs-dev] [PATCH v4 0/6] Add minimum network namespace support.

On Sat, Mar 31, 2018 at 01:23:20PM -0700, Ben Pfaff wrote: > On Thu, Mar 29, 2018 at 11:05:25PM -0300, Flavio Leitner wrote: > > Today Open vSwitch doesn't know about network namespaces (netns), but > > users are moving internal ports to other namespaces. Although packets > > are still flowing,

Re: [ovs-dev] [PATCH v3 3/3] xlate: call tnl_neigh_snoop() from terminate_native_tunnel()

Hi, I took this over from Zoltan and investigated the failing unit test a bit further. The essential difference between master and Zoltan's (rebased) patches is that the dynamic "ARP cache" flow entry table=66,priority=100,reg0=0xa02,reg15=0x2,metadata=0x1

[ovs-dev] Question about ovs megaflow with move NXM_OF_IP_DST actions

Hi all, In my test, add one flow to br-ovs, and running one vm connected this br-ovs: cookie=0x0, duration=286.272s, table=31, n_packets=2, n_bytes=196, idle_age=161, priority=61010,ip,metadata=0x2b193,dl_dst=00:00:00:04:06:03