Re: [ovs-dev] [PATCH ovn] Learn the mac binding only if required

On Wed, Sep 11, 2019 at 1:05 PM wrote: > > From: Numan Siddique > > OVN has the actions - put_arp and put_nd to learn the mac bindings from the > ARP/ND packets. These actions update the Southbound MAC_Binding table. > These actions translates to controller actions. Whenever pinctrl thread >

Re: [ovs-dev] [PATCH branch-2.12] pinctrl: Fix DNS packet parsing

On Wed, Aug 28, 2019 at 9:39 PM Ben Pfaff wrote: > > On Fri, Aug 16, 2019 at 04:35:52PM +0200, Dumitru Ceara wrote: > > Please backport this to 2.11, 2.10, 2.9 at least. > > Done. Thank you! ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Fix flow control configuration.

>-Original Message- >From: Ilya Maximets >Sent: 11 September 2019 15:29 >To: Konieczny, TomaszX ; d...@openvswitch.org >Cc: Stokes, Ian >Subject: Re: [ovs-dev] [PATCH v1] netdev-dpdk: Fix flow control configuration. > >OK. We could, actually, check if user configured something for flow

[ovs-dev] [PATCH v16 07/14] netdev-dpdk: copy large packet to multi-seg. mbufs

From: Mark Kavanagh Currently, packets are only copied to a single segment in the function dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames, particularly when multi-segment mbufs are involved. This patch calculates the number of segments needed by a packet and copies the

[ovs-dev] [PATCH v16 08/14] netdev-dpdk: support multi-segment jumbo frames.

From: Mark Kavanagh Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each user-defined MTU, 'requested_mtu', a

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Fix flow control not configuring.

Bleep bloop. Greetings Tomasz Konieczny, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #29 FILE:

Re: [ovs-dev] [PATCH] MAINTAINERS: Update email for Ilya Maximets.

On 11.09.2019 20:34, Ben Pfaff wrote: > On Wed, Sep 11, 2019 at 06:51:44PM +0300, Ilya Maximets wrote: >> CC: Ilya Maximets >> Signed-off-by: Ilya Maximets >> --- >> >> As someone could already know, my samsung email will be deactivated >> soon. So, the ovn.org address should be used instead. >>

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add support for the RTE_ETH_EVENT_INTR_RESET event

On 12.09.2019 13:19, Ilya Maximets wrote: > On 12.09.2019 13:07, Eelco Chaudron wrote: >> >> >> On 12 Sep 2019, at 10:39, Ilya Maximets wrote: >> >>> On 11.09.2019 16:20, Eelco Chaudron wrote: Currently, OVS does not register and therefore not handle the interface reset event from the

[ovs-dev] [PATCH v16 06/14] dp-packet: Add support for data "linearization".

From: Tiago Lam Previous commits have added support to the dp_packet API to handle multi-segmented packets, where data is not stored contiguously in memory. However, in some cases, it is inevitable and data must be provided contiguously. Examples of such cases are when performing csums over the

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add support for the RTE_ETH_EVENT_INTR_RESET event

On 12 Sep 2019, at 10:39, Ilya Maximets wrote: On 11.09.2019 16:20, Eelco Chaudron wrote: Currently, OVS does not register and therefore not handle the interface reset event from the DPDK framework. This would cause a problem in cases where a VF is used as an interface, and its configuration

[ovs-dev] [PATCH v3] netdev-dpdk: Fix flow control not configuring.

Currently OVS is unable to change flow control configuration in DPDK because new settings are being overwritten by current settings with rte_eth_dev_flow_ctrl_get(). The fix restores correct order of operations and at the same time does not trigger error on devices without flow control support

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add support for the RTE_ETH_EVENT_INTR_RESET event

On 12.09.2019 13:07, Eelco Chaudron wrote: > > > On 12 Sep 2019, at 10:39, Ilya Maximets wrote: > >> On 11.09.2019 16:20, Eelco Chaudron wrote: >>> Currently, OVS does not register and therefore not handle the >>> interface reset event from the DPDK framework. This would cause a >>> problem in

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add support for the RTE_ETH_EVENT_INTR_RESET event

On 11.09.2019 16:20, Eelco Chaudron wrote: > Currently, OVS does not register and therefore not handle the > interface reset event from the DPDK framework. This would cause a > problem in cases where a VF is used as an interface, and its > configuration changes. > > As an example in the following

[ovs-dev] [PATCH v2] netdev-dpdk: Fix flow control not configuring.

Currently OVS is unable to change flow control configuration in DPDK because new settings are being overwritten by current settings with rte_eth_dev_flow_ctrl_get(). The fix restores correct order of operations and at the same time does not trigger error on devices without flow control support

[ovs-dev] [PATCH v3 ovn 2/2] ovn-controller: Minimize SB DB port_binding lookups.

Instead of storing only peer_ports in struct local_datapath, store both local-remote mappings for patch ports. Also, it's useful to directly store sbrec_port_binding pointers for all datapath ports as we avoid doing costly sbrec_port_binding index lookups by port name. Signed-off-by: Dumitru

[ovs-dev] [PATCH v3 ovn 1/2] ovn-controller: Optimize update of ct-zones external-ids.

commit_ct_zones() is called at every ovn-controller iteration but updates to ct-zones don't happen at every iteration. Avoid cloning the br-int->external_ids map unless an update is needed. Signed-off-by: Dumitru Ceara --- controller/ovn-controller.c | 53

[ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

This series adds some (independent) optimizations that improve ovn-controller performance by lowering the number of operations that need to be executed during a iteration of the main controller loop. Each patch in the series addresses a bottleneck reported by running `perf record -g --call-graph

[ovs-dev] [PATCH] netdev-dpdk: Reuse vhost function for dpdk ETH custom stats.

This is yet another refactoring for upcoming detailed drop stats. It allowes to use single function for all the software calculated statistics in netdev-dpdk for both vhost and ETH ports. UINT64_MAX used as a marker for non-supported statistics in a same way as it's done in bridge.c for common

Re: [ovs-dev] [PATCH v8] netdev-dpdk:Detailed packet drop statistics

On 10.09.2019 20:31, Sriram Vatala wrote: > -Original Message- > From: Ilya Maximets > Sent: 10 September 2019 19:29 > To: Sriram Vatala ; ovs-dev@openvswitch.org > Cc: ktray...@redhat.com; ian.sto...@intel.com > Subject: Re: [PATCH v8] netdev-dpdk:Detailed packet drop statistics > > On

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix Tx queue false sharing.

On 26 Aug 2019, at 16:54, Ilya Maximets wrote: 'tx_q' array is allocated for each DPDK netdev. 'struct dpdk_tx_queue' is 8 bytes long, so 8 tx queues are sharing the same cache line in case of 64B cacheline size. This causes 'false sharing' issue in mutliqueue case because taking the

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

Acked-by: Mark Michelson On 9/12/19 10:13 AM, Dumitru Ceara wrote: This series adds some (independent) optimizations that improve ovn-controller performance by lowering the number of operations that need to be executed during a iteration of the main controller loop. Each patch in the series

Re: [ovs-dev] [PATCH v2 ovn 2/3] ovn-controller: Optimize update of ct-zones external-ids.

On Wed, Aug 28, 2019 at 2:36 PM Numan Siddique wrote: > > > > On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: >> >> commit_ct_zones() is called at every ovn-controller iteration but updates to >> ct-zones don't happen at every iteration. Avoid cloning the >> br-int->external_ids map unless

Re: [ovs-dev] [PATCH v2 ovn 3/3] ovn-controller: Minimize SB DB port_binding lookups.

On Wed, Aug 28, 2019 at 2:36 PM Numan Siddique wrote: > > > > On Fri, Aug 23, 2019 at 4:55 PM Dumitru Ceara wrote: >> >> Instead of storing only peer_ports in struct local_datapath, store both >> local-remote mappings for patch ports. Also, it's useful to directly >> store sbrec_port_binding

Re: [ovs-dev] Virtio Crypto with OVS-DPDK

Thanks IIya for the reply . Please find my comment below. >>Hi Harish, >>Why do you want to integrate virtio-crypto into OVS? >>OVS is an OpenFlow Network Switch, but crypto devices are not network devices. >>They will not fit in OVS purposes nor OVS architecture. Let's take a use-case

Re: [ovs-dev] Virtio Crypto with OVS-DPDK

On 12.09.2019 18:35, Harish Kumar Ambati wrote: > Thanks  IIya for the reply . Please find my comment below. > >>>Hi Harish, > >>>Why do you want to integrate virtio-crypto into OVS? >>>OVS is an OpenFlow Network Switch, but crypto devices are not network >>>devices. >>>They will not fit in OVS

Re: [ovs-dev] [PATCH] vswitch: ratelimit the device add log

On Thu, Sep 12, 2019 at 11:45:41AM -0400, Aaron Conole wrote: > It's possible that a port added to the system with certain kinds > of invalid parameters will cause the 'could not add' log to be > triggered. When this happens, the vswitch run loop can continually > re-attempt adding the port.

[ovs-dev] [PATCH] ovs-bugtool: Add ip -s -s to get_device_stats.out.

The patch adds 'ip -s -s' to file get_device_stats.out to collect device statistics. When debugging tunnel related issues, the command shows much more detailed counters, ex: frame, crc, carrier, helping to understand the root cause when packets are dropped. Signed-off-by: William Tu ---

Re: [ovs-dev] [PATCH] ovs-bugtool: Add ip -s -s to get_device_stats.out.

Bleep bloop. Greetings William Tu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #24 FILE:

[ovs-dev] Querying OVS for OpenFlow capabilities

Hi guys, I recently sent a new version of a document describing proposed OVN/OVS compatibility [1]. In it, I suggested that when we add new OpenFlow capabilities to OVS, then OVN needs to probe OVS for the OpenFlow capabilities at startup. This way we can know whether we have the capability,

Re: [ovs-dev] [PATCH] ovs-bugtool: Add ip -s -s to get_device_stats.out.

On Thu, Sep 12, 2019 at 11:01 AM 0-day Robot wrote: > > Bleep bloop. Greetings William Tu, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Line is 80

[ovs-dev] [PATCH] checkpatch: Ignore utitilies/bugtool.

Signed-off-by: William Tu --- utilities/checkpatch.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index f8fa00e306a8..a9f27b52f3c8 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -844,6 +844,8 @@ def

[ovs-dev] [PATCH] vswitch: ratelimit the device add log

It's possible that a port added to the system with certain kinds of invalid parameters will cause the 'could not add' log to be triggered. When this happens, the vswitch run loop can continually re-attempt adding the port. While the parameters remain invalid the vswitch run loop will re-trigger

[ovs-dev] [PATCH] dpdk: trivial: Fix comment and cast.

Comment should start with capital letter. Remove unnecessary type casting. Signed-off-by: William Tu --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 14f0897fa637..5f703ad457b3 100644 --- a/lib/dp-packet.h +++

Re: [ovs-dev] Querying OVS for OpenFlow capabilities

> On Sep 12, 2019, at 11:08 AM, Mark Michelson wrote: > > Hi guys, > > I recently sent a new version of a document describing proposed OVN/OVS > compatibility [1]. In it, I suggested that when we add new OpenFlow > capabilities to OVS, then OVN needs to probe OVS for the OpenFlow >

Re: [ovs-dev] [PATCH 1/1] stream_ssl: fix important memory leak in ssl_connect() function

On Fri, Jul 26, 2019 at 10:11:03AM +0200, Damijan Skvarc wrote: > > While checking valgrind reports after running "make check-valgrind" I have > noticed > reports for several tests similar to the following: > > > ==5345== Memcheck, a memory error detector > ==5345== Copyright (C)

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

On 9/12/19 4:51 PM, Han Zhou wrote: Thanks Mark for writing this up. On Fri, Sep 6, 2019 at 2:08 PM Mark Michelson > wrote: > > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN

Re: [ovs-dev] [PATCH 05/10] trigger: Free leaked ovsdb_schema

One minor suggestion here: Can you also handle freeing result: diff --git a/ovsdb/trigger.c b/ovsdb/trigger.c index 6f4ed96b0..0158957d6 100644 --- a/ovsdb/trigger.c +++ b/ovsdb/trigger.c @@ -214,6 +214,7 @@ ovsdb_trigger_try(struct ovsdb_trigger *t, long long int now) /*

Re: [ovs-dev] [PATCH v5 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > From: Justin Pettit > > Signed-off-by: Justin Pettit > Signed-off-by: Yi-Hung Wei > Co-authored-by: Yi-Hung Wei Thanks. I merged this into master. --Justin ___ dev mailing list

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

On 9/12/19 3:25 PM, Ben Pfaff wrote: On Fri, Sep 06, 2019 at 05:08:17PM -0400, Mark Michelson wrote: +=== +Keeping OVN Compatible with OVS +=== + +OVN has split from OVS. Prior to this split, there was no issue with +compatibility. All

Re: [ovs-dev] Querying OVS for OpenFlow capabilities

On Thu, Sep 12, 2019 at 03:47:58PM -0400, Mark Michelson wrote: > On 9/12/19 2:46 PM, Justin Pettit wrote: > > > > > >>On Sep 12, 2019, at 11:08 AM, Mark Michelson wrote: > >> > >>Hi guys, > >> > >>I recently sent a new version of a document describing proposed OVN/OVS > >>compatibility [1]. In

Re: [ovs-dev] Querying OVS for OpenFlow capabilities

On 9/12/19 2:46 PM, Justin Pettit wrote: On Sep 12, 2019, at 11:08 AM, Mark Michelson wrote: Hi guys, I recently sent a new version of a document describing proposed OVN/OVS compatibility [1]. In it, I suggested that when we add new OpenFlow capabilities to OVS, then OVN needs to probe

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

On Fri, Sep 06, 2019 at 05:08:17PM -0400, Mark Michelson wrote: > +=== > +Keeping OVN Compatible with OVS > +=== > + > +OVN has split from OVS. Prior to this split, there was no issue with > +compatibility. All code changes happened at the

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

Thanks Mark for writing this up. On Fri, Sep 6, 2019 at 2:08 PM Mark Michelson wrote: > > This document serves to provide an explanation for how OVN will remain > compatible with OVS. It provides instructions for OVN contributors for > how to maintain compatibility even across older versions of

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

On Thu, Sep 12, 2019 at 04:06:14PM -0400, Mark Michelson wrote: > On 9/12/19 3:25 PM, Ben Pfaff wrote: > > It's possible that we could introduce features for logical flows that > > allow different behavior based on whether a given node supports a > > particular feature. I've thought about this in

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

On Thu, Sep 12, 2019 at 2:00 PM Mark Michelson wrote: > > On 9/12/19 4:51 PM, Han Zhou wrote: > > Thanks Mark for writing this up. > > > > On Fri, Sep 6, 2019 at 2:08 PM Mark Michelson > > wrote: > > > > > > This document serves to provide an explanation for how OVN

Re: [ovs-dev] [PATCH v5 2/9] ovs-vsctl: Add conntrack zone commands.

> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in > index 7c09df79bd29..5b9883ae1c3d 100644 > --- a/utilities/ovs-vsctl.8.in > +++ b/utilities/ovs-vsctl.8.in > @@ -353,6 +353,32 @@ list. > Prints the name of the bridge that

Re: [ovs-dev] Querying OVS for OpenFlow capabilities

> On Sep 12, 2019, at 2:15 PM, William Tu wrote: > > On Thu, Sep 12, 2019 at 03:47:58PM -0400, Mark Michelson wrote: >> On 9/12/19 2:46 PM, Justin Pettit wrote: >>> >>> On Sep 12, 2019, at 11:08 AM, Mark Michelson wrote: Hi guys, I recently sent a new version of a

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

On Thu, Sep 12, 2019 at 7:14 AM Dumitru Ceara wrote: > > This series adds some (independent) optimizations that improve > ovn-controller performance by lowering the number of operations that > need to be executed during a iteration of the main controller loop. > > Each patch in the series

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

Hi Ben, Please consider this as a gentle remainder and provide your inputs on the below issue. Thanks & Regards, Anil Kumar -Original Message- From: Anil Kumar Koli Sent: Thursday, 5 September, 2019 11:12 PM To: 'Ben Pfaff' Cc: 'Ilya Maximets' ; 'ovs-dev@openvswitch.org' Subject: