[ovs-dev] [PATCH v2] ovsdb-client: fix memory leak to prevent valgrind reporting memory leaks while running test suite

2019-10-01 Thread Damijan Skvarc
memory leaks are reported in several tests and are expressed in a following way: ==29840== 208 (48 direct, 160 indirect) bytes in 1 blocks are definitely lost in loss record 43 of 44 ==29840==at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==29840==by

Re: [ovs-dev] [PATCH net-next 0/9] optimize openvswitch flow looking up

2019-10-01 Thread Eelco Chaudron
Interesting performance gain, copied in the OVS development mailing list. //Eelco On 29 Sep 2019, at 19:09, xiangxia.m@gmail.com wrote: From: Tonghao Zhang This series patch optimize openvswitch. Patch 1, 2, 4: Port Pravin B Shelar patches to linux upstream with little changes. Patch

Re: [ovs-dev] [PATCH 1/1] ovsdb-client: fix memory leak to prevent valgrind reporting memory leaks while running test suite

2019-10-01 Thread Damijan Skvarc
Ups, shame on me. Thanks for review, I will send another patch Damijan On Mon, Sep 30, 2019 at 10:47 PM Ben Pfaff wrote: > On Mon, Sep 30, 2019 at 09:20:39AM +0200, Damijan Skvarc wrote: > > memory leaks are reported in several tests and are expressed in a > following way: > > Thank you for the

Re: [ovs-dev] [PATCHv4] fatal-signal: Catch SIGSEGV and print backtrace.

2019-10-01 Thread Ilya Maximets
On Fri, Sep 27, 2019 at 10:22:55AM -0700, William Tu wrote: The patch catches the SIGSEGV signal and prints the backtrace using libunwind at the monitor daemon. This makes debugging easier when there is no debug symbol package or gdb installed on production systems. Thanks. Let's try it. I

[ovs-dev] [PATCH] cirrus: Fix typo in the name of sphinx package.

2019-10-01 Thread Ilya Maximets
This fixes broken build on CirrusCI: https://cirrus-ci.com/build/4677435792031744 CC: Ben Pfaff Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Signed-off-by: Ilya Maximets --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml

Re: [ovs-dev] [PATCH] cirrus: Fix typo in the name of sphinx package.

2019-10-01 Thread Numan Siddique
On Tue, Oct 1, 2019, 2:58 PM Ilya Maximets wrote: > This fixes broken build on CirrusCI: > https://cirrus-ci.com/build/4677435792031744 > > CC: Ben Pfaff > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") > Signed-off-by: Ilya Maximets > Acked-by: Numan Siddique ---

[ovs-dev] [PATCH v3] odp-util: calc checksum of ip hdr for tunnel encap

2019-10-01 Thread martinbj2008
From: Martin Zhang V2: fix warning V3: replace tab with spaces Signed-off-by: Martin Zhang --- lib/odp-util.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index fe59a56..36c6c3b 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c

Re: [ovs-dev] [PATCH v2] ovsdb-client: fix memory leak to prevent valgrind reporting memory leaks while running test suite

2019-10-01 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (ovsdb/ovsdb-client.c). Repository lacks necessary

[ovs-dev] [PATCH] netdev-afxdp: add afxdp specific maximum MTU check

2019-10-01 Thread Eelco Chaudron
Drivers natively supporting AF_XDP will check that a configured MTU size will not exceed the allowed size for AF_XDP. However, when the skb compatibility mode is used there is no check and any value is accepted. This, for example, is the case when using the TAP interface. This fix adds a check to

Re: [ovs-dev] [PATCH 1/1] ovsdb-client: fix memory leak in do_needs_conversion() and do_convert()

2019-10-01 Thread Damijan Skvarc
Hi Ben and thanks for review. I double checked and I can confirm the patch is ok. Changes which are applied to rpc pointer within do_convert() and do_need_conversion() function are local to functions and not propagated to outside world. This is because rpc is passed to command handler functions

[ovs-dev] From: Yara Zahid

2019-10-01 Thread Yaha Zahid
-- Good Day To You, Please i need your kind Assistance. I will be very glad if you can assist me to receive this sum of ( $22. Million US dollars.) into your bank account for the benefit of our both families, reply me if you are ready to receive this fund. Mr.Yara zahid.

Re: [ovs-dev] [PATCH] cirrus: Fix typo in the name of sphinx package.

2019-10-01 Thread Ilya Maximets
On 01.10.2019 13:02, Numan Siddique wrote: On Tue, Oct 1, 2019, 2:58 PM Ilya Maximets wrote: This fixes broken build on CirrusCI: https://cirrus-ci.com/build/4677435792031744 CC: Ben Pfaff mailto:b...@ovn.org>> Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for

[ovs-dev] Wohltätige Spende

2019-10-01 Thread Herr Richard Wahl
Hallo, Sie haben eine Wohltätigkeitsspende in Höhe von € 2.000.000,00 EURO, ich habe in Amerika die Amerikalotterie im Wert von $ 533 Millionen gewonnen und ich spende einen Teil davon an fünf glückliche Menschen und Wohltätigkeitsheime, um Armut und Hilfe zu beseitigen die Bedürftigen,

[ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread Ilya Maximets
32 and 64 bit versions of libunwind-dev package can not be installed at the same time at least in Debian and Ubuntu. AC_CHECK_LIB macro doesn't know if we have '-m32' in OVS_CFLAGS, so we need to additionally check for actual compiling possibility before enabling the feature. Otherwise 'make'

Re: [ovs-dev] [PATCH] Documentation: Document a useful pre-push hook for committers.

2019-10-01 Thread Simon Horman
On Wed, Sep 25, 2019 at 01:02:31PM -0700, Ben Pfaff wrote: > Someone else wrote this script originally, I think, but I've extended > it quite a bit. > > Signed-off-by: Ben Pfaff Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] MAINTAINERS: Add William Tu.

2019-10-01 Thread Simon Horman
On Mon, Sep 30, 2019 at 01:50:53PM -0700, Ben Pfaff wrote: > William was elected by the Open vSwitch committers today. Welcome to > the team, William! > > Signed-off-by: Ben Pfaff Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCHv4] fatal-signal: Catch SIGSEGV and print backtrace.

2019-10-01 Thread Ilya Maximets
On 01.10.2019 12:01, Ilya Maximets wrote: On Fri, Sep 27, 2019 at 10:22:55AM -0700, William Tu wrote: The patch catches the SIGSEGV signal and prints the backtrace using libunwind at the monitor daemon. This makes debugging easier when there is no debug symbol package or gdb installed on

[ovs-dev] [dpdk-latest PATCH 2/2] travis: Switch to dpdk master branch.

2019-10-01 Thread David Marchand
Make this branch point to current dpdk master branch so that we can track API breakage and benefit from the latest enhancements. Signed-off-by: David Marchand --- .travis.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index

[ovs-dev] [dpdk-latest PATCH 1/2] sparse: Get rid of obsolete rte_flow header.

2019-10-01 Thread David Marchand
This header had been copied to cope with issues on the dpdk side. Now that the problems have been fixed [1], let's drop this file as it is now out of sync with dpdk. 1: https://git.dpdk.org/dpdk/commit/?id=fbb25a3878cc Signed-off-by: David Marchand --- Note: other network headers (rte_esp.h,

[ovs-dev] Attn: Sir/Madam

2019-10-01 Thread PATRICK FOSTER
Attn: Sir/Madam This is the United Nation Crime Commission covering United Kingdom and Africa in partnership with the UK Crime Commission working together to flush out Internet Fraud, money Laundry and other related internet Crimes. It is our pleasure to inform you that we have arrested over

[ovs-dev] [dpdk-latest PATCH v3 0/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2019-10-01 Thread Eelco Chaudron
netdev-dpdk: Add new DPDK RFC 4115 egress policer This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue level, followed by a color-aware marking

[ovs-dev] [dpdk-latest PATCH v3 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2019-10-01 Thread Eelco Chaudron
This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue level, followed by a color-aware marking at the port level. At the end traffic marked as

[ovs-dev] [dpdk-latest PATCH v3 1/2] netdev-dpdk: Add support for multi-queue QoS to the DPDK datapath

2019-10-01 Thread Eelco Chaudron
This patch adds support for multi-queue QoS to the DPDK datapath. Most of the code is based on an earlier patch from a patchset sent out by zhaozhanxu. The patch was titled "[ovs-dev, v2, 1/4] netdev-dpdk.c: Support the multi-queue QoS configuration for dpdk datapath" Signed-off-by: Eelco

[ovs-dev] [PATCH ovn v1] Documentation cleanup: sandbox

2019-10-01 Thread Flavio Fernandes
Fix ovn-sandbox documentation with regards to SANDBOXFLAGS. That is, the sandbox in this repo will actually fail if we attempt to start it with the --ovn flag. Signed-off-by: Flavio Fernandes --- Documentation/tutorials/ovn-sandbox.rst | 10 -- 1 file changed, 4 insertions(+), 6

Re: [ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread Ben Pfaff
On Tue, Oct 01, 2019 at 02:22:20PM +0300, Ilya Maximets wrote: > 32 and 64 bit versions of libunwind-dev package can not be installed > at the same time at least in Debian and Ubuntu. AC_CHECK_LIB macro > doesn't know if we have '-m32' in OVS_CFLAGS, so we need to > additionally check for actual

Re: [ovs-dev] [PATCH 1/1] ovsdb-client: fix memory leak in do_needs_conversion() and do_convert()

2019-10-01 Thread Ben Pfaff
You are right. Thank you. I applied this to master. On Tue, Oct 01, 2019 at 10:23:45AM +0200, Damijan Skvarc wrote: > Hi Ben and thanks for review. > > I double checked and I can confirm the patch is ok. > Changes which are applied to rpc pointer within do_convert() and > do_need_conversion()

Re: [ovs-dev] [PATCH v2] ovsdb-client: fix memory leak to prevent valgrind reporting memory leaks while running test suite

2019-10-01 Thread Ben Pfaff
On Tue, Oct 01, 2019 at 09:22:29AM +0200, Damijan Skvarc wrote: > memory leaks are reported in several tests and are expressed in a following > way: > > ==29840== 208 (48 direct, 160 indirect) bytes in 1 blocks are definitely lost > in loss record 43 of 44 > ==29840==at 0x4C2FB55: calloc

[ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Set no-leader-only as default for clustered dbs

2019-10-01 Thread amginwal
From: Aliasgar Ginwala When using ovn-nb/sbctl running in cluster, one can use local socket to run different commands. It is very inconvenient to pass no-leader-only in different tools using ovn-nb/sbctl instead of allowing one to to connect to any nodes in the cluster including itself. e.g

Re: [ovs-dev] [PATCH v3] odp-util: calc checksum of ip hdr for tunnel encap

2019-10-01 Thread Ben Pfaff
On Tue, Oct 01, 2019 at 03:04:01PM +0800, martinbj2...@gmail.com wrote: > From: Martin Zhang > > V2: fix warning > V3: replace tab with spaces > > Signed-off-by: Martin Zhang Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread William Tu
On Tue, Oct 1, 2019 at 4:19 PM William Tu wrote: > > On Tue, Oct 01, 2019 at 08:29:41PM +0300, Ilya Maximets wrote: > > On 01.10.2019 19:56, Ben Pfaff wrote: > > >On Tue, Oct 01, 2019 at 07:46:10PM +0300, Ilya Maximets wrote: > > >>On 01.10.2019 19:17, Ben Pfaff wrote: > > >>>On Tue, Oct 01, 2019

Re: [ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread William Tu
On Tue, Oct 01, 2019 at 08:29:41PM +0300, Ilya Maximets wrote: > On 01.10.2019 19:56, Ben Pfaff wrote: > >On Tue, Oct 01, 2019 at 07:46:10PM +0300, Ilya Maximets wrote: > >>On 01.10.2019 19:17, Ben Pfaff wrote: > >>>On Tue, Oct 01, 2019 at 02:22:20PM +0300, Ilya Maximets wrote: > 32 and 64 bit

Re: [ovs-dev] [PATCH ovn v1] Documentation cleanup: sandbox

2019-10-01 Thread Han Zhou
On Tue, Oct 1, 2019 at 8:10 AM Flavio Fernandes wrote: > > Fix ovn-sandbox documentation with regards to SANDBOXFLAGS. That > is, the sandbox in this repo will actually fail if we attempt to > start it with the --ovn flag. > > Signed-off-by: Flavio Fernandes > --- >

Re: [ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread Ilya Maximets
On 01.10.2019 19:17, Ben Pfaff wrote: On Tue, Oct 01, 2019 at 02:22:20PM +0300, Ilya Maximets wrote: 32 and 64 bit versions of libunwind-dev package can not be installed at the same time at least in Debian and Ubuntu. AC_CHECK_LIB macro doesn't know if we have '-m32' in OVS_CFLAGS, so we need

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-10-01 Thread William Tu
On Mon, Sep 30, 2019 at 12:40:59PM +0200, Eelco Chaudron wrote: > > > On 27 Sep 2019, at 19:26, William Tu wrote: > > >The patch detects the numa node id from the name of the netdev, > >by reading the '/sys/class/net//device/numa_node'. > >If not available, ex: virtual device, or any error

[ovs-dev] Today's Top 25 Offers

2019-10-01 Thread Bonesca Sales
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-10-01 Thread William Tu
Hi Ilya, Thanks for your review. On Mon, Sep 30, 2019 at 10:18:32PM +0300, Ilya Maximets wrote: > Hi, William. > > Thanks for the patch. > Few general comments on the topic: > 1. This function is not afxdp specific. Maybe it's worth to move >it to more generic netdev-linux? > 2.

[ovs-dev] Sale Tuna Loins

2019-10-01 Thread Bonesca Sales
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread Ilya Maximets
On 01.10.2019 19:56, Ben Pfaff wrote: On Tue, Oct 01, 2019 at 07:46:10PM +0300, Ilya Maximets wrote: On 01.10.2019 19:17, Ben Pfaff wrote: On Tue, Oct 01, 2019 at 02:22:20PM +0300, Ilya Maximets wrote: 32 and 64 bit versions of libunwind-dev package can not be installed at the same time at

Re: [ovs-dev] [PATCH] m4: Fix 32bit build with 64bit version of libunwind-dev installed.

2019-10-01 Thread Ben Pfaff
On Tue, Oct 01, 2019 at 07:46:10PM +0300, Ilya Maximets wrote: > On 01.10.2019 19:17, Ben Pfaff wrote: > > On Tue, Oct 01, 2019 at 02:22:20PM +0300, Ilya Maximets wrote: > > > 32 and 64 bit versions of libunwind-dev package can not be installed > > > at the same time at least in Debian and Ubuntu.

Re: [ovs-dev] [PATCH ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."

2019-10-01 Thread Han Zhou
On Mon, Sep 30, 2019 at 6:51 AM wrote: > > From: Numan Siddique > > This partially revers the commit - 298701dbc99645700be41680a43d049cb061847a > as the commit [1] disables the conjunction. > > We still need the changes to the tests/ovn.at file. > > CC: Han Zhou > Signed-off-by: Numan Siddique

[ovs-dev] [PATCH] flow: Fix using pointer to member of packed struct icmp6_hdr.

2019-10-01 Thread Ilya Maximets
OVS has no structure definition for ICMPv6 header with additional data. More precisely, it has, but this structure named as 'icmp6_error_header' and only suitable to store error related extended information. 'flow_compose_l4' stores additional information in reserved bits by using system defined

Re: [ovs-dev] [PATCH] Documentation: Document a useful pre-push hook for committers.

2019-10-01 Thread Ben Pfaff
On Tue, Oct 01, 2019 at 01:52:54PM +0200, Simon Horman wrote: > On Wed, Sep 25, 2019 at 01:02:31PM -0700, Ben Pfaff wrote: > > Someone else wrote this script originally, I think, but I've extended > > it quite a bit. > > > > Signed-off-by: Ben Pfaff > > Reviewed-by: Simon Horman Thanks! I

Re: [ovs-dev] [PATCHv4] fatal-signal: Catch SIGSEGV and print backtrace.

2019-10-01 Thread William Tu
On Tue, Oct 01, 2019 at 02:25:22PM +0300, Ilya Maximets wrote: > On 01.10.2019 12:01, Ilya Maximets wrote: > >>On Fri, Sep 27, 2019 at 10:22:55AM -0700, William Tu wrote: > >>>The patch catches the SIGSEGV signal and prints the backtrace > >>>using libunwind at the monitor daemon. This makes