Re: [ovs-dev] [PATCH 1/2] dpdk: Remove deprecated pdump support.

On Mon, Mar 2, 2020 at 1:50 PM Ilya Maximets wrote: > DPDK pdump was deprecated in 2.13 release and didn't actually > work since 2.11. Removing it. > > More details in commit 4ae8c4617fd3 ("dpdk: Deprecate pdump support.") > > Signed-off-by: Ilya Maximets Acked-by: David Marchand -- David

Re: [ovs-dev] [PATCH v3] lib: use acquire-release semantics for pvector size

Hi Ilya, Thanks for your comments. V4 has been updated, could you please check it again? https://patchwork.ozlabs.org/patch/1248440/ Best Regards, Wei Yanqin > -Original Message- > From: Ilya Maximets > Sent: Friday, February 28, 2020 9:40 PM > To: Yanqin Wei ; d...@openvswitch.org >

[ovs-dev] [RFC v2 ovn 2/6] ovn-controller: Refactor binding.c

From: Numan Siddique Signed-off-by: Numan Siddique --- controller/binding.c| 682 ++-- controller/binding.h| 16 +- controller/ovn-controller.c | 49 ++- controller/pinctrl.c| 19 +- controller/pinctrl.h| 4 +- 5 files

[ovs-dev] [RFC v2 ovn 3/6] ovn-controller: I-P for port binding in runtime_data stage

From: Numan Siddique This patch handles the port binding changes incrementally in the runtime_data stage. Signed-off-by: Numan Siddique --- controller/binding.c| 455 ++-- controller/binding.h| 7 +- controller/ovn-controller.c | 50 +++- 3

[ovs-dev] [RFC v2 ovn 4/6] ovn-controller: I-P for datapath binding

From: Numan Siddique This patch adds partial support of incremental processing of datapath binding. If a datapath is deleted, then a full recompute is triggered. Signed-off-by: Numan Siddique --- controller/ovn-controller.c | 26 +- 1 file changed, 25 insertions(+), 1

[ovs-dev] [RFC v2 ovn 1/6] Refactor binding_run()to take two context argument - binding_ctx_in and binding_ctx_out.

From: Numan Siddique No functional changes are introduced in this patch. Signed-off-by: Numan Siddique --- controller/binding.c| 260 +--- controller/binding.h| 39 +++--- controller/ovn-controller.c | 120 ++--- 3 files changed,

[ovs-dev] [RFC v2 ovn 5/6] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

From: Numan Siddique If ofctrl_check_and_add_flow(F') is called where flow F' has match-actions (M, A2) and if there already exists a flow F with match-actions (M, A1) in the desired flow table, then this function doesn't update the existing flow F with new actions actions A2. This patch

[ovs-dev] [RFC v2 ovn 6/6] ovn-controller: I-P for ct zone and OVS interface changes

From: Numan Siddique Signed-off-by: Numan Siddique --- controller/binding.c| 22 -- controller/ovn-controller.c | 86 - controller/ovn-controller.h | 22 ++ controller/physical.c | 47 controller/physical.h

[ovs-dev] [PATCH] packets: Fix typo in comment.

Reported-by: Toms Atteka Signed-off-by: Ben Pfaff --- lib/packets.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/packets.h b/lib/packets.h index 5d7f82c45b6a..4c1e91dee254 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -963,7 +963,7 @@ union ovs_16aligned_in6_addr

Re: [ovs-dev] [PATCH] netdev-offload-tc: Flush rules on ingress block when init tc flow api

On Tue, Mar 03, 2020 at 04:42:12PM +0100, Ilya Maximets wrote: > On 3/3/20 4:29 PM, Dmytro Linkin wrote: > > On Tue, Mar 03, 2020 at 02:15:21PM +0100, Ilya Maximets wrote: > >> On 3/3/20 8:58 AM, Roi Dayan wrote: > >>> > >>> > >>> On 2020-02-27 5:22 PM, Roi Dayan wrote: > From: Dmytro Linkin

[ovs-dev] [RFC v2 ovn 0/6] Incremental processing improvements.

From: Numan Siddique This patch series tries to handle port binding, datapath binding and ovs interface changes incrementally. First 2 patches does some refactoring. Submitting this as RFC to get some comments. Still need to update the proper commit messages and fix one test case related to

[ovs-dev] [PATCH v4] lib: use acquire-release semantics for pvector size

Read/write concurrency of pvector library is implemented by a temp vector and RCU protection. Considering performance reason, insertion does not follow this scheme. In insertion function, a thread fence ensures size incrementation is done after new entry is stored. But there is no barrier in the

Re: [ovs-dev] [PATCH] dpif-netdev: Enter quiescent state after each offloading operation.

On 2/28/2020 11:03 AM, Ilya Maximets wrote: On 2/27/20 10:00 AM, Eli Britstein wrote: On 2/26/2020 2:31 PM, Ilya Maximets wrote: On 2/26/20 1:05 PM, Eli Britstein wrote: On 2/24/2020 1:06 PM, Ilya Maximets wrote: On 2/23/20 3:32 PM, Eli Britstein wrote: On 2/21/2020 4:54 PM, Ilya Maximets

Re: [ovs-dev] [PATCH] ovsdb-idl.c: Clear conditions when clearing IDL.

CC-ing Andy and Ben. On 3/3/20 7:43 AM, Han Zhou wrote: > > > On Mon, Mar 2, 2020 at 7:55 AM Dumitru Ceara > wrote: >> >> On 2/29/20 12:00 AM, Dumitru Ceara wrote: >> > If the ovsdb-server reply to "monitor_cond_since" requests has >> > "found" == false then

Re: [ovs-dev] [PATCH] netdev-offload-tc: Flush rules on ingress block when init tc flow api

On 3/3/20 8:58 AM, Roi Dayan wrote: > > > On 2020-02-27 5:22 PM, Roi Dayan wrote: >> From: Dmytro Linkin >> >> OVS can fail to attach ingress block on iface when init tc flow api, >> if block already exist with rules on it and is shared with other iface. >> Fix by flush all existing rules on

[ovs-dev] YOUR APPROVED REWARD:| REF:- CCMML/LON/709/SGT43658/2020

Sir/Madam, Attn; The Manager / Director, CEO Ref SUB| COCA COLA REWARD LONDON, UNITED KINGDOM. REF STATUS: YOUR EMAIL DATA-PROFILE AND/OR NAME HAS BEEN SHORT-LISTED AMONGST OTHER 54 BENEFICIARIES; FOR YOU TO RECEIVE THE CASH REWARD SUM OF 1,265,000.00 MILLION GBP FROM THE

Re: [ovs-dev] [PATCH] netdev-offload-tc: Flush rules on ingress block when init tc flow api

On Tue, Mar 03, 2020 at 02:15:21PM +0100, Ilya Maximets wrote: > On 3/3/20 8:58 AM, Roi Dayan wrote: > > > > > > On 2020-02-27 5:22 PM, Roi Dayan wrote: > >> From: Dmytro Linkin > >> > >> OVS can fail to attach ingress block on iface when init tc flow api, > >> if block already exist with rules

Re: [ovs-dev] [PATCH] netdev-offload-tc: Flush rules on ingress block when init tc flow api

On 3/3/20 4:29 PM, Dmytro Linkin wrote: > On Tue, Mar 03, 2020 at 02:15:21PM +0100, Ilya Maximets wrote: >> On 3/3/20 8:58 AM, Roi Dayan wrote: >>> >>> >>> On 2020-02-27 5:22 PM, Roi Dayan wrote: From: Dmytro Linkin OVS can fail to attach ingress block on iface when init tc flow

Re: [ovs-dev] [PATCH V2 02/11] compat: Fix up changes to inet frags in 5.1+

On 2/28/2020 9:02 AM, Gregory Rose wrote: On 2/27/2020 3:54 PM, Yi-Hung Wei wrote: On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote: Since Linux kernel release 5.1 the fragments field of the inet_frag_queue structure is removed and now only the rb_fragments structure with an rb_node pointer

Re: [ovs-dev] [PATCH net 08/16] openvswitch: add missing attribute validation for hash

On 3/2/2020 9:05 PM, Jakub Kicinski wrote: Add missing attribute validation for OVS_PACKET_ATTR_HASH to the netlink policy. Fixes: bd1903b7c459 ("net: openvswitch: add hash info to upcall") Signed-off-by: Jakub Kicinski --- CC: Pravin B Shelar CC: Tonghao Zhang CC: d...@openvswitch.org ---

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Remove deprecated ring port type.

Ilya Maximets writes: > 'dpdkr' ring ports was deprecated in 2.13 release and was not > actually used for a long time. Remove support now. > > More details in > commit b4c5f00c339b ("netdev-dpdk: Deprecate ring ports.") > > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole

Re: [ovs-dev] [PATCH 1/2] dpdk: Remove deprecated pdump support.

Ilya Maximets writes: > DPDK pdump was deprecated in 2.13 release and didn't actually > work since 2.11. Removing it. > > More details in commit 4ae8c4617fd3 ("dpdk: Deprecate pdump support.") > > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole

[ovs-dev] [PATCH ovn] Broadcast DHCPREPLY when BROADCAST flag is set

As per RFC2131, section 4.1: A server or relay agent sending or relaying a DHCP message directly to a DHCP client (i.e., not to a relay agent specified in the 'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags' field. If this bit is set to 1, the DHCP message SHOULD be

Re: [ovs-dev] [PATCH ovn] Broadcast DHCPREPLY when BROADCAST flag is set

Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #47 FILE:

[ovs-dev] [PATCH ovn] rhel: Fix make rpm-fedora by unified sphinx

If OVS>=2.13, we need '/usr/bin/sphinx-build-3' to bulid[0]. So it could be better to unify the version of "sphinx-build" between OVS and OVN, to avoid erros during make. [0] https://github.com/openvswitch/ovs/blob/master/rhel/openvswitch-fedora.spec.in#L65 Co-authored-by: Liu Chang

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Remove deprecated ring port type.

On Mon, Mar 2, 2020 at 1:50 PM Ilya Maximets wrote: > 'dpdkr' ring ports was deprecated in 2.13 release and was not > actually used for a long time. Remove support now. > > More details in > commit b4c5f00c339b ("netdev-dpdk: Deprecate ring ports.") > > Signed-off-by: Ilya Maximets Acked-by: