On 6/15/21 7:42 PM, Numan Siddique wrote:
> On Thu, Jun 10, 2021 at 8:48 AM Dumitru Ceara wrote:
>> There's no need to parse the IP sets every time we iterate through them.
>> It's enough to parse them once for every main loop iteration.
>>
>> Reported-at: https://bugzilla.redhat.com/1962338
>>
On 6/15/21 6:16 PM, Numan Siddique wrote:
> On Tue, Jun 1, 2021 at 9:33 AM Dumitru Ceara wrote:
>> There's no need to allocate a logical flow structure if we're going to
>> merge it to an existing one that refers to a datapath group.
>>
>> This saves a lot of xstrdup() calls followed immediately
From: Tony van der Peet
When a PACKET_OUT has output port of OFPP_TABLE, and the rule
table includes a meter and this causes the packet to be deleted,
stop the packet from being deleted twice by cloning it and setting
it up to be stolen in execution.
Add a test to verify this condition.
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Wednesday, June 9, 2021 4:56 PM
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> > Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 14/16] dpcls-avx512: Enable avx512 vector
> popcount
> > instruction.
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Tuesday 15 June 2021 18:04
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> > Cc: i.maxim...@ovn.org; Gaetan Rivet ; Sriharsha
> Basavapatna
>
On 6/9/21 3:59 PM, Jan Scheurich wrote:
> LGTM.
> Acked-by: Jan Scheurich
>
>> -Original Message-
>> From: Martin Varghese
>> Sent: Wednesday, 9 June, 2021 15:36
>> To: d...@openvswitch.org; i.maxim...@ovn.org; Jan Scheurich
>>
>> Cc: Martin Varghese
>> Subject: [PATCH] tests: Fixed
Fix an issue where Idl.run() returned False even if there was a change.
If Idl.run() reads multiple messages from the database server, some
may constitute changes and some may not. Changed the way change_seqno
is reset: if a message is not a change, reset change_seqno only to the
value before
Hi Ian,
Thanks for the review. My responses are inline.
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 15 June 2021 18:04
> To: Ferriter, Cian ; ovs-dev@openvswitch.org;
> Ferriter, Cian ; Van Haaren, Harry
>
> Cc: i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [v12 15/16]
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Tuesday 1 June 2021 19:59
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 04/16]
Also store the timestamp when ovn-controller started up. This helps
implementing alerts on the CMS side to detect whether ovn-controller is
still alive and functioning well.
Reported-at: https://bugzilla.redhat.com/1924751
Reported-by: Casey Callendrello
Signed-off-by: Dumitru Ceara
---
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Wednesday 2 June 2021 20:08
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 12/16]
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Wednesday 2 June 2021 18:16
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 06/16]
On 6/7/21 6:12 PM, Jan Scheurich wrote:
>> -Original Message-
>> From: Martin Varghese
>> Sent: Monday, 7 June, 2021 16:47
>> To: Ilya Maximets
>> Cc: d...@openvswitch.org; echau...@redhat.com; Jan Scheurich
>> ; Martin Varghese
>>
>> Subject: Re: [ovs-dev] [PATCH v2] Fix redundant
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Wednesday, June 9, 2021 1:03 PM
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> > Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 11/16] dpif-netdev/dpcls-avx512: Enable 16 block
> > processing.
>
>
Hi Ian,
Thanks for the review. My responses are inline.
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 15 June 2021 18:04
> To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> Cc: i.maxim...@ovn.org; Gaetan Rivet ; Sriharsha
> Basavapatna
> Subject: RE:
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Wednesday 2 June 2021 19:56
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 10/16]
Hi Ian,
Further comments are inline.
> -Original Message-
> From: Stokes, Ian
> Sent: Wednesday 16 June 2021 12:03
> To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> Cc: i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [v12 04/16] dpif-avx512: Add ISA implementation of
On 6/16/21 1:30 AM, Ansis wrote:
> On Tue, Jun 15, 2021 at 3:02 PM William Tu wrote:
>>
>> On Tue, Jun 15, 2021 at 11:43 AM Ansis wrote:
>>>
>>> On Mon, Jun 14, 2021 at 10:22 PM Ansis wrote:
On Mon, Jun 7, 2021 at 1:31 PM Toms Atteka wrote:
>
> This optimization caused
From: Dumitru Ceara
Add a new 'controller_meter' column to OVN Southbound Logical_Flow
table. This stores an optional string which should correspond to
the Meter that must be used for rate limiting controller actions
generated by packets hitting the flow.
Add a new 'ofctrl_add_flow_metred'
From: Dumitru Ceara
Signed-off-by: Dumitru Ceara
Signed-off-by: Lorenzo Bianconi
---
NEWS | 1 +
1 file changed, 1 insertion(+)
diff --git a/NEWS b/NEWS
index 0da7d8f97..72585e56b 100644
--- a/NEWS
+++ b/NEWS
@@ -25,6 +25,7 @@ OVN v21.06.0 - 11 May 2021
* ovn-sbctl now also supports
From: Dumitru Ceara
Change the ovn-northd implementation to set the new 'controller_meter'
field for flows that need to punt packets to ovn-controller.
Protocol packets for which CoPP is enforced when sending packets to
ovn-controller (if configured):
- ARP
- ND_NS
- ND_NA
- ND_RA
- DNS
- IGMP
From: Dumitru Ceara
Add new 'Copp' (Control plane protection) table to OVN Northbound DB:
- this stores mappings between control plane protocol names and meters
that should be used to rate limit controller-destined traffic for
those protocols.
Add new 'copp' columns to the following OVN
This series respin CoPP support introduced here [0] by Dumitru rebasing on top
of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
The main goal of this series is to continue the discussion about the proposed
approach and to align on CMS APIs.
For the moment no ddlog
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#883 FILE: utilities/ovn-nbctl.c:430:
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Tuesday 1 June 2021 19:59
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Finn,
> Emma ; Van Haaren, Harry
> >
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev]
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> Also, one thing I spotted while looking at your later reviews was that we
> should
> update the "lib/dpif-netdev-unixctl.man" file since it prints an example of
> the
> PMD statistics.
> I'll fix that in the next version.
>
> >
> From: Ferriter, Cian
> Sent: Thursday, June 10, 2021 3:47 PM
> To: Stokes, Ian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> Cc: i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [v12 09/16] docs/dpdk/bridge: Add dpif performance
> section.
>
> Hi Ian,
>
> Thanks for the review. My responses
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Wednesday 9 June 2021 16:23
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v12 13/16]
> Hi Ian,
>
> Thanks for the review. My responses are inline.
>
> > -Original Message-
> > From: Stokes, Ian
> > Sent: Tuesday 15 June 2021 18:04
> > To: Ferriter, Cian ; ovs-dev@openvswitch.org;
> Ferriter, Cian ; Van Haaren, Harry
> >
> > Cc: i.maxim...@ovn.org
> > Subject: RE:
On 6/15/21 10:06 PM, Ilya Maximets wrote:
> On 6/11/21 4:29 PM, Terry Wilson wrote:
>> This is a partial revert of c1aa16d19, but keeps its test.
>>
>> Applications that use eventlet cannot use poll() without blocking.
>> To fix an issue where the check_connection_completion() code would
>> not
Hi Ian,
I've replied on the checkpatch issues inline below.
Thanks,
Cian
> -Original Message-
> From: Stokes, Ian
> Sent: Tuesday 15 June 2021 18:26
> To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> Cc: i.maxim...@ovn.org; Gaetan Rivet ; Sriharsha
> Basavapatna
On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote:
> On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote:
> > VStudio 16.10 adds usermode includes before including the driver
> > kit ones.
> >
> > Bug tracked at:
> >
Using 1024 bit params for DH is considered unsafe [1]. Additionally,
from [2]:
"Modern servers that do not support export ciphersuites are advised to
either use SSL_CTX_set_tmp_dh() or alternatively, use the callback but
ignore keylength and is_export and simply supply at least 2048-bit
> -Original Message-
> From: Stokes, Ian
> Sent: Wednesday 16 June 2021 13:48
> To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry
> Cc: i.maxim...@ovn.org; Gaetan Rivet ; Sriharsha
> Basavapatna
> Subject: RE: [ovs-dev] [v12 16/16] netdev: Optimize
Hi Ian,
Further responses are inline.
> -Original Message-
> From: Stokes, Ian
> Sent: Wednesday 16 June 2021 13:47
> To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van
> Haaren, Harry ;
> i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [v12 15/16] dpif-netdev: Optimize dp output action.
>
Recently, Travis-CI has retired the travis-ci.org service. At the
moment, it is read-only. In the future, it may disappear completely.
Currently, Open vSwitch has public facing badges, and documentation,
which heavily refers to the Travis-CI service. (see the
submitting-patches.rst,
Hi Dumitru, I have a few comments down below:
On 6/16/21 7:03 AM, Dumitru Ceara wrote:
Also store the timestamp when ovn-controller started up. This helps
implementing alerts on the CMS side to detect whether ovn-controller is
still alive and functioning well.
Reported-at:
Using 1024 bit params for DH is considered unsafe [1]. Additionally,
from [2]:
"Modern servers that do not support export ciphersuites are advised to
either use SSL_CTX_set_tmp_dh() or alternatively, use the callback but
ignore keylength and is_export and simply supply at least 2048-bit
On 6/16/21 2:04 AM, Tony van der Peet wrote:
> From: Tony van der Peet
>
> When a PACKET_OUT has output port of OFPP_TABLE, and the rule
> table includes a meter and this causes the packet to be deleted,
> stop the packet from being deleted twice by cloning it and setting
> it up to be stolen in
On 6/16/21 10:34 PM, Ilya Maximets wrote:
> Not a very important fix, but fuzzer times out trying to test parsing
> of a huge number of actions. Fixing that by reporting an error as
> soon as ofpacts oversized.
>
> It would be great to use ofpacts_oversized() function instead of manual
> size
For this and patch 1:
Acked-by: Mark Michelson
I have a small question below that may or may not require a change to
the series. If a change is needed, it's so small that it's not worth
having you upload a new version of the patch. Whoever merges this series
can make the change.
On
Signed-off-by: Mark Michelson
---
northd/ovn-northd.c | 223 ++--
1 file changed, 111 insertions(+), 112 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 6b51d12de..59e3c5f84 100644
--- a/northd/ovn-northd.c
+++
For this commit, only the most trivial dynamic string matches have been
replaced with a thread-local buffer. This prevents a great deal of
memory allocations and frees.
Follow-up commits will take care of some of the more complex uses of
dynamic string matches.
Signed-off-by: Mark Michelson
---
Using 1024 bit params for DH is considered unsafe [1]. Additionally,
from [2]:
"Modern servers that do not support export ciphersuites are advised to
either use SSL_CTX_set_tmp_dh() or alternatively, use the callback but
ignore keylength and is_export and simply supply at least 2048-bit
On 6/16/21 10:25 PM, Dumitru Ceara wrote:
>> Micro-optimization suggestion: Declare a static bool in store_nb_cfg()
>> that indicates when the startup_ts has been written to the OVS DB. Then
>> check it at the beginning of this if statement to avoid the smap lookup
>> of br_int->external_ids when
NOTE: This is an RFC. This absolutely should not be committed as-is.
Based on recent patches that have been submitted to ovn-northd.c, I
noticed that dynamic string creation and destruction are hot topics.
Patches have focused on re-using dynamic strings when possible.
I took this to a logical
I forgot to do this in the earlier patches, so I'm adding it here. If
this weren't an RFC series, I'd roll this into earlier commits, but I'm
playing a bit more loosely with it here.
Signed-off-by: Mark Michelson
---
northd/ovn-northd.c | 7 ++-
1 file changed, 6 insertions(+), 1
On 6/16/21 10:13 PM, Mark Michelson wrote:
> Hi Dumitru, I have a few comments down below:
Hi Mark,
Thanks for reviewing this!
>
> On 6/16/21 7:03 AM, Dumitru Ceara wrote:
>> Also store the timestamp when ovn-controller started up. This helps
>> implementing alerts on the CMS side to detect
Not a very important fix, but fuzzer times out trying to test parsing
of a huge number of actions. Fixing that by reporting an error as
soon as ofpacts oversized.
It would be great to use ofpacts_oversized() function instead of manual
size checking, but ofpacts->header here always points to the
Thanks Ilya. For what it's worth, besides running the OVS unit tests, I put
this new code through our (enhanced) version of oftest (500 test cases)
including a couple I wrote just for this situation.
Tony
On Thu, Jun 17, 2021 at 8:05 AM Ilya Maximets wrote:
> On 6/16/21 2:04 AM, Tony van der
51 matches
Mail list logo
