Hi Eelco,
Pls find replies inline.
> > +uint32_t
> > +mfex_study_traffic(struct dp_packet_batch *packets,
> > + struct netdev_flow_key *keys,
> > + uint32_t keys_size, odp_port_t in_port,
> > + struct dp_netdev_pmd_thread *pmd_handle) {
> >
On 6 Jul 2021, at 15:11, Cian Ferriter wrote:
From: Kumar Amber
Tests:
6: OVS-DPDK - MFEX Autovalidator
7: OVS-DPDK - MFEX Autovalidator Fuzzy
Added a new directory to store the PCAP file used
in the tests and a script to generate the fuzzy traffic
type pcap to be used in fuzzy unit
On 7/6/21 3:34 PM, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Thursday, July 1, 2021 11:32 AM
>> To: Van Haaren, Harry ; Ilya Maximets
>>
>> Cc: Eli Britstein ; ovs dev ; Ivan
>> Malov
>> ; Majd Dibbiny ; Stokes, Ian
>> ; Ferriter, Cian ; Ben Pfaff
>>
> -Original Message-
> From: Stokes, Ian
> Sent: Wednesday, July 7, 2021 3:38 PM
> To: Eelco Chaudron ; Van Haaren, Harry
> ; Amber, Kumar
> Cc: Amber, Kumar ; Ferriter, Cian
> ; ovs-dev@openvswitch.org; f...@sysclose.org;
> i.maxim...@ovn.org
> Subject: RE: [v6 00/11] MFEX
On 7/6/21 3:03 PM, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Friday, July 2, 2021 2:34 PM
>> To: Van Haaren, Harry ; Eli Britstein
>> ; d...@openvswitch.org; Ilya Maximets
>> Cc: Ivan Malov ; Majd Dibbiny
>> Subject: Re: [ovs-dev] [PATCH V7 13/13]
On 01/07/2021 17:41, David Marchand wrote:
> Users complained that per rxq pmd usage was confusing: summing those
> values per pmd would never reach 100% even if increasing traffic load
> beyond pmd capacity.
>
> This is because the dpif-netdev/pmd-rxq-show command only reports "pure"
> rxq
On Thu, Jul 01, 2021 at 04:06:12PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds the AVX512 implementation of DPIF functionality,
> specifically the dp_netdev_input_outer_avx512 function. This function
> only handles outer (no re-circulations), and is optimized to use
On Wed, Jul 07, 2021 at 04:43:21AM -0400, Mark Gray wrote:
> The Open vSwitch kernel module uses the upcall mechanism to send
> packets from kernel space to user space when it misses in the kernel
> space flow table. The upcall sends packets via a Netlink socket.
> Currently, a Netlink socket is
On Thu, Jul 01, 2021 at 04:06:11PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a function pointer to the pmd thread data structure,
> giving the pmd thread flexibility in its dpif-input function choice.
> This allows choosing of the implementation based on ISA
On 7/7/21 5:03 PM, Ihar Hrachyshka wrote:
> Recently, we stopped leaking localport traffic through localnet ports
> into fabric to avoid unnecessary flipping between chassis hosting the
> same localport.
>
> Despite the type name, in some scenarios localports are supposed to
> talk outside the
On 6 Jul 2021, at 15:11, Cian Ferriter wrote:
From: Kumar Amber
This commit adds a new command to allow the user to enable
autovalidatior by default at build time thus allowing for
runnig unit test by default.
$ ./configure --enable-mfex-default-autovalidator
Signed-off-by: Kumar Amber
> > -Original Message-
> > From: Eelco Chaudron
> > Sent: Wednesday, July 7, 2021 10:41 AM
> > To: Van Haaren, Harry
> > Cc: Amber, Kumar ; d...@openvswitch.org;
> > i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
> >
> > Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto
Recently, we stopped leaking localport traffic through localnet ports
into fabric to avoid unnecessary flipping between chassis hosting the
same localport.
Despite the type name, in some scenarios localports are supposed to
talk outside the hosting chassis. Specifically, in OpenStack [1]
metadata
Hi Flavio,
Thanks for your comments. My responses are inline.
Thanks,
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Wednesday 7 July 2021 15:40
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v14 05/11] dpif-netdev: Add
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 7, 2021 10:41 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
>
On 6 Jul 2021, at 15:11, Cian Ferriter wrote:
> From: Kumar Amber
>
> The study function runs all the available implementations
> of miniflow_extract and makes a choice whose hitmask has
> maximum hits and sets the mfex to that function.
>
> Study can be run at runtime using the following
Hi Eelco,
Ah great catch :
+#ifdef MFEX_AUTOVALIDATOR_DEFAULT
+ VLOG_INFO("Default miniflow Extract implementation %s",
+ mfex_impls[MFEX_IMPL_AUTOVALIDATOR].name);
+ default_mfex_func = mfex_impls[MFEX_IMPL_AUTOVALIDATOR].extract_func;
+#else
The change above forces you to always use the
> On 7 Jul 2021, at 12:13, Van Haaren, Harry wrote:
>
> > Hi All,
> >
> > This thread has dissolved into unnecessary time-wasting on nitpick changes.
> There is no
> > technical issue with uint32_t, so this patch remains as is, and this should
> > be
> accepted for merge.
> >
> > If you feel
Hi,
Please see my comments below.
On Thu, Jul 01, 2021 at 04:06:13PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a new command to allow the user to switch
> the active DPIF implementation at runtime. A probe function
> is executed before switching the DPIF
On Wed, Jul 7, 2021, at 17:05, Eli Britstein wrote:
> Port numbers are usually small. Maintain an array of netdev handles indexed
> by port numbers. It accelerates looking up for them for
> netdev_hw_miss_packet_recover().
>
> Reported-by: Cian Ferriter
> Signed-off-by: Eli Britstein
>
On 6 Jul 2021, at 15:11, Cian Ferriter wrote:
> From: Kumar Amber
>
> This commit adds a section to the dpdk/bridge.rst netdev documentation,
> detailing the added miniflow functionality. The newly added commands are
> documented, and sample output is provided.
>
> The use of auto-validator
This was causing some IPv6 system tests to fail when run with
ovn-northd-ddlog.
Also fix cleanup of the northd process in system-ovn.at. A few tests
were trying to stop ovn-northd (C version) even when run with
ovn-northd-ddlog.
Signed-off-by: Dumitru Ceara
---
Note: There are some
Did not do a full review, just some small comments as this will change
with the suggested -pmd option.
On 6 Jul 2021, at 15:11, Cian Ferriter wrote:
From: Kumar Amber
This commit introduces additional command line paramter
for mfex study function. If user provides additional packet out
it
Port numbers are usually small. Maintain an array of netdev handles indexed
by port numbers. It accelerates looking up for them for
netdev_hw_miss_packet_recover().
Reported-by: Cian Ferriter
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 41
rte_flow_get_restore_info() API is under experimental attribute. Using it
has a performance impact that can be avoided for non-experimental compilation.
Do not call it without experimental support.
Reported-by: Cian Ferriter
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
Hi Eelco,
Again, looks like email format is broken . I will snip the mail
Pls find the replies inline.
+ uint32_t batch_failed = 0;
+ /* Iterate through each version of miniflow implementations. */
+ for (int j = MFEX_IMPL_MAX; j < MFEX_IMPL_MAX; j++) {
This is really confusing ;) Maybe we
Whenever a Load_Balancer is updated, e.g., a VIP is added, the following
sequence of events happens:
1. The Southbound Load_Balancer record is updated.
2. The Southbound Datapath_Binding records on which the Load_Balancer is
applied are updated.
3. Southbound ovsdb-server sends updates about
Hi Eelco,
Don’t know the formatting keeps breaking . replies are inline.
+optimal implementation. If no packet count is provided then the default value
+128 is chosen.
Not a native speaker, but I think the sentence need some commas?
“If no packet count is provided, then the default value,
On 7/7/2021 7:35 PM, Gaëtan Rivet wrote:
External email: Use caution opening links or attachments
On Wed, Jul 7, 2021, at 17:05, Eli Britstein wrote:
Port numbers are usually small. Maintain an array of netdev handles indexed
by port numbers. It accelerates looking up for them for
On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson wrote:
>
> The same pattern is repeated several times throughout ovn-northd.c, so
> this puts it in its own function. This will be used even more in an
> upcoming commit.
>
> Signed-off-by: Mark Michelson
Acked-by: Numan Siddique
Thanks
Numan
>
On Wed, Jun 16, 2021 at 08:32:28PM +, Jaime Caamaño Ruiz wrote:
> Using 1024 bit params for DH is considered unsafe [1]. Additionally,
> from [2]:
Thanks, I applied this to master.
___
dev mailing list
d...@openvswitch.org
On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson wrote:
>
> Previously, ARP TPAs were filtered down only to "reachable" addresses.
> Reachable addresses are all router interface addresses, as well as NAT
> external addresses and load balancer VIPs that are within the subnet
> handled by a router's
On Tue, Jun 15, 2021 at 09:28:25AM -0400, Mark Michelson wrote:
> On 6/15/21 9:24 AM, Mark Michelson wrote:
> > Signed-off-by: Mark Michelson
> > ---
> > controller/ofctrl.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/controller/ofctrl.c b/controller/ofctrl.c
> > index
On 7/2/21 9:09 AM, aserd...@ovn.org wrote:
> From: Alin Gabriel Serdean
>
>> Fix an issue where Idl.run() returned False even if there was a change.
>> If Idl.run() reads multiple messages from the database server, some
>> may constitute changes and some may not. Changed the way change_seqno
>>
On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson wrote:
>
> Dealing with NAT and load balancer IPs has been a bit of a pain point.
> It requires creating static routes if east-west traffic to those
> addresses is desired. Further, it requires ARPs to be sent between the
> logical routers in order
Hello,
Please find my comments below.
On Thu, Jul 01, 2021 at 04:06:14PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> This commit adds a new command to retrieve the list of available
> DPIF implementations. This can be used by to check what implementations
> of the DPIF are
Hi Eelco,
Replies are inline.
+++ b/tests/mfex_fuzzy.py
@@ -0,0 +1,32 @@
+#!/usr/bin/python3
+try:
+ from scapy.all import *
+except ModuleNotFoundError as err:
+ print(err + ": Scapy")
+import sys
+import os
+
+path = os.environ['OVS_DIR'] + "/tests/pcap/fuzzy"
This is failing in my setup, as
On 7/6/21 3:36 PM, Flavio Leitner wrote:
> On Tue, Jul 06, 2021 at 03:27:41PM +0200, Adrian Moreno wrote:
>>
>>
>> On 7/6/21 2:50 PM, Flavio Leitner wrote:
>>> On Tue, Jul 06, 2021 at 08:25:59AM +0200, Adrian Moreno wrote:
On 7/5/21 4:15 PM, Flavio Leitner wrote:
>
> Hi,
Open vSwitch supports OpenFlow "instructions", which were introduced in
OpenFlow 1.1 and act like restricted kinds of actions that can only
appear in a particular order and particular circumstances. OVS did
not support two of these instructions, "write_metadata" and
"goto_table", properly in the
On Wed, Jul 07, 2021 at 04:37:11PM -0300, Flavio Leitner wrote:
>
> Hi,
>
> On Tue, Jul 06, 2021 at 03:37:09PM -0700, Ben Pfaff wrote:
> > The vswitchd database schema requires role names to be "master" or
> > "slave", but this code tried to use "primary" and "secondary".
>
> We have defined
On 7/7/21 1:41 PM, Numan Siddique wrote:
On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson wrote:
Previously, ARP TPAs were filtered down only to "reachable" addresses.
Reachable addresses are all router interface addresses, as well as NAT
external addresses and load balancer VIPs that are
On Wed, Jul 7, 2021 at 5:03 PM Mark Michelson wrote:
>
> On 7/7/21 2:50 PM, Mark Michelson wrote:
> > On 7/7/21 1:41 PM, Numan Siddique wrote:
> >> On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson
> >> wrote:
> >>>
> >>> Previously, ARP TPAs were filtered down only to "reachable" addresses.
> >>>
On Thu, Jun 24, 2021 at 01:44:48PM +0200, Ilya Maximets wrote:
> We don't need to continue parsing if already oversized. This is not
> very important, but fuzzer times out while parsing very long flow.
>
> The check could be written as a single 'if' statement, but I found
> my variant much more
On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson wrote:
>
> Load_Balancer and NAT entries have a new option, "add_route" that can be
> set to automatically add routes to those addresses to neighbor routers,
> therefore eliminating the need to create static routes.
>
> Signed-off-by: Mark Michelson
https://bugzilla.redhat.com/show_bug.cgi?id=1944220
Lorenzo Bianconi (2):
controller: incrementally create ipv6 prefix delegation port_binding
list
controller: incrementally create ras port_binding list
controller/binding.c| 42
controller/binding.h| 2 +
Incrementally manage local_active_ports_ipv6_pd map for interfaces
where IPv6 prefix-delegation has been enabled. This patch allows to
avoid looping over all local interfaces to check if prefix-delegation
is running on the current port binding.
Signed-off-by: Lorenzo Bianconi
---
Incrementally manage local_active_ports_ras map for interfaces
where periodic router advertisement has been enabled. This patch
allows to avoid looping over all local interfaces to check if
periodic RA is running on the current port binding.
Signed-off-by: Lorenzo Bianconi
---
On 6/24/21 1:44 PM, Ilya Maximets wrote:
> We don't need to continue parsing if already oversized. This is not
> very important, but fuzzer times out while parsing very long flow.
>
> The check could be written as a single 'if' statement, but I found
> my variant much more readable.
>
>
Hi,
On Wed, Jul 07, 2021 at 04:53:14PM +0200, Ilya Maximets wrote:
> On 7/6/21 3:34 PM, Van Haaren, Harry wrote:
> >> -Original Message-
> >> From: Ilya Maximets
> >> Sent: Thursday, July 1, 2021 11:32 AM
> >> To: Van Haaren, Harry ; Ilya Maximets
> >>
> >> Cc: Eli Britstein ; ovs dev
On Wed, Jul 7, 2021 at 1:35 PM Numan Siddique wrote:
>
> On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson wrote:
> >
> > Load_Balancer and NAT entries have a new option, "add_route" that can be
> > set to automatically add routes to those addresses to neighbor routers,
> > therefore eliminating
Hi,
On Tue, Jul 06, 2021 at 03:37:09PM -0700, Ben Pfaff wrote:
> The vswitchd database schema requires role names to be "master" or
> "slave", but this code tried to use "primary" and "secondary".
We have defined the constraints in the schema and we can't change
the schema because it would
On Tue, Jun 15, 2021 at 03:01:47PM +0300, Alexey Roytman wrote:
> From: Alexey Roytman
>
> The original version said that "monitor_cond_change" request response
> should contain '"result": null'. However, if response message has form
> like {"id":13, "result":null} or {"id":13} the ovsdb
On 7/2/21 1:40 PM, aserd...@ovn.org wrote:
> From: Alin-Gabriel Serdean
>
>> Not a very important fix, but fuzzer times out trying to test parsing
>> of a huge number of actions. Fixing that by reporting an error as
>> soon as ofpacts oversized.
>>
>> It would be great to use
On 7/7/21 2:50 PM, Mark Michelson wrote:
On 7/7/21 1:41 PM, Numan Siddique wrote:
On Wed, Jun 30, 2021 at 7:57 PM Mark Michelson
wrote:
Previously, ARP TPAs were filtered down only to "reachable" addresses.
Reachable addresses are all router interface addresses, as well as NAT
external
On Wed, Jul 07, 2021 at 12:58:28PM -0700, Ben Pfaff wrote:
> On Wed, Jul 07, 2021 at 04:37:11PM -0300, Flavio Leitner wrote:
> >
> > Hi,
> >
> > On Tue, Jul 06, 2021 at 03:37:09PM -0700, Ben Pfaff wrote:
> > > The vswitchd database schema requires role names to be "master" or
> > > "slave", but
Hi, I've been talking to Shay Vargaftik (CC'd), also a researcher at
VMware, about some work he's done on optimizing load balancers. What
he's come up with is a technique that in many cases avoids putting
connections into the connection-tracking table, because it can achieve
per-connection
On Wed, Jul 7, 2021 at 3:39 PM Ben Pfaff wrote:
>
> Hi, I've been talking to Shay Vargaftik (CC'd), also a researcher at
> VMware, about some work he's done on optimizing load balancers. What
> he's come up with is a technique that in many cases avoids putting
> connections into the
On Wed, Jul 7, 2021 at 1:28 AM Mark Gray wrote:
>
> This patch addresses a number of interconnected issues with Gateway
Routers
> that have Load Balancing enabled:
>
> 1) In the router pipeline, we have the following stages to handle
> dnat and unsnat.
>
> - Stage 4 : lr_in_defrag (dnat zone)
>
On Tue, Jul 6, 2021 at 6:47 AM Dumitru Ceara wrote:
>
> Time how long change/run handlers take and log this at debug level.
> I-P engine debug logs are not so verbose so enabling them is quite
> common when debugging scale/control plane latency related issues.
>
> One of the major missing pieces
On Wed, Jul 7, 2021 at 1:28 AM Mark Gray wrote:
>
> If a new table is added to a logical flow pipeline, the mapping between
> 'external_ids:stage-name' from the 'Logical_Flow' table in the
> 'OVN_Southbound' database and the 'stage' number may change for some
tables.
>
> If 'ovn-northd' is
On Wed, Jul 7, 2021 at 1:28 AM Mark Gray wrote:
>
> Update email address for Mark Gray
>
> Signed-off-by: Mark Gray
> ---
> .mailmap| 1 +
> AUTHORS.rst | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.mailmap b/.mailmap
> index f01664e5c1d1..bc32255b5cc4 100644
>
On Wed, Jul 7, 2021 at 1:28 AM Mark Gray wrote:
>
> Signed-off-by: Mark Gray
> ---
> tests/ovn.at | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index eb9bccdc7053..e5d8869a8417 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
>
On Tue, Jul 6, 2021 at 8:11 PM Han Zhou wrote:
>
>
>
> On Tue, Jul 6, 2021 at 1:19 AM Frode Nordahl
> wrote:
> >
> > On Mon, Jul 5, 2021 at 6:57 PM Numan Siddique wrote:
> > >
> > > On Mon, Jul 5, 2021 at 12:12 PM Frode Nordahl
> > > wrote:
> > > >
> > > > On Wed, Jun 30, 2021 at 12:32 AM
On 6 Jul 2021, at 17:32, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Tuesday, July 6, 2021 3:19 PM
>> To: Ferriter, Cian
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren,
>> Harry ; Amber, Kumar ;
>> Stokes, Ian
Bleep bloop. Greetings Fabrizio D'Angelo, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#98 FILE:
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 7, 2021 7:45 AM
> To: Van Haaren, Harry
> Cc: Ferriter, Cian ; ovs-dev@openvswitch.org;
> f...@sysclose.org; i.maxim...@ovn.org; Amber, Kumar ;
> Stokes, Ian
> Subject: Re: [v5 01/11] dpif-netdev: Add command line and
On 7/7/21 5:20 AM, Ihar Hrachyshka wrote:
> Recently, we stopped leaking localport traffic through localnet ports
> into fabric to avoid unnecessary flipping between chassis hosting the
> same localport.
>
> Despite the type name, in some scenarios localports are supposed to talk
> outside the
Uses northd database to specify number of threads that should be used
when lflow parallel computation is enabled.
Example:
ovn-nbctl set NB_Global . options:num_parallel_threads=16
Reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1975345
Signed-off-by: Fabrizio D'Angelo
---
Hi Eelco
Pls find my comments inline.
> >> See comments inline...
> >
> >
> >
> >>> +return;
> >>> +}
> >>
> >>
> >> Argument handling is not as it should be, see my previous comment. I
> >> think the packets count should only be available for the study option
> >> (this might not
On 7 Jul 2021, at 9:21, Amber, Kumar wrote:
> Hi Eelco
>
> Pls find my comments inline.
>
See comments inline...
>>>
>>>
>>>
> +return;
> +}
Argument handling is not as it should be, see my previous comment. I
think the packets count should only be
On 07/07/2021 09:28, Mark Gray wrote:
> This patch addresses a number of interconnected issues with Gateway Routers
> that have Load Balancing enabled:
>
> 1) In the router pipeline, we have the following stages to handle
> dnat and unsnat.
>
> - Stage 4 : lr_in_defrag (dnat zone)
> - Stage 5
On 6 Jul 2021, at 17:06, Amber, Kumar wrote:
> Hi Eelco ,
>
>
> Here is the diff vor v6 vs v5 :
>
> Patch 1 :
>
> diff --git a/lib/dpif-netdev-private-extract.c
> b/lib/dpif-netdev-private-extract.c
> index 1aebf3656d..4987d628a4 100644
> --- a/lib/dpif-netdev-private-extract.c
> +++
On 06/07/2021 10:05, David Marc hand wrote:
> Small nits on the NEWS update.
>
> On Mon, Jul 5, 2021 at 3:39 PM Mark Gray wrote:
>> diff --git a/NEWS b/NEWS
>> index a2a2dcf95d7d..80b13e358685 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -29,7 +29,12 @@ Post-v2.15.0
>> - ovsdb-tool:
>> *
On 07/07/2021 09:43, Mark Gray wrote:
> This series proposes a new method of distributing upcalls
> to user space threads attempting to resolve a number of
> issues with the current method.
>
> v2 - Rebase
> Address Flavio's comments
> v3 - Add man page to automake
> v4 - Rebase and address
On 06/07/2021 13:35, Flavio Leitner wrote:
>
> The two functions below are Linux specific, so they need to be conditional
> to the #ifdef above like you did in dpif_netlink_recv_wait():
>
> #ifdef _WIN32
> dpif_netlink_recv_wait_windows()
> #else
> dpif_netlink_recv_wait_vport_dispatch()
>
On 7 Jul 2021, at 6:34, Amber, Kumar wrote:
> Hi Eelco,
>
> MFEX v7 will be available shorty EOD today.
> Some comments are inline.
Thanks, looks like one item is still not clear, and I think why (see below).
>
>>> + * for that packet.
>>> + */
>>> +uint32_t mfex_hit
Hi Eelco,
Thanks for reviews good find I missed it will be fixed in v7.
< Snip>
>
> >>> + * for that packet.
> >>> + */
> >>> +uint32_t mfex_hit = (mf_mask & (1 << i));
> >>
> >> This was supposed to become a bool?
> >>
> >
> > This cannot be a bool as this is used like
On 7 Jul 2021, at 11:09, Van Haaren, Harry wrote:
-Original Message-
From: Eelco Chaudron
Sent: Wednesday, July 7, 2021 9:35 AM
To: Amber, Kumar
Cc: Ferriter, Cian ;
ovs-dev@openvswitch.org;
f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry
; Stokes, Ian
Subject: Re: [v6
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 7, 2021 9:59 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
>
On 7 Jul 2021, at 11:33, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Wednesday, July 7, 2021 9:59 AM
>> To: Van Haaren, Harry
>> Cc: Amber, Kumar ; d...@openvswitch.org;
>> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>>
>> Subject: Re:
This patch addresses a number of interconnected issues with Gateway Routers
that have Load Balancing enabled:
1) In the router pipeline, we have the following stages to handle
dnat and unsnat.
- Stage 4 : lr_in_defrag (dnat zone)
- Stage 5 : lr_in_unsnat (snat zone)
- Stage 6 : lr_in_dnat
If a new table is added to a logical flow pipeline, the mapping between
'external_ids:stage-name' from the 'Logical_Flow' table in the
'OVN_Southbound' database and the 'stage' number may change for some tables.
If 'ovn-northd' is started against a populated Southbound database,
'external_ids'
There are a number of issues with logical flows in the DNAT/SNAT/DEFRAG tables.
This
series addresses these issues.
This is a continuation of the series
https://patchwork.ozlabs.org/project/ovn/list/?series=245191.
As additional changes and patches have been added and the scope of the patch is
Signed-off-by: Mark Gray
---
tests/ovn.at | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index eb9bccdc7053..e5d8869a8417 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -5888,7 +5888,7 @@ test_dhcp() {
local expect_resume=:
Update email address for Mark Gray
Signed-off-by: Mark Gray
---
.mailmap| 1 +
AUTHORS.rst | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index f01664e5c1d1..bc32255b5cc4 100644
--- a/.mailmap
+++ b/.mailmap
@@ -52,6 +52,7 @@ Joe Stringer
Justin
This series proposes a new method of distributing upcalls
to user space threads attempting to resolve a number of
issues with the current method.
v2 - Rebase
Address Flavio's comments
v3 - Add man page to automake
v4 - Rebase and address Flavio's comments
v5 - Rebase and address Flavio and
'n_handlers' and 'n_revalidators' are declared as type 'size_t'.
However, dpif_handlers_set() requires parameter 'n_handlers' as
type 'uint32_t'. This patch fixes this type mismatch.
Signed-off-by: Mark Gray
Acked-by: Flavio Leitner
---
Notes:
v1 - Reworked based on Flavio's comments:
Fixes: 1579cf677fcb ("dpif-linux: Implement the API functions to allow multiple
handler threads read upcall.")
Signed-off-by: Mark Gray
Acked-by: Flavio Leitner
---
Notes:
v1 - Reworked based on Flavio's comments:
* Added "Fixes" tag
lib/dpif-netlink.c | 4 ++--
1 file changed,
The Open vSwitch kernel module uses the upcall mechanism to send
packets from kernel space to user space when it misses in the kernel
space flow table. The upcall sends packets via a Netlink socket.
Currently, a Netlink socket is created for every vport. In this way,
there is a 1:1 mapping between
On 6 Jul 2021, at 15:58, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Friday, July 2, 2021 8:10 AM
>> To: Van Haaren, Harry
>> Cc: Amber, Kumar ; d...@openvswitch.org;
>> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>>
>> Subject: Re: [ovs-dev]
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 7, 2021 9:35 AM
> To: Amber, Kumar
> Cc: Ferriter, Cian ; ovs-dev@openvswitch.org;
> f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry
> ; Stokes, Ian
> Subject: Re: [v6 00/11] MFEX Infrastructure + Optimizations
Hi Flavio,
Thanks for the info. My response is inline.
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Tuesday 6 July 2021 20:36
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple
Hi Eelco,
I tried with the suggestion “zd” is deprecated and in place of it %"PRIdSIZE``
is mentioned which still causes build failure on non-ssl 32 bit builds.
Regards
Amber
From: Eelco Chaudron
Sent: Wednesday, July 7, 2021 3:02 PM
To: Van Haaren, Harry
Cc: Amber, Kumar ; Ferriter, Cian
Hi Flavio,
Thanks for your comment. My response is inline.
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Wednesday 7 July 2021 00:06
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v14 02/11] dpif-netdev: Split HWOL out to
Hi All,
This thread has dissolved into unnecessary time-wasting on nitpick changes.
There is no
technical issue with uint32_t, so this patch remains as is, and this should be
accepted for merge.
If you feel differently, reply to this with a detailed description of a genuine
technical bug.
On 6 Jul 2021, at 15:11, Cian Ferriter wrote:
From: Kumar Amber
This patch introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different miniflow implementations against the linear
miniflow extract and return a hitmask.
The autovaidator
On 7 Jul 2021, at 12:13, Van Haaren, Harry wrote:
> Hi All,
>
> This thread has dissolved into unnecessary time-wasting on nitpick changes.
> There is no
> technical issue with uint32_t, so this patch remains as is, and this should
> be accepted for merge.
>
> If you feel differently, reply
97 matches
Mail list logo
