Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging mechanism

2022-06-15 Thread Daniel Alvarez Sanchez
On Wed, Jun 15, 2022 at 1:54 PM Ales Musil wrote: > Hi Daniel, > > thank you for the suggestions, please see my replies inline. > > On Wed, Jun 15, 2022 at 1:00 PM Daniel Alvarez Sanchez < > dalva...@redhat.com> wrote: > >> Hey Ales, first of all thanks a lot for this series!! Great job and good

Re: [ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.3.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn v2] controller: avoid recomputes triggered by SBDB Port_Binding updates.

2022-06-15 Thread Xavier Simonart
When VIF ports are claimed on a chassis, SBDB Port_Binding table is updated. If the SBDB IDL is still is read-only ("in transaction") when such a update is required, the update is not possible and recompute is triggered through I+P failure. This situation can happen: - after updating

Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging mechanism

2022-06-15 Thread Daniel Alvarez Sanchez
Hey Ales, first of all thanks a lot for this series!! Great job and good approach. I however have some concerns but maybe they're not much of a deal, please let me know what you think: - Broadcast gARPs will cause all ovn-controller instances in the cluster to attempt to write into the SB

[ovs-dev] [PATCH ovn] ovn-controller: fixed ovn-installed not always properly added.

2022-06-15 Thread Xavier Simonart
OVN checks whether ovn-installed is already present (in OVS) before updating it. This might cause ovn-installed related issues in the following case: - (1) ovn-installed is present - (2) we claim the interface - (3) we update ovs, removing ovn-installed and start installing flows - (4) (next

Re: [ovs-dev] [ovs-build] |fail| pw1643589 [ovs-dev, branch-2.13, 1/2] Set release date for 2.13.8.

2022-06-15 Thread Ilya Maximets
On 6/15/22 13:07, ovs_jenk...@intel.com wrote: > Test-Label: intel-ovs-compilation > Test-Status: fail > http://patchwork.ozlabs.org/api/patches/1643589/ > > ./system-dpdk.at:56: ovsdb-tool create conf.db > $abs_top_srcdir/vswitchd/vswitch.ovsschema > --- /dev/null 2022-06-07

Re: [ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.2.

2022-06-15 Thread Ilya Maximets
On 6/15/22 14:07, Aaron Conole wrote: > Ilya Maximets writes: > >> Signed-off-by: Ilya Maximets >> --- > > Acked-by: Aaron Conole > Thanks for reviews! I applied all the patches to all branches and tagged releases. Will update the website and send the announce email soon. Best regards,

[ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.8.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 5728a9c65..05823b5a5 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.13.8 - xx xxx +v2.13.8 - 15 Jun 2022

[ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.8.

2022-06-15 Thread Ilya Maximets
It's been more than 2 months since the last series of stable releases and we have a few important bug fixes accepted including fixes for the classifier and connection tracking. Ilya Maximets (2): Set release date for 2.13.8. Prepare for 2.13.9. NEWS | 6 +- configure.ac

[ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.9.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 05823b5a5..a3b745fc7 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.13.9 - xx xxx

[ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.6.

2022-06-15 Thread Ilya Maximets
It's been more than 2 months since the last series of stable releases and we have a few important bug fixes accepted including fixes for the classifier and connection tracking. Ilya Maximets (2): Set release date for 2.14.6. Prepare for 2.14.7. NEWS | 6 +- configure.ac

Re: [ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.5.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.2.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.4.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.6.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.5.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] northd: add condition for stateless nat drop flow in S_ROUTER_IN_GW_REDIRECT pipeline

2022-06-15 Thread Mark Michelson
Hi Lorenzo, I have a few comments below On 6/10/22 13:49, Lorenzo Bianconi wrote: Match the drop flow for stateless dnat_and_snat flow in S_ROUTER_IN_GW_REDIRECT stage just if allowed_ext_ips or exempted_ext_ips conditions do not match since it breaks the hairping scenario with stateless nat.

[ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.6.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 0f854baab..36e1f03ae 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.14.6 - xx xxx +v2.14.6 - 15 Jun 2022

[ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.7.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 36e1f03ae..14d9aa36c 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.14.7 - xx xxx

[ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.5.

2022-06-15 Thread Ilya Maximets
It's been more than 2 months since the last series of stable releases and we have a few important bug fixes accepted including fixes for the classifier and connection tracking. Ilya Maximets (2): Set release date for 2.15.5. Prepare for 2.15.6. NEWS | 6 +- configure.ac

[ovs-dev] [PATCH branch-2.15 2/2] Prepare for 2.15.6.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d27f9a744..f58c2c9e4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.15.6 - xx xxx

[ovs-dev] [PATCH branch-2.15 1/2] Set release date for 2.15.5.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 0fd58efce..d27f9a744 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.15.5 - xx xxx +v2.15.5 - 15 Jun 2022

Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging mechanism

2022-06-15 Thread Dumitru Ceara
Hi, Ales, Daniel, On 6/15/22 14:36, Daniel Alvarez Sanchez wrote: > On Wed, Jun 15, 2022 at 1:54 PM Ales Musil wrote: > >> Hi Daniel, >> >> thank you for the suggestions, please see my replies inline. >> >> On Wed, Jun 15, 2022 at 1:00 PM Daniel Alvarez Sanchez < >> dalva...@redhat.com> wrote:

[ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.4.

2022-06-15 Thread Ilya Maximets
It's been more than 2 months since the last series of stable releases and we have a few important bug fixes accepted including fixes for the classifier and connection tracking. Ilya Maximets (2): Set release date for 2.16.4. Prepare for 2.16.5. NEWS | 6 +- configure.ac

[ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.2.

2022-06-15 Thread Ilya Maximets
It's been more than 2 months since the last series of stable releases and we have a few important bug fixes accepted including fixes for the classifier and connection tracking. Additionally, this release was validated with the new DPDK 21.11.1. Ilya Maximets (2): Set release date for 2.17.2.

[ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.3.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 29d49c552..9adc5bc9c 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.17.3 - xx xxx

[ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.2.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index f3e801b02..29d49c552 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.17.2 - xx xxx +v2.17.2 - 15 Jun 2022

[ovs-dev] [PATCH branch-2.16 1/2] Set release date for 2.16.4.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2a159310a..d2f9c7823 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.16.4 - xx xxx +v2.16.4 - 15 Jun 2022

[ovs-dev] [PATCH branch-2.16 2/2] Prepare for 2.16.5.

2022-06-15 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d2f9c7823..c6b9c2ca8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.16.5 - xx xxx

Re: [ovs-dev] [PATCH branch-2.14 1/2] Set release date for 2.14.6.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.13 2/2] Prepare for 2.13.9.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.13 1/2] Set release date for 2.13.8.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.14 2/2] Prepare for 2.14.7.

2022-06-15 Thread Aaron Conole
Ilya Maximets writes: > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn 0/5] Add MAC binding aging mechanism

2022-06-15 Thread Ales Musil
Hi Daniel, thank you for the suggestions, please see my replies inline. On Wed, Jun 15, 2022 at 1:00 PM Daniel Alvarez Sanchez wrote: > Hey Ales, first of all thanks a lot for this series!! Great job and good > approach. > > I however have some concerns but maybe they're not much of a deal,

Re: [ovs-dev] [PATCH] odp-util: Ignore unknown attributes in parse_key_and_mask_to_match()

2022-06-15 Thread Michael Santana
On Tue, May 31, 2022 at 10:35 AM Eelco Chaudron wrote: > > When processing netlink messages, we should ignore unknown OVS_KEY_ATTR > as we can assume if newer attributes are present, they are backward > compatible. > > This patch also updates the existing comments to better explain what > happens

[ovs-dev] [PATCH v3] ovsdb idl: Add the support to specify the uuid for row insert.

2022-06-15 Thread numans
From: Numan Siddique ovsdb-server already supports specifying the uuid in the insert transaction by the client. But the C IDL client library was missing this feature. This patch adds this support. For each schema table, a new function is generated - insert_persistent_uuid(txn, uuid) and the

Re: [ovs-dev] [PATCH v3] ovsdb idl: Add the support to specify the uuid for row insert.

2022-06-15 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 118 characters long (recommended limit is 79) #98 FILE:

Re: [ovs-dev] [PATCH ovn 5/5] ovn.at: Add test case covering the MAC binding aging

2022-06-15 Thread Mark Michelson
Hi Ales, I think this test needs to ensure that MAC bindings are not aged out when there is active traffic on the owning chassis. As an example, you could create a MAC_Binding on a chassis that is supposed to age out after a certain amount of time. You can ensure that sending pings to the

Re: [ovs-dev] [PATCH ovn 2/5] Add MAC binding aging mechanism

2022-06-15 Thread Mark Michelson
Hi Ales, I have a few comments in-line below. On 6/14/22 09:49, Ales Musil wrote: Add MAC binding aging mechanism that utilizes the ownership of MAC binding row. The controller that "owns" the MAC binding will track idle_age statistics for related OpenFlows (table 66 and 67). If the idle_age

Re: [ovs-dev] [PATCH ovn 3/5] Add stopwatch for MAC binding aging

2022-06-15 Thread Mark Michelson
On 6/14/22 09:49, Ales Musil wrote: Add stopwatch fro MAC bidning aging so we can observe how long are the aging check taking. Reported-at: https://bugzilla.redhat.com/2084668 Signed-off-by: Ales Musil --- controller/ovn-controller.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [ovs-dev] [PATCH ovn 4/5] Allow the MAC binding age threshold to be configurable

2022-06-15 Thread Mark Michelson
On 6/14/22 09:49, Ales Musil wrote: To allow fine tuning the right value for MAC binding aging add configuration into NB global table called "mac_binding_age_threshold" which accept threshold in seconds. Default value being 60 if not specified. Would there be any value to allowing users to

Re: [ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-15 Thread Ihar Hrachyshka
For this version, the IP engine still doesn't trigger _run functions nor iterative handlers when ovsdb commit fails and no ovsdb transaction is available, so activation flows are not flushed when ovsdb-server is down. Sent this as a reference for further discussions of the engine behavior. On

[ovs-dev] [PATCH ovn v18] Implement RARP activation strategy for ports

2022-06-15 Thread Ihar Hrachyshka
When options:activation-strategy is set to "rarp" for LSP, when used in combination with multiple chassis names listed in options:requested-chassis, additional chassis will install special flows that would block all ingress and egress traffic for the port until a special activation event happens.

Re: [ovs-dev] [PATCH ovn v15] Implement RARP activation strategy for ports

2022-06-15 Thread Ihar Hrachyshka
On Wed, Jun 15, 2022 at 12:18 AM Han Zhou wrote: > > > > On Tue, Jun 14, 2022 at 6:19 PM Ihar Hrachyshka wrote: >> >> On Tue, Jun 14, 2022 at 4:19 PM Numan Siddique wrote: >> > > > > > > If I understand correctly, the major benefit of this feature is >> > > > > > > to >> > > > > activate the

Re: [ovs-dev] [ovn patch v2 ]OVN-CI: remove ddlog test cases.

2022-06-15 Thread Dumitru Ceara
On 6/9/22 14:27, Mohammad Heib wrote: > currently there is no new changes applied to the ddlog code base > in ovn and we keep skipping ddlog test cases in our ci runs which leads > to so many skips lines printed to the ci logs and that cause us to miss > some tests cases that were skipped because

Re: [ovs-dev] [PATCH v7 00/11] Actions Infrastructure + Optimizations

2022-06-15 Thread Eelco Chaudron
Hi Emma, I noticed this v7 while the discussion on the v6 has not yet finished. Maybe next time, it will be good to not send a new revision until the discussion on the previous revision has finished. This will potentially save another review round, as reviewing these large patchsets take a lot