Re: [ovs-dev] [PATCH ovn] ovn-controller: Reduce size of the SB monitor condition.

2023-06-20 Thread Han Zhou
On Tue, Jun 20, 2023 at 12:48 AM Dumitru Ceara wrote: > > On 6/20/23 03:49, Han Zhou wrote: > > On Tue, Jun 6, 2023 at 7:57 AM Dumitru Ceara wrote: > >> > >> We don't need to explicitly add port bindings that were already bound > >> locally. We implicitly get those because we monitor the

Re: [ovs-dev] [PATCH ovn 0/2] Update stale TODO items.

2023-06-20 Thread Han Zhou
On Tue, Jun 20, 2023 at 2:19 AM Dumitru Ceara wrote: > > Patch 1/2 removes the ones that are not applicable anymore. > Patch 2/2 addresses a TODO related to SB.Port_Group.name backwards compatibility. > > Dumitru Ceara (2): > TODO.rst: Remove no longer applicable items. > expr.c:

[ovs-dev] [PATCH v4] rhel: make the version, displayed to the user, customizable

2023-06-20 Thread Timothy Redaelli
Since on CentOS/RHEL the builds are based on stable branches and not on tags for debugging purpose it's better to have the downstream version as version so it's easier to know which commits are included in a build. This commit adds --with-version-suffix as ./configure option in order to set an

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-20 Thread Ilya Maximets
On 6/14/23 21:03, Mike Pattrick wrote: > The netdev receiving packets is supposed to provide the flags > indicating if the L4 checksum was verified and it is OK or BAD, > otherwise the stack will check when appropriate by software. > > If the packet comes with good checksum, then postpone the >

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-20 Thread Ilya Maximets
On 6/21/23 00:14, Ilya Maximets wrote: > On 6/14/23 21:03, Mike Pattrick wrote: >> The netdev receiving packets is supposed to provide the flags >> indicating if the L4 checksum was verified and it is OK or BAD, >> otherwise the stack will check when appropriate by software. >> >> If the packet

Re: [ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-06-20 Thread 0-day Robot
Bleep bloop. Greetings wangchuanlei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 101 characters long (recommended limit is 79) #50 FILE: northd/northd.c:345:

Re: [ovs-dev] [PATCH ovn] ovn-controller: Reduce size of the SB monitor condition.

2023-06-20 Thread Dumitru Ceara
On 6/20/23 03:49, Han Zhou wrote: > On Tue, Jun 6, 2023 at 7:57 AM Dumitru Ceara wrote: >> >> We don't need to explicitly add port bindings that were already bound >> locally. We implicitly get those because we monitor the datapaths >> they're attached to. >> >> When performing an ovn-heater

Re: [ovs-dev] [PATCH v2 2/2] debian: Run system testsuites as autopkgtest.

2023-06-20 Thread Frode Nordahl
On Tue, Jun 20, 2023 at 10:08 AM Frode Nordahl wrote: > > The autopkgtests [0][1] are relevant in an upstream context > because an Open vSwitch contributor may want to have a quick > way of running the upstream system testsuites on recent > Debian/Ubuntu releases in an automated and contained

[ovs-dev] [PATCH v2 1/2] debian: Conditionally build package with AF_XDP.

2023-06-20 Thread Frode Nordahl
Allow building the upstream Open vSwitch deb package with AF_XDP datapath enabled by passing in the string 'afxdp' in the DEB_BUILD_OPTIONS environment variable. Signed-off-by: Frode Nordahl --- debian/automake.mk | 30 ++ debian/control.in | 2 ++ debian/rules

[ovs-dev] [PATCH v2 2/2] debian: Run system testsuites as autopkgtest.

2023-06-20 Thread Frode Nordahl
The autopkgtests [0][1] are relevant in an upstream context because an Open vSwitch contributor may want to have a quick way of running the upstream system testsuites on recent Debian/Ubuntu releases in an automated and contained manner. During the Debian/Ubuntu/upstream package source sync work

[ovs-dev] [PATCH ovn] northd: Lookup route policy before ip routing

2023-06-20 Thread wangchuanlei
If there is no route in table ip_routing, the route policy item in table policy is useless. Because route policy has a higher priority than ip routing, so modify the table id of IP_ROUTING and POLICY is a little better.By this way, there is no need reroute any more, this should be more

[ovs-dev] [PATCH RESEND v4] netdev-dpdk: Drop TSO in case of conflicting virtio features.

2023-06-20 Thread David Marchand
At some point in OVS history, some virtio features were announced as supported (ECN and UFO virtio features). The userspace TSO code, which has been added later, does not support those features and tries to disable them. This breaks OVS upgrades: if an existing VM already negotiated such

Re: [ovs-dev] [PATCH] dpif: Add coverage counters for dpif_operate() failures.

2023-06-20 Thread Adrian Moreno
On 6/19/23 14:57, Eelco Chaudron wrote: Add additional error coverage counters for dpif operation failures. This could help to quickly identify netlink problems when communicating with the OVS kernel module. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2070630 Signed-off-by: Eelco

Re: [ovs-dev] Request adding long poll interval metrics to coverage metrics

2023-06-20 Thread Adrian Moreno
On 6/19/23 10:36, Eelco Chaudron wrote: On 16 Jun 2023, at 19:19, Aaron Conole wrote: Martin Kennelly writes: Hey ovs community, I am a developer working on ovn-kubernetes and I want to programmatically consume long poll information i.e: ovs|00211|timeval(handler25)|WARN|Unreasonably

[ovs-dev] [PATCH ovn 2/2] expr.c: Remove backwards compatibility lookup in parse_port_group().

2023-06-20 Thread Dumitru Ceara
It's been more than 2.5 years since the first release in which northd started storing SB.Port_Group.name as after bff01d49d6f2 ("Split SB Port_Group per datapath."). There's a safe upgrade path via the LTS release for deployments that still run older ovn-controller versions. Signed-off-by:

[ovs-dev] [PATCH ovn 1/2] TODO.rst: Remove no longer applicable items.

2023-06-20 Thread Dumitru Ceara
Incremental processing is supported in both ovn-controller and ovn-northd (partially). Live migration is supported through the multi-value LSP.options:requested-chassis configuration. MAC learning is supported for all ports with addresses set to "unknown". CoPP is supported for ARP request

[ovs-dev] [PATCH ovn 0/2] Update stale TODO items.

2023-06-20 Thread Dumitru Ceara
Patch 1/2 removes the ones that are not applicable anymore. Patch 2/2 addresses a TODO related to SB.Port_Group.name backwards compatibility. Dumitru Ceara (2): TODO.rst: Remove no longer applicable items. expr.c: Remove backwards compatibility lookup in parse_port_group().

Re: [ovs-dev] [PATCH 2/6] pmd.at: Add macro for checking pmd sleep max time and state.

2023-06-20 Thread Kevin Traynor
On 14/06/2023 16:08, David Marchand wrote: On Wed, Jun 14, 2023 at 3:37 PM Kevin Traynor wrote: This is just cosmetic. There is no change to the tests. Hum, except one issue in CHECK_DP_SLEEP_MAX, I would tend to agree :-). Signed-off-by: Kevin Traynor --- tests/pmd.at | 39

Re: [ovs-dev] [PATCH 3/6] dpif-netdev: Add pmd-sleep-show command.

2023-06-20 Thread Kevin Traynor
On 14/06/2023 16:49, David Marchand wrote: On Wed, Jun 14, 2023 at 3:37 PM Kevin Traynor wrote: Max requested sleep time and status for a PMD thread is logged at start up or when changed, but it can be convenient to have a command to dump this information explicitly. It is envisaged that

[ovs-dev] [PATCH] tests: Add macro to common file.

2023-06-20 Thread Kevin Traynor
get_log_next_line_num() was defined in alb.at. As it may be useful in other test files, move to ofproto-macros.at. Suggested-by: David Marchand Signed-off-by: Kevin Traynor --- tests/alb.at| 4 tests/ofproto-macros.at | 7 +++ 2 files changed, 7 insertions(+), 4

Re: [ovs-dev] [PATCH v2 1/2] debian: Conditionally build package with AF_XDP.

2023-06-20 Thread Ilya Maximets
On 6/20/23 10:08, Frode Nordahl wrote: > Allow building the upstream Open vSwitch deb package with AF_XDP > datapath enabled by passing in the string 'afxdp' in the > DEB_BUILD_OPTIONS environment variable. Hi, Frode. Thanks for the patch! Can we also update the debian-deb make target to pass

Re: [ovs-dev] [PATCH ovn 2/2] binding: fixed qos when no iface

2023-06-20 Thread Xavier Simonart
On Wed, Jun 7, 2023 at 8:16 PM Lorenzo Bianconi wrote: > > If iface does not exist when qos I+P is run the first time > > a qos queue is still created and qos I+P will never apply qos to OVS > > qos might still be applied later, if/when (for any reason) runtime_date > must be recomputed > > > >

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Figure out dependencies dynamically.

2023-06-20 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 87 characters long (recommended limit is 79) #116 FILE:

Re: [ovs-dev] [PATCH v2 1/2] debian: Conditionally build package with AF_XDP.

2023-06-20 Thread Ilya Maximets
On 6/20/23 16:13, Frode Nordahl wrote: > On Tue, Jun 20, 2023 at 3:44 PM Ilya Maximets wrote: >> >> On 6/20/23 10:08, Frode Nordahl wrote: >>> Allow building the upstream Open vSwitch deb package with AF_XDP >>> datapath enabled by passing in the string 'afxdp' in the >>> DEB_BUILD_OPTIONS

Re: [ovs-dev] [PATCH v2 2/2] debian: Run system testsuites as autopkgtest.

2023-06-20 Thread Ilya Maximets
On 6/20/23 10:08, Frode Nordahl wrote: > The autopkgtests [0][1] are relevant in an upstream context > because an Open vSwitch contributor may want to have a quick > way of running the upstream system testsuites on recent > Debian/Ubuntu releases in an automated and contained manner. > > During

Re: [ovs-dev] [PATCH v2 2/2] debian: Run system testsuites as autopkgtest.

2023-06-20 Thread Ilya Maximets
On 6/20/23 10:13, Frode Nordahl wrote: > On Tue, Jun 20, 2023 at 10:08 AM Frode Nordahl > wrote: >> >> The autopkgtests [0][1] are relevant in an upstream context >> because an Open vSwitch contributor may want to have a quick >> way of running the upstream system testsuites on recent >>

[ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Figure out dependencies dynamically.

2023-06-20 Thread Dumitru Ceara
This avoids manual intervention when upstream ovn-kubernetes changes its dependency versions. Signed-off-by: Patryk Diak Co-authored-by: Patryk Diak Signed-off-by: Dumitru Ceara --- .ci/ovn-kubernetes/Dockerfile| 16 +++--- .ci/ovn-kubernetes/prepare.sh| 11 ++

Re: [ovs-dev] [PATCH v2 1/2] debian: Conditionally build package with AF_XDP.

2023-06-20 Thread Frode Nordahl
On Tue, Jun 20, 2023 at 3:44 PM Ilya Maximets wrote: > > On 6/20/23 10:08, Frode Nordahl wrote: > > Allow building the upstream Open vSwitch deb package with AF_XDP > > datapath enabled by passing in the string 'afxdp' in the > > DEB_BUILD_OPTIONS environment variable. > > Hi, Frode. Thanks for

Re: [ovs-dev] Request adding long poll interval metrics to coverage metrics

2023-06-20 Thread Aaron Conole
Adrian Moreno writes: > On 6/19/23 10:36, Eelco Chaudron wrote: >> On 16 Jun 2023, at 19:19, Aaron Conole wrote: >> >>> Martin Kennelly writes: >>> Hey ovs community, I am a developer working on ovn-kubernetes and I want to programmatically consume long poll information

Re: [ovs-dev] Request adding long poll interval metrics to coverage metrics

2023-06-20 Thread Ilya Maximets
On 6/20/23 16:10, Aaron Conole wrote: > Adrian Moreno writes: > >> On 6/19/23 10:36, Eelco Chaudron wrote: >>> On 16 Jun 2023, at 19:19, Aaron Conole wrote: >>> Martin Kennelly writes: > Hey ovs community, > > I am a developer working on ovn-kubernetes and I want to >

[ovs-dev] [PATCH ovn v2 2/2] binding: fixed qos when no iface

2023-06-20 Thread Xavier Simonart
Before this patch, if iface did not exist when qos I+P was run the first time a qos queue was still created and qos I+P was not applying qos to OVS. qos was potentially applied later, if/when (for any reason) runtime_data had to be recomputed. Fixes: 7d1d111ff213 ("controller: configure qos

[ovs-dev] [PATCH ovn v2 1/2] qos: fix potential double deletion of ovs idl row

2023-06-20 Thread Xavier Simonart
If an interface with an qos option is deleted at the same time as an ofport notification from ovs (causing runtime_data recompute) is received, the binding module was trying to delete twice the same qos queue, causing ovs to raise an exception. Reported-at:

Re: [ovs-dev] [PATCH] dpif: Add coverage counters for dpif_operate() failures.

2023-06-20 Thread Aaron Conole
Eelco Chaudron writes: > Add additional error coverage counters for dpif operation failures. > This could help to quickly identify netlink problems when communicating > with the OVS kernel module. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2070630 > Signed-off-by: Eelco

Re: [ovs-dev] [PATCH] dpif: Add coverage counters for dpif_operate() failures.

2023-06-20 Thread Eelco Chaudron
On 20 Jun 2023, at 16:17, Aaron Conole wrote: > Eelco Chaudron writes: > >> Add additional error coverage counters for dpif operation failures. >> This could help to quickly identify netlink problems when communicating >> with the OVS kernel module. >> >> Reported-at:

Re: [ovs-dev] [PATCH v4] Add editorconfig file.

2023-06-20 Thread Ilya Maximets
On 6/19/23 17:37, Robin Jarry wrote: > EditorConfig is a file format and collection of text editor plugins for > maintaining consistent coding styles between different editors and IDEs. > > Initialize the file following the coding rules in > Documentation/internals/contributing/coding-style.rst