After the commit 0c1bde1c4a the recompute counters are more predictable,
so we changed the LSP incremental processing test to not tolerate any
failures (instead of 50% successful rate). But the test would then fail
occasionally at the first check, because sometimes the update of the
initial
On Fri, Jul 7, 2023 at 6:40 AM Han Zhou wrote:
>
> On Thu, Jul 6, 2023 at 9:55 PM Numan Siddique wrote:
> >
> > On Thu, Jul 6, 2023 at 3:32 PM Han Zhou wrote:
> > >
> > > Although each individual VIF port related changes are handled
> > > incrementally, it still triggers recompute if there are
On Fri, Jul 7, 2023 at 2:02 PM Numan Siddique wrote:
>
> On Fri, Jul 7, 2023 at 6:40 AM Han Zhou wrote:
> >
> > On Thu, Jul 6, 2023 at 9:55 PM Numan Siddique wrote:
> > >
> > > On Thu, Jul 6, 2023 at 3:32 PM Han Zhou wrote:
> > > >
> > > > Although each individual VIF port related changes are
On Tue, Jun 20, 2023 at 4:26 PM Xavier Simonart wrote:
> If an interface with an qos option is deleted at the same
> time as an ofport notification from ovs (causing runtime_data recompute)
> is received, the binding module was trying to delete twice the same qos
> queue, causing ovs to raise an
On 7/5/23 16:22, Eelco Chaudron wrote:
>>> +dnl Hold the prefix 10.1.2.2/24 by another 10s.
>>> +AT_CHECK([ovs-appctl netdev-dummy/receive p1
>>> 'ipv4(src=10.0.0.1,dst=10.1.2.2),tcp(src=1,dst=2)'])
>>> +dnl Send more 10.1.0.2 to make 10.1.0.0/16 tuple preprend 10.1.2.0/24
>>> tuple in pvector
On 7/6/23 21:42, David Marchand wrote:
> At some point in OVS history, some virtio features were announced as
> supported (ECN and UFO virtio features).
>
> The userspace TSO code, which has been added later, does not support
> those features and tries to disable them.
>
> This breaks OVS
On 7 Jul 2023, at 12:58, Ilya Maximets wrote:
> On 7/5/23 15:54, Eelco Chaudron wrote:
>>
>>
>> On 4 Jul 2023, at 15:11, Ilya Maximets wrote:
>>
>>> Before the cleanup option, the bridge_exit() call was fairly fast,
>>> because it didn't include any particularly long operations. However,
>>>
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> other_config:pmd-maxsleep is a config option to allow
> PMD thread cores to sleep under low or no load conditions.
>
> Rename it to 'pmd-sleep-max' to allow a more structured
> name and so that additional options or command can follow
>
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> This is just cosmetic. There is no change to the tests.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> Max requested sleep time and status for a PMD thread
> is logged at start up or when changed, but it can be
> convenient to have a command to dump this information
> explicitly.
>
> It is envisaged that this will be expanded when future
>
On 7/5/23 21:47, Eelco Chaudron wrote:
>
>
> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
>
> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote:
> >
> >
> > On 30 Jun 2023, at 21:05, Eric Garver wrote:
> > Hi Eric,
> >
> > I started reviewing the
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> Extend 'pmd-sleep-max' so that individual PMD thread cores
> may have a specified max sleep request value.
>
> Any PMD thread core without a value will use the datapath default
> (no sleep request) or datapath global value set by the user.
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jun 21, 2023 at 11:26 AM Kevin Traynor wrote:
>
> Add unit tests for new per pmd options of pmd-sleep-max.
>
> Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
--
David Marchand
___
dev mailing list
d...@openvswitch.org
On Wed, Jul 5, 2023 at 5:57 PM Xavier Simonart wrote:
> Usually, when cleaning up a system test we execute (for the ovn-vswitchd
> process):
> - OVS_TRAFFIC_VSWITCHD_STOP (i.e. ovs-appctl -t $1 exit --cleanup, wait up
> to 30 seconds
> and report failure if not properly cleaned up).
> -
On 7/6/23 15:57, Eric Garver wrote:
> On Thu, Jul 06, 2023 at 08:54:16AM -0400, Aaron Conole wrote:
>> Eric Garver writes:
>>
>>> This adds an explicit drop action. This is used by OVS to drop packets
>>> for which it cannot determine what to do. An explicit action in the
>>> kernel allows
On 7/6/23 11:30, Eelco Chaudron wrote:
>
>
> On 30 Jun 2023, at 21:05, Eric Garver wrote:
>
> Hi Eric,
>
> I guess some description here would be good. Maybe add some info that this is
> added due to kernel support being added.
>
>
> In general, the patch looks good, and I would ack it.
On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
> On 7/5/23 21:47, Eelco Chaudron wrote:
>>
>>
>> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
>>
>> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco Chaudron wrote:
>> >
>> >
>> > On 30 Jun 2023, at 21:05, Eric Garver wrote:
>>
On 7/7/23 14:12, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 12:58, Ilya Maximets wrote:
>
>> On 7/5/23 15:54, Eelco Chaudron wrote:
>>>
>>>
>>> On 4 Jul 2023, at 15:11, Ilya Maximets wrote:
>>>
Before the cleanup option, the bridge_exit() call was fairly fast,
because it didn't
On 6/28/23 18:27, Aaron Conole wrote:
Building on the previous work, add a very simplistic NAT case
using ipv4. This just tests dnat transformation
Signed-off-by: Aaron Conole
Hi Aaron,
I know that the goal is not to support the full syntax, and that nat is a
specially convoluted
On 7 Jul 2023, at 14:25, Ilya Maximets wrote:
> On 7/7/23 14:11, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 13:03, Ilya Maximets wrote:
>>
>>> On 7/6/23 11:30, Eelco Chaudron wrote:
On 30 Jun 2023, at 21:05, Eric Garver wrote:
Hi Eric,
I guess some
On 7 Jul 2023, at 14:19, Ilya Maximets wrote:
> On 7/7/23 14:12, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 12:58, Ilya Maximets wrote:
>>
>>> On 7/5/23 15:54, Eelco Chaudron wrote:
On 4 Jul 2023, at 15:11, Ilya Maximets wrote:
> Before the cleanup option, the
On 7 Jul 2023, at 13:03, Ilya Maximets wrote:
> On 7/6/23 11:30, Eelco Chaudron wrote:
>>
>>
>> On 30 Jun 2023, at 21:05, Eric Garver wrote:
>>
>> Hi Eric,
>>
>> I guess some description here would be good. Maybe add some info that this
>> is added due to kernel support being added.
>>
>>
>>
On Tue, Jun 27, 2023 at 11:37 AM Xavier Simonart
wrote:
> When sb is read-only, the port claim is delayed until sb is rw.
> However, before this patch, this resulted in the chassis always
> claiming the port as main (while it was maybe an additional chassis).
>
> Fixes: a7c7d4519e50
On 7/7/23 14:11, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 13:03, Ilya Maximets wrote:
>
>> On 7/6/23 11:30, Eelco Chaudron wrote:
>>>
>>>
>>> On 30 Jun 2023, at 21:05, Eric Garver wrote:
>>>
>>> Hi Eric,
>>>
>>> I guess some description here would be good. Maybe add some info that this
On Fri, Jul 7, 2023 at 8:30 AM Han Zhou wrote:
> After the commit 0c1bde1c4a the recompute counters are more predictable,
> so we changed the LSP incremental processing test to not tolerate any
> failures (instead of 50% successful rate). But the test would then fail
> occasionally at the first
On 6/28/23 18:27, Aaron Conole wrote:
Forwarding via ct() action is an important use case for openvswitch, but
generally would require using a full ovs-vswitchd to get working. Add a
ct action parser for basic ct test case.
Signed-off-by: Aaron Conole
---
NOTE: 3 lines flag the line-length
On 7/5/23 15:54, Eelco Chaudron wrote:
>
>
> On 4 Jul 2023, at 15:11, Ilya Maximets wrote:
>
>> Before the cleanup option, the bridge_exit() call was fairly fast,
>> because it didn't include any particularly long operations. However,
>> with the cleanup flag, this function destroys a lot of
On Fri, Jul 7, 2023 at 1:50 PM Ilya Maximets wrote:
> > @@ -4268,7 +4295,9 @@ new_device(int vid)
> > dev->hw_ol_features |= NETDEV_TX_SCTP_CKSUM_OFFLOAD;
> > }
> >
> > -if (userspace_tso_enabled()) {
> > +if
On Wed, Jul 5, 2023 at 7:08 PM Dumitru Ceara wrote:
> If we want to catch new failures faster we have a better chance if CI
> doesn't auto-retry (once).
>
> There are some tests that are still "unstable" and fail every now and
> then. In order to reduce the number of false negatives keep the
>
On 7/7/23 14:22, David Marchand wrote:
> On Fri, Jul 7, 2023 at 1:50 PM Ilya Maximets wrote:
>>> @@ -4268,7 +4295,9 @@ new_device(int vid)
>>> dev->hw_ol_features |= NETDEV_TX_SCTP_CKSUM_OFFLOAD;
>>> }
>>>
>>> -if (userspace_tso_enabled()) {
At some point in OVS history, some virtio features were announced as
supported (ECN and UFO virtio features).
The userspace TSO code, which has been added later, does not support
those features and tries to disable them.
This breaks OVS upgrades: if an existing VM already negotiated such
On 7/7/23 15:51, Eric Garver wrote:
> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
>>
>>> On 7/5/23 21:47, Eelco Chaudron wrote:
On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
On Wed, Jul 05,
On 7 Jul 2023, at 16:48, Ilya Maximets wrote:
> On 7/7/23 16:42, Eelco Chaudron wrote:
>>
>>
>> On 7 Jul 2023, at 16:06, Ilya Maximets wrote:
>>
>>> On 7/7/23 15:51, Eric Garver wrote:
On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at
On 7/7/23 16:50, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 16:48, Ilya Maximets wrote:
>
>> On 7/7/23 16:42, Eelco Chaudron wrote:
>>>
>>>
>>> On 7 Jul 2023, at 16:06, Ilya Maximets wrote:
>>>
On 7/7/23 15:51, Eric Garver wrote:
> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco
On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
>
> > On 7/5/23 21:47, Eelco Chaudron wrote:
> >>
> >>
> >> On Wed, Jul 5, 2023 at 6:46 PM Eric Garver wrote:
> >>
> >> On Wed, Jul 05, 2023 at 04:58:47PM +0200, Eelco
On 7/7/23 16:42, Eelco Chaudron wrote:
>
>
> On 7 Jul 2023, at 16:06, Ilya Maximets wrote:
>
>> On 7/7/23 15:51, Eric Garver wrote:
>>> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
> On 7/5/23 21:47, Eelco
On 7 Jul 2023, at 16:06, Ilya Maximets wrote:
> On 7/7/23 15:51, Eric Garver wrote:
>> On Fri, Jul 07, 2023 at 02:09:49PM +0200, Eelco Chaudron wrote:
>>>
>>>
>>> On 7 Jul 2023, at 13:08, Ilya Maximets wrote:
>>>
On 7/5/23 21:47, Eelco Chaudron wrote:
>
>
> On Wed, Jul 5, 2023
On 7/7/23 15:59, David Marchand wrote:
At some point in OVS history, some virtio features were announced as
supported (ECN and UFO virtio features).
The userspace TSO code, which has been added later, does not support
those features and tries to disable them.
This breaks OVS upgrades: if an
On 6/28/23 18:27, Aaron Conole wrote:
The openvswitch self-tests can test much of the control side of
the module (ie: what a vswitchd implementation would process),
but the actual packet forwarding cases aren't supported, making
the testing of limited value.
Add some flow parsing and an
On 7/6/23 10:27, wangze wrote:
> When doing set_queue action, skb_priority is marked in
> userspace, but there is no further processing in datapath
> dpdk.
Hi. There actually is further processing for dpdk ports.
The naming is confusing, I understand that, but set_queue OpenFlow
action actually
On Fri, 7 Jul 2023 12:30:38 +0200 Ilya Maximets wrote:
> A wild idea: How about we do not define actual reasons? i.e. define a
> subsystem and just call kfree_skb_reason(skb, SUBSYSTEM | value), where
> 'value' is whatever userspace gives as long as it is within a subsystem
> range?
That
On 7/6/23 18:22, Eelco Chaudron wrote:
>
>
> On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
>
>> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>>
>> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
>> netdev's API expressing kbps rates using 32-bit
On 7 Jul 2023, at 17:04, Ilya Maximets wrote:
> On 7/6/23 18:22, Eelco Chaudron wrote:
>>
>>
>> On 2 Jun 2023, at 16:13, Adrian Moreno wrote:
>>
>>> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>>>
>>> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
On 7/7/23 17:00, Jakub Kicinski wrote:
> On Fri, 7 Jul 2023 12:30:38 +0200 Ilya Maximets wrote:
>> A wild idea: How about we do not define actual reasons? i.e. define a
>> subsystem and just call kfree_skb_reason(skb, SUBSYSTEM | value), where
>> 'value' is whatever userspace gives as long as it
Hello everyone!
We are happy to announce this year's Open vSwitch and OVN conference!
The conference will be on November 1-2, 2023 and will be a fully virtual event.
We are seeking long and short ("lightning") talks on topics related to
Open vSwitch and OVN. We expect long talks to last 25
From: Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote:
> From: Flavio Leitner
>
> The netdev receiving packets is supposed to provide the flags
> indicating if the L4 checksum was verified and it is OK or BAD,
> otherwise the stack will check when appropriate by software.
>
> If the
On 7/7/23 17:18, Maxime Coquelin wrote:
>
>
> On 7/7/23 15:59, David Marchand wrote:
>> At some point in OVS history, some virtio features were announced as
>> supported (ECN and UFO virtio features).
>>
>> The userspace TSO code, which has been added later, does not support
>> those features
Please ignore this email.
fbl
On 7/7/23 16:21, Flavio Leitner wrote:
From: Ilya Maximets
On 11/24/22 06:30, Mike Pattrick wrote:
From: Flavio Leitner
The netdev receiving packets is supposed to provide the flags
indicating if the L4 checksum was verified and it is OK or BAD,
otherwise the
On 7/7/23 17:29, Ilya Maximets wrote:
> On 7/7/23 17:00, Jakub Kicinski wrote:
>> On Fri, 7 Jul 2023 12:30:38 +0200 Ilya Maximets wrote:
>>> A wild idea: How about we do not define actual reasons? i.e. define a
>>> subsystem and just call kfree_skb_reason(skb, SUBSYSTEM | value), where
>>>
Single out flagged words and allow for more useful
details, like spelling suggestions. Fixed syntax
error from v1
Signed-off-by: Chandan Somani
---
utilities/checkpatch.py | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/utilities/checkpatch.py
This will be useful for correcting possible spelling
mistakes with ease. Suggestions limited to 3 at first,
but configurable in the future.
Signed-off-by: Chandan Somani
Acked-by: Aaron Conole
---
utilities/checkpatch.py | 3 +++
1 file changed, 3 insertions(+)
diff --git
This narrows down spelling errors that are in the commit
subject. In v2, it also provides a subject if the subject
line is missing. The provisional subject is the name of the
patch file, which should provide some context about the patch.
Signed-off-by: Chandan Somani
---
utilities/checkpatch.py
Hi Numan,
I have one small nit below.
On 7/7/23 01:53, num...@ovn.org wrote:
From: Numan Siddique
This patch separates out the 'lbs' and 'lb_groups' from the 'northd' engine
node data into a new engine node 'northd_lb_data'. This new node becomes
an input to the 'northd' node.
This makes
Hi Numan,
I have one small nit below.
On 7/7/23 01:53, num...@ovn.org wrote:
From: Numan Siddique
Any changes to load balancers and load balancer groups
are handled incrementally in the newly added 'northd_lb_data'
engine node. 'northd_lb_data' is input to 'northd' node
and the handler -
Hi Numan,
I gave the series a look. I've looked at the code but haven't yet run
any tests with it. The main reason for this is that the series does not
apply cleanly to OVN main.
Overall, I only have small notes. I've replied to patches 2 and 3 with
the specifics.
On 7/7/23 01:51,
Bleep bloop. Greetings Chandan Somani, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has trailing whitespace
#27 FILE: utilities/checkpatch.py:1030:
On Fri, 7 Jul 2023 18:04:36 +0200 Ilya Maximets wrote:
> >> That already exists, right? Johannes added it in the last release for
> >> WiFi.
> >
> > I'm not sure. The SKB_DROP_REASON_SUBSYS_MAC80211_UNUSABLE behaves
> > similarly
> > to that on a surface. However, looking closer, any value
On Fri, Jul 7, 2023 at 8:31 PM Ales Musil wrote:
>
>
>
> On Fri, Jul 7, 2023 at 8:30 AM Han Zhou wrote:
>>
>> After the commit 0c1bde1c4a the recompute counters are more predictable,
>> so we changed the LSP incremental processing test to not tolerate any
>> failures (instead of 50% successful
59 matches
Mail list logo
