[ovs-dev] [PATCH ovn] tests: Fix grep warning

2024-01-29 Thread Ales Musil
The Fedora version of grep (grep (GNU grep) 3.11) complains about the syntax grep "output\:": grep: warning: stray \ before : Remove the \ which works also for Ubuntu grep version (grep (GNU grep) 3.7). Signed-off-by: Ales Musil --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH ovn 3/3] ovn-controller: Support VIF-based local encap IPs selection.

2024-01-29 Thread Han Zhou
On Mon, Jan 29, 2024 at 2:41 AM Ales Musil wrote: > > > > On Fri, Jan 26, 2024 at 8:05 PM Han Zhou wrote: >> >> >> >> On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote: >> > >> > >> > >> > On Fri, Jan 26, 2024 at 4:07 AM Han Zhou wrote: >> >> >> >> >> >> >> >> On Tue, Jan 23, 2024 at 5:29 AM

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to latest OVS branch-3.3.

2024-01-29 Thread Numan Siddique
On Mon, Jan 29, 2024 at 6:43 PM Dumitru Ceara wrote: > > On 1/30/24 00:36, Dumitru Ceara wrote: > > This picks up the following relevant OVS commits: > > 8893e24d9d dpdk: Update to use v23.11. > > ed738eca39 util: Annotate function that will never return NULL. > > 77d0bad04 mcast-snooping:

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-29 Thread Han Zhou
On Mon, Jan 29, 2024 at 7:11 PM Numan Siddique wrote: > On Thu, Jan 25, 2024 at 1:08 AM Han Zhou wrote: > > > > On Thu, Jan 11, 2024 at 7:32 AM wrote: > > > > > > From: Numan Siddique > > > > > > ovn_lflow_add() and other related functions/macros are now moved > > > into a separate module -

Re: [ovs-dev] [PATCH ovn] ovn-ic: fix global blacklist filter for IPv6 addresses

2024-01-29 Thread 0-day Robot
Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject

[ovs-dev] [PATCH ovn] ovn-ic: fix global blacklist filter for IPv6 addresses

2024-01-29 Thread Roberto Bartzen Acosta via dev
This commit fixes the prefix filter function as the return condition for IPv6 addresses is disabling the advertisement of all learned prefixes regardless of the match with the blacklist or not. Reported-at: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/2046804 Fixes: 57b347c55168 ("ovn-ic:

Re: [ovs-dev] [PATCH ovn v5 11/16] northd: Handle lb changes in lflow engine.

2024-01-29 Thread Numan Siddique
On Fri, Jan 19, 2024 at 6:13 AM Dumitru Ceara wrote: > > On 1/11/24 16:32, num...@ovn.org wrote: > > From: Numan Siddique > > > > Since northd tracked data has the changed lb data, northd > > engine handler for lflow engine now handles the lb changes > > incrementally. All the lflows generated

Re: [ovs-dev] [PATCH ovn v5 11/16] northd: Handle lb changes in lflow engine.

2024-01-29 Thread Numan Siddique
On Thu, Jan 25, 2024 at 1:25 AM Han Zhou wrote: > > On Thu, Jan 11, 2024 at 7:33 AM wrote: > > > > From: Numan Siddique > > > > Since northd tracked data has the changed lb data, northd > > engine handler for lflow engine now handles the lb changes > > incrementally. All the lflows generated

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2024-01-29 Thread Numan Siddique
On Fri, Jan 26, 2024 at 4:30 AM Dumitru Ceara wrote: > > On 1/25/24 22:01, Numan Siddique wrote: > > On Thu, Jan 25, 2024, 3:29 PM Dumitru Ceara wrote: > > > >> On 1/25/24 17:46, Numan Siddique wrote: > >>> On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wrote: > > On 1/11/24 16:28,

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-29 Thread Numan Siddique
On Thu, Jan 25, 2024 at 1:08 AM Han Zhou wrote: > > On Thu, Jan 11, 2024 at 7:32 AM wrote: > > > > From: Numan Siddique > > > > ovn_lflow_add() and other related functions/macros are now moved > > into a separate module - lflow-mgr.c. This module maintains a > > table 'struct lflow_table' for

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to latest OVS branch-3.3.

2024-01-29 Thread Dumitru Ceara
On 1/30/24 00:36, Dumitru Ceara wrote: > This picks up the following relevant OVS commits: > 8893e24d9d dpdk: Update to use v23.11. > ed738eca39 util: Annotate function that will never return NULL. > 77d0bad04 mcast-snooping: Store IGMP/MLD protocol version. > b222593bc6 mcast-snooping:

Re: [ovs-dev] [PATCH ovn 1/2] ovs: Bump submodule to include igmp protocol version.

2024-01-29 Thread Dumitru Ceara
On 1/29/24 16:30, Ilya Maximets wrote: > On 1/23/24 14:53, Mohammad Heib wrote: >> Hi Dumitru, >> >> Thank you for the review, >> yes sure will bump the submodule to the last stable once they fix the issue. > > I applied the BFD fix and also applied the typedef fix for the > mcast_group_proto >

[ovs-dev] [PATCH ovn] ovs: Bump submodule to latest OVS branch-3.3.

2024-01-29 Thread Dumitru Ceara
This picks up the following relevant OVS commits: 8893e24d9d dpdk: Update to use v23.11. ed738eca39 util: Annotate function that will never return NULL. 77d0bad04 mcast-snooping: Store IGMP/MLD protocol version. b222593bc6 mcast-snooping: Add group protocol to mdb/show output. a940a691e7

[ovs-dev] [PATCH] github: Bump Fedora version to 39.

2024-01-29 Thread Ilya Maximets
Fedora 37 reached EOL in November. Switch to the most recent version to avoid potential CI failures in the future. Signed-off-by: Ilya Maximets --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml

Re: [ovs-dev] [PATCH v2] github: Update versions of action dependencies (Node.js 20).

2024-01-29 Thread Ilya Maximets
On 1/26/24 17:00, Eelco Chaudron wrote: > > > On 26 Jan 2024, at 15:38, Ilya Maximets wrote: > >> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16 >> which is now deprecated in GHA [1], so these actions will stop working >> soon. >> >> Updating to most recent major

Re: [ovs-dev] [PATCH OVN] Add "disable_arp_nd_rsp" option to LSP

2024-01-29 Thread Ihar Hrachyshka
On Mon, Jan 22, 2024 at 12:22 PM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > This option can be used to enable/disable arp/nd reply flows. > > Usecase: > = > It is useful to reduce packet loss when VM is being migrated to > It may indeed be useful to be able to disable

Re: [ovs-dev] [PATCH ovn 1/2] ovs: Bump submodule to include igmp protocol version.

2024-01-29 Thread Ilya Maximets
On 1/23/24 14:53, Mohammad Heib wrote: > Hi Dumitru, > > Thank you for the review, > yes sure will bump the submodule to the last stable once they fix the issue. I applied the BFD fix and also applied the typedef fix for the mcast_group_proto enum. So, make sure to include both for the update.

Re: [ovs-dev] [PATCH] mcast-snooping: Remove typedef from mcast_group_proto.

2024-01-29 Thread Ilya Maximets
On 1/28/24 11:20, Mohammad Heib wrote: > Thanks, Ilya, > Looks good to me. > > Acked-by: Mohammad Heib mailto:mh...@redhat.com>> > Thanks! I applied the change and backported to branch-3.3. Best regards, Ilya Maximets. > Thanks, > > > > On Fri, Jan 26, 2024 at 7:11 PM Ilya Maximets

Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-29 Thread Xavier Simonart
Hi Dumitru Thanks for the patch. On Tue, Jan 23, 2024 at 10:44 PM Mark Michelson wrote: > Hi Dumitru, > > Acked-by: Mark Michelson > > I think this change is good. I looked through the documentation for the > "external_port_range" column in the NAT table. This change appears to > actually

[ovs-dev] [PATCH v2] utilities: Add TASK_STOPPED accounting to the kernel_delay.py script.

2024-01-29 Thread Eelco Chaudron
This changes add statistics for when a thread is put into stop state. For example with the following: kill -STOP $(pidof ovs-vswitchd); sleep 1; kill -CONT $(pidof ovs-vswitchd); Acked-by: Simon Horman Signed-off-by: Eelco Chaudron --- v2: - Removed worst/max ns delay zero checks.

[ovs-dev] [PATCH ovs v2] Documentation: Adding note about using the jemalloc library.

2024-01-29 Thread Roberto Bartzen Acosta via dev
Updating the reference documentation with the inclusion of possible building problems with libjemalloc and solution suggestions. Reported-at: https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/2015748 Signed-off-by: Roberto Bartzen Acosta --- Documentation/intro/install/general.rst |

Re: [ovs-dev] [PATCH ovn 3/3] ovn-controller: Support VIF-based local encap IPs selection.

2024-01-29 Thread Ales Musil
On Fri, Jan 26, 2024 at 8:05 PM Han Zhou wrote: > > > On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote: > > > > > > > > On Fri, Jan 26, 2024 at 4:07 AM Han Zhou wrote: > >> > >> > >> > >> On Tue, Jan 23, 2024 at 5:29 AM Ales Musil wrote: > >> > > >> > > >> > > >> > On Wed, Jan 17, 2024 at

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Explicitly handle SNAT for ICMP need frag.

2024-01-29 Thread Dumitru Ceara
On 1/29/24 07:20, Ales Musil wrote: > Considering following topology: > client - sw0 - lrp0 - lr - lrp1 - sw1 - server > sw0 in subnet 192.168.0.0/24 > sw1 in subnet 172.168.0.0/24 > SNAT configured for client > gateway_mtu=1400 configured for lrp0 > > If we send UDP traffic from client to server