On 31 Jan 2024, at 18:03, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 25 Jan 2024, at 21:55, Aaron Conole wrote:
>>
>>> From: Kevin Sprague
>>>
>>> During normal operations, it is useful to understand when a particular flow
>>> gets removed from the system. This can be useful when
On Wed, Jan 31, 2024 at 10:00:11AM +0100, Frode Nordahl wrote:
> On Mon, Jan 29, 2024 at 12:33 PM Roberto Bartzen Acosta
> wrote:
> >
> > Updating the reference documentation with the inclusion of possible
> > building problems with libjemalloc and solution suggestions.
>
> nit: the above line
On 2/1/24 02:33, Mark Michelson wrote:
>> static void
>> build_qos(struct ovn_datapath *od, struct hmap *lflows) {
>> struct ds action = DS_EMPTY_INITIALIZER;
>> @@ -8371,16 +8375,26 @@ build_qos(struct ovn_datapath *od, struct hmap
>> *lflows) {
>> ovn_lflow_add(lflows, od,
Recheck-request: github-robot-_Build_and_Test
On Tue, Jan 30, 2024 at 4:22 PM wrote:
>
> From: Numan Siddique
>
> Previous commits added new engine nodes to store logical router's
> stateful (LB and NAT data). Make use of the data stored by these
> engine nodes to generate logical flows
On Tue, Jan 30, 2024 at 4:25 PM wrote:
>
> From: Numan Siddique
>
> A new engine node "global_config" is added which handles the changes
> to NB_Global an SB_Global tables. It also creates these rows if
> not present.
>
> Without the I-P, any changes to the options column of these tables
>
On Tue, Jan 30, 2024 at 4:23 PM wrote:
>
> From: Numan Siddique
>
> It also moves the ovn-controller specific code from lib/lb.c
> and lib/lb.h to controller/lb.c and controller/lb.h.
>
> Acked-by: Han Zhou
> Co-authored-by: Dumitru Ceara
> Signed-off-by: Dumitru Ceara
> Signed-off-by: Numan
On Tue, Jan 30, 2024 at 4:24 PM wrote:
>
> From: Numan Siddique
>
> Acked-by: Han Zhou
> Signed-off-by: Numan Siddique
Recheck-request: github-robot-_Build_and_Test
> ---
> northd/en-lflow.c| 26 +
> northd/en-lflow.h| 1 +
> northd/en-ls-stateful.c | 9 +++--
> Hi Lorenzo,
>
> I have just a few small comments below.
Hi Mark,
thx for the review.
>
> On 1/30/24 09:53, Lorenzo Bianconi wrote:
> > Add the capbility to mark (through pkt.mark) incoming/outgoing packets
> > in logical_switch datapath according to user configured QoS rule.
> >
> >
On Thu, Feb 1, 2024 at 10:13 AM Numan Siddique wrote:
>
> On Tue, Jan 30, 2024 at 4:25 PM wrote:
> >
> > From: Numan Siddique
> >
> > A new engine node "global_config" is added which handles the changes
> > to NB_Global an SB_Global tables. It also creates these rows if
> > not present.
> >
>
Add macro for OFTABLE_LOG_INGRESS_PIPELINE and replace all table=8
occurrences in OF with table=OFTABLE_LOG_INGRESS_PIPELINE.
Signed-off-by: Ales Musil
---
tests/ovn-controller-vtep.at | 4 ++--
tests/ovn-macros.at | 1 +
tests/ovn.at | 2 +-
3 files changed, 4
Replace all usage of "sort | sed 's/table=./table=?/'" or
'sort | sed 's/table=../table=??/' with ovn_strip_lflows.
Adjust all table=? to table=?? and re-sort the expected flows.
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 260 ++--
tests/ovn.at
Add macro for OFTABLE_PHY_TO_LOG and replace all table=0
occurrences in OF with table=OFTABLE_PHY_TO_LOG.
Signed-off-by: Ales Musil
---
tests/ovn-controller-vtep.at | 10 ++---
tests/ovn-controller.at | 6 +--
tests/ovn-macros.at | 2 +
tests/ovn.at | 72
Add macro for OFTABLE_REMOTE_OUTPUT and replace all table=39
occurrences in OF with table=OFTABLE_REMOTE_OUTPUT.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 40
2 files changed, 21 insertions(+), 20 deletions(-)
diff
Add macro for OFTABLE_OUTPUT_LARGE_PKT_DETECT and replace all table=37
occurrences in OF with table=OFTABLE_OUTPUT_LARGE_PKT_DETECT.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 14 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git
Replace all usage of "sed 's/table=./table=?/' | sort"
with ovn_strip_lflows and adjust all table=? to be table=??.
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 564 ++--
1 file changed, 281 insertions(+), 283 deletions(-)
diff --git
Add macro for OFTABLE_LOG_TO_PHY and replace all table=65
occurrences in OF with table=OFTABLE_LOG_TO_PHY.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 28 ++--
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git
Add macro for OFTABLE_LOCAL_OUTPUT and replace all table=40
occurrences in OF with table=OFTABLE_LOCAL_OUTPUT.
Signed-off-by: Ales Musil
---
tests/ovn-controller.at | 6 +++---
tests/ovn-macros.at | 1 +
tests/ovn.at| 24
3 files changed, 16
Add macro for OFTABLE_MAC_LOOKUP and replace all table=67
occurrences in OF with table=OFTABLE_MAC_LOOKUP.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 26 +-
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git
A lot of tests were relying on exact table numbers for
flow comparison either logical or OpenFlows.
To solve this problem logical flows will have stripped table
maening that the table= will become table=??. This makes it
future proof for any logical table shifts and there is no need to deal
with
Add the capbility to mark (through pkt.mark) incoming/outgoing packets
in logical_switch datapath according to user configured QoS rule.
Co-developed-by: Dumitru Ceara
Reported-at: https://issues.redhat.com/browse/FDP-42
Signed-off-by: Lorenzo Bianconi
---
- move qos packet mark action in
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: checkpatch: Add rule to check for
On 2/1/24 17:51, Lorenzo Bianconi wrote:
> Add the capbility to mark (through pkt.mark) incoming/outgoing packets
> in logical_switch datapath according to user configured QoS rule.
>
> Co-developed-by: Dumitru Ceara
> Reported-at: https://issues.redhat.com/browse/FDP-42
> Signed-off-by: Lorenzo
Add macro for OFTABLE_LOOKUP_FDB and replace all table=72
occurrences in OF with table=OFTABLE_LOOKUP_FDB.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 18 +-
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/tests/ovn-macros.at
Add macro for OFTABLE_CHK_LB_HAIRPIN_REPLY and replace all table=69
occurrences in OF with table=OFTABLE_CHK_LB_HAIRPIN_REPLY.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 404 ++--
2 files changed, 203 insertions(+),
Add macro for OFTABLE_CT_SNAT_HAIRPIN and replace all table=70
occurrences in OF with table=OFTABLE_CT_SNAT_HAIRPIN.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 206 ++--
2 files changed, 104 insertions(+), 103
Add macro for OFTABLE_CHK_IN_PORT_SEC_ND and replace all table=74
occurrences in OF with table=OFTABLE_CHK_IN_PORT_SEC_ND.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 151 ++--
2 files changed, 77 insertions(+), 75
Add macro for OFTABLE_CHK_LB_HAIRPIN and replace all table=68
occurrences in OF with table=OFTABLE_CHK_LB_HAIRPIN.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 316 ++--
2 files changed, 159 insertions(+), 158
Add macro for OFTABLE_CHK_LB_AFFINITY and replace all table=78
occurrences in OF with table=OFTABLE_CHK_LB_AFFINITY.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/system-ovn-kmod.at | 16
tests/system-ovn.at | 6 +++---
3 files changed, 12
Replace all usage of "sed 's/table=./table=?/'" or
"sed 's/table=../table=??/' with ovn_strip_lflows.
Adjust all table=? to table=?? and re-sort the expected flows.
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 183 ++--
tests/ovn.at| 24
Add macro for OFTABLE_CHK_OUT_PORT_SEC and replace all table=75
occurrences in OF with table=OFTABLE_CHK_OUT_PORT_SEC.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 121 ++--
2 files changed, 62 insertions(+), 60
Add macro for OFTABLE_MAC_BINDING and replace all table=66
occurrences in OF with table=OFTABLE_MAC_BINDING.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/ovn-macros.at
Add macro for OFTABLE_GET_FDB and replace all table=71
occurrences in OF with table=OFTABLE_GET_FDB.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 16
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/ovn-macros.at
Add macro for OFTABLE_CHK_IN_PORT_SEC and replace all table=73
occurrences in OF with table=OFTABLE_CHK_IN_PORT_SEC.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 112 ++--
2 files changed, 58 insertions(+), 55
Add macro for OFTABLE_ECMP_NH_MAC and replace all table=76
occurrences in OF with table=OFTABLE_ECMP_NH_MAC.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/system-ovn.at | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-macros.at
Add macro for OFTABLE_ECMP_NH and replace all table=77
occurrences in OF with table=OFTABLE_ECMP_NH.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/system-ovn.at | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
To avoid issues with hardcoded table numbers in future add rule
into check patch. The rule is only warning because there are still
legitimate use cases and not everything can be abstracted.
Signed-off-by: Ales Musil
---
utilities/checkpatch.py | 12
1 file changed, 12 insertions(+)
Add macro for OFTABLE_MAC_CACHE_USE and replace all table=79
occurrences in OF with table=OFTABLE_MAC_CACHE_USE.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/ovn-macros.at
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 286 characters long (recommended limit is 79)
#352 FILE:
Eelco Chaudron writes:
> On 31 Jan 2024, at 18:03, Aaron Conole wrote:
>
>> Eelco Chaudron writes:
>>
>>> On 25 Jan 2024, at 21:55, Aaron Conole wrote:
>>>
From: Kevin Sprague
During normal operations, it is useful to understand when a particular flow
gets removed from the
Hi Ales,
Thanks for simplifying this. However, I think there is a subtle bug
introduced here. Consider the case where two datapaths, A and B, both
request SNAT zone 0. With the current code, both datapaths will be
assigned zone 0. I think with this change, only one datapath will get
their
Hi Priyankar,
I'm not sure I understand the purpose of this patch. Even without this
patch, you could configure whatever IP address you want in the
ip_port_mappings as the source address for the health checks. I don't
see anything in the code that restricts the IP to be within the subnet
of
On Thu, Feb 1, 2024 at 5:30 PM Han Zhou wrote:
>
>
>
> On Mon, Jan 29, 2024 at 1:36 AM Dumitru Ceara wrote:
> >
> > On 1/29/24 07:20, Ales Musil wrote:
> > > Considering following topology:
> > > client - sw0 - lrp0 - lr - lrp1 - sw1 - server
> > > sw0 in subnet 192.168.0.0/24
> > > sw1 in
On Mon, Jan 29, 2024 at 1:36 AM Dumitru Ceara wrote:
>
> On 1/29/24 07:20, Ales Musil wrote:
> > Considering following topology:
> > client - sw0 - lrp0 - lr - lrp1 - sw1 - server
> > sw0 in subnet 192.168.0.0/24
> > sw1 in subnet 172.168.0.0/24
> > SNAT configured for client
> > gateway_mtu=1400
The documentation for Service_Monitors in the southbound database state
that only IPv4 is supported. However, IPv6 service monitors have been
supported since OVN 23.03 was released.
This patch addresses the problem by removing the incorrect
documentation.
Fixes: 40a686e8e70f ("Add IPv6 support
Bleep bloop. Greetings Felix Huettner, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Co-author Max Lamprecht needs to sign off.
WARNING: Unexpected sign-offs from
On Thu, Feb 1, 2024 at 9:06 PM Mark Michelson wrote:
> Hi Ales,
>
> Thanks for simplifying this. However, I think there is a subtle bug
> introduced here. Consider the case where two datapaths, A and B, both
> request SNAT zone 0. With the current code, both datapaths will be
> assigned zone 0.
Previously the kernel did not provide a netlink interface to flush/list
only conntrack entries matching a specific zone. With [1] it is now
possible to flush and list conntrack entries filtered by zone. Older
kernels not yet supporting this feature will ignore the filter.
For the list request that
Hi Lorenzo,
I have a few comments below.
On 1/17/24 06:11, Lorenzo Bianconi wrote:
Similar to OVN static routes, introduce the capability to link a BFD
session for OVN reroute policies.
Reported-at: https://issues.redhat.com/browse/FDP-234
Signed-off-by: Lorenzo Bianconi
---
NEWS
Thanks Lorenzo!
Acked-by: Mark Michelson
On 1/17/24 06:11, Lorenzo Bianconi wrote:
Fix regression introduce in BFD system tests
Fixes: 1655a6c146ca ("northd, utils: support for RouteTables in LRs")
Signed-off-by: Lorenzo Bianconi
---
tests/system-ovn.at | 4 ++--
1 file changed, 2
Thanks Lorenzo!
Acked-by: Mark Michelson
On 1/17/24 06:11, Lorenzo Bianconi wrote:
In order to properly check if we already have a running BFD session for
the next hop used by the brand new route, load logical port column of
the nb BFD table in nbctl_pre_lr_route_add routine.
Fixes:
50 matches
Mail list logo
