On Fri, Feb 9, 2024 at 5:51 PM Mark Michelson wrote:
> Hi Ales,
>
> I have one comment below, but it's small enough it can be fixed during
> merge.
>
> Acked-by: Mark Michelson
>
> On 2/8/24 13:17, Ales Musil wrote:
> > There were some comments left with hardcoded numbers. Even if it
> >
Include inner offsets in functions where l3 and l4 offsets are either
modified or checked.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Signed-off-by: Mike Pattrick
---
v2:
- Prints out new offsets in autovalidator
- Extends resize_l2 change to avx512
v3:
- Reordered
Previously the BFD packet creation code did not appropriately set
offsets or flags. This contributed to issues involving encapsulation and
the TSO code.
The transition to using standard functions also means some other
metadata like packet_type are set appropriately.
Fixes: ccc096898c46 ("bfd:
This patch fixes the correctness of dp_packet_inner_l4_size() when
checking for the existence of an inner L4 header. Previously it checked
for the outer L4 header.
This function is currently only used when a packet is already flagged
for tunneling, so an incorrect determination isn't possible as
Currently the monitor will call dp_packet_clear() on the dp_packet that
is shared amongst BFD, LLDP, and CFM. However, all of these packets are
created with eth_compose(), which already calls dp_packet_clear().
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
