Re: [ovs-dev] [PATCH] rhel: Environment file option for northd service

2016-11-15 Thread Babu Shanmugam
On Tuesday 15 November 2016 08:11 PM, Russell Bryant wrote: On Tue, Nov 15, 2016 at 6:19 AM, > wrote: From: Babu Shanmugam > Since the northd service starts the DB servers as

Re: [ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

2016-11-15 Thread Neil McKee
Hi Robert, It seems like there are three separable things here: (1) filling in the multicast and broadcast counters that were missing from the generic interface counters structure. This is great -- assuming it's portable across OS versions etc. (2) adding the ethernet counters structure. This

[ovs-dev] [PATCH] netdev: Fix sockaddr cast warning.

2016-11-15 Thread Pravin B Shelar
Following warning was reported by Travis:- lib/netdev.c:1916:19: error: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 2 to 4 [-Werror,-Wcast-align] sin = (struct sockaddr_in *) ifa->ifa_netmask;

[ovs-dev] openvswitch is marked for autoremoval from testing

2016-11-15 Thread Debian testing autoremoval watch
openvswitch 2.3.0+git20140819-4 is marked for autoremoval from testing on 2016-12-15 It is affected by these RC bugs: 828478: openvswitch: FTBFS with openssl 1.1.0 ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Restore flags of dpdk netdev

2016-11-15 Thread Daniele Di Proietto
2016-11-11 5:44 GMT-08:00 Binbin Xu : > If the eth device starts failed or vhost port is not running, > the flags of dpdk netdev should be restored. > > Signed-off-by: Binbin Xu > --- > lib/netdev-dpdk.c | 8 +++- > 1 file changed, 7

Re: [ovs-dev] [PATCH] dpif-netdev: non-pmd thread static_tx_qid should be constant

2016-11-15 Thread Daniele Di Proietto
2016-10-28 4:32 GMT-07:00 Patrik Andersson : > The non-pmd thread static_tx_qid is assumed to be equal to the highest > core ID + 1. The function dp_netdev_del_pmds_on_numa() invalidates > this assumption by re-distributing the static_tx_qid:s on all pmd and >

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fix the issue of physical port's admin state configuration

2016-11-15 Thread Daniele Di Proietto
2016-11-11 5:44 GMT-08:00 Binbin Xu : > When we set physical port's admin state via ovs-appctl, the application > seems to work and returns "OK". But the application doesn't work perfectly, > the state stored in database doesn't change. > > Signed-off-by: Binbin Xu

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Can't set specified vhost port's admin state

2016-11-15 Thread Daniele Di Proietto
2016-11-11 5:44 GMT-08:00 Binbin Xu : > When we set a vhost port's admin state via ovs-appctl, the > application doesn't work and returns the information > "Not a DPDK Interface". > > Signed-off-by: Binbin Xu > Thanks for the patch I'm thinking

[ovs-dev] [PATCH 17/17] ovs-numa: Remove unused functions.

2016-11-15 Thread Daniele Di Proietto
ovs-numa doesn't need to keep the state of the pmd threads, it is an implementation detail of dpif-netdev. Signed-off-by: Daniele Di Proietto --- lib/ovs-numa.c | 168 - lib/ovs-numa.h | 7 --- 2 files changed,

[ovs-dev] [PATCH 16/17] dpif-netdev: Centralized threads and queues handling code.

2016-11-15 Thread Daniele Di Proietto
Currently we have three different code paths that deal with pmd threads and queues, in response to different input 1. When a port is added 2. When a port is deleted 3. When the cpumask changes or a port must be reconfigured. 1. and 2. are carefully written to minimize disruption to the running

[ovs-dev] [PATCH 11/17] dpctl: Avoid making assumptions on pmd threads.

2016-11-15 Thread Daniele Di Proietto
Currently dpctl depends on ovs-numa module to delete and create flows on different pmd threads for pmd devices. The next commits will move away the pmd threads state from ovs-numa to dpif-netdev, so the ovs-numa interface will not be supported. Also, the assignment between ports and thread is an

[ovs-dev] [PATCH 10/17] dpif-netdev: Make 'static_tx_qid' const.

2016-11-15 Thread Daniele Di Proietto
Since previous commit, 'static_tx_qid' doesn't need to be atomic and is actually never touched (except for initialization), so it can be made const. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

[ovs-dev] [PATCH 07/17] dpif-netdev: Use a boolean instead of pmd->port_seq.

2016-11-15 Thread Daniele Di Proietto
There's no need for a sequence number, since the main thread has to wait for the pmd thread, so there's no chance that an update will be undetected. A seq object will be introduced for another purpose in the next commit, and changing this to boolean makes the code more readable. Signed-off-by:

[ovs-dev] [PATCH 08/17] dpif-netdev: Block pmd threads if there are no ports.

2016-11-15 Thread Daniele Di Proietto
There's no reason for a pmd thread to perform its main loop if there are no queues in its poll_list. This commit introduces a seq object on which the pmd thread can be blocked, if there are no queues. When the main thread wants to reload a pmd threads it must now change the seq object (in case

[ovs-dev] [PATCH 01/17] dpif-netdev: Fix memory leak.

2016-11-15 Thread Daniele Di Proietto
We keep all the per-port classifiers around, since they can be reused, but when a pmd thread is destroyed we should free them. Found using valgrind. Fixes: 3453b4d62a98("dpif-netdev: dpcls per in_port with sorted subtables") Signed-off-by: Daniele Di Proietto ---

Re: [ovs-dev] relationship between dpcls_rule and dp_netdev_flow

2016-11-15 Thread Jarno Rajahalme
> On Nov 15, 2016, at 3:35 PM, Joo Kim wrote: > > Hello, > > In this OVS (2.6) code below, > It seems that a dp_netdev_flow obj contains a dpcls_rule struct, and given > a dpcls_rule, it gets the corresponding dp_netdev_flow via > dp_netdev_flow_cast(). > Does it mean

Re: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

2016-11-15 Thread Yang, Yi Y
Got it, thanks, I'll follow your discussion thread. -Original Message- From: Thadeu Lima de Souza Cascardo [mailto:casca...@cascardo.eti.br] Sent: Wednesday, November 16, 2016 3:01 AM To: Yang, Yi Y ; Jiri Benc ; net...@vger.kernel.org Cc:

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-15 Thread nickcooper-zhangtonghao
I got it. Thank you explaining this. Can you review the v1 of NAT command, and other patches ? Thanks very much. http://patchwork.ozlabs.org/patch/680778/ http://patchwork.ozlabs.org/patch/680777/

Re: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

2016-11-15 Thread Thadeu Lima de Souza Cascardo
On November 15, 2016 11:57:21 AM GMT-02:00, "Yang, Yi Y" wrote: >Hi, Jiri > >I'm very glad to see you're continuing this work :-), I asked Simon >about this twice, but nobody replies. I also remember Cascardo has a >patch set to collaborate with this patch set, I asked

[ovs-dev] Proposal to move the Python lib to its own repo

2016-11-15 Thread Terry Wilson
The Python library isn't dependent on the code in the OVS tree. It being in-tree has a few shortcomings. My rationale for recommending the split: * Simple features and bugfixes for the Python lib can't be used by other projects (like Neutron) until the very latest OVS release is widely supported

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-15 Thread Guru Shetty
On 15 November 2016 at 06:30, nickcooper-zhangtonghao wrote: > Hi Guru Shetty. > LB may support DNAT with port. But in some case, there is only a public ip > address set on the gateway router, which is connected to multiple VMs. Thus > this public ip address need to be

Re: [ovs-dev] [PATCH] rhel: Environment file option for northd service

2016-11-15 Thread Russell Bryant
On Tue, Nov 15, 2016 at 6:19 AM, wrote: > From: Babu Shanmugam > > Since the northd service starts the DB servers as well, it will be > better to have an environment file options in the systemd unit file for > northd service. > The environment file is

[ovs-dev] FW: OVS 2.6.1 DPDK 16.07 issue: pthread_mutex_lock failed (Resource deadlock avoided) in

2016-11-15 Thread Yang, Yi Y
Hi, all I found this issue when I use ovs 2.6.1 and dpdk 16.07, the error is located in the line "ovs_mutex_lock(>mutex);" in get_stats() in lib/netdev-vport.c, it looks like a deadlock is detected, so resulted in ovs-vswitchd coredump, anybody noticed this issue? How can we fix it? this has

[ovs-dev] quick loan

2016-11-15 Thread James Reardon
Do you need a personal,cooperate business loan to finance your business or refinance your mortgage?If your answer is YES kindly reply to waynep201...@gmail.com for details as we offer loan at 4% interest rate annually. ___ dev mailing list

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-15 Thread nickcooper-zhangtonghao
Hi Guru Shetty. LB may support DNAT with port. But in some case, there is only a public ip address set on the gateway router, which is connected to multiple VMs. Thus this public ip address need to be projected to multiple private ip address. They denote a one to many relationship not one to

Re: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

2016-11-15 Thread Yang, Yi Y
Hi, Jiri I'm very glad to see you're continuing this work :-), I asked Simon about this twice, but nobody replies. I also remember Cascardo has a patch set to collaborate with this patch set, I asked Cascardo, but nobody responds, will you continue to do Cascardo's " create tunnel devices

[ovs-dev] [PATCH] utilities: Use FQDN for external_ids:hostname in Openvswitch table

2016-11-15 Thread bschanmu
From: Babu Shanmugam Openstack compute manager uses FQDN to check for the hypervisors to which the ports are bound. Without this fix, no instances can be launched as the hypervisor's hostname mismatches. Signed-off-by: Babu Shanmugam ---

[ovs-dev] [PATCH] rhel: Environment file option for northd service

2016-11-15 Thread bschanmu
From: Babu Shanmugam Since the northd service starts the DB servers as well, it will be better to have an environment file options in the systemd unit file for northd service. The environment file is expected to define NORTHD_OPTS which will have additional parameters to be

[ovs-dev] [PATCH] sflow: Expose ethernet and vlan stats via sFlow

2016-11-15 Thread Robert Wojciechowicz
Expose existing netdev stats via sFlow. Export sFlow ETHERNET structure with available counters. Map existing stats to counters in the GENERIC INTERFACE sFlow structure. Export sFlow VLAN structure with available counters. Adjust unit test to accommodate these new counters. Signed-off-by: Robert

[ovs-dev] [PATCH 2/3] ovs-router: report error when failing to insert route

2016-11-15 Thread Thadeu Lima de Souza Cascardo
Signed-off-by: Thadeu Lima de Souza Cascardo --- lib/ovs-router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index e27514a..e29d462 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c @@ -316,7 +316,7 @@