Re: [ovs-dev] [RFC PATCHv2] ofp-actions: Add clone action.

2016-12-01 Thread William Tu
On Thu, Dec 1, 2016 at 6:25 PM, Gao Zhenyu wrote: > Thanks for working on it! > > Can we have nested clone? > > actions=clone(push_vlan(1), resubmit(1,2), clone(mod_dl_src:, > output:5) ) > I tested it for a couple of simple cases, it seems ok. But it might complicate

Re: [ovs-dev] [patch_v8] ovn: Add datapaths of interest filtering.

2016-12-01 Thread Darrell Ball
On 11/30/16, 3:07 AM, "ovs-dev-boun...@openvswitch.org on behalf of Liran Schour" wrote: Darrell Ball wrote on 30/11/2016 02:29:01 AM: > On Tue, Nov 29, 2016 at 4:10 AM, Liran Schour

Re: [ovs-dev] [RFC PATCHv2] ofp-actions: Add clone action.

2016-12-01 Thread Gao Zhenyu
Thanks for working on it! Can we have nested clone? actions=clone(push_vlan(1), resubmit(1,2), clone(mod_dl_src:, output:5) ) BTW, I believe the port 3 will get a 104byte size packet with this action, right? actions= clone(truncate(100), push_vlan, output:3) Thanks Zhenyu Gao 2016-12-01 5:35

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-01 Thread Jarno Rajahalme
> On Nov 30, 2016, at 8:50 PM, Ben Pfaff wrote: > > On Wed, Nov 30, 2016 at 06:58:57PM -0800, Jarno Rajahalme wrote: >> >>> On Nov 30, 2016, at 8:41 AM, Ben Pfaff wrote: >>> >>> On Wed, Nov 30, 2016 at 12:05:46PM +0100, Thomas Morin wrote: Hi Ben,

Re: [ovs-dev] [PATCH v2] ovn-controller: Remove unused members from local_datapath.

2016-12-01 Thread Mickey Spiegel
On Thu, Dec 1, 2016 at 4:34 PM, Ben Pfaff wrote: > Nothing used these, except to initialize and free them. 'logical_port' > wasn't meaningful in any case, it was just the name of the first logical > port encountered from a particular logical datapath when traversing the >

Re: [ovs-dev] What is the minimum Linux kernel version ovs 2.6.1 build requires?

2016-12-01 Thread Yang, Yi Y
Joe, it is my bad. Our nsh patches added two pointer variables to " struct ovs_skb_cb", that increased its size by 16 bytes, but sk_buff.cb only has 48 bytes, when I build ovs with "--with-linux=..." option, sizeof(struct ovs_gso_cb) will be over 48 bytes, that is the root cause of this build

[ovs-dev] [PATCH v2] ovn-controller: Remove unused members from local_datapath.

2016-12-01 Thread Ben Pfaff
Nothing used these, except to initialize and free them. 'logical_port' wasn't meaningful in any case, it was just the name of the first logical port encountered from a particular logical datapath when traversing the database's Port_Binding table, which isn't in a meaningful order. Signed-off-by:

[ovs-dev] [PATCH] ovn-controller: Remove unused member 'logical_port' from local_datapath.

2016-12-01 Thread Ben Pfaff
Nothing used this, except to initialize and free it. It wasn't meaningful in any case, it was just the name of the first logical port encountered from a particular logical datapath when traversing the database's Port_Binding table, which isn't in a meaningful order. Also, use assignment to copy

Re: [ovs-dev] [PATCH] CONTRIBUTING.rst: Update patch summary and description style guidelines.

2016-12-01 Thread Ben Pfaff
On Thu, Dec 01, 2016 at 01:16:14PM +, Stephen Finucane wrote: > On Wed, 2016-11-30 at 12:40 -0800, Ben Pfaff wrote: > > Suggested-by: Joe Stringer > > Suggested-at: https://mail.openvswitch.org/pipermail/ovs-dev/2016-Nov > > ember/325513.html > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

2016-12-01 Thread Ben Pfaff
On Thu, Dec 01, 2016 at 09:37:19PM +, Tony van der Peet wrote: > I will foreshadow another problem I found while implementing test > suite 140. This is where flow is created without SEND_FLOW_REM flag, > but flow delete does set this bit. The flow removed message is not > sent in this case. I

[ovs-dev] Tome el Control de su Empresa

2016-12-01 Thread Normas de Información Financiera (NIF)
En línea y en Vivo / Para todo su Equipo con una sola Conexión Normas de Información Financiera (NIF) CONTROLES INTERNOS 16 de diciembre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs Tome el verdadero control de su empresa. Aprenda la manera óptima de regular, registrar

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

2016-12-01 Thread Ben Pfaff
On Thu, Dec 01, 2016 at 01:09:12PM -0800, Jarno Rajahalme wrote: > > If I may be permitted to nit-pick, the name "modify_forward_counts" took > > me a bit of thinking to properly understand. Maybe "modify_keep_stats" > > would be easier for me to understand at first glance. > > “stats” include

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

2016-12-01 Thread Tony van der Peet
Hi Ben, Jarno > Tony, does this solve the problem for you? Yes it does. I like the solution presented by Jarno a bit more than mine too, I had a feeling that adding a new flag would cause problems. I will foreshadow another problem I found while implementing test suite 140. This is where flow

[ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

2016-12-01 Thread Sairam Venugopal
Introduce a new table to track related connections. This table will be used to track FTP data connections based on the control connection. There is a new Conntrack-ftp.c to parse incoming FTP messages to determine the related data ports. It creates a new entry in the related connections tracker

[ovs-dev] [PATCH 0/4] datapath-windows: Enable support for tracking FTP connections

2016-12-01 Thread Sairam Venugopal
Add support for maintaining and tracking related connections. This patch introduces the concept of related-connections table. There is an FTP parser in place to parse FTP PASV and PORT commands. Support for traking extended FTP commands will be added in subsequently. Sairam Venugopal (4):

[ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-01 Thread Sairam Venugopal
Enable the support for tracking FTP connections in the Connection tracker. This checks an incoming ftp control connection to extract the related data connection. When a matching data connection arrives, it would then update the connection entry to point to the original control connection.

[ovs-dev] [PATCH 2/4] datapath-windows: Cleanup Conntrack definitions and introduce related entries

2016-12-01 Thread Sairam Venugopal
Consolidate the reusable structs and includes. Introduce the new OVS_CT_REL_ENTRY to track related connections. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 12 datapath-windows/ovsext/Conntrack.h | 37

Re: [ovs-dev] [PATCH] ofproto: Support reset_counts on flow mod message.

2016-12-01 Thread Jarno Rajahalme
> On Nov 29, 2016, at 3:46 PM, Tony van der Peet > wrote: > > If the reset_counts flag is set on a flow modification message, the > flow counters must be cleared, even if the flow does not already have > the reset_counts flag set. And the flow modification

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

2016-12-01 Thread Jarno Rajahalme
> On Nov 30, 2016, at 9:06 PM, Ben Pfaff wrote: > > On Wed, Nov 30, 2016 at 05:51:12PM -0800, Jarno Rajahalme wrote: >> While a flow modify must keep the original flow's flags, it must reset >> counts if (and only if) the reset_counts flag is present in the flow >> mod message. >>

[ovs-dev] [PATCH] ovsdb-tool: Document database numbering scheme.

2016-12-01 Thread Ben Pfaff
Prompted by an IRC discussion. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-tool.1.in | 25 + vswitchd/vswitch.xml | 11 ++- 2 files changed, 27 insertions(+), 9 deletions(-) diff --git a/ovsdb/ovsdb-tool.1.in b/ovsdb/ovsdb-tool.1.in index

[ovs-dev] [RFC PATCH] Pipeline packet processing in OVS using FVL flow director.

2016-12-01 Thread Sugesh Chandran
The patch uses a pipeline model of packet processing in dpif-netdev. Packets are processed by either normal or hardware pipeline based on flow- director ID on the packet. The extendable model allows to enable any type of partial offloads(Packet types, flow director) in a need basis. The patch

[ovs-dev] [RFC PATCH] Pipeline packet processing in OVS using FVL flow director.

2016-12-01 Thread Sugesh Chandran
The RFC patch that uses the metadata information from the NIC to avoid/reduce the packet processing overhead in OVS. It uses the flow director feature in XL710 NICs to identify and report the VxLAN tunneled packets. OVS-DPDK uses the reported

Re: [ovs-dev] [PATCH] build: fix rpm-fedora target breakage

2016-12-01 Thread Ben Pfaff
On Thu, Dec 01, 2016 at 09:58:10AM +, Stephen Finucane wrote: > On Wed, 2016-11-30 at 20:56 -0800, Ben Pfaff wrote: > > On Wed, Nov 30, 2016 at 10:57:25PM -0500, Lance Richardson wrote: > > > Since commit 3deca69b08f2 ("doc: Convert AUTHORS to rST"), the rpm- > > > fedora > > > target fails to

Re: [ovs-dev] [PATCH] ovn-controller: Remove obsolete concept of "stale" patched datapaths.

2016-12-01 Thread Ben Pfaff
On Thu, Dec 01, 2016 at 09:02:57AM -0500, Russell Bryant wrote: > On Thu, Dec 1, 2016 at 2:11 AM, Ben Pfaff wrote: > > > When ovn-controller implemented incremental processing, the set of > > patched datapaths was revised on each trip through the main loop, so it > > was necessary

[ovs-dev] [PATCH 1/3] ovn-nb: remote connection management in nb db

2016-12-01 Thread Lance Richardson
Add support for managing remote connections, including SSL configuration, to northbound db schema, and add necessary commands to ovn-nbctl. Signed-off-by: Lance Richardson --- NEWS | 2 + ovn/ovn-nb.ovsschema | 53 +++-

Re: [ovs-dev] [PATCH] physical: Remove obsolete comments.

2016-12-01 Thread Russell Bryant
On Thu, Dec 1, 2016 at 2:11 AM, Ben Pfaff wrote: > These comments were added above code that removed flows from the flow > table. Now that that code was deleted, the comments no longer make sense. > > Signed-off-by: Ben Pfaff > Acked-by: Russell Bryant

Re: [ovs-dev] [PATCH] CONTRIBUTING.rst: Update patch summary and description style guidelines.

2016-12-01 Thread Stephen Finucane
On Wed, 2016-11-30 at 12:40 -0800, Ben Pfaff wrote: > Suggested-by: Joe Stringer > Suggested-at: https://mail.openvswitch.org/pipermail/ovs-dev/2016-Nov > ember/325513.html > Signed-off-by: Ben Pfaff > --- >  CONTRIBUTING.rst | 12 ++-- >  1 file changed, 10

Re: [ovs-dev] Packet type-aware pipeline, L3 tunneling, EXT-382 and NSH: Minutes call 2016-11-29

2016-12-01 Thread Jiri Benc
On Wed, 30 Nov 2016 22:52:38 +, Jan Scheurich wrote: > The corresponding section in the document is already updated with the > results of the discussion. So please have look. There's also a short > summary of the main results at the end of the mail. Thanks for writing that down. I see several

Re: [ovs-dev] [PATCH] build: fix rpm-fedora target breakage

2016-12-01 Thread Stephen Finucane
On Wed, 2016-11-30 at 20:56 -0800, Ben Pfaff wrote: > On Wed, Nov 30, 2016 at 10:57:25PM -0500, Lance Richardson wrote: > > Since commit 3deca69b08f2 ("doc: Convert AUTHORS to rST"), the rpm- > > fedora > > target fails to build with: > > > >   *** No rule to make target `AUTHORS.rst', needed by