Re: [ovs-dev] [PATCH v2 00/11] ovn: get rid of most uses of patch ports

2016-12-17 Thread Mickey Spiegel
On Fri, Dec 16, 2016 at 2:51 PM, Guru Shetty wrote: > On 16 December 2016 at 14:25, Ben Pfaff wrote: > > > At least a v3 will be forthcoming to incorporate Darrell and Liran's > > "datapaths of interest" concept, but I said yesterday that I'd send a > > revised version before v3 is ready. > > >

[ovs-dev] [PATCH 1/5] doc: Add vlan cookbook from website

2016-12-17 Thread Stephen Finucane
This is mostly copied verbatim. Signed-off-by: Stephen Finucane --- Documentation/automake.mk | 2 + Documentation/howto/index.rst | 1 + Documentation/howto/vlan.png | Bin 0 -> 83598 bytes Documentation/howto/vlan.rst | 142 ++ 4 files changed,

[ovs-dev] [PATCH 4/5] doc: Add port tunneling cookbook from website

2016-12-17 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- Documentation/automake.mk | 2 + Documentation/howto/index.rst | 1 + Documentation/howto/tunneling.png | Bin 0 -> 72197 bytes Documentation/howto/tunneling.rst | 165 ++ 4 files changed, 168 insertions(+) c

[ovs-dev] [PATCH 2/5] doc: Add QoS cookbook from website

2016-12-17 Thread Stephen Finucane
This is mostly copied verbatim. Signed-off-by: Stephen Finucane --- Documentation/automake.mk | 2 + Documentation/howto/index.rst | 1 + Documentation/howto/qos.png | Bin 0 -> 69865 bytes Documentation/howto/qos.rst | 157 ++ 4 files changed,

[ovs-dev] [PATCH 3/5] doc: Add sFlow cookbook from website

2016-12-17 Thread Stephen Finucane
This is mostly copied verbatim. Signed-off-by: Stephen Finucane --- Documentation/automake.mk | 2 + Documentation/howto/index.rst | 1 + Documentation/howto/sflow.png | Bin 0 -> 85755 bytes Documentation/howto/sflow.rst | 171 ++ 4 files changed,

[ovs-dev] [PATCH 5/5] doc: Add DPDK to userspace tunneling guide

2016-12-17 Thread Stephen Finucane
Instructions were provided in the userspace tunneling cookbook. Signed-off-by: Stephen Finucane --- Documentation/automake.mk | 2 +- Documentation/howto/index.rst | 2 +- Documentation/howto/native-tunneling.rst| 176 Documentation/ho

[ovs-dev] [PATCH 6/6] doc: Add a 'what-is-ovs' document

2016-12-17 Thread Stephen Finucane
Add description of Open vSwitch from README, along with the overview image from openvswitch.org. Signed-off-by: Stephen Finucane --- Documentation/_static/overview.jpg | Bin 0 -> 105786 bytes Documentation/automake.mk | 1 + Documentation/index.rst | 3 +++ Documentat

[ovs-dev] [PATCH 4/6] doc: Misc fixes to 'bash-completion'

2016-12-17 Thread Stephen Finucane
Fix some minor formatting issues with this document. Signed-off-by: Stephen Finucane --- Documentation/intro/install/bash-completion.rst | 27 ++--- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/Documentation/intro/install/bash-completion.rst b/Documentatio

[ovs-dev] [PATCH 3/6] doc: Add info on building documentation

2016-12-17 Thread Stephen Finucane
I know how to do this, but does anyone else? Let's make it obvious and ease the cognitive load on the great folks writing docs. Links to the various packaging guides, previously missing, are included on the main page. Signed-off-by: Stephen Finucane --- Documentation/automake.mk

[ovs-dev] [PATCH 5/6] doc: Document various language bindings

2016-12-17 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- Documentation/automake.mk | 1 + Documentation/index.rst| 2 + Documentation/topics/index.rst | 1 + Documentation/topics/language-bindings.rst | 60 ++ 4 files changed, 64 insertio

[ovs-dev] [PATCH 1/6] doc: Add some useful tools for doc editing

2016-12-17 Thread Stephen Finucane
This has come up on the mailing list. Let's document it! Signed-off-by: Stephen Finucane --- .../internals/contributing/documentation-style.rst | 29 +++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/Documentation/internals/contributing/documentation-style.rst

[ovs-dev] [PATCH 2/6] doc: Misc fixes to 'documentation-style'

2016-12-17 Thread Stephen Finucane
The table headers are unnecessary and make the doc harder to read, while the headers guide was not displaying very well. Signed-off-by: Stephen Finucane --- .../internals/contributing/documentation-style.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [ovs-dev] [PATCH v2 03/11] ofp-actions: Add clone action.

2016-12-17 Thread William Tu
Thanks for the patch, I have some comments. > +static char * OVS_WARN_UNUSED_RESULT > +parse_CLONE(char *arg, struct ofpbuf *ofpacts, > + enum ofputil_protocol *usable_protocols) > +{ > + > +const size_t ct_offset = ofpacts_pull(ofpacts); I will s/ct_offset/clone_offset/g > +s