Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

Thanks for the review and comments. On Thu, Mar 9, 2017 at 10:00 AM, Darrell Ball wrote: > Daniele and I discussed > > 1) Seems ok in that there is security at the VM LP so weakening the > Check at the router port for ICMP seems ok. > 2) The same applies to V6 ? > ​I need to

Re: [ovs-dev] [PATCH] debian; Avoid installing ovs-vswitchd.conf.db manpage as "db" language.

I have tested it. It is ok now. Simon, what do you think about it? Tested-by: nickcooper-zhangtonghao > On Mar 9, 2017, at 2:22 AM, Ben Pfaff wrote: > > Simon, would you mind reviewing this, since it's about the Debian > packaging?

Re: [ovs-dev] [PATCH] ovsdb: Expose openvswitch run directory through ovsdb

On Thu, Mar 02, 2017 at 02:40:19PM +, Robert Wojciechowicz wrote: > When using vhost-user client or server mode with openstack, > neutron needs to be able to construct the fully qualified socket path > and pass it to nova. > While the relative vhost-user socket directory is exposed via > the

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

On 3/8/17, 1:30 PM, "Ben Pfaff" wrote: On Wed, Mar 08, 2017 at 08:58:05PM +, Darrell Ball wrote: > > > On 3/7/17, 3:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: >

[ovs-dev] [PATCH] debian: Rewrite "ifconfig" to "ip" command.

Some debian distribution may not contain the ifconfig. We use the ip command instead of ifconfig in debian/ifupdown.sh Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329503.html CC: prochazka Signed-off-by: nickcooper-zhangtonghao

Re: [ovs-dev] [PATCH] dpdk: Use VLOG_INFO_ONCE instead of open-coding it.

On Wed, Mar 08, 2017 at 05:09:27PM -0800, Andy Zhou wrote: > On Wed, Mar 8, 2017 at 3:44 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou Thanks, I applied this to master. ___ dev

Re: [ovs-dev] [PATCH] pinsched: Clear next_txq pointer when destroying pinqueue

On Fri, Feb 24, 2017 at 09:09:19AM +1300, Tony van der Peet wrote: > When a packet-in queue is destroyed, clear next_txq if it is referencing > the destroyed queue. NULL is a valid value for next_txq. > > Signed-off-by: Tony van der Peet Thanks, I applied

Re: [ovs-dev] [patch_v6 3/8] dpdk: Remove batch sorting in userspace conntrack.

Thanks for posting this as a separate patch, it makes the review easier. The idea and the patch look good to me. One comment: with this code we don't need the ctxs array, we can just have a single ctx in the for loop. Other than that: Acked-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH] pinsched: Clear next_txq pointer when destroying pinqueue

Yes, your change is better. If I get some time I'll do a build with this and re-run our test, but by inspection I would say that this is solid. Thanks Tony From: Ben Pfaff Sent: Thursday, 9 March 2017 2:04 p.m. To: Tony van der Peet Cc:

Re: [ovs-dev] [PATCH v3 00/22] Conntrack enhancements

> On Mar 7, 2017, at 5:46 PM, Joe Stringer wrote: > > On 6 March 2017 at 16:22, Jarno Rajahalme > wrote: >> This patch set backports the recent upstream conntrack fixes and new >> features to the OVS tree kernel module, and adds the OVS

[ovs-dev] [PATCH] lib: Indicate if netlink message had labels.

Conntrack update events include labels only if they have changed. Record the presence of labels in the netlink message to OVS internal representation, so that the user may keep the old labels when an update does not modify them. Signed-off-by: Jarno Rajahalme --- lib/ct-dpif.h

Re: [ovs-dev] [PATCH] dpdk: Use VLOG_INFO_ONCE instead of open-coding it.

On Wed, Mar 8, 2017 at 3:44 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/2] debian: Add hostname as dependency

On Thu, Feb 23, 2017 at 04:06:17PM -0500, Russell Bryant wrote: > From: Jakub Libosvar > > ovs-ctl script uses hostname. This patch adds dependency for debian > systems. > > Signed-off-by: Jakub Libosvar Thanks a lot for the patch. It's very kind to

Re: [ovs-dev] [PATCH] pinsched: Clear next_txq pointer when destroying pinqueue

On Fri, Feb 24, 2017 at 09:09:19AM +1300, Tony van der Peet wrote: > When a packet-in queue is destroyed, clear next_txq if it is referencing > the destroyed queue. NULL is a valid value for next_txq. > > Signed-off-by: Tony van der Peet > --- >

Re: [ovs-dev] [PATCH] bundle: add nw_src/dst hash method

On Thu, Feb 23, 2017 at 01:19:11PM +0800, we...@ucloud.cn wrote: > From: wenxu > > Add this feature to help only nw_src or nw_dst hash senario. > > Signed-off-by: wenxu Thanks for the contribution! Please add documentation for this new support in

Re: [ovs-dev] [PATCH 1/4] id-pool: Allocate the lowest available ids.

On Tue, Feb 21, 2017 at 05:49:25PM +0300, Ilya Maximets wrote: > This simple change makes id-pool to always allocate the > lowest possible id from the pool. No any other code affected > because, actually, there is no users of 'id_pool_free_id' in > OVS. > > This behaviour of id-pool will be used

Re: [ovs-dev] [PATCH] ovs-tcpdump: Set mirror port mtu

On Wed, Feb 22, 2017 at 02:59:41PM -0500, Aaron Conole wrote: > When using ovs-tcpdump to mirror interfaces with MTU larger than the default, > Open vSwitch will lower the interfaces we are interested in monitoring. > Instead, probe the MTU and set the mirrored port's MTU value correctly. > >

Re: [ovs-dev] [PATCH] mirror: Allow concurrent lookups.

On Tue, Feb 21, 2017 at 07:44:02PM -0800, Jarno Rajahalme wrote: > Handler threads use a selection of mirror functions with the > assumption that the data referred to is RCU protected, while the > implementation has not provided for this, which can lead to an OVS > crash. > > This patch fixes

Re: [ovs-dev] [PATCH] python: Fix Chinese characters UnicodeEncodeError exception

On Mon, Feb 20, 2017 at 07:38:25PM +0800, Guoshuai Li wrote: > The OVSDB client may send or recv Chinese characters. > So we should use UTF-8 encoding data for send or recv by default. > > Signed-off-by: Guoshuai Li Thanks for the patch! This fails to build with the following

Re: [ovs-dev] [PATCH V5 1/1] ovs-vtep: vtep-ctl and ovs-vtep support of adding explicit tunnel key

Justin, you've reviewed previous versions of this patch. Will you look at this one? On Sun, Feb 19, 2017 at 01:45:15PM +0200, itamaro wrote: > From: itamarofek > > This patch adds support for handeling a per-tunnel tunnel key in the > ovs-vtep and vtep-ctl. > > The aim

Re: [ovs-dev] [PATCH 1/3] dpdk: postpone dpdk_init

On Sun, Feb 19, 2017 at 06:41:25PM +0800, hanxue...@126.com wrote: > From: Huanle Han > > Currently, dpdk_init takes a long time and system datapath keeps > disconnecting during dpdk_init on ovs restart. Put bridge_reconfigure() > in front of dpdk_init() so that system

Re: [ovs-dev] [PATCH] windows: Crash when the handle communication device cannot be found

On Fri, Feb 17, 2017 at 12:35:08PM +, Alin Serdean wrote: > When trying to uninstall/disable the OVS extension the driver will > fail to unload properly(require reboot)/hang until ovs-vswitchd is closed. > > The root cause of this behavior is because the handles from ovs-vswitchd > to the

Re: [ovs-dev] [patch_v6 2/8] dpdk: Parse NAT netlink for userspace datapath.

On Thu, Feb 16, 2017 at 12:47:33AM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball Here are some proposed changes as an incremental diff: diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 61704419f962..a7407e65958d 100644 --- a/lib/dpif-netdev.c +++

Re: [ovs-dev] [PATCH] ofproto/bond: Simplify bond_may_recirc()

On Wed, Mar 8, 2017 at 1:39 PM, Ben Pfaff wrote: > On Fri, Feb 24, 2017 at 06:08:05PM -0800, Andy Zhou wrote: >> The extra information passed back is no longer used outside bond.c. >> Make the API simpler. >> >> Signed-off-by: Andy Zhou > > Acked-by: Ben Pfaff

Re: [ovs-dev] [patch_v6 1/8] dpdk: Export packet_set_ipv6_addr() for DPDK.

On Thu, Feb 16, 2017 at 12:47:32AM -0800, Darrell Ball wrote: > The NAT changes in this series need both packet_set_ipv4_addr() > and packet_set_ipv6_addr() exporting, however, the ipv4 api was > exported with an unrelated patch. > > Signed-off-by: Darrell Ball > Acked-by:

Re: [ovs-dev] OVN: Compromised Chassis Mitigation

Thanks, Lance. I have one more comment to add to this version: On Wed, Mar 8, 2017 at 4:28 PM, Lance Richardson wrote: > This email (prompted by recent discussions in IRC on the subject) > outlines some of the options that have been discussed for securing > OVN_Southbound

Re: [ovs-dev] [PATCH] ofproto/bond: Simplify bond_may_recirc()

On Fri, Feb 24, 2017 at 06:08:05PM -0800, Andy Zhou wrote: > The extra information passed back is no longer used outside bond.c. > Make the API simpler. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

I'm also looking at this one. I was trying to review today, but have been slowed down by getting an OpenStack test environment working for testing this and looking closer. On Wed, Mar 8, 2017 at 4:32 PM, Ben Pfaff wrote: > Hi Darrell and Daniele, do one of you have an opinion on

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

Hi Darrell and Daniele, do one of you have an opinion on whether this is the right approach? Thanks, Ben. On Mon, Feb 27, 2017 at 11:29:14AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Presently, the icmp4 requests to the router gateway ip are sent to the

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

On Wed, Mar 08, 2017 at 08:58:05PM +, Darrell Ball wrote: > > > On 3/7/17, 3:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" > wrote: > > On Thu, Mar 02, 2017 at 08:01:42PM -0800, Darrell Ball wrote: > >

[ovs-dev] OVN: Compromised Chassis Mitigation

This email (prompted by recent discussions in IRC on the subject) outlines some of the options that have been discussed for securing OVN_Southbound from a compromised chassis, and includes a strawman proposal for an ovsdb transaction ACL implementation. Feedback appreciated, hopefully we can

Re: [ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

On Wed, Mar 08, 2017 at 01:09:00PM -0800, Justin Pettit wrote: > > > On Jan 26, 2017, at 10:26 AM, Ben Pfaff wrote: > > > > It turns out that, since groff 1.20 around 2009, groff comes with a > > preprocessor named "preconv" that can fix encoding issues. Use it instead > > of the

Re: [ovs-dev] [PATCH v2 2/2] ovn-northd ipam: Support IPv6 dynamic assignment

On Tue, Mar 07, 2017 at 07:19:45AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > OVN will generate the IPv6 address for a logical port if requested > using the IPv6 prefix and the MAC address (as IEEE EUI64 identifier). > To generate the IPv6 address, CMS

Re: [ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

> On Jan 26, 2017, at 10:26 AM, Ben Pfaff wrote: > > It turns out that, since groff 1.20 around 2009, groff comes with a > preprocessor named "preconv" that can fix encoding issues. Use it instead > of the existing hack. Geez, you didn't know that? Where've you been? > ---

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

On 3/7/17, 3:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Thu, Mar 02, 2017 at 08:01:42PM -0800, Darrell Ball wrote: > Some code-block directives are not understood using > Trusty (I was using

Re: [ovs-dev] [PATCH v4 2/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Ben, Please find my answer below. Regards _Sugesh > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, March 7, 2017 6:07 PM > To: Chandran, Sugesh > Cc: d...@openvswitch.org; Gray, Mark D ; >

Re: [ovs-dev] [PATCH] rhel: Use correct default port for OVN SB database

On Wed, Mar 8, 2017 at 3:19 PM, Lance Richardson wrote: > Fix typo in OVN SB database TCP port number. > > Fixes: commit 55f36be59122 ("rhel: Firewall service files for OVN.") > Signed-off-by: Lance Richardson Applied to master and branch-2.7, thanks!

[ovs-dev] [PATCH] rhel: Use correct default port for OVN SB database

Fix typo in OVN SB database TCP port number. Fixes: commit 55f36be59122 ("rhel: Firewall service files for OVN.") Signed-off-by: Lance Richardson --- rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [ovs-dev] [PATCH 2/2] ofproto: Add ref counting for variable length mf_fields.

On 7 March 2017 at 09:39, Yi-Hung Wei wrote: > Currently, a controller may potentially trigger a segmentation fault if it > accidentally removes a TLV mapping that is still used by an active flow. > To resolve this issue, in this patch, we maintain reference counting for

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix running under python3.

On Wed, Mar 8, 2017 at 12:54 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > utilities/checkpatch.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py > index

Re: [ovs-dev] [PATCH 4/7] ofproto: New cookie-counters module.

On 07/03/2017 10:35, "Ben Pfaff" wrote: >On Fri, Feb 24, 2017 at 06:57:58PM -0800, Daniele Di Proietto wrote: >> The new module will be used by ofproto to keep track of the number of >> learned flows with the same cookie in the same table. >> >> The counters are used to

Re: [ovs-dev] [PATCH 6/7] ofproto: Implement learning limit.

On 07/03/2017 10:39, "Ben Pfaff" wrote: >On Fri, Feb 24, 2017 at 06:58:00PM -0800, Daniele Di Proietto wrote: >> With this commit we honor the newly introduced limit to the learn >> action. >> >> When learning a new rule (with the limit set), the rule will hold a >> reference

[ovs-dev] [PATCH v2 3/3] ofp-actions: Add limit to learn action.

This commit adds a new feature to the learn actions: the possibility to limit the number of learned flows. To be compatible with users of the old learn action, a new structure is introduced as well as a new OpenFlow raw action number. There's a small corner case when we have to slowpath the

[ovs-dev] [PATCH v2 2/3] ofp-actions: Factor out decode_LEARN_{common, spec}().

No functional change, they will be used by next commit. Signed-off-by: Daniele Di Proietto --- lib/ofp-actions.c | 58 ++- 1 file changed, 40 insertions(+), 18 deletions(-) diff --git a/lib/ofp-actions.c

[ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: Create XC_LEARN entry after learning.

This will be useful in a separate commit, because learning can fail. Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git

[ovs-dev] [PATCH v2 0/3] Learn action limit

This series implements the possibility to have a limit on the number of flows learned by a learn action. After the learn action execution the pipeline can read the result (to know if the limit was exceeded). v1->v2: * 'limit' counts both learn flows and flows installed by controller, suggested

Re: [ovs-dev] [PATCH 1/2] checkpatch: Check for pointer whitespace.

On Wed, Mar 8, 2017 at 12:54 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > utilities/checkpatch.py | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py > index

Re: [ovs-dev] [PATCH 1/2] nx-match: Use vl_mff_map to parse match field.

Thanks for review. Please find v2 in the following e-mail. -Yi-Hung On Wed, Mar 8, 2017 at 9:56 AM, Joe Stringer wrote: > On 7 March 2017 at 09:39, Yi-Hung Wei wrote: > > vl_mff_map is introduced in patch (04f48a68c428 ofp-actions: Fix variable > > length

[ovs-dev] [PATCH v2 1/2] nx-match: Use vl_mff_map to parse match field.

vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs") to account variable length mf_field, and it is used to decode variable length mf_field in ofp_action. In this patch, vl_mff_map is further used to decode the variable length match field as well.

Re: [ovs-dev] [PATCH v2 1/2] ovn-northd ipam: Support 'exclude_ips' option

On Tue, Mar 07, 2017 at 07:19:13AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > If the CMS wants to make use of ovn ipam it can now provide a > list of IPv4 addresses and a range of IPv4 addresses which > will be excluded from the dynamic address assignment.

Re: [ovs-dev] [PATCH] python: List 3.5 as a supported version.

On Tue, Feb 28, 2017 at 08:36:17AM -0500, Russell Bryant wrote: > All tests pass with Python 3.5 so list it as supported. > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] -fomit-frame-pointer in OVS

On Mon, Feb 27, 2017 at 08:32:20PM +0500, Valentine Sinitsyn wrote: > Currently, OVS seems to disable frame pointer (-fomit-frame-pointer) in > non-debug builds. > > While I do know this is a common optimization, it makes run-time profiling > substantially less straightforward. So I wonder, if

Re: [ovs-dev] [PATCH] Makefile: Drop vestiges of support for non-GNU Make.

On Wed, Mar 08, 2017 at 12:34:56PM -0500, Russell Bryant wrote: > On Tue, Mar 7, 2017 at 11:48 PM, Ben Pfaff wrote: > > > Open vSwitch has documented a requirement for GNU Make for a long time, yet > > it had vestiges catering to other make implementations. This removes > > those.

Re: [ovs-dev] [PATCH 1/2] nx-match: Use vl_mff_map to parse match field.

On 7 March 2017 at 09:39, Yi-Hung Wei wrote: > vl_mff_map is introduced in patch (04f48a68c428 ofp-actions: Fix variable > length meta-flow OXMs) to account variable length mf_field, and it is used Usually we format this in the kernel patch style, ie 'commit 04f48a68c428

[ovs-dev] [PATCH 2/2] checkpatch: Fix running under python3.

Signed-off-by: Joe Stringer --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index e795646de4a8..a94736d380c2 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@

[ovs-dev] [PATCH 1/2] checkpatch: Check for pointer whitespace.

Signed-off-by: Joe Stringer --- utilities/checkpatch.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 26eb5c32b9bc..e795646de4a8 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -68,6

Re: [ovs-dev] [PATCH] ovn-controller: Don't bind non-existent interfaces.

On Wed, Mar 8, 2017 at 2:18 AM, Gurucharan Shetty wrote: > There are multiple reasons why a interface can exist > in the Open vSwitch database but not exist in the system. > For e.g, a restart of a host after a system crash. Ideally, > whoever added the interface in the Open vSwitch

Re: [ovs-dev] [PATCH] Makefile: Drop vestiges of support for non-GNU Make.

On Tue, Mar 7, 2017 at 11:48 PM, Ben Pfaff wrote: > Open vSwitch has documented a requirement for GNU Make for a long time, yet > it had vestiges catering to other make implementations. This removes > those. > > Signed-off-by: Ben Pfaff > --- > Makefile.am | 6

Re: [ovs-dev] [PATCH 2/2] ovn-northd: Add logical flows to support native DNS

On Fri, Feb 10, 2017 at 08:02:33PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, the logical ports should be

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Add 'dns_lkup' action

On Fri, Feb 10, 2017 at 08:02:15PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new OVN action 'dns_lkup' to support native DNS. > ovn-controller parses this action and adds a NXT_PACKET_IN2 > OF flow with 'pause' flag set. > > A new table

Re: [ovs-dev] [PATCH v3] packaging: Make Fedora spec file CentOS compatible

On Mon, Mar 6, 2017 at 3:46 PM, Leif Madsen wrote: > On CentOS, the package names aren't prefixed with python2, but rather > are prefixed with simply python. This change addresses that and fixes > up some documentation that was outdated, and updates the Vagrantfile > to use

[ovs-dev] Microsoft Office:

Microsoft Office: As part of our effort to improve your experience across our consumer services, we're updating the Microsoft Services Agreement and the Microsoft Privacy Statement. We want to take this opportunity to notify you about these updates. by CLICKING

[ovs-dev] [PATCH] tests: Fix mcast test on slow systems

On slow systems(or which start processes slow) the test: `testing mcast - delete the port mdb when port destroyed` is influenced by the running time. i.e.: http://64.119.130.115/ovs/911b7e9b08b9f4f890eeecd228d5124f4ce94d4e/testsuite.dir/2326/testsuite.log.gz This patches adds a time stop on

[ovs-dev] [PATCH] stp: Set time of BPDU packet.

The OvS BPDU packets have not right format. The STP works well in OvS bridges when stp enabled, because they set the time(e.g. max age, hello time and forward delay) in ticks. But they should be sec. If so, OvS STP can work well with other type of bridge using STP. Signed-off-by:

[ovs-dev] Copyright © 2017 Microsoft outlook .Inc . All rights reserved.

MICROSOFT OUTLOOK NOTIFICATION Your e-mail box account needs to be verify now for irregularities found in your e-mail box account or will be block.Please CLICK HERE to verify your mail box and fill in your complete user name and

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

On Tue, 2017-03-07 at 11:01 -0800, Ben Pfaff wrote: > On Tue, Mar 07, 2017 at 05:01:06PM +, Stephen Finucane wrote: > > PS: This also sounds like something that could be automatically > > tested. > > If only some folks were working on a tool to automatically test > > mailing > > list

Re: [ovs-dev] [PATCH 1/3] doc: Fix issues.rst formatting typo.

On Thu, 2017-03-02 at 05:02 -0800, nickcooper-zhangtonghao wrote: > The preformatted block is only finished when the text > falls back to the same indentation level as a paragraph > prior to the preformatted block. > > Signed-off-by: nickcooper-zhangtonghao LGTM. Acked-by:

Re: [ovs-dev] [PATCH v3] dpif-netdev: Change definitions of 'idle' & 'processing' cycles

> > On 02/21/2017 10:49 AM, Jan Scheurich wrote: > >> -Original Message- > >> From: Kevin Traynor [mailto:ktray...@redhat.com] > >> Sent: Friday, 17 February, 2017 17:38 > >> > >> If there are multiple queues in a poll list and only one has packets, > >> the cycles polling the empty

Re: [ovs-dev] [PATCH] Documentation: Report errors for use of features not in Sphinx 1.1.3.

On Tue, 2017-03-07 at 10:54 -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff I'm not sure if this is completely necessary, but I imagine it won't slow the build down too much and looks about right so: Acked-by: Stephen Finucane I'd also like to see a TODO