[ovs-dev] [PATCH 6/6] rstp: Add the 'ovs-appctl rstp/show' command.

2017-03-31 Thread nickcooper-zhangtonghao
The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao --- NEWS | 4 +- lib/rstp.c | 113

[ovs-dev] [PATCH 3/6] stp: Add link-state checking support for stp ports.

2017-03-31 Thread nickcooper-zhangtonghao
When bridge stp enabled, we enable the stp ports despite ports are down. When initializing, this patch checks link-state of ports and enable or disable them according to their link-state. This patch also allow user to enable and disable a port when bridge stp is running. Signed-off-by:

[ovs-dev] [PATCH 5/6] rstp: Add rstp port name for human reading.

2017-03-31 Thread nickcooper-zhangtonghao
This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao --- lib/rstp-common.h | 1 + lib/rstp.c | 14

[ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

2017-03-31 Thread nickcooper-zhangtonghao
This patch will be used for next patch. Signed-off-by: nickcooper-zhangtonghao --- lib/rstp.c | 15 --- lib/rstp.h | 6 -- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/rstp.c b/lib/rstp.c index 907a907..6f1c1e3 100644 --- a/lib/rstp.c

[ovs-dev] [PATCH 2/6] stp: Use OpenFlow port number for stp ports.

2017-03-31 Thread nickcooper-zhangtonghao
When a bridge stp enabled, we assign sequentially element of stp_port array (in stp struct) to bridge ports. That is ok when no ports are added to bridge. When adding a port to bridge which stp enabled, the ovs-vswitchd will assign stp_port sequentially again. Then the stp_port belonging to one

[ovs-dev] [PATCH 1/6] rstp/stp: Unref the rstp/stp when bridges destroyed.

2017-03-31 Thread nickcooper-zhangtonghao
When bridges destroyed, which stp enabled, you can still get stp info via the command 'ovs-appctl stp/show'. And the rstp is also in the same case. We should unref them. The rstp/stp ports have been unregistered via 'ofproto_port_unregister' function when ports destroyed. We will unref rstp/stp

Re: [ovs-dev] [PATCH 2/3] ofproto: Store meters into imap

2017-03-31 Thread Ben Pfaff
On Fri, Mar 31, 2017 at 01:42:02PM -0700, Andy Zhou wrote: > Currently, meters are stored in a fixed pointer array. It is not > very efficient since the controller, at least in theory, can > pick any meter id (up to the limits to uint32_t), not necessarily > within the lower end of a region, or in

Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet?

2017-03-31 Thread Joo Kim
While static MAC binding addon is good in the sense that we can avoid expense ARP resolution, but still in the usecase of running OVS switch alone without controller, ARP resolution is needed for forwarding non-tunnel traffic to nexthop, isn't it? On Fri, Mar 31, 2017 at 11:12 AM, Darrell Ball

[ovs-dev] [PATCH] ovn-sbctl: fix lflow-list when uuid has leading 0s.

2017-03-31 Thread Han Zhou
When uuid starts with 0s, lflow-list will fail if leading 0s are not included in command argument. This leads to unexpected results considering that leading 0s are usually not shown up in cookies of OpenFlow outputs of tools such as ovs-ofctl dump-flows and ovs-appctl ofproto/trace. E.g. lflow

[ovs-dev] ovs-dev@openvswitch.org邮件系统升级验证提醒!

2017-03-31 Thread postmaster
这是一封 HTML 格式的邮件,请以网页方式查看邮件。 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 3/3] ofproto-dpif: Add 'meter_ids' to backer

2017-03-31 Thread Andy Zhou
Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. provider_meter_id. Currently, only userspace datapath supports meter, and it implements the provider_meter_id management. Moving this function to 'backer' allows other datapath implementation to share the same logic.

[ovs-dev] [PATCH 2/3] ofproto: Store meters into imap

2017-03-31 Thread Andy Zhou
Currently, meters are stored in a fixed pointer array. It is not very efficient since the controller, at least in theory, can pick any meter id (up to the limits to uint32_t), not necessarily within the lower end of a region, or in close range to each other. In particular, OFPM_SLOWPATH and

[ovs-dev] [PATCH 1/3] lib: Add imap

2017-03-31 Thread Andy Zhou
'imap' implements a sparse array that maps a uint32_t value to a pointer of arbitrary object. Future patches will make use of this library. Signed-off-by: Andy Zhou --- lib/automake.mk | 2 + lib/imap.c | 129

Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet?

2017-03-31 Thread Darrell Ball
From: Joo Kim Date: Thursday, March 30, 2017 at 5:09 PM To: Darrell Ball Cc: "ovs-dev@openvswitch.org" Subject: Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet? Thanks for reply Darrell.

[ovs-dev] [PATCH] table: provide table formatting option help at runtime

2017-03-31 Thread Lance Richardson
Show table formatting options with help output from ovn-nbctl, obn-sbctl, ovs-vsctl, and vtep-ctl commands. Include "--data" option in ovsdb-client help output. Signed-off-by: Lance Richardson --- lib/table.c | 16 lib/table.h |

[ovs-dev] [PATCH 2/2] ovn-nbctl: include table formatting options in man page

2017-03-31 Thread Lance Richardson
Include descriptions of table formatting optiosn in ovn-nbctl man page. Signed-off-by: Lance Richardson --- ovn/utilities/ovn-nbctl.8.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index

[ovs-dev] [PATCH 1/2] table: add xml version of lib/table.man

2017-03-31 Thread Lance Richardson
Add lib/table.xml, translated from lib/table.man for inclusion in XML man pages (such as ovn-nbctl.8.xml). Signed-off-by: Lance Richardson --- lib/automake.mk | 1 + lib/table.xml | 114 2 files changed, 115

[ovs-dev] [PATCH 0/2] add table formatting options to ovn-nbctl man page

2017-03-31 Thread Lance Richardson
Add missing descriptions of table formatting options to the ovn-nbctl(8) man page. Lance Richardson (2): table: add xml version of lib/table.man ovn-nbctl: include table formatting options in man page lib/automake.mk | 1 + lib/table.xml | 114

[ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

2017-03-31 Thread Russell Bryant
The RPM build makefile targets are helpful during development and testing, but I personally almost never want the tests to run when I use them. Leave tests on by default in the spec file for when the package is built by distro build systems, but disable it by default in the Makefile targets and

Re: [ovs-dev] [PATCH v1] ofproto-dpif-mirror: Fix issue of reseting snaplen in mirroring

2017-03-31 Thread William Tu
Looks good to me, thanks for the fix. Acked-by: William Tu On Sun, Mar 26, 2017 at 8:16 PM, Zhenyu Gao wrote: > Currently, the mirror code doesn't check new value of snaplen when try > to reconfigure snaplen. > This patch fix this issue and add