[ovs-dev] [PATCH v2] ovn: increase size of ingress and egress pipelines

2017-05-16 Thread Mickey Spiegel
The OVN ingress pipeline for a logical switch is maxed out at 16 stages. This patch takes the simple approach of starting the ingress pipeline at table 8 rather than table 16, and starting the egress pipeline at table 40 rather than table 48. v1->v2: Bumped range of Logical_Flow.table_id column i

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-05-16 Thread Ilya Maximets
Hi Darrell, Good catch. Thanks. One comment inline. Best regards, Ilya Maximets. On 16.05.2017 20:14, Darrell Ball wrote: > I applied the following incremental to fix a missing free on error, but > otherwise is fine > Can you fold in the incremental. > > > diff --git a/lib/netdev-dpdk.c b/li

Re: [ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

2017-05-16 Thread Darrell Ball
On 5/15/17, 6:00 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bodireddy, Bhanuprakash" wrote: >Commit daf4d3c18da4("odp: Support conntrack orig tuple key.") introduced >new fields in struct 'pkt_metadata'. pkt_metadata_init() is called for every >packet in the userspace data

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread fukaige
I start a vm with its backend tap device "vnet0" attached to a Linux bridge, then delete the bridge and vm. Next time, vm will start failed. this is as expected. But, seeing that linux bridge was already delelted; there is no reason that the OVS bridge with the same name can not be created. Wha

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread Ben Pfaff
On Wed, May 17, 2017 at 01:16:11AM +, fukaige wrote: > I am using ovs-2.5.2 and get error when creating a bridge using “ovs-vsctl > add-br br-eth” > brctl addbr br0;ifconfig br0 up [...] > ifconfig br0 down; brctl delbr br0 > > ovs-vsctl add-br br0 > > ovs-vsctl del-br br0 Wait, what? W

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread fukaige
I test ovs 2.5.0/2.5.2/2.5.3 on ARM64&x86. All got the same error. From: fukaige Sent: Wednesday, May 17, 2017 9:16 AM To: 'd...@openvswitch.org' Cc: 'Ben Pfaff' Subject: [bug] failed to add ovs bridge Hi, all I am using ovs-2.5.2 and get error when creating a bridge using “ovs-vsctl add-br br-

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Skip EMC lookup when EMC is disabled.

2017-05-16 Thread Darrell Ball
I found 4-5% throughput improvement when emc is disabled and it is a simple change Thanks for adding this. Acked-by: Darrell Ball dlu...@gmail.com On 4/13/17, 11:30 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bodireddy, Bhanuprakash" wrote: >On 04/13/2017 07:11 PM, Kevin Traynor w

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: enable multi-segment jumbo frames

2017-05-16 Thread 仇大玉
2017/5/15 18:17, Mark Kavanagh : Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the pool is large enough to contain an entire jumbo frame of a user-defined size. Typically, for each user-defined MTU 'requeste

Re: [ovs-dev] [PATCH v4 6/7] dpif-netlink-rtnl: add GENEVE creation support

2017-05-16 Thread Joe Stringer
On 7 May 2017 at 06:43, Eric Garver wrote: > Creates GENEVE devices using rtnetlink and tunnel metadata. > > Co-Authored-by: Thadeu Lima de Souza Cascardo > Signed-off-by: Thadeu Lima de Souza Cascardo > Signed-off-by: Eric Garver Does this pass the "make check-kernel" tests for geneve on a ne

Re: [ovs-dev] [PATCH v4 3/7] dpif-netlink: Support rtnetlink port creation.

2017-05-16 Thread Joe Stringer
On 7 May 2017 at 06:43, Eric Garver wrote: > In order to be able to add those tunnels, we need to add code to create > the tunnels and add them as NETDEV vports. And when there is no support > to create them, we need to fallback to compatibility code and add them > as tunnel vports. > > When remov

[ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread fukaige
Hi, all I am using ovs-2.5.2 and get error when creating a bridge using “ovs-vsctl add-br br-eth” ovs-vsctl: Error detected while setting up 'br-eth'. See ovs-vswitchd log for details. ovs-vswitchd log is as below: 2017-05-11T03:45:25.293Z|00026|ofproto_dpif|INFO|system@ovs-system: Datapath

Re: [ovs-dev] [PATCH v7 3/4] datapath-windows: NAT integration with conntrack

2017-05-16 Thread Yin Lin
See inline comments for reply. -Original Message- From: Sairam Venugopal Sent: Tuesday, May 16, 2017 5:09 PM To: Yin Lin ; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 3/4] datapath-windows: NAT integration with conntrack Please find my comments inline. Thanks, Sairam On 5

[ovs-dev] [PATCH] ovn-controller: Fix a wrong comment.

2017-05-16 Thread Han Zhou
Flows are sent to switch by ofctrl_put() instead of ofctrl_run(), so fix the comment which was misleading. Signed-off-by: Han Zhou --- ovn/controller/ofctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c index 417fdc9..5762

[ovs-dev] 系统备案

2017-05-16 Thread post
这是一封 HTML 格式的邮件,请以网页方式查看邮件。 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in conntrack

2017-05-16 Thread Yin Lin
Thanks Sai for the review! I fixed most of them and explained the remaining ones in the inline comments. -Original Message- From: Sairam Venugopal Sent: Tuesday, May 16, 2017 4:50 PM To: Yin Lin ; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module

Re: [ovs-dev] [PATCH v7 3/4] datapath-windows: NAT integration with conntrack

2017-05-16 Thread Sairam Venugopal
Please find my comments inline. Thanks, Sairam On 5/9/17, 3:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin" wrote: >This patch integrates NAT module with existing conntrack module. NAT >action is now supported. > >Signed-off-by: Yin Lin >--- > datapath-windows/automake.mk

Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in conntrack

2017-05-16 Thread Sairam Venugopal
Hi Yin, Thanks for the patch. Please find my comments inline. Thanks, Sairam On 5/9/17, 3:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin" wrote: >Signed-off-by: Yin Lin >--- > datapath-windows/automake.mk| 2 + > datapath-windows/ovsext/Conntrack-nat.c | 424 +++

Re: [ovs-dev] [PATCH v7 1/4] datapath-windows: Add support for NAT in conntrack

2017-05-16 Thread Sairam Venugopal
Looks like outlook messed up my formatting. I had 2 comments in this patch. The default case statement is missing and 2 other cases aren't handled: case OVS_NAT_ATTR_UNSPEC: break; case __OVS_NAT_ATTR_MAX: break; default: ; OvsCtExecute_ - parameters exceed th

Re: [ovs-dev] [PATCH v7 1/4] datapath-windows: Add support for NAT in conntrack

2017-05-16 Thread Sairam Venugopal
Not sure why the "From: Anand Kumar ” shows up in the commit description. Since they are already listed as co-author, it should be safe to remove this. Acked-by: Sairam Venugopal On 5/9/17, 3:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin" wrote: >From: Anand Kumar > >Ad

[ovs-dev] [PATCH v2] datapath-windows: Set Version correctly for OVSExt

2017-05-16 Thread Shashank Ram
- Previously, the 'Version' property passed to MSBuild was not being passed to the RcComplile section. To use the value of 'Version' property in the rc file, it needs to be passed. - Adds a macro to convert the Version to a string literal. Previously, the Version was simply being converted

Re: [ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

2017-05-16 Thread Joe Stringer
On 16 May 2017 at 07:25, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman Is this n

Re: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

2017-05-16 Thread Lance Richardson
> From: nusid...@redhat.com > To: d...@openvswitch.org > Sent: Monday, 15 May, 2017 11:39:25 AM > Subject: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL > v0.13 > > From: Numan Siddique > > Centos provides pyOpenSSL version pyOpenSSL-0.13.1-3.el7.x86_64. > There are 2 iss

Re: [ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

2017-05-16 Thread Greg Rose
On Tue, 2017-05-16 at 15:25 +0100, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman

Re: [ovs-dev] [PATCH RFC] Drop support for RHEL 5 and 6

2017-05-16 Thread Guru Shetty
On 15 May 2017 at 16:49, Joe Stringer wrote: > On 12 May 2017 at 07:45, Timothy Redaelli wrote: > > RHEL 6 is not supported anymore since it uses Python 2.6 and GCC 4.4.x, > > but Open vSwitch needs, at least, Python 2.7 and GCC 4.6 to build > correctly. > > > > http://docs.openvswitch.org/en/la

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-05-16 Thread Darrell Ball
I applied the following incremental to fix a missing free on error, but otherwise is fine Can you fold in the incremental. diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 56b9d25..25d9c9b 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1128,7 +1128,7 @@ netdev_dpdk_process_d

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix Rx checksum reconfigure.

2017-05-16 Thread Chandran, Sugesh
Hi Kevin, Thank you for sending out this patch series. Have you tested the tunneling decap usecase with checksum offload? I am seeing weird behavior when I testing the tunneling with Rx checksum offload ON and OFF.(Seeing the same behavior on master as well) Here is the summary of issue with the

[ovs-dev] Question about port statistics

2017-05-16 Thread Junguk Cho
Hi, I used userplane OVS-2.7 with DPDK-16.11.1. I set up two dpdk ring device ports in OVS. 27afd0dc-cdac-4bb4-947c-65e13df66e99 Bridge "br0" Controller "tcp:10.1.2.2" is_connected: true fail_mode: secure Port "dpdkr2" Interface "dpdkr2"

[ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

2017-05-16 Thread Anoob Soman
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding") the skb->sender_cpu needs to be cleared before forwarding packets. Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") Signed-off-by: Anoob Soman --- net/openvswitch/vport.c | 1 + 1 file changed, 1 insertion(+)

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-16 Thread Roi Dayan
On 10/05/2017 17:29, Flavio Leitner wrote: On Wed, May 10, 2017 at 10:44:46AM +0300, Roi Dayan wrote: On 09/05/2017 22:05, Flavio Leitner wrote: On Sun, May 07, 2017 at 10:55:32AM +0300, Roi Dayan wrote: On 03/05/2017 18:58, Federico Iezzi wrote: On Wed, May 3, 2017 at 5:07 PM, Roi Daya

Re: [ovs-dev] [PATCH ovs V8 26/26] dpif-netlink: Use dpif logging functions

2017-05-16 Thread Roi Dayan
On 10/05/2017 18:20, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:17PM +0300, Roi Dayan wrote: Please add some changelog text here. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif-netlink.c | 55 +- 1 file changed, 17

Re: [ovs-dev] [PATCH ovs V8 25/26] dpif: Refactor flow logging functions to be used by other modules

2017-05-16 Thread Roi Dayan
On 10/05/2017 18:21, Simon Horman wrote: On Wed, May 10, 2017 at 05:19:26PM +0200, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:16PM +0300, Roi Dayan wrote: Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Reviewed-by: Simon Horman Sorry, I didn't notice before but could you add

Re: [ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

2017-05-16 Thread Roi Dayan
On 10/05/2017 16:57, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:12PM +0300, Roi Dayan wrote: From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to dum

Re: [ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

2017-05-16 Thread Roi Dayan
On 10/05/2017 16:48, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:12PM +0300, Roi Dayan wrote: From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to dum

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

2017-05-16 Thread Flavio Leitner
On Mon, May 15, 2017 at 09:34:35AM +0300, Roi Dayan wrote: > > > On 09/05/2017 21:12, Flavio Leitner wrote: > > On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: > > > From: Paul Blakey > > > > > > Signed-off-by: Paul Blakey > > > Reviewed-by: Roi Dayan > > > Reviewed-by: Simon Horma

Re: [ovs-dev] [PATCH] ovn: increase size of ingress and egress pipelines

2017-05-16 Thread Miguel Angel Ajo Pelayo
Makes sense, but Numan is right https://github.com/openvswitch/ovs/blob/master/ovn/ovn-sb.ovsschema#L64 On Mon, May 15, 2017 at 12:07 PM, Numan Siddique wrote: > On Fri, May 12, 2017 at 12:06 AM, Mickey Spiegel > wrote: > > > The OVN ingress pipeline for a logical switch is maxed out at 16 stag

Re: [ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-16 Thread Roi Dayan
On 10/05/2017 16:28, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote: From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 4 +- lib/netdev

Re: [ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-16 Thread Roi Dayan
On 09/05/2017 21:12, Flavio Leitner wrote: On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote: From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 4 +- lib/netd

Re: [ovs-dev] [PATCH ovs V8 12/26] netdev-tc-offloads: Add flower mask to priority map

2017-05-16 Thread Roi Dayan
On 09/05/2017 22:10, Flavio Leitner wrote: On Tue, May 09, 2017 at 03:23:12PM -0300, Flavio Leitner wrote: On Wed, May 03, 2017 at 06:08:03PM +0300, Roi Dayan wrote: From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority fo

Re: [ovs-dev] [PATCH ovs V8 07/26] netdev-tc-offloads: Implement netdev flow flush using tc interface

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:56, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:58PM +0300, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman This does not appear to address Flavio Leitner's review of v7 of this patch. email issues.

Re: [ovs-dev] [PATCH ovs V8 06/26] dpif-netlink: Flush added ports using netdev flow api

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:50, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:57PM +0300, Roi Dayan wrote: From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Flavio Le

Re: [ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:49, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:56PM +0300, Roi Dayan wrote: From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate d

Re: [ovs-dev] [PATCH ovs V8 03/26] other-config: Add hw-offload switch to control netdev flow offloading

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:38, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:54PM +0300, Roi Dayan wrote: From: Paul Blakey Add a new configuration option - hw-offload that enables netdev flow api. Enabling this option will allow offloading flows using netdev implementation instead of the kernel d

Re: [ovs-dev] [PATCH] netdev-dpdk: add support for rx_multicast_packets counter

2017-05-16 Thread Szczerbik, PrzemyslawX
Hi, Any comments on this change? It's really trivial patch, which has been sitting in patchwork for some time now. Is there anything that I can do to expedite the review process? Kind regards, Przemek > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun..