When I test OvS openflow, I confuse the 'in_port' with
'output:in_port'. I doc the openflow.rst and it may
help others to avoid it.
Signed-off-by: nickcooper-zhangtonghao
---
Documentation/faq/openflow.rst | 4
1 file changed, 4 insertions(+)
diff --git
- Minimum valid fragment size is 400 bytes, any fragment smaller
is likely to be intentionally crafted (CVE-2000-0305).
- Validate maximum length of an Ip datagram
- Added counters to keep track of number of fragments for a given
Ip datagram.
Signed-off-by: Anand Kumar
Thanks.
> On Jun 10, 2017, at 12:44 AM, Ben Pfaff wrote:
>
> On Fri, Jun 09, 2017 at 08:28:41PM +0800, nickcooper-zhangtonghao wrote:
>> Why OvS does not support that we output a packet to a port which it is
>> coming from.
>> In the case, eth1 can receive vlan1 and vlan2
Part of the hash input for nat_range_hash() was accidentally
omitted, so this fixes the problem. Also, add a missing call to
hash_finish().
Fixes: 286de2729955 ("dpdk: Userspace Datapath: Introduce NAT Support.")
Co-authored-by: Ben Pfaff
Signed-off-by: Ben Pfaff
The function conn_key_hash() is updated to include
a call to hash_finish() and also to make use of a
new hash abstraction - ct_endpoint_hash_add().
Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 10
From: Ben Pfaff
These will receive their first user (outside of hash.h) in the following
commit.
Signed-off-by: Ben Pfaff
Acked-by: Darrell Ball
---
lib/hash.h | 66 +-
1 file changed,
This patch integrates NAT module with existing conntrack module. NAT
action is now supported.
Signed-off-by: Yin Lin
---
datapath-windows/ovsext/Actions.c | 119 ++-
datapath-windows/ovsext/Actions.h | 20
datapath-windows/ovsext/Conntrack.c
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk| 2 +
datapath-windows/ovsext/Conntrack-nat.c | 433
datapath-windows/ovsext/Conntrack-nat.h | 39 +++
3 files changed, 474 insertions(+)
create mode 100644
From: Alin Gabriel Serdean
There is a known bug with NAT where checksum computation is wrong on
the RX path if offload is enabled. This patch works around the problem
by always computing a software checksum and should be reverted once
we figure out the root cause
Sure, on the way.
On 6/9/17, 2:35 PM, "Ben Pfaff" wrote:
OK. Do you want to post a new version of the series that adds your
changes and acks?
On Fri, Jun 09, 2017 at 09:23:44PM +, Darrell Ball wrote:
> I noticed the pre-existing hash function,
OK. Do you want to post a new version of the series that adds your
changes and acks?
On Fri, Jun 09, 2017 at 09:23:44PM +, Darrell Ball wrote:
> I noticed the pre-existing hash function, conn_key_hash() was missing
> hash_finish(), I added it locally and retested.
>
>
>
> On 6/8/17, 8:34
On 06/09/2017 01:42 AM, Kavanagh, Mark B wrote:
From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
On Behalf Of
Ben Pfaff
Sent: Thursday, June 8, 2017 10:34 PM
To: Darrell Ball
Cc: d...@openvswitch.org; Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:41PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> netdev vports are backed by actualy netdev at the kernel
> level, so they can use the common netdev-tc offloads interface
> for flow offloading (if enabled).
>
> Signed-off-by: Paul Blakey
On Thu, Jun 08, 2017 at 02:46:40PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Notify as not supported. Otherwise the ingress qdisc is being removed and
> offload rules will be removed.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
On Thu, Jun 08, 2017 at 02:46:39PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Search the requested ufid for a offloaded flow, and if found,
> dump and parse it back to required format.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
On Thu, Jun 08, 2017 at 02:46:38PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Search all datapath added netdevs for a given flow
> using netdev flow api and parse it back to dpif flow.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
On Thu, Jun 08, 2017 at 02:46:37PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
Acked-by: Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:36PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> If a flow was offloaded to a netdev we delete it using netdev
> flow api.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon
On Thu, Jun 08, 2017 at 02:46:35PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Currently only tunnel offload is supported.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
On Thu, Jun 08, 2017 at 02:46:34PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Flower classifer requires a different priority per mask,
> so we hash the mask and generate a new priority for
> each new mask used.
>
> Signed-off-by: Paul Blakey
>
On Thu, Jun 08, 2017 at 02:46:33PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Using the new netdev flow api operate will now try and
> offload flows to the relevant netdev of the input port.
> Other operate methods flows will come in later patches.
>
> Signed-off-by:
On Thu, Jun 08, 2017 at 02:46:32PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
Acked-by: Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:30PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Flows offloaded to tc are identified by priority
> and handle pair while OVS flows are identified by ufid.
> Added a hash map to convert between the two for later
> retrieval and deleting of
On Thu, Jun 08, 2017 at 02:46:29PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> While dumping flows, dump flows that were offloaded to
> netdev and parse them back to dpif flow.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
On 06/02/2017 06:40 PM, Stokes, Ian wrote:
>> -Original Message-
>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
>> boun...@openvswitch.org] On Behalf Of Kevin Traynor
>> Sent: Friday, May 5, 2017 5:34 PM
>> To: d...@openvswitch.org
>> Subject: [ovs-dev] [RFC PATCH 2/6]
On 06/02/2017 06:40 PM, Stokes, Ian wrote:
>> -Original Message-
>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
>> boun...@openvswitch.org] On Behalf Of Kevin Traynor
>> Sent: Friday, May 5, 2017 5:34 PM
>> To: d...@openvswitch.org
>> Subject: [ovs-dev] [RFC PATCH 1/6]
On 06/02/2017 06:39 PM, Stokes, Ian wrote:
>> -Original Message-
>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
>> boun...@openvswitch.org] On Behalf Of Kevin Traynor
>> Sent: Friday, May 5, 2017 5:34 PM
>> To: d...@openvswitch.org
>> Subject: [ovs-dev] [RFC PATCH 0/6] Change
On Thu, Jun 08, 2017 at 02:46:23PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Add a new API interface for offloading dpif flows to netdev.
> The API consist on the following:
> flow_put - offload a new flow
> flow_get - query an offloaded flow
> flow_del - delete
On Thu, Jun 08, 2017 at 02:46:22PM +0300, Roi Dayan wrote:
> Add tc helper functions to query and manipulate the flower classifier.
>
> Signed-off-by: Paul Blakey
> Co-authored-by: Roi Dayan
> Signed-off-by: Roi Dayan
Acked-by: Flavio
On Thu, Jun 08, 2017 at 02:46:21PM +0300, Roi Dayan wrote:
> Those functions are just wrappers to available macros for readability.
> Move them to tc.h to avoid function-call overhead.
>
> Signed-off-by: Roi Dayan
> ---
I think misses a function to set TC_H_ROOT, but that's
On 9 June 2017 at 09:39, Ben Pfaff wrote:
> On Fri, May 26, 2017 at 11:19:46AM -0700, Joe Stringer wrote:
>> On 25 May 2017 at 16:21, Anand Kumar wrote:
>> > - Minimum valid fragment size is 400 bytes, any fragment smaller
>> > is likely to be intentionally
On Thu, Jun 08, 2017 at 02:46:20PM +0300, Roi Dayan wrote:
> Use the available TC macros instead of 0x.
>
> Signed-off-by: Roi Dayan
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
Hi Kevin,
Thank you for the patch.
You can add 'tested by' as I verified the behavior in my test setup.
Regards
_Sugesh
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Friday, June 9, 2017 5:38 PM
> To: d...@openvswitch.org
> Cc: Chandran, Sugesh
Rx checksum offload is enabled by default on DPDK NICs where
supported. Previously Rx checksum offload not supported was
logged only once. It meant that if multiple NICs did not
support Rx checksum offload, it was only reported for the
first NIC configured.
Fixes: 1a2bb11817a4 ("netdev-dpdk:
On Fri, May 26, 2017 at 11:19:46AM -0700, Joe Stringer wrote:
> On 25 May 2017 at 16:21, Anand Kumar wrote:
> > - Minimum valid fragment size is 400 bytes, any fragment smaller
> > is likely to be intentionally crafted.
>
> This seems arbitrary and surprising. Is there
Rx checksum offload is enabled by default on DPDK physical NICs
where available, with reconfiguration through
options:rx-checksum-offload. However, changing rx-checksum-offload
did not result in a reconfiguration of the NIC and wrong status is
reported for it.
As there seems to be diminishing
V5:
- Update commit message for 2/2.
V4:
- Drop V3 2/2 as applied.
- Add new 2/2 to change logging.
- Add Darrell's Acked-by to 1/2, as comment addressed in 2/2.
V3: After tests by Sugesh and discussion on ML, drop the Rx checksum
offload reconfig option.
V2: Added 3/3 to refactor Rx
On 6/9/17, 6:41 AM, "Aaron Conole" wrote:
Hi Sean, and Mark,
"Mooney, Sean K" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Thursday, June 8, 2017 8:12 PM
>> To:
Las 4 C’s: curiosidad, confianza, coraje y constancia
La Creatividad de Disney
OBJETIVOS:
- Diseñar modelos de servicio y atención por medio del uso de la creatividad
que tenía Walt Disney y que lo llevó a la innovación.
- Comprenderán técnicas comprobadas de innovación y calidad en el
On 06/09/2017 05:06 PM, Darrell Ball wrote:
>
>
> On 6/9/17, 4:51 AM, "Kevin Traynor" wrote:
>
> Rx checksum offload is enabled by default on DPDK NICs where
> supported. Previously Rx checksum offload not supported was
> logged on first configure only. The
On 6/9/17, 4:51 AM, "Kevin Traynor" wrote:
Rx checksum offload is enabled by default on DPDK NICs where
supported. Previously Rx checksum offload not supported was
logged on first configure only. The DPDK port may be configured
multiple times so log on each
On 8 June 2017 at 20:44, Yin Lin wrote:
> From: Anand Kumar
>
> Add support for parsing netlink attributes related to NAT
> in conntrack.
>
> Co-Authored-by: Anand Kumar
> Co-Authored-by: Darrell Ball
>
The daemon is killed leaving resources behind when a test fails.
This fixes to first signal the daemon to exit gracefully.
Fixes: 0f28164be02ac ("netdev-linux: make tap devices persistent")
Suggested-by: Joe Stringer
Co-authored-by: Ben Pfaff
Signed-off-by: Flavio
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 26, 2017 2:21 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH]
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Yin Lin
> Sent: Friday, June 9, 2017 6:44 AM
> To: d...@openvswitch.org
> Cc: Yin Lin
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Yin Lin
> Sent: Friday, June 9, 2017 6:44 AM
> To: d...@openvswitch.org
> Cc: Yin Lin
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Yin Lin
> Sent: Friday, June 9, 2017 6:44 AM
> To: d...@openvswitch.org
> Cc: Yin Lin
No worries.
Let's get them in for the moment and fix them in incremental patches.
Thanks,
Alin.
> -Original Message-
> From: Yin Lin [mailto:li...@vmware.com]
> Sent: Friday, June 9, 2017 6:29 AM
> To: Alin Serdean ;
> d...@openvswitch.org; Sairam
On 8 June 2017 at 14:39, Ben Pfaff wrote:
> On Thu, Jun 08, 2017 at 02:05:05PM +, majop...@redhat.com wrote:
> > From: Miguel Angel Ajo
> >
> > This patch handles multiple gateways with priorities in chassisredirect
> > ports, any gateway with a chassis
> -Original Message-
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Friday, June 9, 2017 2:42 PM
> To: Mooney, Sean K ; Kavanagh, Mark B
>
> Cc: Kevin Traynor ; d...@openvswitch.org; Darrell
> Ball
Hi Kevin,
The changes are LGTM!
I have also verified in my test setup that, the checksum is reported correctly
by the NIC for the tunneling.
Regards
_Sugesh
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Friday, June 9, 2017 12:52 PM
> To:
Hi,
We have updated our Nimble users list and thought you would be interested in
receiving fresh and accurate contacts for your marketing campaign. We
provide data across the globe so you can target your audience and reach to a
wider market and increase your lead flow.
We can filter the
Hi Sean, and Mark,
"Mooney, Sean K" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Thursday, June 8, 2017 8:12 PM
>> To: Kevin Traynor
>> Cc: d...@openvswitch.org; Darrell Ball ;
As an addition to this, I've uploaded the tests here:
https://github.com/mangelajo/ovs/commit/065ddf514167eb6da871813786e5615f0bf811ba#diff-97d4cf929e4894ef95c4bfde3f896c34
I will send-mail that change on next version.
On Thu, Jun 8, 2017 at 4:05 PM, wrote:
> From: Miguel
DPDK provides an API to set the MTU of compatible physical devices -
rte_eth_dev_set_mtu(). Prior to DPDK v16.07 however, this API was not
implemented in some DPDK PMDs (i40e, specifically). To allow the use
of jumbo frames with affected NICs in OvS-DPDK, MTU configuration was
achieved by setting
>From: sai kiran [mailto:kirans...@gmail.com]
>Sent: Friday, June 9, 2017 12:41 PM
>To: Kavanagh, Mark B
>Cc: ovs-dev@openvswitch.org
>Subject: Re: [ovs-dev] Vhostuser ports - Jumbo MTU issue
>
>Hi Mark,
>
>Like you suggested, rebuilding the database configuration with
Rx checksum offload is enabled by default on DPDK physical NICs
where available, with reconfiguration through
options:rx-checksum-offload. However, changing rx-checksum-offload
did not result in a reconfiguration of the NIC and wrong status is
reported for it.
As there seems to be diminishing
V4:
- Drop V3 2/2 as applied.
- Add new 2/2 to change logging.
- Add Darrell's Acked-by to 1/2, as comment addressed in 2/2.
V3: After tests by Sugesh and discussion on ML, drop the Rx checksum
offload reconfig option.
V2: Added 3/3 to refactor Rx checksum config code and make generic.
Hi Mark,
Like you suggested, rebuilding the database configuration with the command
you mentioned solved the issue.
Thanks very much for your inputs.
Regards,
Sai kiran
On Thu, Jun 8, 2017 at 6:10 PM, Kavanagh, Mark B
wrote:
>
>
> >-Original Message-
>
On 06/09/2017 02:16 AM, Darrell Ball wrote:
> oops, I did notice a minor issue with the original code moved to the _init
> function
> in this patch; in theory, it should be a separate patch.
>
Thanks for reviewing. yeah, I agree any changes to the how it's logged
should be a separate patch.
>
> -Original Message-
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Thursday, June 8, 2017 8:12 PM
> To: Kevin Traynor
> Cc: d...@openvswitch.org; Darrell Ball ; Loftus, Ciara
> ; Mooney, Sean K
I'd like this feature to be considered for OVS 2.8,
I know the deadline for branching is close, but this would let us implement
l3ha on the networking-ovn side, closing one of the gaps we have
with the reference implementation now.
Best regards,
Miguel Ángel
On Fri, Jun 9, 2017 at 11:35 AM,
Thank you Ben and Guru,
I plan to generalise this work with follow up patches, to let us
setup a multiple chassis on a Logical_Router too (and hence handle it
via the l3gateway ports).
Anil Venkata is also working on a follow up patch to make sure
gARPs are only announced on the
This is a follow up patch for an earlier patch send by Cascardo,
however I think this patch might not be needed...
This patch will make sure VXLAN tunnels with and without the group
based policy (gbp) option enabled can not coexist on the same
destination udp port.
However the interface ports
On 03/06/17 16:09, Aaron Conole wrote:
> Under rpm based distributions, the only user:group that the rhel daemons run
> as is 'root:root'. This is fine as a default, but as part of a security
> procedure, users may want to run as an alternate uid/gid. This commit
> adds an OVS_USER_ID
>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
>On Behalf Of
>Ben Pfaff
>Sent: Thursday, June 8, 2017 10:34 PM
>To: Darrell Ball
>Cc: d...@openvswitch.org; Flavio Leitner
>Subject: Re: [ovs-dev] [PATCH v2] dpdk: announce
On 07/06/17 22:00, Flavio Leitner wrote:
> On Sat, Jun 03, 2017 at 11:09:58AM -0400, Aaron Conole wrote:
>> Currently, the db lockfile will cause the openvswitch directory to
>> linger after uninstall because the rpm database isn't aware that it
>> should be treated as part of the system. This
commit 49a3592b2878a33033e5fd2e6e5ce82ebccef780
Author: Satya Valli
OpenVswitch: OF1.5/EXT-334 Extensible Flow Entry Statistics
OpenFlow 1.5 introduces the Extensible Statistics (OXS) by redefining the
existing
flow entry statistics with OXS Fields.
This Patch provides
Some pmd driver(e.g: vNIC thunderx PMD) want mbuf_size to be multiple of
cache_line_size. With out this fix, Netdev-dpdk initialization would
fail for those PMD.
Signed-off-by: Santosh Shukla
---
v1 --> v2
- Removed mtu to dmp->mtu change in v2.
- Removed
69 matches
Mail list logo