Re: [ovs-dev] [PATCH v10] netdev-dpdk: Increase pmd thread priority.

-Original Message- From: "Bodireddy, Bhanuprakash" Date: Monday, June 26, 2017 at 5:56 AM To: Darrell Ball , "d...@openvswitch.org" Subject: RE: [ovs-dev] [PATCH v10] netdev-dpdk: Increase pmd thread priority.

Re: [ovs-dev] [PATCH v3] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

Ping Thanks Zhenyu Gao 2017-07-17 10:39 GMT+08:00 Zhenyu Gao : > Sendmmsg can reduce cpu cycles in sending packets to kernel. > Replace sendmsg with sendmmsg in function netdev_linux_send to send > batch packets if sendmmsg is available. > > If kernel side doesn't

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On 26 July 2017 at 17:33, Russell Bryant wrote: > On Wed, Jul 26, 2017 at 8:28 PM, Russell Bryant wrote: >> On Wed, Jul 26, 2017 at 5:45 PM, Joe Stringer wrote: >>> On 26 July 2017 at 13:32, Russell Bryant wrote: On Wed, Jul

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On Wed, Jul 26, 2017 at 8:28 PM, Russell Bryant wrote: > On Wed, Jul 26, 2017 at 5:45 PM, Joe Stringer wrote: >> On 26 July 2017 at 13:32, Russell Bryant wrote: >>> On Wed, Jul 26, 2017 at 4:29 PM, Lance Richardson >>>

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On Wed, Jul 26, 2017 at 5:45 PM, Joe Stringer wrote: > On 26 July 2017 at 13:32, Russell Bryant wrote: >> On Wed, Jul 26, 2017 at 4:29 PM, Lance Richardson >> wrote: From: "Russell Bryant" To: d...@openvswitch.org

[ovs-dev] Despedir Empleados en el Marco de la Ley

En línea y en Vivo / Para todo su Equipo con una sola Conexión Cómo Despedir Empleados en el Marco de la Ley 16 de agosto - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00Hrs Despedir a una persona es un delicado proceso invadido de “bombas” legales. No importa qué tan preparado se

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Run the 'dmesg' command without condition.

On 07/25/2017 12:23 AM, Gurucharan Shetty wrote: Currently we look for files with the name of "dmesg" in "/var/log". If it exists, we don't run the command "dmesg". This is unreliable as the file does not always contain the latest dmesg information. Since OVS kernel module emits information to

Re: [ovs-dev] [PATCH 1/2] ovs-bugtool: Collect OVS logs with "--ovs" option.

On 07/25/2017 12:23 AM, Gurucharan Shetty wrote: ovs-bugtool collects a lot of data. This can be time consuming and can end up collecting a lot of redundant data. A option "--ovs" was added a while ago to only collect OVS relevent data. We missed adding the OVS logs to this filter.

Re: [ovs-dev] [PATCH] system-userspace-macros: Fix ethtool with new kernels.

On 26 July 2017 at 14:46, Joe Stringer wrote: > On 26 July 2017 at 13:19, Andy Zhou wrote: >> On Wed, Jul 26, 2017 at 12:49 PM, Joe Stringer wrote: >>> The latest net-next kernels have removed the UFO feature, which results >>> in older ethtool

Re: [ovs-dev] [PATCH V2] datapath: fix potential out of bound access in parse_ct

On 25 July 2017 at 08:40, Greg Rose wrote: > Upstream commit: > commit 69ec932e364b1ba9c3a2085fe96b76c8a3f71e7c > Author: Liping Zhang > Date: Sun Jul 23 17:52:23 2017 +0800 > > openvswitch: fix potential out of bound access in

Re: [ovs-dev] [PATCH] system-userspace-macros: Fix ethtool with new kernels.

On 26 July 2017 at 13:19, Andy Zhou wrote: > On Wed, Jul 26, 2017 at 12:49 PM, Joe Stringer wrote: >> The latest net-next kernels have removed the UFO feature, which results >> in older ethtool reporting the following error: >> >> Cannot get device

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On 26 July 2017 at 13:32, Russell Bryant wrote: > On Wed, Jul 26, 2017 at 4:29 PM, Lance Richardson wrote: >>> From: "Russell Bryant" >>> To: d...@openvswitch.org >>> Sent: Thursday, 20 July, 2017 8:23:21 PM >>> Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] dpif: Refactor obj type from void pointer to dpif_class

On 24 July 2017 at 22:28, Roi Dayan wrote: > It's basically what is being passed today and passing a specific > type adds a compiler type check. > > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey Acked-by: Joe Stringer

Re: [ovs-dev] [PATCH 1/2] ovn: Add lsp-set-dhcpv6-options ovn-nbctl operation.

On Wed, Jul 26, 2017 at 3:22 PM Russell Bryant wrote: > On Wed, Jul 26, 2017 at 10:17 AM, Mark Michelson > wrote: > > OVN offers a shortcut to set DHCPv4 options on a logical switch port, > > but it did not offer the same for DHCPv6. This commit adds a

[ovs-dev] [PATCH v2 3/3] ovn: Update ovn-nbctl manpage with DHCP lsp commands.

This adds the appropriate manpage entries for ovn-nbctl for lsp-set-dhcpv4-options lsp-get-dhcpv4-options lsp-set-dhcpv6-options lsp-get-dhcpv4-options Signed-off-by: Mark Michelson --- ovn/utilities/ovn-nbctl.8.xml | 22 ++ 1 file changed, 22

[ovs-dev] [PATCH v2 2/3] tests: Use ovn-nbctl lsp-set-dhcpvX-options

Existing OVN tests manually added DHCP options to the Logical_Switch_Port database. There is a shortcut CLI command for doing the same thing, so we may as well use it and get the extra test coverage as a result. Signed-off-by: Mark Michelson --- tests/ovn.at | 31

[ovs-dev] [PATCH v2 1/3] ovn: Add lsp-set-dhcpv6-options ovn-nbctl operation.

OVN offers a shortcut to set DHCPv4 options on a logical switch port, but it did not offer the same for DHCPv6. This commit adds a similar option for DHCPv6. Signed-off-by: Mark Michelson --- ovn/utilities/ovn-nbctl.c | 45 + 1

Re: [ovs-dev] [PATCH] ovn-northd: Optimize acl of localnet-port

On Sun, Jul 9, 2017 at 9:51 PM, wrote: > Localnet port is not an endpoint, and have no security requirements > to use localnet port at present. So, for performance consideration, we > could do not use ct for localnet port. > > The more specific discussion can be found

[ovs-dev] [PATCH v2] ovn: Restrict encap modification to its creating chassis

This patch extends RBAC restrictiveness of the encap table in the ovn southbound database by only allowing modification by the chassis that created the encap. Signed-off-by: Mark Michelson Reported-by: Lance Richardson --- ovn/controller/chassis.c | 1

[ovs-dev] [PATCH] ovn: Add support for ACL logging.

Signed-off-by: Justin Pettit --- NEWS| 1 + include/ovn/actions.h | 67 --- ovn/controller/ovn-controller.8.xml | 9 +++ ovn/controller/pinctrl.c| 38 +++ ovn/lib/actions.c

Re: [ovs-dev] [PATCH] dpif-netdev: Reorder elements in dp_netdev_port structure.

On 07/24/2017 09:18 PM, Bhanuprakash Bodireddy wrote: By reordering the elements in dp_netdev_port structure, pad bytes can be reduced there by saving a cache line. Marginal performance improvement is also observed with this change. Before: structure size: 136, holes: 7, sum padbytes:7,

Re: [ovs-dev] [PATCH 4/4] checkpatch: Print commit hashes and names.

On Fri, Jul 14, 2017 at 6:57 AM, Ilya Maximets wrote: > It's better to see real commits instead of 'HEAD~n'. > > Signed-off-by: Ilya Maximets > --- > utilities/checkpatch.py | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-)

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On Wed, Jul 26, 2017 at 4:29 PM, Lance Richardson wrote: >> From: "Russell Bryant" >> To: d...@openvswitch.org >> Sent: Thursday, 20 July, 2017 8:23:21 PM >> Subject: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx >> theme. >> >>

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

> From: "Russell Bryant" > To: d...@openvswitch.org > Sent: Thursday, 20 July, 2017 8:23:21 PM > Subject: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx > theme. > > Update the log message emitted when the OVS sphinx theme is not found > to reference the

Re: [ovs-dev] [PATCH] system-userspace-macros: Fix ethtool with new kernels.

On Wed, Jul 26, 2017 at 12:49 PM, Joe Stringer wrote: > The latest net-next kernels have removed the UFO feature, which results > in older ethtool reporting the following error: > > Cannot get device udp-fragmentation-offload settings: Operation not > supported > > Currently, we

Re: [ovs-dev] [PATCH] ovn: Restrict encap modification to its creating chassis

A couple of suggestions inline -- On Wed, Jul 26, 2017 at 9:07 AM, Lance Richardson wrote: >> From: "Mark Michelson" >> To: d...@openvswitch.org >> Sent: Friday, 21 July, 2017 4:44:50 PM >> Subject: [ovs-dev] [PATCH] ovn: Restrict encap modification to

Re: [ovs-dev] [PATCH] ovn-controller: avoid null ptr dereference

On Wed, Jul 26, 2017 at 3:47 PM, Lance Richardson wrote: > Avoid null pointer dereference in fdb_calculate_active_tunnels() > when integration bridge isn't present. This is easily encountered > by executing "make sandbox SANDBOXFLAGS=--ovn". > > Fixes: 3475695ea61c ("ovn:

[ovs-dev] [PATCH] system-userspace-macros: Fix ethtool with new kernels.

The latest net-next kernels have removed the UFO feature, which results in older ethtool reporting the following error: Cannot get device udp-fragmentation-offload settings: Operation not supported Currently, we rely on no errors being reported, and if there is an error then a failure is

[ovs-dev] [PATCH] ovn-controller: avoid null ptr dereference

Avoid null pointer dereference in fdb_calculate_active_tunnels() when integration bridge isn't present. This is easily encountered by executing "make sandbox SANDBOXFLAGS=--ovn". Fixes: 3475695ea61c ("ovn: l3ha, enable bfd between tunnel endpoints") Signed-off-by: Lance Richardson

Re: [ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

On Tue, Jul 25, 2017 at 11:44 AM, Andy Zhou wrote: > Thanks. I have pushed the series to master. > > While applying the patches. I noticed a minor issue and sent a follow > up patch at: > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html > > Will consider back

Re: [ovs-dev] [PATCH] bond: Adjust bond hash masks

On Wed, Jul 26, 2017 at 12:06 AM, Ilya Maximets wrote: > On 25.07.2017 21:39, Andy Zhou wrote: >> Commit 42781e77035d (bond: Unify hash functions in hash action and entry >> lookup.) changed the BM_TCP's hash function, but did not update >> hash mask fields accordingly.

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

Darrell Ball writes: > Hi Aaron > > You had mentioned that you would be testing with the patch as well. > Were you able to try it ? I did some limited testing, with single queue and VM-to-VM traffic only (no dpdk physical ports). That seemed to work, but I trust Ian's and

Re: [ovs-dev] Revisit OVN meeting schedule?

rview of time zone > >overlap of some of our contributors. > > > >https://www.timeanddate.com/worldclock/meetingtime.html? > iso=20170726=1082=54=141=405=224 > > > >2) Consider a rotating schedule, where we have 2 different meeting > >times that rotate each week. I c

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Kavanagh, Mark B > Sent: Wednesday, July 26, 2017 4:03 PM > To: Aaron Conole > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4] Update

[ovs-dev] [PATCH RFC v2 4/4] dpif-netdev: Time based output batching.

This allows to collect packets from more than one RX burst and send them together with a configurable maximum latency. 'other_config:output-max-latency' can be used to configure time that a packet can wait in output batch for sending. Signed-off-by: Ilya Maximets ---

[ovs-dev] [PATCH v2 3/4] netdev: Remove useless cutlen.

Cutlen already applied while processing OVS_ACTION_ATTR_OUTPUT. Signed-off-by: Ilya Maximets --- lib/netdev-bsd.c | 3 --- lib/netdev-dpdk.c | 5 - lib/netdev-dummy.c | 2 -- lib/netdev-linux.c | 3 --- 4 files changed, 13 deletions(-) diff --git

[ovs-dev] [PATCH v2 2/4] netdev: Remove unused may_steal.

Not needed anymore because 'may_steal' already handled on dpif-netdev layer and always true; Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 2 +- lib/netdev-bsd.c | 4 ++-- lib/netdev-dpdk.c | 25 +++-- lib/netdev-dummy.c| 4

[ovs-dev] [PATCH v2 0/4] Output packet batching.

This patch-set inspired by [1] from Bhanuprakash Bodireddy. Implementation of [1] looks very complex and introduces many pitfalls for later code modifications like possible packet stucks. This version targeted to make simple and flexible output packet batching on higher level without introducing

[ovs-dev] [PATCH v2 1/4] dpif-netdev: Output packet batching.

While processing incoming batch of packets they are scattered across many per-flow batches and sent separately. This becomes an issue while using more than a few flows. For example if we have balanced-tcp OvS bonding with 2 ports there will be 256 datapath internal flows for each dp_hash

Re: [ovs-dev] Revisit OVN meeting schedule?

e to accommodate more contributors. My suggestion to >consider would be 8am Pacific / 11am Eastern (meeting 2 hours earlier >than currently). See the following page for an overview of time zone >overlap of some of our contributors. > >https://www.timeanddate.com/worldclock/meetingti

[ovs-dev] Revisit OVN meeting schedule?

(meeting 2 hours earlier than currently). See the following page for an overview of time zone overlap of some of our contributors. https://www.timeanddate.com/worldclock/meetingtime.html?iso=20170726=1082=54=141=405=224 2) Consider a rotating schedule, where we have 2 different meeting times

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

>From: Aaron Conole [mailto:acon...@redhat.com] >Sent: Wednesday, July 26, 2017 3:25 PM >To: Kavanagh, Mark B >Cc: Weglicki, MichalX ; d...@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for >DPDK

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

"Kavanagh, Mark B" writes: >>From: Weglicki, MichalX >>Sent: Wednesday, July 26, 2017 10:52 AM >>To: Kavanagh, Mark B ; d...@openvswitch.org >>Subject: RE: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for >>DPDK 17.05.1. >>

[ovs-dev] [PATCH 2/2] tests: Use ovn-nbctl lsp-set-dhcpvX-options

Existing OVN tests manually added DHCP options to the Logical_Switch_Port database. There is a shortcut CLI command for doing the same thing, so we may as well use it and get the extra test coverage as a result. Signed-off-by: Mark Michelson --- tests/ovn.at | 31

[ovs-dev] [PATCH 1/2] ovn: Add lsp-set-dhcpv6-options ovn-nbctl operation.

OVN offers a shortcut to set DHCPv4 options on a logical switch port, but it did not offer the same for DHCPv6. This commit adds a similar option for DHCPv6. Signed-off-by: Mark Michelson --- ovn/utilities/ovn-nbctl.c | 42 ++ 1 file

[ovs-dev] [PATCH 0/2] Rectify some DHCPv4 and DHCPv6 differences.

Whlie trying to set up a tutorial for someone about using IPv6 and DHCP, I found that there was no equivalent DHCPv6 command for 'ovn-nbctl lsp-set-dhcpv4-options'. This patch set rectifies the situation by adding the equivalent DHCPv6 command, as well as using the DHCP commands in the testsuite.

[ovs-dev] [PATCH] ovs-ctl: Remove a leftover restore_interfaces in restart

Since commit c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.") the kernel configuration of the specified network interfaces is not saved anymore for restart command so there is no need to try to restore it. CC: Ben Pfaff Fixes: c416eaf8c247

Re: [ovs-dev] [PATCH] ovn: Restrict encap modification to its creating chassis

> From: "Mark Michelson" > To: d...@openvswitch.org > Sent: Friday, 21 July, 2017 4:44:50 PM > Subject: [ovs-dev] [PATCH] ovn: Restrict encap modification to its creating > chassis > > This patch extends RBAC restrictiveness of the encap table in > the ovn southbound

Re: [ovs-dev] [PATCH RFC 2/4] dpif-netdev: Skip EMC lookup/insert for recirculated packets.

Thanks for your feedback, good to see this could follow up with some further solutions. In the meantime - based also on your suggestions - I posted a v2 of this patch at https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335940.html It's in a patchset that begins at

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

Hi. You need to backport at least following patch: commit 3b1fb0779b87788968c1a6a9ff295a9883547485 Author: Daniele Di Proietto Date: Tue Nov 15 15:40:49 2016 -0800 netdev-dpdk: Don't call rte_dev_stop() in update_flags(). Calling rte_eth_dev_stop() while

Re: [ovs-dev] [PATCH v3] netdev: check for NULL fields in netdev_get_addrs

> From: "Daniel Alvarez" > To: d...@openvswitch.org > Sent: Friday, 21 July, 2017 11:28:24 AM > Subject: [ovs-dev] [PATCH v3] netdev: check for NULL fields in > netdev_get_addrs > > When the interfaces list is retrieved through getiffaddrs(), there > might be

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

Hi, This patch was supposed to be v2, but I forgot to mention that in the subject. Previous version: https://patchwork.ozlabs.org/patch/792730/ Let me know if you want me to re-sent it with a proper version. Regards, Przemek > -Original Message- > From: Szczerbik, PrzemyslawX > Sent:

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

>From: Weglicki, MichalX >Sent: Wednesday, July 26, 2017 10:52 AM >To: Kavanagh, Mark B ; d...@openvswitch.org >Subject: RE: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for >DPDK 17.05.1. > >Hey Mark, > >Sorry, I had some problems with rebase, and

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

Hey Mark, Sorry, I had some problems with rebase, and somehow I just simply forgot t to do so. Do you want me to re-apply this patch as v5? > -Original Message- > From: Kavanagh, Mark B > Sent: Wednesday, July 26, 2017 10:04 AM > To: Weglicki, MichalX ;

[ovs-dev] [PATCH 1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr

This commit extends netdev_dpdk_get_status API to include additional driver-related information: if_type and if_descr. Signed-off-by: Przemyslaw Szczerbik --- lib/netdev-dpdk.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

Extend flow key part of data record to include following Information Elements: - ingressInterface - ingressInterfaceType - egressInterface - egressInterfaceType - interfaceName - interfaceDescription In case of input sampling we don't have information about egress port. Define templates depending

Re: [ovs-dev] [PATCH 1/4] dpif-netdev: Avoid reading RSS hash when EMC is disabled.

Hi Antonio, Ok, I guess you can't argue with performance! I look forward to the next rev. No further comments below. /Billy > -Original Message- > From: Fischetti, Antonio > Sent: Wednesday, July 19, 2017 4:59 PM > To: Fischetti, Antonio ; O Mahony, Billy >

Re: [ovs-dev] [PATCH RFC 2/4] dpif-netdev: Skip EMC lookup/insert for recirculated packets.

Hi Antonio, > -Original Message- > From: Fischetti, Antonio > Sent: Friday, June 23, 2017 10:49 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH RFC 2/4] dpif-netdev: Skip EMC lookup/insert > for recirculated packets. > > Thanks a

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

>-Original Message- >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] >On Behalf Of Michal Weglicki >Sent: Tuesday, July 25, 2017 1:35 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for >DPDK 17.05.1. >

Re: [ovs-dev] [PATCH v2 2/3] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

On 26.07.2017 02:33, Darrell Ball wrote: > > > -Original Message- > From: Ilya Maximets > Date: Monday, July 24, 2017 at 4:58 AM > To: Darrell Ball , "d...@openvswitch.org" > > Cc: Heetae Ahn ,

Re: [ovs-dev] [PATCH] bond: Adjust bond hash masks

On 25.07.2017 21:39, Andy Zhou wrote: > Commit 42781e77035d (bond: Unify hash functions in hash action and entry > lookup.) changed the BM_TCP's hash function, but did not update > hash mask fields accordingly. Found by inspection. > > CC: Ilya Maximets > Signed-off-by: