Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On 11/11/2017 9:57 AM, William Tu wrote: yes, this is an artificial dependency. Another way I'm thinking is for ovs-vswitchd to hold the geneve.ko dependency instead of openvswitch.ko, when user creates a geneve device. Is there a way to do that through rtnetlink or at

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

>> yes, this is an artificial dependency. Another way I'm thinking is for >> ovs-vswitchd >> to hold the geneve.ko dependency instead of openvswitch.ko, when user >> creates >> a geneve device. Is there a way to do that through rtnetlink or at >> dpif_netlink_rtnl_create()? > > It should be

Re: [ovs-dev] [PATCH] dpif-netdev: Remove unnecessary resets on new rxqs.

On 11/10/2017 11:42 PM, Kevin Traynor wrote: 38259bd7eb21 added a memset for the dp_netdev_rxq of new rxq's to remove a valgrind warning. Since it is all set to 0, we can remove explicit reset of some fields. Signed-off-by: Kevin Traynor --- lib/dpif-netdev.c | 7 ---

[ovs-dev] [PATCH] ovs-ctl: Don't remember vport-* kernel modules

>From OVS 2.8, ovs-vswitchd, when it starts, will load the kernel modules for tunnels. It has logic inside it to choose either upstream kernel module or vport-* kernel module. So, when we run 'force-reload-kmod' to upgrade to OVS 2.8 from a previous version, we do not need to remember the

[ovs-dev] [PATCH] ovs-tcpdump: handle large interface names on linux

Linux has a fixed size interface name, which will not change. This means that attempts to dump interfaces whose names are larger than the max size will result in an error making the tap device. This commit brings a new function. When the generated name would be too large, use a random number

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Fri, Nov 10, 2017 at 10:01:29AM -0800, William Tu wrote: > On Fri, Nov 10, 2017 at 7:54 AM, Eric Garver wrote: > > On Fri, Nov 10, 2017 at 05:36:25AM -0800, William Tu wrote: > >> Before we introduce dpif-netlink-rtnl, creating a tunnel device > >> depends on openvswitch/vport

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Fri, Nov 10, 2017 at 12:23:37PM -0800, William Tu wrote: > >> After the dpif-netlink-rtnl, a tunnel device can be created by using > >> rtnetlink, so the creation of fb device comes from the ovs-vswitchd > >> instead of going through OVS kernel modules. This breaks the module > >> dependency

Re: [ovs-dev] [PATCH] netdev-dpdk: replace uint8_t with dpdk_port_t

> > >From: Ilya Maximets [mailto:i.maxim...@samsung.com] > > >Sent: Tuesday, October 31, 2017 6:46 AM > > >To: Kavanagh, Mark B ; d...@openvswitch.org > > >Subject: Re: [ovs-dev][PATCH] netdev-dpdk: replace uint8_t with > > >dpdk_port_t > > > > > >Thanks. I wanted to

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with negative vid.

> I couldn't recreate the issue on x86 but after testing with vhostuser and > vhostuserclient for a few scenarios such as client, server reconnect and > multi-queue I didn't find any problems with this patch. > > Tested-by: Billy O'Mahony > Acked-by: Billy O'Mahony

Re: [ovs-dev] [PATCH v3 0/3] netdev-dpdk: mempool management: Leaks & Refactoring.

> Fixed memory leak in mempool management code + a big clean up. > > First patch is simple fix for leaks while the second one simplifies the > whole mempool management by removing redundant struct dpdk_mp. > > To be honest, patch #2 removes all the buggy conditions fixed in the first > patch,

[ovs-dev] Conceptos obligatorios y opcionales

Actualice sus conocimientos en materia fiscal y cumpla con las disposiciones del SAT CFDI de Nóminas 17 de noviembre - Mtro. David Lozada Martínez9am-8pm La Reforma Fiscal del año 2014 trajo consigo la modificación del artículo 99 en su fracción III de la Ley del Impuesto sobre la Renta,

[ovs-dev] Fall into Savings - Get 20% off until November 21st.

Enroll your OSHA training at 20% Discount with PROMO CODE: RES20! OSHA Authorized Training: - OSHA 10 Hour Construction - OSHA 30 Hour Construction - OSHA 10 Hour General Industry - OSHA 30 Hour General Industry After completion receive your OSHA DOL wallet card. Our course library includes

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Fri, Nov 10, 2017 at 7:54 AM, Eric Garver wrote: > On Fri, Nov 10, 2017 at 05:36:25AM -0800, William Tu wrote: >> Before we introduce dpif-netlink-rtnl, creating a tunnel device >> depends on openvswitch/vport kernel module calling kernel's tunnel API. >> Example call sequence:

Re: [ovs-dev] [PATCH v3 2/2] OVN: Add support for periodic router advertisements.

Hi Mark, A couple more things caught my attention. Otherwise than that it LGTM. On Fri, Nov 03, 2017 at 09:24 PM GMT, Mark Michelson wrote: > This change adds three new options to the Northbound > Logical_Router_Port's ipv6_ra_configs option: > > * send_periodic: If set to "true", then OVN will

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On 10 November 2017 at 07:54, Eric Garver wrote: > On Fri, Nov 10, 2017 at 05:36:25AM -0800, William Tu wrote: > > Before we introduce dpif-netlink-rtnl, creating a tunnel device > > depends on openvswitch/vport kernel module calling kernel's tunnel API. > > Example call sequence:

Re: [ovs-dev] [PATCH] datapath: compat: fix kernel module reference count.

On Fri, Nov 10, 2017 at 05:36:25AM -0800, William Tu wrote: > Before we introduce dpif-netlink-rtnl, creating a tunnel device > depends on openvswitch/vport kernel module calling kernel's tunnel API. > Example call sequence: > 1) ovs_vport_add (openvswitch.ko) > 2) geneve_create

[ovs-dev] [PATCH v3 2/3] netdev-dpdk: Factor out struct dpdk_mp.

Since commit d555d9bded5f ("netdev-dpdk: Create separate memory pool for each port."), struct dpdk_mp is redundant because each mempool can be used by single port only and this port already contains all the information we store in dpdk_mp. There is no need to duplicate the information. Fields of

[ovs-dev] [PATCH v3 0/3] netdev-dpdk: mempool management: Leaks & Refactoring.

Fixed memory leak in mempool management code + a big clean up. First patch is simple fix for leaks while the second one simplifies the whole mempool management by removing redundant struct dpdk_mp. To be honest, patch #2 removes all the buggy conditions fixed in the first patch, but I think that

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: Remove unused MAX_NB_MBUF.

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, November 7, 2017 1:33 PM > To: ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Fischetti, Antonio > ; Loftus, Ciara ; >

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix dpdk_mp leak in case of EEXIST.

Hi Ilya, Patch looks OK to me and I'm running validation before adding itto the DPDK merge branch, one nit, would you mind re-submitting and expanding the commit message to summarize why the change is needed to keep with OVS commit message policy.

Re: [ovs-dev] [PATCH v2 0/3] Add dpif support for ct_clear action

On Thu, Oct 26, 2017 at 03:30:41PM -0400, Eric Garver wrote: > This series adds dpif support for OVS_ACTION_ATTR_CT_CLEAR. Previously the > ct_clear action was a userspace only operation, but it has use cases in the > dpif as well. Namely changing a packet's tuple after a ct() lookup has >

Re: [ovs-dev] ovs-tcpdump error

"Bodireddy, Bhanuprakash" writes: >>Aaron Conole writes: >> >>> Hi Bhanu, >>> >>> "Bodireddy, Bhanuprakash" writes: >>> Hi, ovs-tcpdump throws the below error when trying to capture

[ovs-dev] [PATCH] Upcall/Slowpath rate limiter for OVS

In OVS-DPDK, both fast-path and slow-path execute in the context of a common thread (i.e, PMD thread), without any partitioning of CPU cycles between the two. When there is a burst of new flows coming into the data-path, packets are punted to slow-path in the order they are received and the PMD is

Re: [ovs-dev] ovs-tcpdump error

>Aaron Conole writes: > >> Hi Bhanu, >> >> "Bodireddy, Bhanuprakash" writes: >> >>> Hi, >>> >>> >>> >>> ovs-tcpdump throws the below error when trying to capture packets on >>> one of the vhostuserports. >>> >>> >>> >>> $ ovs-tcpdump -i

Re: [ovs-dev] [PATCH 3/2] vswitchd: Document netdev-dpdk commands.

> On 09.11.2017 17:02, Flavio Leitner wrote: > > > > Hi Ilya, > > > > This patch is doing two things. If we need to revert the mempool > > stuff, it will impact on everything on top of the documentation > > refactoring. > > > > I think the refactoring looks easier for Ian to get in. > > > > I