[ovs-dev] [patch v2] conntrack: Fix alg expectation cleanup.

Presently, alg expectations are removed by being time expired. This was intended to happen before the control connections and was intended to minimize the extra work involved for tracking and removing the expectations. This is not the best option and conceptually an expectation should not exist

[ovs-dev] [PATCH v5 4/4] unaligned.h: Fixed C++ compilation issue due to designated initializers

This change fixes compilation issues related to designated initializers, which are not supported by C++ compiler. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Sairam Venugopal Co-authored-by: Sairam Venugopal ---

[ovs-dev] [PATCH v5 3/4] Windows: Changing explicit typecasts to fix C++ compilation issues

C++ compiler cannot find matching function calls due to unsupported implicit conversions. This change adds appropriate explicit typecasts to match the existing function prototypes. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Sairam Venugopal

[ovs-dev] [PATCH v5 2/4] lib: Adding explicit typecasts to fix C++ compilation issues

C++ does not allow implicit conversion from void pointer to a specific pointer type. This change adds explicit typecasts to appropriate types wherever needed. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Sairam Venugopal Co-authored-by: Sairam

[ovs-dev] [PATCH v5 1/4] Windows: Fixing Windows C++ compilation issues with unnamed structure

MSVC does not allow to redefine unnamed structure in union. Thus, this fix defines the struct outside of the anonymous union in order to calculate the padded size. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Shireesh Kumar Singh

[ovs-dev] [PATCH 4/4] unaligned.h: Fixed C++ compilation issue due to designated initializers

This change fixes compilation issues related to designated initializers, which are not supported by C++ compier. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Sairam Venugopal Co-authored-by: Sairam Venugopal ---

[ovs-dev] [PATCH 3/4] Windows: Changing explicit typecasts to fix C++ compilation issues

C++ compiler cannot find matching function calls due to unsupported implicit conversions. This change adds appropriate explicit typecasts to match the existing function prototypes. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Sairam Venugopal

[ovs-dev] [PATCH 2/4] lib: Adding explicit typecasts to fix C++ compilation issues

C++ does not allow implicit conversion from void pointer to a specific pointer type. This change adds explicit typecasts to appropriate types wherever needed. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Sairam Venugopal Co-authored-by: Sairam

[ovs-dev] [PATCH 1/4] Windows: Fixing Windows C++ compilation issues with unnamed structure

MSVC does not allow to re-define unnamed structure in union. Thus, this fix defines the struct outside of the anonymous union in order to calculate the padded size. Signed-off-by: Shireesh Kumar Singh Signed-off-by: Shireesh Kumar Singh

[ovs-dev] [PATCH 0/4] Fixing C++ compiltation issues

v4: Rebased Modified commit message v3: Rebased Split patch into subparts v2: Rebased Fixed formatting erros Removed Windows specific macro Shireesh Singh (4): Windows: Fixing Windows C++ compilation issues with unnamed structure lib: Adding explicit typecasts to fix C++

[ovs-dev] [PATCH v3] Fixed C++ compilation issue due to unsupported initializer list usage

This change fixes compilation issues related to designated initializers, which are not supported by C++ compier. Signed-off-by: Shireesh Kumar Singh --- lib/unaligned.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/unaligned.h

[ovs-dev] [PATCH v3] Windows: Changing explicit typecasts to fix C++ compilation issues

C++ compiler cannot find matching function calls due to unsupported implicit conversions. This change adds appropriate explicit typecasts to match the existing function prototypes. --- lib/ovs-atomic-msvc.h | 59 +++ 1 file changed, 36

[ovs-dev] [PATCH v3] Adding explicit typecasts to fix C++ compilation issues

C++ does not allow implicit conversion from void pointer to a specific pointer type. This change adds explicit typecasts to appropriate types wherever needed. --- lib/netlink.h | 3 ++- lib/ovs-thread.h | 4 ++-- lib/packets.h | 15 ++- lib/socket-util.h | 4 ++-- 4 files

[ovs-dev] [PATCH v3] Windows: Fixing Windows C++ compilation issues with unnamed structure

MSVC does not allow to re-define unnamed structure in union. Thus, this fix defines the struct outside of the anonymous union in order to calculate the padded size. Signed-off-by: Shireesh Kumar Singh --- include/openvswitch/util.h | 14 +++--- 1 file changed, 7

[ovs-dev] Blindaje económico empresarial contra desastres

Mida y minimice el impacto económico por desastres Blindaje económico empresarial contra desastres 17 de Enero - Mtro. David Lozada Martínez - 9am-8pm Inscríbase hoy a este seminario, en el cual nuestro experto le enseñará no sólo a identificar los riesgos y sus impactos, sino a establecer

[ovs-dev] [PATCH v2] tests: add-del-add sequence for interface

Added a unit test case for testing the condition when a veth interface is added to br0 and then the veth interface is deleted from the system and added back with the same name. Signed-off-by: Ashish Varma --- v1-v2 Incorporated the comments by Yi-Hung Wei: Added

Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT parameters.

Sure, that's perfect. Thanks, Antonio > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Friday, December 15, 2017 7:23 PM > To: Fischetti, Antonio ; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3 2/5] conntrack: add

Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT parameters.

Hi Antonio Alternatively, given that most of code is rewritten, I was planning on just submitting the patches, which are in process, and adding you as co-author. Will that work for you? Thanks Darrell On 12/15/17, 11:05 AM, "Fischetti, Antonio" wrote:

Re: [ovs-dev] [PATCH v3 5/5] doc: ConnTracker cfg parameters.

Thanks Darrell and Stephen for your suggestions. I'll rework accordingly in v4. Antonio > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Monday, December 11, 2017 6:02 PM > To: Fischetti, Antonio ; > d...@openvswitch.org > Subject:

Re: [ovs-dev] [PATCH v3 2/5] conntrack: add commands to r/w CT parameters.

Thanks Darrell for your review. I agree with your comments, if we have to consider R/W commands with more than one parameter is much better to have specific functions as you explained and showed. I'll rework accordingly and post a v4. Regards, -Antonio > -Original Message- > From:

[ovs-dev] [PATCH] ovsdb-server: Drop 'txn' member from struct db.

This member was only used in one particular code path, so this commit adds code to pass it around as a function parameter instead. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-server.c | 40 1 file changed, 16 insertions(+), 24 deletions(-)

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

> On 12/15/2017 12:32 PM, Jan Scheurich wrote: > > Hi, > > > What if we have 2, 4, 10 HW NICs and a few different destinations for > traffic from VM? > What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and > just a few different packet flows? > What if we have HW NICs

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

On 12/15/2017 09:39 AM, Ilya Maximets wrote: >>> What if we have 2, 4, 10 HW NICs and a few different destinations for >>> traffic from VM? >>> What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and just a >>> few different packet flows? >>> What if we have HW NICs with small number

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

On 12/15/2017 12:32 PM, Jan Scheurich wrote: > Hi, > What if we have 2, 4, 10 HW NICs and a few different destinations for traffic from VM? What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and just a few different packet flows? What if we have HW NICs with

Re: [ovs-dev] [PATCH v3 1/8] ovsdb: Improve documentation.

On Thu, Dec 14, 2017 at 04:01:55PM -0800, Yifeng Sun wrote: > Thanks. It is a good reading and learning. I found a small issue in the > line below. > > +A boolean value, true if authorized insertions and authorized are > allowed, > > For "insertions and authorized", maybe you are saying

Re: [ovs-dev] [PATCH v3 5/8] ovsdb-client: Add new "backup" command.

On Thu, Dec 14, 2017 at 05:55:36PM -0800, Justin Pettit wrote: > > > > On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > > > diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in > > index 694a7abed46d..2e2df5e5aa7f 100644 > > --- a/ovsdb/ovsdb-client.1.in > > +++

Re: [ovs-dev] [PATCH] rhel: Add the new ovsdb manpages to %files list

On Fri, Dec 15, 2017 at 05:09:40PM +0100, Timothy Redaelli wrote: > Currently, "make rpm-fedora" doesn't work correctly since the new ovsdb > manpages (ovsdb.5, ovsdb.7 and ovsdb-server.7) were added. > > This patch adds the new ovsdb manpages in the %files list in the spec > file. > > CC: Ben

Re: [ovs-dev] [PATCH v6 8/8] NEWS: Add keepalive support information in NEWS.

I think this needs a trivial rebase, other than that it's ok. Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday, December

Re: [ovs-dev] [PATCH v6 6/8] keepalive: Add support to query keepalive status and statistics.

LGTM, Tested-by: Antonio Fischetti Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday,

Re: [ovs-dev] [PATCH v6 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

> From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ciara Loftus > Sent: Friday, 15 December, 2017 14:14 > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v6 2/2] netdev-dpdk: Enable optional dequeue zero > copy for vHost User > > Enabled per

Re: [ovs-dev] [PATCH v6 5/8] bridge: Update keepalive status in OVSDB.

LGTM, Tested-by: Antonio Fischetti Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday,

Re: [ovs-dev] [PATCH v6 4/8] keepalive: Retrieve PMD status periodically.

LGTM, Tested-by: Antonio Fischetti Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday,

Re: [ovs-dev] [PATCH v6 3/8] dpif-netdev: Enable heartbeats for DPDK datapath.

LGTM, Tested-by: Antonio Fischetti Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday,

Re: [ovs-dev] [PATCH v6 2/8] dpif-netdev: Register packet processing cores to KA framework.

LGTM, Tested-by: Antonio Fischetti Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday,

Re: [ovs-dev] [PATCH v6 1/8] Keepalive: Add initial keepalive configuration.

LGTM, Tested-by: Antonio Fischetti Acked-by: Antonio Fischetti > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy > Sent: Friday,

Re: [ovs-dev] [PATCH v6 0/8] Add OVS DPDK keep-alive functionality.

Hi Bhanu, I've tested v6 and LGTM, works as expected. To check the behavior I blocked one or more of the PMD with the trick of attaching cgdb. So with utilities/ovs-appctl keepalive/pmd-health-show I could see for example 2 of the 3 PMDs - those I intentionally blocked - correctly

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

Not a full review. General thoughts: If following conditions are true: 1. We don't need to add new feature to deprecated vhostuser port. 2. We actually don't need to have ability to change ZC config if vhost-server-path already configured. Let me explain this condition: To change

[ovs-dev] [PATCH v6 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

Enabled per port like so: ovs-vsctl set Interface dpdkvhostuserclient0 options:dq-zero-copy=true The feature is disabled by default and can only be enabled/disabled when a vHost port is down. When packets from a vHost device with zero copy enabled are destined for a 'dpdk' port, the number of tx

[ovs-dev] [PATCH v6 0/2] vHost Dequeue Zero Copy

This patch enables optional dequeue zero copy for vHost ports. This gives a performance increase for some use cases. I'm using the cover letter to report my results. vhost (vm1) -> vhost (vm2) Using testpmd to source (txonly) in vm1 and sink (rxonly) in vm2. 4C1Q 64B packets: 5.05Mpps -> 5.52Mpps

Re: [ovs-dev] [ovs-dev, v5, 1/2] netdev-dpdk: Helper function for vHost device setup

One general concern: Why we're adding new (experimental) feature to deprecated port type? If we'll not do that, this patch will not be needed. IMHO, it's better to keep vhostuser ports intact to avoid possible regressive changes. Also, this patch increases code size. Some comments about patch

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

Hi, > >> What if we have 2, 4, 10 HW NICs and a few different destinations for > >> traffic from VM? > >> What if we have 2, 4, 10 HW NICs added to balanced OVS bonding and just a > >> few different packet flows? > >> What if we have HW NICs with small number of TX queues (like VFs) and XPS >

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

> Hello Ciara, > Thanks for the patches. > > I did not review the code. But I have few general concerns about number of > tx descriptors in HW NICs inline. > > Best regards, Ilya Maximets. > > On 08.12.2017 18:26, Ciara Loftus wrote: > > Enabled per port like so: > > ovs-vsctl set Interface

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

On 14.12.2017 19:26, Kevin Traynor wrote: > On 12/14/2017 03:30 PM, Ilya Maximets wrote: >> Hello Ciara, >> Thanks for the patches. >> >> I did not review the code. But I have few general concerns about number >> of tx descriptors in HW NICs inline. >> >> Best regards, Ilya Maximets. >> >> On