[ovs-dev] [PATCH] openvswitch: meter: Use 64-bit arithmetic instead of 32-bit

Add suffix LL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type long long int (64 bits, signed). The expression (band->burst_size + band->rate) * 1000 is

[ovs-dev] Detecte y Prevenga Fraudes Oportunamente

En línea y en Vivo / Para todo su Equipo con una sola Conexión Sistemas Eficaces de Control a través de Auditorías Administrativas 22 de Febrero - Online en Vivo - Horario de 10:00 a 13:00 y de 15:00 a 18:00 ¡No más fugas de recursos! Detecte y prevenga fraudes de manera oportuna,

Re: [ovs-dev] [PATCH 18/20] datapath: use ktime_get_ts64() instead of ktime_get_ts()

On 1/30/2018 3:40 PM, Greg Rose wrote: From: Arnd Bergmann Upstream commit: commit 311af51dcb5629f04976a8e451673f77e3301041 Author: Arnd Bergmann Date: Mon Nov 27 12:41:38 2017 +0100 openvswitch: use ktime_get_ts64() instead of

[ovs-dev] [PATCH V2] rhel: Fix support for root user using DPDK

Since 2.8.0 OVS runs as non-root user on rhel distros, but the current implementation breaks the ability to run as root with DPDK and as a consequence there is no way possible to use UIO drivers on kernel 4.0 and newer [1, 2]. [1]

Re: [ovs-dev] [PATCH 20/20] Documentation: Update NEWS and faq

On 1/30/2018 3:43 PM, Justin Pettit wrote: On Jan 30, 2018, at 3:40 PM, Greg Rose wrote: Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git

Re: [ovs-dev] [PATCH 20/20] Documentation: Update NEWS and faq

> On Jan 30, 2018, at 3:40 PM, Greg Rose wrote: > > Signed-off-by: Greg Rose > --- > Documentation/faq/releases.rst | 1 + > NEWS | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/faq/releases.rst

[ovs-dev] [PATCH 20/20] Documentation: Update NEWS and faq

Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 62a1957..2f03c89 100644 ---

[ovs-dev] [PATCH 19/20] compat:inet_frag.h: Check for frag_percpu_counter_batch

Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Fixes compile errors on 3.16 series kernels from 3.16.50 on. Signed-off-by: Greg Rose ---

[ovs-dev] [PATCH 18/20] datapath: use ktime_get_ts64() instead of ktime_get_ts()

From: Arnd Bergmann Upstream commit: commit 311af51dcb5629f04976a8e451673f77e3301041 Author: Arnd Bergmann Date: Mon Nov 27 12:41:38 2017 +0100 openvswitch: use ktime_get_ts64() instead of ktime_get_ts() timespec is deprecated because of the

[ovs-dev] [PATCH 17/20] datapath: fix the incorrect flow action alloc size

From: zhangliping Upstream commit: commit 67c8d22a73128ff910e2287567132530abcf5b71 Author: zhangliping Date: Sat Nov 25 22:02:12 2017 +0800 openvswitch: fix the incorrect flow action alloc size If we want to add a

[ovs-dev] [PATCH 16/20] datapath: fix data type in queue_gso_packets

From: "Gustavo A. R. Silva" Upstream commit: commit 2734166e89639c973c6e125ac8bcfc2d9db72b70 Author: Gustavo A. R. Silva Date: Sat Nov 25 13:14:40 2017 -0600 net: openvswitch: datapath: fix data type in queue_gso_packets

[ovs-dev] [PATCH 15/20] datapath: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start

From: "Gustavo A. R. Silva" Upstream commit: commit b74912a2fdae9aadd20da502644aa8848c861954 Author: Gustavo A. R. Silva Date: Tue Nov 14 14:26:16 2017 -0600 openvswitch: meter: fix NULL pointer dereference in

[ovs-dev] [PATCH 14/20] datapath: Using kfree_rcu() to simplify the code

From: Wei Yongjun Upstream commit: commit 6dc14dc40a1d1dafd8491c349b5f3e15aabc4edb Author: Wei Yongjun Date: Tue Nov 14 06:27:12 2017 + openvswitch: Using kfree_rcu() to simplify the code The callback function of

[ovs-dev] [PATCH 13/20] datapath: Fix return value check in ovs_meter_cmd_features()

From: Wei Yongjun Upstream commit: commit 8a860c2bcc84a8e4fbcabb928cd97e4c51b17d93 Author: Wei Yongjun Date: Tue Nov 14 06:20:16 2017 + openvswitch: Fix return value check in ovs_meter_cmd_features() In case of error,

[ovs-dev] [PATCH 12/20] datapath: Add meter infrastructure

From: Andy Zhou Upstream commit: commit 96fbc13d7e770b542d2d1fcf700d0baadc6e8063 Author: Andy Zhou Date: Fri Nov 10 12:09:42 2017 -0800 openvswitch: Add meter infrastructure OVS kernel datapath so far does not support Openflow meter action.

[ovs-dev] [PATCH 11/20] datapath: Add meter netlink definitions

From: Andy Zhou Upstream commit: commit 5794040647de4011598a6d005fdad95d24fd385b Author: Andy Zhou Date: Fri Nov 10 12:09:40 2017 -0800 openvswitch: Add meter netlink definitions Meter has its own netlink family. Define netlink messages and

[ovs-dev] [PATCH 09/20] datapath: reliable interface indentification in port dumps

From: Jiri Benc Upstream commit: commit 9354d452034273a50a4fd703bea31e5d6b1fc20b Author: Jiri Benc Date: Thu Nov 2 17:04:37 2017 -0200 openvswitch: reliable interface indentification in port dumps This patch allows reliable

[ovs-dev] [PATCH 10/20] datapath: export get_dp() API

From: Andy Zhou Upstream commit: commit 9602c01e57f7b868d748c2ba2aef0efa64b71ffc Author: Andy Zhou Date: Fri Nov 10 12:09:41 2017 -0800 openvswitch: export get_dp() API. Later patches will invoke get_dp() outside of datapath.c. Export it.

[ovs-dev] [PATCH 08/20] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()

From: Christophe JAILLET Upstream commit: commit 5829e62ac17a40ab08c1b905565604a4b5fa7af6 Author: Christophe JAILLET Date: Mon Sep 11 21:56:20 2017 +0200 openvswitch: Fix an error handling path in

[ovs-dev] [PATCH 07/20] compat: Fix compiler headers

Since Linux kernel upstream commit d15155824c50 ("linux/compiler.h: Split into compiler.h and compiler_types.h") this error check for the gcc compiler header is no longer valid. Remove so that openvswitch builds for linux kernels 4.14.8 and since. Signed-off-by: Greg Rose

[ovs-dev] [PATCH 06/20] travis: Update kernel test list from kernel.org

Signed-off-by: Greg Rose --- .travis.yml | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index 48acc8e..88bdda2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -26,17 +26,16 @@ sudo: false env: -

[ovs-dev] [PATCH 05/20] acinclude.m4: Enable Linux 4.14

Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 768c20c..d0f9d82 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -151,10 +151,10 @@ AC_DEFUN([OVS_CHECK_LINUX], [

[ovs-dev] [PATCH 04/20] datapath: Fix SKB_GSO_UDP usage

Using SKB_GSO_UDP breaks the compilation on Linux 4.14. Check for the HAVE_SKB_GSO_UDP compiler #define. Signed-off-by: Greg Rose --- datapath/datapath.c | 9 ++--- datapath/linux/compat/stt.c | 11 ++- 2 files changed, 16 insertions(+), 4 deletions(-)

[ovs-dev] [PATCH 03/20] datapath: conntrack: make protocol tracker pointers const

From: Florian Westphal Upstream commit: commit b3480fe059ac9121b5714205b4ddae14b59ef4be Author: Florian Westphal Date: Sat Aug 12 00:57:08 2017 +0200 netfilter: conntrack: make protocol tracker pointers const Doesn't change generated code,

[ovs-dev] [PATCH 02/20] compat: Do not include headers when not compiling

If the entire file is not going to be compiled because OVS is using upstream tunnel support then also don't bother pulling in the headers. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c| 2 +- datapath/linux/compat/ip_output.c | 2 +- 2 files changed, 2

[ovs-dev] [PATCH 01/20] datapath: Fix netdev_master_upper_dev_link for 4.14

An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose --- acinclude.m4| 3 +++ datapath/linux/compat/include/linux/netdevice.h |

[ovs-dev] [PATCH 00/20] Update and backport of upstream Linux

Allow OVS to compile and build on Linux 4.14.x kernels. Added necessary compatability layer changes to the respective patches as required for our OOT build environment. Note that NSH and ERSPAN patches are not in this series. We are working with the authors of those patches to get them

Re: [ovs-dev] [PATCH 09/15] ovsdb-server: Add support for a built-in _Server database.

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > @@ -5,6 +7,7 @@ > /ovsdb-idlc > /ovsdb-server > /ovsdb-server.1 > +/ovsdb-server.5 Do you need to add the new man page to the distributions? debian/openvswitch-switch.manpages rhel/openvswitch-fedora.spec.in

[ovs-dev] Top Gun de Ventas

Top Gun de Ventas Febrero 12 - webinar Interactivo Objetivo: El participante conocerá una poderosa metodología para incrementar su capacidad y talento para ser un vendedor de alto rendimiento. COMPETENCIAS A DESARROLLAR: Automotivación | Espíritu Comercial | Atención al Cliente 1. Vendedor

Re: [ovs-dev] deleting chassis doesn't delete the lport and lflows from northd

Thanks Han: Sorry for the typo. I thought devs would catch that. So to summarize, I was concerned about two issues: 1. killing the compute/HV gracefully should have deleted the chassis from southbound db along with the bindings which did not happen 2. It is ok to leave the ports acting as orphan

Re: [ovs-dev] [patch v4 03/10] Userspace datapath: Add fragmentation handling.

I added the following incremental to this patch: diff --git a/lib/ipf.c b/lib/ipf.c index 11f8f18..6eb283e 100644 --- a/lib/ipf.c +++ b/lib/ipf.c @@ -463,7 +463,7 @@ ipf_reassemble_v6_frags(struct ipf_list *ipf_list) add_len = frag_list[i].end_data_byte -

Re: [ovs-dev] deleting chassis doesn't delete the lport and lflows from northd

Hi Ali, Thanks for the details. Please see my comments inlined. On Mon, Jan 29, 2018 at 7:12 PM, Ali Gin wrote: > > Hi team/Ben: > > Want to get inputs about compute de-comm use case. So when deleting the chassis from southd after gracefully killing the compute, doesn't

Re: [ovs-dev] [PATCH v2 2/3] ofp-util: New data structure for mapping between table names and numbers.

Looks good to me, thanks. Reviewed-by: Yifeng Sun On Fri, Jan 12, 2018 at 12:57 PM, Ben Pfaff wrote: > This shares the infrastructure for mapping port names and numbers. It will > be used in an upcoming commit. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH v2 1/3] ofp-actions: Make formatting and parsing functions take a struct argument.

Looks good to me, thanks. Reviewed-by: Yifeng Sun On Fri, Jan 12, 2018 at 12:57 PM, Ben Pfaff wrote: > An upcoming commit will add another parameter for parsing and formatting > actions. It is much easier to add these parameters if they are >

Re: [ovs-dev] [PATCH] classifier: Refactor interface for classifier_remove().

Thanks for the patch, which is better than the one I submitted. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Tue, Jan 30, 2018 at 1:00 PM, Ben Pfaff wrote: > Until now, classifier_remove() returned either null or the

Re: [ovs-dev] [PATCH] classifier: Fix typo in comment.

Thanks, applied to master. On Tue, Jan 30, 2018 at 12:52:09PM -0800, Yifeng Sun wrote: > Thanks for the fix. > > Reviewed-by: Yifeng Sun > > On Tue, Jan 30, 2018 at 12:34 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > >

[ovs-dev] [PATCH] classifier: Refactor interface for classifier_remove().

Until now, classifier_remove() returned either null or the classifier rule passed to it, which is an unusual interface. This commit changes it to return true if it succeeds or false on failure. In addition, most of classifier_remove()'s callers know ahead of time that it must succeed, even

[ovs-dev] [PATCH] classifier: refactor classifier_remove and introduce classifier_remove_assert

The return type of classifier_remove is changed to bool. Besides, classifier_remove_assert is introduced to assert that the classifier must contain the rule. This patch is based on Ben's advice. Signed-off-by: Yifeng Sun --- lib/classifier.c | 21 +

Re: [ovs-dev] [PATCH] classifier: Fix typo in comment.

Thanks for the fix. Reviewed-by: Yifeng Sun On Tue, Jan 30, 2018 at 12:34 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/classifier.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/classifier.h

[ovs-dev] [PATCH] classifier: Fix typo in comment.

Signed-off-by: Ben Pfaff --- lib/classifier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/classifier.h b/lib/classifier.h index f0ea5a9cb8b2..71c2e507d7c3 100644 --- a/lib/classifier.h +++ b/lib/classifier.h @@ -284,7 +284,7 @@ * * The classifier may

[ovs-dev] Habilidades necesarias para alcanzar sus objetivos

Adecuada gestión de personal para resultados excelentes Técnicas de Supervisión Efectiva, Liderazgo, Productividad y Manejo de Conflictos 14 de Febrero- Psi. Dolores Romero Mora - 9am- 8pm Las habilidades de supervisión son imprescindibles para aquellos jefes o supervisores que tienen equipos

Re: [ovs-dev] [PATCH V2 7/7] compat: Fix compiler headers

Please ignore this series - a couple of other things have changed in the stable and long term kernels that need some attention.  I'll send  V3 when I get them fixed up. On 1/29/2018 2:54 PM, Greg Rose wrote: Since Linux kernel upstream commit d15155824c50 ("linux/compiler.h: Split into

Re: [ovs-dev] [PATCH v2 1/5] xlate: fix packets loopback caused by duplicate read of xcfgp.

That 'ctx->xcfg' can't be null in my previous patch. This patch looks good to me. On Thu, Jan 25, 2018 at 3:40 AM, Ben Pfaff wrote: > From: Huanle Han > > Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle > pointers equality to avoid

Re: [ovs-dev] [PATCH 3/3] mirror: do not mirror packet on recirculation

Thanks for your review. Here is a test case: 1. add a trunk, balance-tcp bond to a bridge 2. add a access port tag=xxx to same bridge 3. add a mirror, which mirrors all ports in vlan=xxx to another out port 4. send packet from access port to bond (simply use arp). as a result, *mirror send 2

Re: [ovs-dev] [PATCH] rhel: Fix support for root user using DPDK

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Marcos Felipe Schwarz > Sent: Sunday, January 28, 2018 2:42 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] rhel: Fix support for root user using DPDK > > Since

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

On Tue, Jan 30, 2018 at 11:33:55AM +, Yang, Yi Y wrote: > Hi, Greg > > I installed linux 3.10.107 in Ubuntu 14.04 and fixed skb_gso_error_unwind > issue, but for unit test, tests/system-layer3-tunnels.at is a good reference > for it because we used vxlan-gpe for nsh, I ran unit test 90, but

Re: [ovs-dev] [PATCH] rhel: Fix support for root user using DPDK

Marcos Felipe Schwarz writes: > Since 2.8.0 OVS runs as non-root user on rhel distros, but the current > implementation breaks the ability to run as root with DPDK and as a > consequence there is no way possible to use UIO drivers on kernel 4.0 and > newer [1, 2]. > [1] >

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

Hi, Greg I installed linux 3.10.107 in Ubuntu 14.04 and fixed skb_gso_error_unwind issue, but for unit test, tests/system-layer3-tunnels.at is a good reference for it because we used vxlan-gpe for nsh, I ran unit test 90, but it always fails (I have installed and used net-next kernel and the

Re: [ovs-dev] [PATCH] Add unixctl option for ovn-northd

This is required for spawning ovn-northd for networking-ovn functional tests i.e https://review.openstack.org/#/c/532440/ https://review.openstack.org/#/c/532440/11/networking_ovn/tests/functional/resources/process.py@60

Re: [ovs-dev] [PATCH 1/3] ovn-controller: Add extend_table instead of group_table to expand meter.

Acked-By: Miguel Angel Ajo The refactor looks good to me. On Wed, Jan 24, 2018 at 2:40 AM Ben Pfaff wrote: > From: Guoshuai Li > > The structure and function of the group table and meter table are similar, > refactoring code is used to

Re: [ovs-dev] test

ACK. It worked for me. On Mon, Jan 29, 2018 at 9:55 PM Ben Pfaff wrote: > I've heard that there are problems with the mailing list this morning, > so here's a test email. > ___ > dev mailing list > d...@openvswitch.org >

[ovs-dev] [PATCH] docs: Update supported DPDK versions.

Update the OVS to DPDK release table to use the latest stable DPDK 16.11.4 for OVS 2.7. Signed-off-by: Ian Stokes --- Documentation/faq/releases.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/faq/releases.rst

[ovs-dev] [PATCH branch-2.7] docs: Use DPDK 16.11.4 stable release.

Modify docs and travis linux build script to use DPDK 16.11.4 stable branch to benefit from most recent bug fixes. There are no new features introduced in the DPDK release, only back ported bug fixes. For completeness these bug fixes have been documented under the 16.11.4 section in the link

[ovs-dev] [PATCH] Add unixctl option for ovn-northd

From: Venkata Anil Signed-off-by: Venkata Anil --- lib/automake.mk | 3 ++- lib/unixctl.xml | 26 ++ ovn/northd/ovn-northd.8.xml | 7 +-- ovn/northd/ovn-northd.c | 9 -

[ovs-dev] [patch v4 10/10] tests: Enable fragmentation for userspace datapath.

Signed-off-by: Darrell Ball --- tests/system-kmod-macros.at | 14 +++- tests/system-traffic.at | 34 tests/system-userspace-macros.at | 49 3 files changed, 72 insertions(+), 25

[ovs-dev] [patch v4 09/10] tests: Add missed local stack checks.

Signed-off-by: Darrell Ball --- tests/system-traffic.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..5b59392 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@

[ovs-dev] [patch v4 06/10] ipf: Add set minimum fragment size command.

A new command "ovs-appctl dpctl/ipf-set-minfrag" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 40

[ovs-dev] [patch v4 05/10] ipf: Add command to enable fragmentation handling.

A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 40

[ovs-dev] [patch v4 03/10] Userspace datapath: Add fragmentation handling.

Fragmentation handling is added for supporting conntrack. Fragmentation handling is disabled by default and enabled via a user commands implemented in a subsequent patch. Both v4 and v6 are supported. Signed-off-by: Darrell Ball --- include/sparse/netinet/ip6.h |1 +

[ovs-dev] [patch v4 04/10] conntrack: Support fragmentation.

The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/conntrack.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 726589c..dccff06 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@

[ovs-dev] [patch v4 02/10] flow: Enhance parse_ipv6_ext_hdrs.

Enhance the api parse_ipv6_ext_hdrs to return the fragmentation header to be used in later patches. Signed-off-by: Darrell Ball --- lib/conntrack.c | 5 +++-- lib/flow.c | 23 ++- lib/flow.h | 3 ++- 3 files changed, 19 insertions(+), 12

[ovs-dev] [patch v4 01/10] dp-packet: Add const qualifiers for checksum apis.

Signed-off-by: Darrell Ball --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(struct

[ovs-dev] [patch v4 00/10] Userspace datapath: Add fragmentation support.

Fragmentation support for userspace datapath conntrack is added; both v4 and v6 are supported. See the patches for additional details. v3->v4: Add V6 support to the patches. Fix possible race cleanup bug when the user disables fragmentation and there are list occupancies, not