Re: [ovs-dev] [PATCH V2] ovn-controller: Reduce the number of flows by use conjunction action

在 2018/2/6 0:41, Numan Siddique 写道: On Mon, Feb 5, 2018 at 3:21 PM, Numan Siddique > wrote: On Feb 5, 2018 12:32 PM, "Wei Li" > wrote: your patch is better, pls ignore my patch,

Re: [ovs-dev] [PATCH 14/15] json: Make it safe to pass null pointers to json_equal().

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 13/15] jsonrpc: Add comment for jsonrpc_msg_to_json().

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > From a glance at the prototype it wasn't obvious that it destroyed its > argument. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH 12/15] ovsdb-client: Add --timeout option.

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 12/20] datapath: Add meter infrastructure

On 2/2/2018 10:18 AM, Pravin Shelar wrote: On Tue, Jan 30, 2018 at 3:40 PM, Greg Rose wrote: From: Andy Zhou Upstream commit: commit 96fbc13d7e770b542d2d1fcf700d0baadc6e8063 Author: Andy Zhou Date: Fri Nov 10 12:09:42 2017

Re: [ovs-dev] [PATCH 11/15] ovsdb: Add support for online schema conversion.

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > --- a/NEWS > +++ b/NEWS > @@ -5,6 +5,8 @@ Post-v2.8.0 > * New high-level documentation in ovsdb(7). > * New file format documentation for developers in ovsdb(5). > * Protocol documentation moved from

Re: [ovs-dev] [PATCH 4/4] ovs-vsctl: Add commands "add-bond-iface" and "del-bond-iface".

Looks good to me, thanks. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Fri, Feb 2, 2018 at 1:51 PM, Ben Pfaff wrote: > It was not too hard to build these commands using the database commands, > but a few people have asked for

Re: [ovs-dev] [PATCH 3/4] NEWS: Consolidate ovs-vswitchd sections and fix indentation.

Looks good to me. Thanks. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Fri, Feb 2, 2018 at 1:51 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > NEWS | 11 +-- > 1 file changed, 5 insertions(+),

Re: [ovs-dev] [PATCH 2/4] ovs-vsctl: Use default socket name in tests.

It seems test "ovs-xapi-sync" is broken after this patch. I haven't figured out myself. Can you please take a look? Thanks. On Fri, Feb 2, 2018 at 1:51 PM, Ben Pfaff wrote: > By using the default socket name "db.sock", instead of "socket", we can > avoid passing --db=unix:socket

Re: [ovs-dev] [PATCH] netdev-linux: Report netdev change events when mac changed.

On Sun, Feb 04, 2018 at 06:45:38AM -0800, Tonghao Zhang wrote: > When mac addr of ports on bridge has been changed, for example, > > $ ip link set dev eth0 address 00:11:22:33:44:55 > > we should reconfigure the datapath id and mac addr of local port. > But now openvswitch dont do that as

Re: [ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

That sounds like a good idea. Do you want to try to write up a patch for that approach? The current series still seems like a good idea to me, do you have an opinion? On Mon, Feb 05, 2018 at 07:57:20PM +0800, Huanle Han wrote: > The patches make "ODP_FIT_TOO_LITTLE" logic more clear for me. >

Re: [ovs-dev] [PATCH v2] Makefile.am: Use correct path separator for Windows

On Fri, Feb 02, 2018 at 03:49:05PM -0800, Shashank Ram wrote: > Signed-off-by: Shashank Ram Thanks! Applied to master and branch-2.9. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

On Mon, Feb 05, 2018 at 05:40:28PM +0100, Jakub Sitnicki wrote: > On Mon, Feb 05, 2018 at 04:25 PM GMT, Ben Pfaff wrote: > > On Mon, Feb 05, 2018 at 05:03:13PM +0100, Jakub Sitnicki wrote: > >> > >> It caught my attention that the contract with hexit_value() callers has > >> changed. Previously

Re: [ovs-dev] [OVN][Request] New OVS 2.8 tag

On Sun, Feb 04, 2018 at 02:37:12PM +0530, Numan Siddique wrote: > On Tue, Jan 2, 2018 at 5:24 PM, Daniel Alvarez Sanchez > wrote: > > > Hi folks, > > > > It'd be great if we could have 2.8.2 tag so that we can benefit > > from some patches that we would require in OVN and

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

Just finished my review and some basic testing (see other email), so let me reply to these inline. On 05/02/18 15:31, Ilya Maximets wrote: On 05.02.2018 17:18, Róbert Mulik wrote: Hi Ilya, As I see you are concerned if the code is working, also Eelco mentioned that the configuration change

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

On Mon, Feb 05, 2018 at 04:25 PM GMT, Ben Pfaff wrote: > On Mon, Feb 05, 2018 at 05:03:13PM +0100, Jakub Sitnicki wrote: >> >> It caught my attention that the contract with hexit_value() callers has >> changed. Previously we had a catch-all clause for out-of-range values. >> Now there will be an

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

On 02/02/18 17:17, Ilya Maximets wrote: On 02.02.2018 17:05, Róbert Mulik wrote: It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

On Mon, Feb 05, 2018 at 05:03:13PM +0100, Jakub Sitnicki wrote: > Hi Ben, > > On Fri, Feb 02, 2018 at 11:16 PM GMT, Ben Pfaff wrote: > > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > > due to a similar patch. > > > > Reported-by: Daniel Alvarez Sanchez

Re: [ovs-dev] [ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

See some minor comments inline below... On 02/02/18 15:05, Róbert Mulik wrote: It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode more

Re: [ovs-dev] [PATCH] util: Use lookup table to optimize hexit_value().

Hi Ben, On Fri, Feb 02, 2018 at 11:16 PM GMT, Ben Pfaff wrote: > Daniel Alvarez Sanchez reported a significant overall speedup in ovn-northd > due to a similar patch. > > Reported-by: Daniel Alvarez Sanchez > Reported-at: >

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

It was triggered right after the change. This was my ovs setup: ovs-vsctl show 57390393-2b8b-4aba-b5dc-aaf822138e66 Bridge br-prv Port "dpdk0" Interface "dpdk0" type: dpdk options: {dpdk-devargs=":83:00.1", n_rxq="2"} Port br-prv

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

On 05.02.2018 17:18, Róbert Mulik wrote: > Hi Ilya, > > As I see you are concerned if the code is working, also Eelco mentioned that > the configuration change didn't take effect for him, so I retested the patch. > > I added 2 different types of NICs to OVS on the same server: > > 1 > product:

Re: [ovs-dev] [ovs-dev, ovs-dev, v4] netdev-dpdk: Configurable Link State Change (LSC) detection mode

Hi Ilya, As I see you are concerned if the code is working, also Eelco mentioned that the configuration change didn't take effect for him, so I retested the patch. I added 2 different types of NICs to OVS on the same server: 1 product: 82599ES 10-Gigabit SFI/SFP+ Network Connection It uses

Re: [ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

The patches make "ODP_FIT_TOO_LITTLE" logic more clear for me. But it seems not fix the problem I mentioned at beginnig: revalidate_ukey__() always return UKEY_DELETE for igmp, because flow_wildcards_has_extra() return true. Should we UKEY_KEEP igmp or other "ODP_FIT_TOO_LITTLE" flows whose

Re: [ovs-dev] [PATCH 18/20] datapath: use ktime_get_ts64() instead of ktime_get_ts()

On Fri, Feb 2, 2018 at 10:27 PM, Gregory Rose wrote: > On 2/2/2018 12:13 PM, Arnd Bergmann wrote: >> >> On Fri, Feb 2, 2018 at 7:31 PM, Gregory Rose wrote: > > That's an interesting suggestion Arnd. I'm generally opposed to divide > operations when I

Re: [ovs-dev] [PATCH 3/3] mirror: do not mirror packet on recirculation

Here is a full script, assuming you have interfaces vnet0,vnet1,eth5,eth6. and with peer switch of eth5 and eth6 is configured as lacp=active bond. (you can use linux veth interfaes instead of true physical iface for eth5 and eth6). #!/bin/bash br=br1 bond_iface1=eth5 bond_iface2=eth6

Re: [ovs-dev] [PATCH branch-2.7] docs: Use DPDK 16.11.4 stable release.

> -Original Message- > From: Kavanagh, Mark B > Sent: Friday, February 2, 2018 1:03 PM > To: Stokes, Ian ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH branch-2.7] docs: Use DPDK 16.11.4 stable > release. > > >From: ovs-dev-boun...@openvswitch.org