Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

On Fri, Apr 13, 2018 at 2:40 PM, Han Zhou wrote: > > > > On Fri, Apr 13, 2018 at 1:42 PM, Ben Pfaff wrote: > > > > On Fri, Apr 13, 2018 at 01:33:26PM -0700, Han Zhou wrote: > > > On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > > > I think

[ovs-dev] [PATCH v3] ovn: Support address sets generated from port groups

Address sets are automatically generated from corresponding port groups, and can be used directly in ACL match conditions. There are two address sets generated for each port group: _ip4 _ip6 For example, if port_group1 is created, we can directly use below match condition in ACL: "outport

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

On Fri, Apr 13, 2018 at 1:42 PM, Ben Pfaff wrote: > > On Fri, Apr 13, 2018 at 01:33:26PM -0700, Han Zhou wrote: > > On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > > I think that sync_address_sets() is O(n**2) in n_ipv4_addrs and > > > n_ipv6_addrs, because of

Re: [ovs-dev] [PATCH] rhel/systemd: Prevent deletion of runtime directory.

On 4 April 2018 at 08:13, Aaron Conole wrote: > Gurucharan Shetty writes: > > > Currently, when we do a 'service openvswitch stop', > > '/var/run/openvswitch' gets deleted. This is a problem > > if you have other users (like OVN) using the same > > runtime

Re: [ovs-dev] [PATCH] ovn: Recirculate packets after a unSNAT.

On 4 April 2018 at 14:47, Ben Pfaff wrote: > On Mon, Mar 26, 2018 at 02:18:28PM -0700, Gurucharan Shetty wrote: > > commit f6fabcc6245 (ofproto-dpif: Mark packets as "untracked" > > after call to ct().) changed the behavior after a call to ct(). > > The +trk bit would automatically

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: native tunnel using valid tun_src specified by flow or port options

OK. I think I understand the patch now. It makes OVS native tunneling honor tunnel-specified source addresses, in the same way that Linux kernel tunneling honors them. I see one potential problem: it makes ovs-router.c #include . This is a problem because ovs-router.c is used on Windows and

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

On Fri, Apr 13, 2018 at 01:33:26PM -0700, Han Zhou wrote: > On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > I think that sync_address_sets() is O(n**2) in n_ipv4_addrs and > > n_ipv6_addrs, because of the allocation strategy. If port groups get > > big (and they will

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > On Wed, Apr 04, 2018 at 05:51:48PM -0700, Han Zhou wrote: > > Address sets are automatically generated from corresponding port > > groups, and can be used directly in ACL match conditions. > > Thanks! > > I think that

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

On Wed, Apr 04, 2018 at 05:51:48PM -0700, Han Zhou wrote: > Address sets are automatically generated from corresponding port > groups, and can be used directly in ACL match conditions. Thanks! I think that sync_address_sets() has a memory leak, because I don't see any free() calls that match up

Re: [ovs-dev] [PATCH v2 1/2] ovn: Support port groups in ACLs

On Wed, Apr 04, 2018 at 05:51:47PM -0700, Han Zhou wrote: > This patch enables using port group names in ACL match conditions. > Users can create a port group in northbound DB Port_Group table, > and then use the name of the port group in ACL match conditions > for "inport" or "outport". It can

Re: [ovs-dev] [PATCH 09/11] ofproto-dpif-slow: Add IPv6 agent address support.

Thanks for taking a look! On Fri, Apr 13, 2018 at 12:27:40PM -0700, Neil McKee wrote: > Looks ok to me. Will this be accessible via ovs-vsctl? Yes, it should work the same as before. > If so, hsflowd will be able to tell ovs to use the same agent-address > as the one it already settled on.

Re: [ovs-dev] [PATCH 09/11] ofproto-dpif-slow: Add IPv6 agent address support.

Looks ok to me. Will this be accessible via ovs-vsctl? If so, hsflowd will be able to tell ovs to use the same agent-address as the one it already settled on. Instead of just specifying the device and hoping it works out: https://github.com/sflow/host-sflow/blob/v2.0.15/src/Linux/mod_ovs.c#L258

Re: [ovs-dev] [PATCH v2] Edit Open vSwitch license info so that GitHub recognizes it.

Ben Pfaff writes: > From: Andrea Kao > > GitHub uses a library called Licensee to identify a project's license > type. It shows this information in the status bar and via the API if it > can unambiguously identify the license. > > This commit creates a LICENSE

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

On 04/13/2018 04:20 PM, Stokes, Ian wrote: >> Currently to RX jumbo packets fails for NICs not supporting scatter. >> Scatter is not strictly needed for jumbo support on RX. This change fixes >> the issue by only enabling scatter for NICs supporting it. Add a quirk for >> "igb" while the PMD is

Re: [ovs-dev] [PATCH v2 0/2] Correct handling of double encap and decap actions

Thanks for checking. I applied both patches to branch-2.9. For branch-2.8, would you mind submitting the fixed-up patches? It would save me a few minutes. Thanks, Ben. On Fri, Apr 06, 2018 at 05:37:20PM +, Jan Scheurich wrote: > Yes that fix should be applied to branches 2.9 and 2.8. >

Re: [ovs-dev] [PATCH net-next 0/6] Add dpdk-bond support

On Thu, Apr 12, 2018 at 05:52:46AM -0700, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > The bond of openvswitch has not good performance. I'd really say that the best solution to that is to improve the performance, rather than piling on another bonding

Re: [ovs-dev] [PATCH net-next 0/6] Add dpdk-bond support

Why is this series tagged "net-next"? It doesn't appear to have anything to do with the kernel. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] netns: Add documentation and update NEWS.

On Wed, Apr 11, 2018 at 08:50:56PM -0300, Flavio Leitner wrote: > Create a document to describe the how it works and known > limitations and update the NEWS accordingly. > > Signed-off-by: Flavio Leitner Thanks! I folded in the following to make "checkpatch" and "make"

[ovs-dev] [PATCH v2] Edit Open vSwitch license info so that GitHub recognizes it.

From: Andrea Kao GitHub uses a library called Licensee to identify a project's license type. It shows this information in the status bar and via the API if it can unambiguously identify the license. This commit creates a LICENSE file that stores the full text of the Apache

[ovs-dev] Follow Up- Oil & Gas, Energy & Utility

Hi, Hope you are doing well. Would you be interested in acquiring an Email List for Oil & Gas, Energy & Utility Industry? PS: If you have a very specific and niche target, please do mention that here as we can customize the lists for you across industries and geographies/countries.

Re: [ovs-dev] [PATCH v2 1/1] netdev-vport: reject concomitant incompatible tunnels

On Fri, Feb 09, 2018 at 03:42:56PM +0100, Eelco Chaudron wrote: > This patch will make sure VXLAN tunnels with and without the group > based policy (GBP) option enabled can not coexist on the same > destination UDP port. > > In theory, VXLAN tunnel with and without GBP enables can be >

Re: [ovs-dev] [PATCH v2] flow: Extend 5-tuple hash calculation for non-IP packets

On Thu, Apr 12, 2018 at 01:01:09PM +, Gabor Halász wrote: > In real-world vSwitch deployments, handling a few thousand flows, > EMC is quickly saturated, so it's optimal usage is critical to > reach the highest packet forwarding speed of the vSwitch. > > EMC lookup is initiated based on the

Re: [ovs-dev] [PATCH] stopwatch: Add latch_poll to stopwatch loop.

On Wed, Apr 11, 2018 at 09:15:22AM -0500, Mark Michelson wrote: > Nothing was clearing the latch, so the loop was busy. This makes it so > the loop only runs on new calls to latch_set() by a separate thread. > > Signed-off-by: Mark Michelson Thanks, applied.

Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

On Fri, Apr 13, 2018 at 10:27:03AM -0500, Terry Wilson wrote: > One could argue that if if distro packaging is the issue, then distros > could patch in the simple try/except ImportError and add the > sortedcontainer code like I did above. I'm quite sympathetic to that viewpoint--I think that OVS

Re: [ovs-dev] [PATCH] ofproto: Allow bundle idle timeout to be configured.

On Fri, Apr 13, 2018 at 01:45:30PM -0300, Flavio Leitner wrote: > In some cases 10 seconds might be too much time and in > other cases it might be too little. > > The OpenFlow spec mandates that it should wait at least one > second, so enforce that as the minimum acceptable value. > >

[ovs-dev] [PATCH v2] netdev-dpdk: Free mempool only when no in-use mbufs.

DPDK mempools are freed when they are no longer needed. This can happen when a port is removed or a port's mtu is reconfigured so that a new mempool is used. It is possible that an mbuf is attempted to be returned to a freed mempool from NIC Tx queues and this can lead to a segfault. In order to

[ovs-dev] [PATCH] tests: Fix typo in test name.

Signed-off-by: Ben Pfaff --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index 3ceeab3ce073..e5a648661f3c 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -177,7 +177,7 @@ ct_state = NXM_NX_CT_STATE ]]) AT_CLEANUP

Re: [ovs-dev] [PATCH v3] ovn-controller: Handle Port_Binding's "requested-chassis" option in physical.c

On Tue, Mar 20, 2018 at 04:59:42PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > When a Logical_Switch_Port P's options is set with 'requested-chassis=hv1' > and if the user has bound this logical port to two OVS interfaces each in > different host (eg. hv1

Re: [ovs-dev] [PATCH 1/2] vswitchd: Allow user to directly specify sFlow agent address.

The IPv6 feature was more work than I expected, but I did post the series: https://patchwork.ozlabs.org/project/openvswitch/list/?series=38837=* On Tue, Apr 10, 2018 at 12:23:12PM -0700, Ben Pfaff wrote: > It's currently IPv4 only but it's a good idea to add IPv6 support. I'll > put

[ovs-dev] [PATCH 11/11] ovn-nbctl: Use common code for sockaddr_storage.

This better reuses existing code. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.c | 43 --- 1 file changed, 12 insertions(+), 31 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index

[ovs-dev] [PATCH 10/11] ovn-nbctl: Simplify lb_info_add_smap().

Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 16698de1f049..85d4d3534b54 100644 --- a/ovn/utilities/ovn-nbctl.c +++

[ovs-dev] [PATCH 09/11] ofproto-dpif-slow: Add IPv6 agent address support.

Suggested-by: Neil McKee Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-sflow.c | 55 ++-- 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sflow.c

[ovs-dev] [PATCH 08/11] netdev: New function netdev_get_ip_by_name().

This is like netdev_get_in4_by_name() but accepts any IP address instead of just an IPv4 address. It will acquire its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/netdev.c | 81 +++- lib/netdev.h | 1 +

[ovs-dev] [PATCH 07/11] socket-util: Add more functions for IPv[46] sockaddr and sockaddr_storage.

The existing functions for working with sockaddr_storage that contain an IPv4 or IPv6 address are useful. This commit adds more functions for working with them, as well as a parallel set of functions for struct sockaddr. This also adds an initial user for some of the new sockaddr functions in

[ovs-dev] [PATCH 06/11] Make : parsing uniform treewide.

I didn't realize until now that the tree had two different ways of parsing strings in the form : and :. There are the long-standing inet_parse_active() and inet_parse_passive() functions, and more recently the ipv46_parse() function. This commit eliminates the latter and changes the code to use

[ovs-dev] [PATCH 05/11] socket-util: Make inet_parse_active() and inet_parse_passive() more alike.

Until now, the default_port parameters to these functions have had different types and different behavior. There is a reason for this, since it makes sense to listen on a kernel-selected port but it does not make sense to connect to a kernel-selected port, but this overlooks the possibility that

[ovs-dev] [PATCH 04/11] socket-util: New function inet_parse_address().

This will acquire its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 26 ++ lib/socket-util.h | 2 ++ 2 files changed, 28 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-util.c index b36de371baa1..2d893bc9feb6

[ovs-dev] [PATCH 02/11] socket-util: Make address parser check for trailing garbage.

Signed-off-by: Ben Pfaff --- lib/socket-util.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/socket-util.c b/lib/socket-util.c index 5485e3b515dd..86ac4d433a2d 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -455,6 +455,9 @@ inet_parse_active(const char

[ovs-dev] [PATCH 01/11] socket-util: Fix error in comment on ss_format_address().

The output for this function is a dynamic string and doesn't have a fixed buffer size, so the comment was wrong. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index

[ovs-dev] [branch 2.9 PATCH v3 2/2] netdev-dpdk: Add mempool reuse/free debug.

There is debug when a new mempool is created, but not when it is reused or freed. Add these as it is very difficult to debug mempool issues from logs without them. Signed-off-by: Kevin Traynor --- lib/netdev-dpdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[ovs-dev] [branch 2.9 PATCH v3 1/2] netdev-dpdk: Free mempool only when no in-use mbufs.

DPDK mempools are freed when they are no longer needed. This can happen when a port is removed or a port's mtu is reconfigured so that a new mempool is used. It is possible that an mbuf is attempted to be returned to a freed mempool from NIC Tx queues and this can lead to a segfault. In order to

[ovs-dev] [PATCH] ofproto: Allow bundle idle timeout to be configured.

In some cases 10 seconds might be too much time and in other cases it might be too little. The OpenFlow spec mandates that it should wait at least one second, so enforce that as the minimum acceptable value. Signed-off-by: Flavio Leitner --- ofproto/connmgr.c | 19

Re: [ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

OVS_FORCE does not affect Clang, only sparse. On Fri, Apr 13, 2018 at 11:43:24AM +, Gabor Halász wrote: > Hi Ben, > Indeed there was some problem with that line. > Instead of using the eth_addr_to_uint64() func, I have added OVS_FORCE > compiler flag to keep the logic more visible. > +

Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

One could argue that if if distro packaging is the issue, then distros could patch in the simple try/except ImportError and add the sortedcontainer code like I did above. But, if this works for the ovs team and distro folks, I'm happy with it. Terry ___

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

> Currently to RX jumbo packets fails for NICs not supporting scatter. > Scatter is not strictly needed for jumbo support on RX. This change fixes > the issue by only enabling scatter for NICs supporting it. Add a quirk for > "igb" while the PMD is fixed to advertise scatter. > Thanks for the v2

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo support on RX. This change fixes the issue by only enabling scatter for NICs supporting it. Add a quirk for "igb" while the PMD is fixed to advertise scatter. Reported-by: Louis Peens

[ovs-dev] [PATCH v2 0/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

Hello, here is a v2, this cover letter is to highlight that there is a quirk being added and that it has not been tested with "igb" (don't have an available system with igb at the moment). Some test with "igb" would be greatly appreciated, along with any feedback. Thanks, Pablo Pablo Cascón

[ovs-dev] Yourlong awaited part payment of $5.5 Million USD

Attn: Your long awaited part payment of $5.5 Million USD is ready for immediate release to you, and it was electronically credited into an ATM Visa Card for easy delivery. Your new Payment Reference No.- 6363836, Password No: 006786, Pin Code No: 1787 Your Certificate of Merit Payment No:

Re: [ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

Hi Ben, Indeed there was some problem with that line. Instead of using the eth_addr_to_uint64() func, I have added OVS_FORCE compiler flag to keep the logic more visible. +hash = hash_add64(hash, *((OVS_FORCE uint64_t *) >dl_dst)); +hash = hash_add(hash, (OVS_FORCE uint32_t) +

[ovs-dev] Transfer

Good day to you. I am the director for payment and within my capacity as the person in charge, i want to transfer some amount out for safe keeping and investment. If you can assit, then let me know so i can send you the full details. I would want you to keep the letter secret. This is not

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

On 12/04/18 14:05, Stokes, Ian wrote: On 10/04/18 21:08, Stokes, Ian wrote: Currently to RX jumbo packets fails for NICs not supporting scatter. Scatter is not strictly needed for jumbo support on RX. This change fixes the issue by only enabling scatter for NICs supporting it. Reported-by:

Re: [ovs-dev] [PATCH 2/2] dpdk docs: Drop file share in libvirt config.

On Thu, 2018-04-12 at 08:24 +0100, Lam, Tiago wrote: > On 11/04/2018 15:03, Stephen Finucane wrote: > > On Wed, 2018-04-11 at 09:54 -0400, Aaron Conole wrote: > > > Tiago Lam writes: > > > > > > > When explaining on how to add vhost-user ports to a guest, using > > > >